Adrian Bunk | 1 Aug 2008 21:22

annoying "trying to assign nonexistent symbol" warnings

Now that defconfig became less chatty the "trying to assign nonexistent symbol"
warnings become annoying: They are in practice not avoidable and give a 
false impression that something would have gone wrong.

If anyone already knows where to touch the code for disabling these 
warnings for defconfigs that would be appreciated, otherwise I'll cook
up a patch.

cu
Adrian

--

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Sam Ravnborg | 1 Aug 2008 21:38
Gravatar

Re: annoying "trying to assign nonexistent symbol" warnings

On Fri, Aug 01, 2008 at 10:22:20PM +0300, Adrian Bunk wrote:
> Now that defconfig became less chatty the "trying to assign nonexistent symbol"
> warnings become annoying: They are in practice not avoidable and give a 
> false impression that something would have gone wrong.
> 
> If anyone already knows where to touch the code for disabling these 
> warnings for defconfigs that would be appreciated, otherwise I'll cook
> up a patch.

Last time I posted a patch to remove these warnings the feedback was
that the warnings was used to say when a defconfig really needed an update.
And the patch was buried inside another serie so I dropped it again.

IIRC I added this warning long time ago and Roman was not happy
with it - and he was right then.

	Sam

diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index 0759761..df6a188 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
 <at>  <at>  -222,10 +222,8  <at>  <at>  load:
 				continue;
 			if (def == S_DEF_USER) {
 				sym = sym_find(line + 9);
-				if (!sym) {
-					conf_warning("trying to assign nonexistent symbol %s", line + 9);
+				if (!sym)
 					break;
(Continue reading)

Adrian Bunk | 2 Aug 2008 21:26

Re: Kconfig no longer outputs a .config with freshly updated defconfigs

On Sat, Aug 02, 2008 at 12:03:33PM -0400, Josh Boyer wrote:
> I was going through the somewhat tedious task of updating the 4xx
> defconfigs today, and I noticed some odd behavior from Kconfig.
> Basically, I would do:
> 
> 	make ppc44x_defconfig
> 	make oldconfig
> 	<build>
> 	cp .config arch/powerpc/configs/ppc44x_defconfig
> 	make distclean
> 
> I did this for a number of configs.  Then I went back and tried to build
> ppc44x_defconfig again and I got this result:
> 
> [jwboyer <at> localhost linux-2.6]$ make ppc44x_defconfig
>   HOSTCC  scripts/basic/fixdep
>   HOSTCC  scripts/basic/docproc
>   HOSTCC  scripts/kconfig/conf.o
>   HOSTCC  scripts/kconfig/kxgettext.o
>   SHIPPED scripts/kconfig/zconf.tab.c
>   SHIPPED scripts/kconfig/lex.zconf.c
>   SHIPPED scripts/kconfig/zconf.hash.c
>   HOSTCC  scripts/kconfig/zconf.tab.o
> scripts/kconfig/lex.zconf.c:1628: warning: ‘input’ defined but not used
>   HOSTLD  scripts/kconfig/conf
> [jwboyer <at> localhost linux-2.6]$ make oldconfig
> scripts/kconfig/conf -o arch/powerpc/Kconfig
> #
> # using defaults found in /boot/config-2.6.25.13-104.fc9.ppc64
> #
(Continue reading)

Josh Boyer | 3 Aug 2008 01:58
Picon

Re: Kconfig no longer outputs a .config with freshly updated defconfigs

On Sat, 2 Aug 2008 22:26:47 +0300
Adrian Bunk <bunk <at> kernel.org> wrote:

> On Sat, Aug 02, 2008 at 12:03:33PM -0400, Josh Boyer wrote:
> > I was going through the somewhat tedious task of updating the 4xx
> > defconfigs today, and I noticed some odd behavior from Kconfig.
> > Basically, I would do:
> > 
> > 	make ppc44x_defconfig
> > 	make oldconfig
> > 	<build>
> > 	cp .config arch/powerpc/configs/ppc44x_defconfig
> > 	make distclean
> > 
> > I did this for a number of configs.  Then I went back and tried to build
> > ppc44x_defconfig again and I got this result:
> > 
> > [jwboyer <at> localhost linux-2.6]$ make ppc44x_defconfig
> >   HOSTCC  scripts/basic/fixdep
> >   HOSTCC  scripts/basic/docproc
> >   HOSTCC  scripts/kconfig/conf.o
> >   HOSTCC  scripts/kconfig/kxgettext.o
> >   SHIPPED scripts/kconfig/zconf.tab.c
> >   SHIPPED scripts/kconfig/lex.zconf.c
> >   SHIPPED scripts/kconfig/zconf.hash.c
> >   HOSTCC  scripts/kconfig/zconf.tab.o
> > scripts/kconfig/lex.zconf.c:1628: warning: ‘input’ defined but not used
> >   HOSTLD  scripts/kconfig/conf
> > [jwboyer <at> localhost linux-2.6]$ make oldconfig
> > scripts/kconfig/conf -o arch/powerpc/Kconfig
(Continue reading)

Sam Ravnborg | 3 Aug 2008 10:00
Gravatar

Re: Kconfig no longer outputs a .config with freshly updated defconfigs

On Sat, Aug 02, 2008 at 10:26:47PM +0300, Adrian Bunk wrote:
> On Sat, Aug 02, 2008 at 12:03:33PM -0400, Josh Boyer wrote:
> > I was going through the somewhat tedious task of updating the 4xx
> > defconfigs today, and I noticed some odd behavior from Kconfig.
> > Basically, I would do:
> > 
> > 	make ppc44x_defconfig
> > 	make oldconfig
> > 	<build>
> > 	cp .config arch/powerpc/configs/ppc44x_defconfig
> > 	make distclean
> > 
> > I did this for a number of configs.  Then I went back and tried to build
> > ppc44x_defconfig again and I got this result:
> > 
> > [jwboyer <at> localhost linux-2.6]$ make ppc44x_defconfig
> >   HOSTCC  scripts/basic/fixdep
> >   HOSTCC  scripts/basic/docproc
> >   HOSTCC  scripts/kconfig/conf.o
> >   HOSTCC  scripts/kconfig/kxgettext.o
> >   SHIPPED scripts/kconfig/zconf.tab.c
> >   SHIPPED scripts/kconfig/lex.zconf.c
> >   SHIPPED scripts/kconfig/zconf.hash.c
> >   HOSTCC  scripts/kconfig/zconf.tab.o
> > scripts/kconfig/lex.zconf.c:1628: warning: ‘input’ defined but not used
> >   HOSTLD  scripts/kconfig/conf
> > [jwboyer <at> localhost linux-2.6]$ make oldconfig
> > scripts/kconfig/conf -o arch/powerpc/Kconfig
> > #
> > # using defaults found in /boot/config-2.6.25.13-104.fc9.ppc64
(Continue reading)

Adrian Bunk | 3 Aug 2008 12:07

Re: Kconfig no longer outputs a .config with freshly updated defconfigs

On Sun, Aug 03, 2008 at 10:00:19AM +0200, Sam Ravnborg wrote:
> On Sat, Aug 02, 2008 at 10:26:47PM +0300, Adrian Bunk wrote:
> > On Sat, Aug 02, 2008 at 12:03:33PM -0400, Josh Boyer wrote:
> > > I was going through the somewhat tedious task of updating the 4xx
> > > defconfigs today, and I noticed some odd behavior from Kconfig.
> > > Basically, I would do:
> > > 
> > > 	make ppc44x_defconfig
> > > 	make oldconfig
> > > 	<build>
> > > 	cp .config arch/powerpc/configs/ppc44x_defconfig
> > > 	make distclean
> > > 
> > > I did this for a number of configs.  Then I went back and tried to build
> > > ppc44x_defconfig again and I got this result:
> > > 
> > > [jwboyer <at> localhost linux-2.6]$ make ppc44x_defconfig
> > >   HOSTCC  scripts/basic/fixdep
> > >   HOSTCC  scripts/basic/docproc
> > >   HOSTCC  scripts/kconfig/conf.o
> > >   HOSTCC  scripts/kconfig/kxgettext.o
> > >   SHIPPED scripts/kconfig/zconf.tab.c
> > >   SHIPPED scripts/kconfig/lex.zconf.c
> > >   SHIPPED scripts/kconfig/zconf.hash.c
> > >   HOSTCC  scripts/kconfig/zconf.tab.o
> > > scripts/kconfig/lex.zconf.c:1628: warning: ‘input’ defined but not used
> > >   HOSTLD  scripts/kconfig/conf
> > > [jwboyer <at> localhost linux-2.6]$ make oldconfig
> > > scripts/kconfig/conf -o arch/powerpc/Kconfig
> > > #
(Continue reading)

Geert Uytterhoeven | 4 Aug 2008 09:02

`make oldconfig' no longer updating `.config.old'?

	Hi,

I have the habit of doing `make .config{.old,}' after each config run,
to see what was changed. But since a few weeks, `make oldconfig' no longer
seems to update `.config.old'.

This also breaks the default behavior of `scripts/diffconfig' (`If no
config files are specified, .config and .config.old are used.').

Was this change intentional?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert <at> linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
Sam Ravnborg | 4 Aug 2008 22:10
Gravatar

Re: `make oldconfig' no longer updating `.config.old'?

On Mon, Aug 04, 2008 at 09:02:43AM +0200, Geert Uytterhoeven wrote:
> 	Hi,
> 
> I have the habit of doing `make .config{.old,}' after each config run,
> to see what was changed. But since a few weeks, `make oldconfig' no longer
> seems to update `.config.old'.
> 
> This also breaks the default behavior of `scripts/diffconfig' (`If no
> config files are specified, .config and .config.old are used.').
> 
> Was this change intentional?

.config is with current kconfig updated only if a user visible
symbol changes (or something like that).
I had another similar report where .config was not created if
missing and confi was not changed.

Fix is below and I will commit it soon.

	Sam

diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 9fba838..36b5eed 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
 <at>  <at>  -596,7 +596,7  <at>  <at>  int main(int ac, char **av)
 		break;
 	}

-	if (conf_get_changed() && conf_write(NULL)) {
(Continue reading)

Sam Ravnborg | 4 Aug 2008 23:01
Gravatar

[GIT PULL] kbuild fixes

Hi Linus.

Please pull the following two kconfig related fixes.

	Sam

The following changes since commit 48a61569bb5396415c5dad0e81e1cfeb87c0aca3:
  Adrian Bunk (1):
        kbuild: scripts/ver_linux: don't set PATH

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/sam/kbuild-fixes.git master

Sam Ravnborg (2):
      kconfig: always write out .config
      kconfig: drop the ""trying to assign nonexistent symbol" warning

 scripts/kconfig/conf.c     |    2 +-
 scripts/kconfig/confdata.c |    8 ++------
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 9fba838..36b5eed 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
 <at>  <at>  -596,7 +596,7  <at>  <at>  int main(int ac, char **av)
 		break;
 	}

(Continue reading)

Sam Ravnborg | 4 Aug 2008 23:08
Gravatar

Re: Kconfig no longer outputs a .config with freshly updated defconfigs

On Sun, Aug 03, 2008 at 01:07:32PM +0300, Adrian Bunk wrote:
> On Sun, Aug 03, 2008 at 10:00:19AM +0200, Sam Ravnborg wrote:
> > On Sat, Aug 02, 2008 at 10:26:47PM +0300, Adrian Bunk wrote:
> > > On Sat, Aug 02, 2008 at 12:03:33PM -0400, Josh Boyer wrote:
> > > > I was going through the somewhat tedious task of updating the 4xx
> > > > defconfigs today, and I noticed some odd behavior from Kconfig.
> > > > Basically, I would do:
> > > > 
> > > > 	make ppc44x_defconfig
> > > > 	make oldconfig
> > > > 	<build>
> > > > 	cp .config arch/powerpc/configs/ppc44x_defconfig
> > > > 	make distclean
> > > > 
> > > > I did this for a number of configs.  Then I went back and tried to build
> > > > ppc44x_defconfig again and I got this result:
> > > > 
> > > > [jwboyer <at> localhost linux-2.6]$ make ppc44x_defconfig
> > > >   HOSTCC  scripts/basic/fixdep
> > > >   HOSTCC  scripts/basic/docproc
> > > >   HOSTCC  scripts/kconfig/conf.o
> > > >   HOSTCC  scripts/kconfig/kxgettext.o
> > > >   SHIPPED scripts/kconfig/zconf.tab.c
> > > >   SHIPPED scripts/kconfig/lex.zconf.c
> > > >   SHIPPED scripts/kconfig/zconf.hash.c
> > > >   HOSTCC  scripts/kconfig/zconf.tab.o
> > > > scripts/kconfig/lex.zconf.c:1628: warning: ‘input’ defined but not used
> > > >   HOSTLD  scripts/kconfig/conf
> > > > [jwboyer <at> localhost linux-2.6]$ make oldconfig
> > > > scripts/kconfig/conf -o arch/powerpc/Kconfig
(Continue reading)


Gmane