kirin.vanderveer | 8 Jul 06:57 2014
Picon

[FEATURE REQUEST] Warning on long passwords

Hi all,
While setting up iSCSI for the first time on a Debian box, I ran into some authentication errors that turned out to be because I was using a password on the target and initiator that was longer than 16 chars.
It would have been helpful if when iscsiadm encountered such long passwords if it said something like:
"Warning: Out of spec/too long password detected"

Thanks for all the hard work making open-iscsi BTW.

Kirin.

IMPORTANT NOTE. If you are NOT AN AUTHORISED RECIPIENT of this e-mail, please contact Planet Innovation Pty Ltd by return e-mail or by telephone on +613 9945 7510.  In this case, you should not read, print, re-transmit, store or act in reliance on this e-mail or any attachments, and should destroy all copies of them.  This e-mail and any attachments are confidential and may contain legally privileged information and/or copyright material of Planet Innovation Pty Ltd or third parties.  You should only re-transmit, distribute or commercialise the material if you are authorised to do so.  Although we use virus scanning software, we deny all liability for viruses or alike in any message or attachment. This notice should not be removed.

--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
vikas.chaudhary | 3 Jul 14:22 2014

[PATCH] iscsiuio: Rebranding iscsiuio

From: Vikas Chaudhary <vikas.chaudhary@...>

QLogic has acquired the NetXtremeII products and drivers from Broadcom.
This patch re-brands iscsiuio as QLogic driver.

Signed-off-by: Vikas Chaudhary <vikas.chaudhary@...>
Acked-by: Eddie Wai <eddie.wai@...>
---
 iscsiuio/README                           | 12 ++++-----
 iscsiuio/RELEASE.TXT                      |  9 ++++---
 iscsiuio/configure.ac                     |  3 ++-
 iscsiuio/docs/iscsiuio.8                  |  9 ++++---
 iscsiuio/src/apps/brcm-iscsi/brcm_iscsi.c |  1 +
 iscsiuio/src/apps/brcm-iscsi/brcm_iscsi.h |  1 +
 iscsiuio/src/apps/dhcpc/dhcpv6.c          |  1 +
 iscsiuio/src/apps/dhcpc/dhcpv6.h          |  3 ++-
 iscsiuio/src/uip/icmpv6.h                 |  1 +
 iscsiuio/src/uip/ipv6.c                   |  1 +
 iscsiuio/src/uip/ipv6.h                   |  1 +
 iscsiuio/src/uip/ipv6_ndpc.c              |  1 +
 iscsiuio/src/uip/ipv6_ndpc.h              |  1 +
 iscsiuio/src/uip/ipv6_pkt.h               |  1 +
 iscsiuio/src/uip/uip_eth.c                |  1 +
 iscsiuio/src/unix/iscsid_ipc.c            |  1 +
 iscsiuio/src/unix/iscsid_ipc.h            |  1 +
 iscsiuio/src/unix/libs/bnx2.c             | 17 ++++++------
 iscsiuio/src/unix/libs/bnx2.h             |  1 +
 iscsiuio/src/unix/libs/bnx2x.c            | 45 ++++++++++++++++---------------
 iscsiuio/src/unix/libs/cnic.c             |  1 +
 iscsiuio/src/unix/libs/cnic.h             |  1 +
 iscsiuio/src/unix/logger.c                |  1 +
 iscsiuio/src/unix/logger.h                |  1 +
 iscsiuio/src/unix/nic.c                   |  1 +
 iscsiuio/src/unix/nic.h                   |  1 +
 iscsiuio/src/unix/nic_id.c                |  1 +
 iscsiuio/src/unix/nic_id.h                |  1 +
 iscsiuio/src/unix/nic_nl.c                |  1 +
 iscsiuio/src/unix/nic_nl.h                |  1 +
 iscsiuio/src/unix/nic_utils.c             |  1 +
 iscsiuio/src/unix/nic_utils.h             |  1 +
 iscsiuio/src/unix/nic_vlan.c              |  1 +
 iscsiuio/src/unix/nic_vlan.h              |  1 +
 iscsiuio/src/unix/options.h               |  1 +
 iscsiuio/src/unix/packet.c                |  1 +
 iscsiuio/src/unix/packet.h                |  1 +
 37 files changed, 83 insertions(+), 45 deletions(-)

diff --git a/iscsiuio/README b/iscsiuio/README
index a283116..9ae1411 100644
--- a/iscsiuio/README
+++ b/iscsiuio/README
 <at>  <at>  -3,11 +3,11  <at>  <at>  Version 0.7.8.2
 Dec 10, 2013
 ------------------------------------------------------

-This tool is to be used in conjunction with the Broadcom NetXtreme II Linux
-driver (Kernel module name: 'bnx2' and 'bnx2x'), Broadcom CNIC driver,
-and the Broadcom iSCSI driver (Kernel module name: 'bnx2i').
+This tool is to be used in conjunction with the QLogic NetXtreme II Linux
+driver (Kernel module name: 'bnx2' and 'bnx2x'), QLogic CNIC driver,
+and the QLogic iSCSI driver (Kernel module name: 'bnx2i').
 This user space tool is used in conjunction with the following
-Broadcom Network Controllers:
+QLogic Network Controllers:
   bnx2:  BCM5706, BCM5708, BCM5709 devices
   bnx2x: BCM57710, BCM57711, BCM57711E, BCM57712, BCM57712E,
          BCM57800, BCM57810, BCM57840 devices
 <at>  <at>  -25,8 +25,8  <at>  <at>  Dependencies:
 =======================================

 Linux Kernel Dependencies:
-1.  Broadcom CNIC driver (cnic)
-1.  Broadcom iSCSI offload driver (bnx2i)
+1.  QLogic CNIC driver (cnic)
+1.  QLogic iSCSI offload driver (bnx2i)
 2.  Userspace I/O driver (uio)

 Directory Structure of this Package:
diff --git a/iscsiuio/RELEASE.TXT b/iscsiuio/RELEASE.TXT
index 48feedd..44d67f9 100644
--- a/iscsiuio/RELEASE.TXT
+++ b/iscsiuio/RELEASE.TXT
 <at>  <at>  -1,13 +1,14  <at>  <at> 
                               Release Notes
-                        Broadcom uIP Linux Driver
+                        QLogic uIP Linux Driver
                             Version 0.7.8.2
                                12/10/2013

-                          Broadcom Corporation
-                         5300 California Avenue,
-                            Irvine, CA 92617
+                          QLogic Corporation
+                        26650 Aliso Viejo Pkwy,
+                         Aliso Viejo, CA 92656

                Copyright (c) 2004 - 2013 Broadcom Corporation
+                   Copyright (c) 2014, QLogic Corporation
                            All rights reserved

 uIP v0.7.10.2 (Feb 12, 2014)
diff --git a/iscsiuio/configure.ac b/iscsiuio/configure.ac
index 4faee9e..d619598 100644
--- a/iscsiuio/configure.ac
+++ b/iscsiuio/configure.ac
 <at>  <at>  -1,6 +1,7  <at>  <at> 
 dnl iscsiuio uIP user space stack configure.ac file
 dnl
 dnl Copyright (c) 2004-2013 Broadcom Corporation
+dnl Copyright (c) 2014, QLogic Corporation
 dnl
 dnl This program is free software; you can redistribute it and/or modify
 dnl it under the terms of the GNU General Public License as published by
 <at>  <at>  -13,7 +14,7  <at>  <at>  dnl
 PACKAGE=iscsiuio
 VERSION=0.7.8.2

-AC_INIT([iscsiuio], [0.7.8.2], [eddie.wai@...])
+AC_INIT([iscsiuio], [0.7.8.2], [QLogic-Storage-Upstream@...])

 AM_INIT_AUTOMAKE
 AC_CONFIG_HEADER(config.h)
diff --git a/iscsiuio/docs/iscsiuio.8 b/iscsiuio/docs/iscsiuio.8
index 3b50409..b329979 100644
--- a/iscsiuio/docs/iscsiuio.8
+++ b/iscsiuio/docs/iscsiuio.8
 <at>  <at>  -1,11 +1,12  <at>  <at> 
 .\" Copyright (c) 2010-2013 Broadcom Corporation
+.\" Copyright (c) 2014, QLogic Corporation
 .\" This is free documentation; you can redistribute it and/or
 .\" modify it under the terms of the GNU General Public License as
 .\" published by the Free Software Foundation.
 .\"
 .\" bnx2.4,v 0.7.8.1b
 .\"
-.TH iscsiuio 8 "12/10/2013" "Broadcom Corporation"
+.TH iscsiuio 8 "12/10/2013" "QLogic Corporation"
 .\"
 .\" NAME part
 .\"
 <at>  <at>  -22,9 +23,9  <at>  <at>  iscsiuio \- iSCSI UserSpace I/O driver
 .\" DESCRIPTION part
 .\"
 .SH DESCRIPTION
-iscsiuio is the UserSpace I/O driver for the Broadcom NetXtreme II
+iscsiuio is the UserSpace I/O driver for the QLogic NetXtreme II
 BCM5706/5708/5709 series PCI/PCI-X Gigabit Ethernet Network Interface Card
-(NIC) and for the Broadcom NetXtreme II BCM57710/57711/57712/57800/57810/57840
+(NIC) and for the QLogic NetXtreme II BCM57710/57711/57712/57800/57810/57840
 series PCI-E 10 Gigabit Ethernet Network Interface Card.
 The driver has been tested on 2.6.28 kernels and above.
 .PP
 <at>  <at>  -84,3 +85,5  <at>  <at>  Display this help and exit.
 Benjamin Li \- benli@...
 .P
 Eddie Wai \- eddie.wai@...
+.SH Maintained by
+QLogic-Storage-Upstream@...
diff --git a/iscsiuio/src/apps/brcm-iscsi/brcm_iscsi.c b/iscsiuio/src/apps/brcm-iscsi/brcm_iscsi.c
index 7979774..4223ca4 100644
--- a/iscsiuio/src/apps/brcm-iscsi/brcm_iscsi.c
+++ b/iscsiuio/src/apps/brcm-iscsi/brcm_iscsi.c
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li <benli@...>
  *              Based on code example from Adam Dunkels
diff --git a/iscsiuio/src/apps/brcm-iscsi/brcm_iscsi.h b/iscsiuio/src/apps/brcm-iscsi/brcm_iscsi.h
index f008471..10bfc95 100644
--- a/iscsiuio/src/apps/brcm-iscsi/brcm_iscsi.h
+++ b/iscsiuio/src/apps/brcm-iscsi/brcm_iscsi.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li <benli@...>
  *              Based on code example from Adam Dunkels
diff --git a/iscsiuio/src/apps/dhcpc/dhcpv6.c b/iscsiuio/src/apps/dhcpc/dhcpv6.c
index a92209a..bfaf269 100644
--- a/iscsiuio/src/apps/dhcpc/dhcpv6.c
+++ b/iscsiuio/src/apps/dhcpc/dhcpv6.c
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Eddie Wai <eddie.wai@...>
  *              Based on code from Kevin Tran's iSCSI boot code
diff --git a/iscsiuio/src/apps/dhcpc/dhcpv6.h b/iscsiuio/src/apps/dhcpc/dhcpv6.h
index f82cfdb..d4ec4b9 100644
--- a/iscsiuio/src/apps/dhcpc/dhcpv6.h
+++ b/iscsiuio/src/apps/dhcpc/dhcpv6.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Eddie Wai <eddie.wai@...>
  *              Based on code from Kevin Tran's iSCSI boot code
 <at>  <at>  -227,7 +228,7  <at>  <at>  struct dhcpv6_option {

 #define IANA_ENTERPRISE_NUM_BROADCOM   0x113d

-/* Broadcom Extended DHCP options used in iSCSI boot */
+/* QLogic Extended DHCP options used in iSCSI boot */
 #define DHCPV6_TAG_FIRST_ISCSI_TARGET_NAME              201
 #define DHCPV6_TAG_SECOND_ISCSI_TARGET_NAME             202
 #define DHCPV6_TAG_ISCSI_INITIATOR_NAME                 203
diff --git a/iscsiuio/src/uip/icmpv6.h b/iscsiuio/src/uip/icmpv6.h
index 9b00d82..cbf9aa8 100644
--- a/iscsiuio/src/uip/icmpv6.h
+++ b/iscsiuio/src/uip/icmpv6.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by: Eddie Wai  (eddie.wai@...)
  *             Based on Kevin Tran's iSCSI boot code
diff --git a/iscsiuio/src/uip/ipv6.c b/iscsiuio/src/uip/ipv6.c
index edaa2e9..cf92bdd 100644
--- a/iscsiuio/src/uip/ipv6.c
+++ b/iscsiuio/src/uip/ipv6.c
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Eddie Wai  (eddie.wai@...)
  *              Based on Kevin Tran's iSCSI boot code
diff --git a/iscsiuio/src/uip/ipv6.h b/iscsiuio/src/uip/ipv6.h
index 91bfaa6..231f454 100644
--- a/iscsiuio/src/uip/ipv6.h
+++ b/iscsiuio/src/uip/ipv6.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Eddie Wai  (eddie.wai@...)
  *              Based on Kevin Tran's iSCSI boot code
diff --git a/iscsiuio/src/uip/ipv6_ndpc.c b/iscsiuio/src/uip/ipv6_ndpc.c
index 6f965f4..a396cb7 100644
--- a/iscsiuio/src/uip/ipv6_ndpc.c
+++ b/iscsiuio/src/uip/ipv6_ndpc.c
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Eddie Wai  (eddie.wai@...)
  *              Based on the Swedish Institute of Computer Science's
diff --git a/iscsiuio/src/uip/ipv6_ndpc.h b/iscsiuio/src/uip/ipv6_ndpc.h
index 1eaced9..709a050 100644
--- a/iscsiuio/src/uip/ipv6_ndpc.h
+++ b/iscsiuio/src/uip/ipv6_ndpc.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Eddie Wai  (eddie.wai@...)
  *
diff --git a/iscsiuio/src/uip/ipv6_pkt.h b/iscsiuio/src/uip/ipv6_pkt.h
index e0da018..b42f1aa 100644
--- a/iscsiuio/src/uip/ipv6_pkt.h
+++ b/iscsiuio/src/uip/ipv6_pkt.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Eddie Wai  (eddie.wai@...)
  *              Based on Kevin Tran's iSCSI boot code
diff --git a/iscsiuio/src/uip/uip_eth.c b/iscsiuio/src/uip/uip_eth.c
index 449616e..9e1ea81 100644
--- a/iscsiuio/src/uip/uip_eth.c
+++ b/iscsiuio/src/uip/uip_eth.c
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/iscsid_ipc.c b/iscsiuio/src/unix/iscsid_ipc.c
index 0b9b18c..4a89ec2 100644
--- a/iscsiuio/src/unix/iscsid_ipc.c
+++ b/iscsiuio/src/unix/iscsid_ipc.c
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/iscsid_ipc.h b/iscsiuio/src/unix/iscsid_ipc.h
index 30843fb..60bcd71 100644
--- a/iscsiuio/src/unix/iscsid_ipc.h
+++ b/iscsiuio/src/unix/iscsid_ipc.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/libs/bnx2.c b/iscsiuio/src/unix/libs/bnx2.c
index 91c44e5..937336e 100644
--- a/iscsiuio/src/unix/libs/bnx2.c
+++ b/iscsiuio/src/unix/libs/bnx2.c
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
 <at>  <at>  -75,20 +76,20  <at>  <at>  static const char cnic_uio_sysfs_name[] = "bnx2_cnic";
 /*******************************************************************************
  * String constants used to display human readable adapter name
  ******************************************************************************/
-static const char brcm_5706C[] = "Broadcom NetXtreme II BCM5706 1000Base-T";
+static const char brcm_5706C[] = "QLogic NetXtreme II BCM5706 1000Base-T";
 static const char hp_NC370T[] =
 	"HP NC370T Multifunction Gigabit Server Adapter";
 static const char hp_NC370I[] =
 	"HP NC370i Multifunction Gigabit Server Adapter";
-static const char brcm_5706S[] = "Broadcom NetXtreme II BCM5706 1000Base-SX";
+static const char brcm_5706S[] = "QLogic NetXtreme II BCM5706 1000Base-SX";
 static const char hp_NC370F[] =
 	"HP NC370F Multifunction Gigabit Server Adapter";
-static const char brcm_5708C[] = "Broadcom NetXtreme II BCM5708 1000Base-T";
-static const char brcm_5708S[] = "Broadcom NetXtreme II BCM5708 1000Base-SX";
-static const char brcm_5709C[] = "Broadcom NetXtreme II BCM5709 1000Base-T";
-static const char brcm_5709S[] = "Broadcom NetXtreme II BCM5709 1000Base-SX";
-static const char brcm_5716C[] = "Broadcom NetXtreme II BCM5716 1000Base-T";
-static const char brcm_5716S[] = "Broadcom NetXtreme II BCM5716 1000Base-SX";
+static const char brcm_5708C[] = "QLogic NetXtreme II BCM5708 1000Base-T";
+static const char brcm_5708S[] = "QLogic NetXtreme II BCM5708 1000Base-SX";
+static const char brcm_5709C[] = "QLogic NetXtreme II BCM5709 1000Base-T";
+static const char brcm_5709S[] = "QLogic NetXtreme II BCM5709 1000Base-SX";
+static const char brcm_5716C[] = "QLogic NetXtreme II BCM5716 1000Base-T";
+static const char brcm_5716S[] = "QLogic NetXtreme II BCM5716 1000Base-SX";

 /*******************************************************************************
  * PCI ID constants
diff --git a/iscsiuio/src/unix/libs/bnx2.h b/iscsiuio/src/unix/libs/bnx2.h
index c025542..3ec9437 100644
--- a/iscsiuio/src/unix/libs/bnx2.h
+++ b/iscsiuio/src/unix/libs/bnx2.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/libs/bnx2x.c b/iscsiuio/src/unix/libs/bnx2x.c
index 748b59d..1268975 100644
--- a/iscsiuio/src/unix/libs/bnx2x.c
+++ b/iscsiuio/src/unix/libs/bnx2x.c
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
 <at>  <at>  -80,39 +81,39  <at>  <at>  static const char bnx2x_uio_sysfs_name[] = "bnx2x_cnic";
 /*******************************************************************************
  * String constants used to display human readable adapter name
  ******************************************************************************/
-static const char brcm_57710[] = "Broadcom NetXtreme II BCM57710 10-Gigabit";
-static const char brcm_57711[] = "Broadcom NetXtreme II BCM57711 10-Gigabit";
-static const char brcm_57711e[] = "Broadcom NetXtreme II BCM57711E 10-Gigabit";
-static const char brcm_57712[] = "Broadcom NetXtreme II BCM57712 10-Gigabit";
-static const char brcm_57712_MF[] = "Broadcom NetXtreme II BCM57712 MF "
+static const char brcm_57710[] = "QLogic NetXtreme II BCM57710 10-Gigabit";
+static const char brcm_57711[] = "QLogic NetXtreme II BCM57711 10-Gigabit";
+static const char brcm_57711e[] = "QLogic NetXtreme II BCM57711E 10-Gigabit";
+static const char brcm_57712[] = "QLogic NetXtreme II BCM57712 10-Gigabit";
+static const char brcm_57712_MF[] = "QLogic NetXtreme II BCM57712 MF "
 				    "10-Gigabit";
-static const char brcm_57712_VF[] = "Broadcom NetXtreme II BCM57712 VF "
+static const char brcm_57712_VF[] = "QLogic NetXtreme II BCM57712 VF "
 				    "10-Gigabit";
-static const char brcm_57713[] = "Broadcom NetXtreme II BCM57713 10-Gigabit";
-static const char brcm_57713e[] = "Broadcom NetXtreme II BCM57713E 10-Gigabit";
-static const char brcm_57800[] = "Broadcom NetXtreme II BCM57800 10-Gigabit";
-static const char brcm_57800_MF[] = "Broadcom NetXtreme II BCM57800 MF "
+static const char brcm_57713[] = "QLogic NetXtreme II BCM57713 10-Gigabit";
+static const char brcm_57713e[] = "QLogic NetXtreme II BCM57713E 10-Gigabit";
+static const char brcm_57800[] = "QLogic NetXtreme II BCM57800 10-Gigabit";
+static const char brcm_57800_MF[] = "QLogic NetXtreme II BCM57800 MF "
 				    "10-Gigabit";
-static const char brcm_57800_VF[] = "Broadcom NetXtreme II BCM57800 VF "
+static const char brcm_57800_VF[] = "QLogic NetXtreme II BCM57800 VF "
 				    "10-Gigabit";
-static const char brcm_57810[] = "Broadcom NetXtreme II BCM57810 10-Gigabit";
-static const char brcm_57810_MF[] = "Broadcom NetXtreme II BCM57810 MF "
+static const char brcm_57810[] = "QLogic NetXtreme II BCM57810 10-Gigabit";
+static const char brcm_57810_MF[] = "QLogic NetXtreme II BCM57810 MF "
 				    "10-Gigabit";
-static const char brcm_57810_VF[] = "Broadcom NetXtreme II BCM57810 VF "
+static const char brcm_57810_VF[] = "QLogic NetXtreme II BCM57810 VF "
 				    "10-Gigabit";
-static const char brcm_57811[] = "Broadcom NetXtreme II BCM57811 10-Gigabit";
-static const char brcm_57811_MF[] = "Broadcom NetXtreme II BCM57811 MF "
+static const char brcm_57811[] = "QLogic NetXtreme II BCM57811 10-Gigabit";
+static const char brcm_57811_MF[] = "QLogic NetXtreme II BCM57811 MF "
 				    "10-Gigabit";
-static const char brcm_57811_VF[] = "Broadcom NetXtreme II BCM57811 VF "
+static const char brcm_57811_VF[] = "QLogic NetXtreme II BCM57811 VF "
 				    "10-Gigabit";
-static const char brcm_57840[] = "Broadcom NetXtreme II BCM57840 10-Gigabit";
-static const char brcm_57840_MF[] = "Broadcom NetXtreme II BCM57840 MF "
+static const char brcm_57840[] = "QLogic NetXtreme II BCM57840 10-Gigabit";
+static const char brcm_57840_MF[] = "QLogic NetXtreme II BCM57840 MF "
 				    "10-Gigabit";
-static const char brcm_57840_VF[] = "Broadcom NetXtreme II BCM57840 VF "
+static const char brcm_57840_VF[] = "QLogic NetXtreme II BCM57840 VF "
 				    "10-Gigabit";
-static const char brcm_57840_4_10[] = "Broadcom NetXtreme II BCM57840 4x"
+static const char brcm_57840_4_10[] = "QLogic NetXtreme II BCM57840 4x"
 				      "10-Gigabit";
-static const char brcm_57840_2_20[] = "Broadcom NetXtreme II BCM57840 2x"
+static const char brcm_57840_2_20[] = "QLogic NetXtreme II BCM57840 2x"
 				      "20-Gigabit";

 /*******************************************************************************
diff --git a/iscsiuio/src/unix/libs/cnic.c b/iscsiuio/src/unix/libs/cnic.c
index 6ba8bce..7f473c4 100644
--- a/iscsiuio/src/unix/libs/cnic.c
+++ b/iscsiuio/src/unix/libs/cnic.c
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by: Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/libs/cnic.h b/iscsiuio/src/unix/libs/cnic.h
index 3e53307..6244a94 100644
--- a/iscsiuio/src/unix/libs/cnic.h
+++ b/iscsiuio/src/unix/libs/cnic.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/logger.c b/iscsiuio/src/unix/logger.c
index 1a65793..d41f9e8 100644
--- a/iscsiuio/src/unix/logger.c
+++ b/iscsiuio/src/unix/logger.c
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by: Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/logger.h b/iscsiuio/src/unix/logger.h
index edf85ae..06e2084 100644
--- a/iscsiuio/src/unix/logger.h
+++ b/iscsiuio/src/unix/logger.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/nic.c b/iscsiuio/src/unix/nic.c
index 18e3007..e00e8f2 100644
--- a/iscsiuio/src/unix/nic.c
+++ b/iscsiuio/src/unix/nic.c
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/nic.h b/iscsiuio/src/unix/nic.h
index 7d1ae28..8484032 100644
--- a/iscsiuio/src/unix/nic.h
+++ b/iscsiuio/src/unix/nic.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/nic_id.c b/iscsiuio/src/unix/nic_id.c
index 8f21ba9..6b2467c 100644
--- a/iscsiuio/src/unix/nic_id.c
+++ b/iscsiuio/src/unix/nic_id.c
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/nic_id.h b/iscsiuio/src/unix/nic_id.h
index 8d1e1db..340580f 100644
--- a/iscsiuio/src/unix/nic_id.h
+++ b/iscsiuio/src/unix/nic_id.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/nic_nl.c b/iscsiuio/src/unix/nic_nl.c
index 3ab4eb9..391003f 100644
--- a/iscsiuio/src/unix/nic_nl.c
+++ b/iscsiuio/src/unix/nic_nl.c
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/nic_nl.h b/iscsiuio/src/unix/nic_nl.h
index 90f76be..c68d81c 100644
--- a/iscsiuio/src/unix/nic_nl.h
+++ b/iscsiuio/src/unix/nic_nl.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/nic_utils.c b/iscsiuio/src/unix/nic_utils.c
index fee9a4b..cc11f9a 100644
--- a/iscsiuio/src/unix/nic_utils.c
+++ b/iscsiuio/src/unix/nic_utils.c
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/nic_utils.h b/iscsiuio/src/unix/nic_utils.h
index 2644e43..962d130 100644
--- a/iscsiuio/src/unix/nic_utils.h
+++ b/iscsiuio/src/unix/nic_utils.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/nic_vlan.c b/iscsiuio/src/unix/nic_vlan.c
index d371ec5..eb33381 100644
--- a/iscsiuio/src/unix/nic_vlan.c
+++ b/iscsiuio/src/unix/nic_vlan.c
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/nic_vlan.h b/iscsiuio/src/unix/nic_vlan.h
index f7293d4..610f721 100644
--- a/iscsiuio/src/unix/nic_vlan.h
+++ b/iscsiuio/src/unix/nic_vlan.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/options.h b/iscsiuio/src/unix/options.h
index 9691c4e..df03255 100644
--- a/iscsiuio/src/unix/options.h
+++ b/iscsiuio/src/unix/options.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/packet.c b/iscsiuio/src/unix/packet.c
index 1657d73..efb3eec 100644
--- a/iscsiuio/src/unix/packet.c
+++ b/iscsiuio/src/unix/packet.c
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
diff --git a/iscsiuio/src/unix/packet.h b/iscsiuio/src/unix/packet.h
index f62b685..b63d688 100644
--- a/iscsiuio/src/unix/packet.h
+++ b/iscsiuio/src/unix/packet.h
 <at>  <at>  -1,5 +1,6  <at>  <at> 
 /*
  * Copyright (c) 2009-2011, Broadcom Corporation
+ * Copyright (c) 2014, QLogic Corporation
  *
  * Written by:  Benjamin Li  (benli@...)
  *
-- 
1.8.2.GIT

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Hannes Reinecke | 30 Jun 11:43 2014
Picon

Target Portal Group tag usage in iscsistart

Hi Mike,

iscsistart has the Target Portal Group Tag (tpgt) set to 'required', 
ie without specifying it iscsistart won't attempt to connect to the 
target.

Now as we're not supporting MC/S anyway, the usage of tpgt is pretty 
much defined by the target, ie we should be using whatever the 
target presents to us.

And there is no way of specifying the tpgt when using DHCP; RFC4173 
doesn't know about this and consequently doesn't specify it.

Can't we get rid of the mandatory usage in iscsistart and have it 
use the target-provided tpgt?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

felipe | 18 Jun 22:40 2014

iscsi initiator connecting to 2 address

Hi, I am connecting to the iscsi-target with open-iscsi. I don't know why my iscsi-initiator connect to 2 IP address on the same target name. Maybe is some wrong configuration on /etc/hosts.

Does anyone have any idea? Thanks in advance!

root <at> dell-felipe:~# iscsiadm -m node --login 10.0.1.37
Logging in to [iface: default, target: iqn.2014-06.ustore-test:disk1, portal: 127.0.0.1,3260] (multiple)
Logging in to [iface: default, target: iqn.2014-06.ustore-test:disk1, portal: 10.0.1.37,3260] (multiple)
Login to [iface: default, target: iqn.2014-06.ustore-test:disk1, portal: 127.0.0.1,3260] successful.
Login to [iface: default, target: iqn.2014-06.ustore-test:disk1, portal: 10.0.1.37,3260] successful.



--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
mabra | 14 Jun 00:38 2014
Picon

(i)SCSI initiator/target with ZFS ?

Hi All !

I am just on installing two new debian machines - migrating from windows server.
I am installing ZFS on boot [have this running for about two years], but needs
iSCSI in my network. If I see the comparision sheet given on the SCST page
on soureforge, you'll never need something else .... but: I could even not found
installation istructions. If I look deeper, there are several different forks from LIO
which are - naturally - all the best ones and I am finally completely out of hope :-(

Finally, I found this group ;-)
I saw the footer, dated from year 2005.

I need to provide networked disks and CD-ROMs to clients.
Is there someone, who may give me a hint ??
Is there a complete feature-list ?
Does it probably play with ZFS [I have to compile the kernel modules ...] ??
At best, I want to find debian setup instructions.

I am not a zynician, I am out of hope ...

Thanks anyway,

++mabra

--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
felipe | 11 Jun 19:10 2014

Does open-iscsi implement target and initiator?

Hi,

I am reading the http://www.open-iscsi.org/docs/README and I am not sure if open-iscsi is only for initiator.

Does open-iscsi implement target of iscsi on linux?

and this information says I could have blocks on my target?

single iSCSI session:

  • 450MB/s Read and 450 MB/s Write for 64KB block

Thanks!
Felipe

--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
Ariel Nahum | 8 Jun 14:45 2014

[PATCH] Fix possible infinite loop when conn bind fails

Currently, when conn bind fails, iscsi_conn_connect is called and it
reschedules the login_timer by adding it to the pending list while
it's actually already there. This will create an infinite loop when
the pending list is processed.

To fix that, use queue_delayed_reopen which first calls actor_delete
to make sure the actor is not in the list before rescheduling it.

Signed-off-by: Ariel Nahum <arieln@...>
Signed-off-by: Roi Dayan <roid@...>
---
 usr/initiator.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/usr/initiator.c b/usr/initiator.c
index 05a5b19..067cf0a 100644
--- a/usr/initiator.c
+++ b/usr/initiator.c
 <at>  <at>  -543,8 +543,7  <at>  <at>  static int iscsi_conn_connect(struct iscsi_conn *conn, queue_task_t *qtask)
 	iscsi_sched_ev_context(ev_context, conn, 0, EV_CONN_POLL);
 	log_debug(3, "Setting login timer %p timeout %d", &conn->login_timer,
 		  conn->login_timeout);
-	actor_timer(&conn->login_timer, conn->login_timeout * 1000,
-		    iscsi_login_timedout, qtask);
+	queue_delayed_reopen(qtask, conn->login_timeout);
 	return 0;
 }

-- 
1.7.1

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

garabedy | 4 Jun 15:20 2014
Picon

iSCSI Help Needed

Hello all,


I have a MSFT 2012 box which has 10TB of storage RAID6. I would like to setup the system to host several servers, an SQL server, a Fileserver and a SharePoint Server. I have created 3 targets on the storage server and will connect each server to its corresponding target. I read that connecting multiple initiators to a single target will cause data corruption. Will the same corruption occur if I have 3 targets each with its own server connected to it?

Diagram

--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
vichharaks ros | 4 Jun 14:11 2014
Picon

No new disk atatched

Hi,


Target server :

2.6.32-431.17.1.el6.centos.plus.x86_64
# rpm -qa | grep scsi
iscsi-initiator-utils-6.2.0.873-10.el6.x86_64
scsi-target-utils-1.0.24-12.el6_5.x86_64

# cat /etc/tgt/targets.conf
default-driver iscsi
<target iqn.2008-09.com.example:server.target1>
    backing-store /dev/vgiscsi/lviscsi1
    initiator-address 192.168.10.0/24
</target>

# tgtadm --lld iscsi --mode target --op show 
Target 1: iqn.2008-09.com.example:server.target1
    System information:
        Driver: iscsi
        State: ready
    I_T nexus information:
        I_T nexus: 1
            Initiator: iqn.1994-05.com.redhat:z400
            Connection: 0
                IP Address: 192.168.10.70
    LUN information:
        LUN: 0
            Type: controller
            SCSI ID: IET     00010000
            SCSI SN: beaf10
            Size: 0 MB, Block size: 1
            Online: Yes
            Removable media: No
            Prevent removal: No
            Readonly: No
            Backing store type: null
            Backing store path: None
            Backing store flags: 
    Account information:
    ACL information:
        192.168.10.0/24


Initiator host:

2.6.32-431.17.1.el6.x86_64 #1
# rpm -qa | grep scsi
iscsi-initiator-utils-6.2.0.873-10.el6.x86_64

# iscsiadm -m node
192.168.10.50:3260,1 iqn.2008-09.com.example:server.target1
# iscsiadm -m session
tcp: [1] 192.168.10.50:3260,1 iqn.2008-09.com.example:server.target1


# iscsiadm -m session -P 3
iSCSI Transport Class version 2.0-870
version 6.2.0-873.10.el6
Target: iqn.2008-09.com.example:server.target1
        Current Portal: 192.168.10.50:3260,1
        Persistent Portal: 192.168.10.50:3260,1
                **********
                Interface:
                **********
                Iface Name: iface0
                Iface Transport: tcp
                Iface Initiatorname: iqn.1994-05.com.redhat:z400
                Iface IPaddress: 192.168.10.70
                Iface HWaddress: F4:CE:46:2D:A6:E9
                Iface Netdev: <empty>
                SID: 1
                iSCSI Connection State: LOGGED IN
                iSCSI Session State: LOGGED_IN
                Internal iscsid Session State: NO CHANGE
                *********
                Timeouts:
                *********
                Recovery Timeout: 120
                Target Reset Timeout: 30
                LUN Reset Timeout: 30
                Abort Timeout: 15
                *****
                CHAP:
                *****
                username: <empty>
                password: ********
                username_in: <empty>
                password_in: ********
                ************************
                Negotiated iSCSI params:
                ************************
                HeaderDigest: None
                DataDigest: None
                MaxRecvDataSegmentLength: 262144
                MaxXmitDataSegmentLength: 8192
                FirstBurstLength: 65536
                MaxBurstLength: 262144
                ImmediateData: Yes
                InitialR2T: Yes
                MaxOutstandingR2T: 1
                ************************
                Attached SCSI devices:
                ************************
                Host Number: 6  State: running
                scsi6 Channel 00 Id 0 Lun: 0

# dmesg | grep scsi
scsi0 : ahci
scsi1 : ahci
scsi2 : ahci
scsi3 : ahci
scsi4 : ahci
scsi5 : ahci
scsi 1:0:0:0: Direct-Access     ATA      ST3500641AS      3.AH PQ: 0 ANSI: 5
sd 1:0:0:0: Attached scsi generic sg0 type 0
iscsi: registered transport (tcp)
iscsi: registered transport (iser)
iscsi: registered transport (cxgb3i)
iscsi: registered transport (cxgb4i)
iscsi: registered transport (bnx2i)
iscsi: registered transport (be2iscsi)
In beiscsi_module_init, tt=ffffffffa060ee80
scsi6 : iSCSI Initiator over TCP/IP
scsi 6:0:0:0: RAID              IET      Controller       0001 PQ: 0 ANSI: 5
scsi 6:0:0:0: Attached scsi generic sg1 type 12


# fdisk -l

Disk /dev/sda: 500.1 GB, 500107862016 bytes
255 heads, 63 sectors/track, 60801 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disk identifier: 0x4c05c860

   Device Boot      Start         End      Blocks   Id  System
/dev/sda1   *           1          64      512000   83  Linux
Partition 1 does not end on cylinder boundary.
/dev/sda2              64       60802   487873536   8e  Linux LVM


So my problem is that , no new iscsi disk is attached to the initiator host, any idea?

Thanks.

Vic.


--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
Garabed Yegavian | 4 Jun 15:26 2014
Picon

iscsi setup help

I have a Windows 2012 box which has 10tb of storage RAID6. I would like to use this server to house the data for 3 other servers, an SQL server, File server and SharePoint server. I have created 3 iscsi targets on the box and connected each server to its corresponding target. Then I read that there may be data corruption when connecting multiple initiators to a single target. Now I am wondering if the same is true for what I am trying to do? Looking for input please.


--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
Ariel Nahum | 9 Jun 08:44 2014

[PATCH] Fix infinite loop when conn bind fails

Currently, when conn bind fails, iscsi_conn_connect is called and it
reschedules the login_timer by adding it to the pending list while
it's actually already there. This will create an infinite loop when
the pending list is processed.

To fix that, use queue_delayed_reopen which first calls actor_delete
to make sure the actor is not in the list before rescheduling it.

Signed-off-by: Ariel Nahum <arieln@...>
Signed-off-by: Roi Dayan <roid@...>
---
 usr/initiator.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/usr/initiator.c b/usr/initiator.c
index 05a5b19..067cf0a 100644
--- a/usr/initiator.c
+++ b/usr/initiator.c
 <at>  <at>  -543,8 +543,7  <at>  <at>  static int iscsi_conn_connect(struct iscsi_conn *conn, queue_task_t *qtask)
 	iscsi_sched_ev_context(ev_context, conn, 0, EV_CONN_POLL);
 	log_debug(3, "Setting login timer %p timeout %d", &conn->login_timer,
 		  conn->login_timeout);
-	actor_timer(&conn->login_timer, conn->login_timeout * 1000,
-		    iscsi_login_timedout, qtask);
+	queue_delayed_reopen(qtask, conn->login_timeout);
 	return 0;
 }

-- 
1.7.1

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.


Gmane