Mike Christie | 22 Apr 20:28 2016
Picon

[ANNOUNCE] new open-iscsi maintainers

Hi open-iscsi list,

I am very happy to announce that Chris Leech and Lee Duncan will be
taking over open-iscsi maintainership.

They have created a new github organization:

https://github.com/open-iscsi

that will host the userspace code.

Send all userspace patches to the list and to Chris Leech
(cleech@...) and Lee Duncan (lduncan@...).

Send kernel patches to this list, myself, and also to Lee and Chris. In
the hopefully near future, they will be comfortable with taking over the
kernel code as well.

Thanks to Lee and Chris for taking this over!

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Bob Stlt | 17 Apr 17:05 2016

[PATCH] SCSI: LIBSCSI: Fixed codeing style errors

Fixed codeing style formatting errors.

Signed-off-by: Bob Stlt <bobstlt40@...>
---
 drivers/scsi/libiscsi.c | 90 ++++++++++++++++++++++++-------------------------
 1 file changed, 45 insertions(+), 45 deletions(-)

diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 6bffd91..41be9d3 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
 <at>  <at>  -197,7 +197,7  <at>  <at>  static int iscsi_prep_ecdb_ahs(struct iscsi_task *task)
 	pad_len = iscsi_padding(rlen);

 	rc = iscsi_add_hdr(task, sizeof(ecdb_ahdr->ahslength) +
-	                   sizeof(ecdb_ahdr->ahstype) + ahslength + pad_len);
+			sizeof(ecdb_ahdr->ahstype) + ahslength + pad_len);
 	if (rc)
 		return rc;

 <at>  <at>  -210,10 +210,10  <at>  <at>  static int iscsi_prep_ecdb_ahs(struct iscsi_task *task)
 	memcpy(ecdb_ahdr->ecdb, cmd->cmnd + ISCSI_CDB_SIZE, rlen);

 	ISCSI_DBG_SESSION(task->conn->session,
-			  "iscsi_prep_ecdb_ahs: varlen_cdb_len %d "
-		          "rlen %d pad_len %d ahs_length %d iscsi_headers_size "
-		          "%u\n", cmd->cmd_len, rlen, pad_len, ahslength,
-		          task->hdr_len);
+			"iscsi_prep_ecdb_ahs: varlen_cdb_len %d "
+			"rlen %d pad_len %d ahs_length %d iscsi_headers_size "
(Continue reading)

adheer.chandravanshi | 22 Apr 18:33 2016

iscsi tools: Support for host statistics

From: Adheer Chandravanshi <adheer.chandravanshi@...>

The following patch obsoletes the patchset posted earlier for
host stats.

This patch is based on kernel-based solution for host stats and
depends on following patches posted on linux-scsi list:
  scsi_transport_iscsi: Add support for stats param at host level
  libiscsi: Add support to update host stats param
  bnx2i: Enable support for host stats param

Adheer Chandravanshi (1):
  iscsiadm: Add support to show host stats from sysfs

 include/iscsi_if.h |   24 ++++++++++++++
 usr/idbm.c         |   39 +++++++++++++++++++++++
 usr/idbm.h         |    4 ++-
 usr/idbm_fields.h  |   13 ++++++++
 usr/iscsi_sysfs.c  |   86 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 usr/iscsi_sysfs.h  |    3 ++
 usr/iscsiadm.c     |   41 ++++++++++++++++++++-----
 usr/transport.c    |    1 +
 usr/transport.h    |    1 +
 9 files changed, 203 insertions(+), 9 deletions(-)

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at https://groups.google.com/group/open-iscsi.
(Continue reading)

adheer.chandravanshi | 22 Apr 15:39 2016

[PATCH 0/3] iscsi: Add statistics support for iscsi host

From: Adheer Chandravanshi <adheer.chandravanshi@...>

The following patches add the support to maintain some iscsi initiator
stats at the iscsi host level. The stats will be exposed using iscsi
host sysfs attrs.

This adds support for following stats:
       ISCSI_HOST_PARAM_LOGIN_ACCEPT_RSPS
       ISCSI_HOST_PARAM_LOGIN_OTHER_FAILS
       ISCSI_HOST_PARAM_LOGIN_AUTHENTICATION_FAILS
       ISCSI_HOST_PARAM_LOGIN_AUTHORIZATION_FAILS
       ISCSI_HOST_PARAM_LOGIN_NEGOTIATION_FAILS
       ISCSI_HOST_PARAM_LOGIN_REDIRECT_RSPS
       ISCSI_HOST_PARAM_LOGOUT_NORMAL_RSPS
       ISCSI_HOST_PARAM_LOGOUT_OTHER_RSPS
       ISCSI_HOST_PARAM_DIGEST_ERR
       ISCSI_HOST_PARAM_TIMEOUT_ERR
       ISCSI_HOST_PARAM_FORMAT_ERR
       ISCSI_HOST_PARAM_SESSION_FAILS

Adheer Chandravanshi (3):
  scsi_transport_iscsi: Add support for stats param at host level
  libiscsi: Add support to update host stats param
  bnx2i: Enable support for host stats param

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at https://groups.google.com/group/open-iscsi.
(Continue reading)

Chris Leech | 20 Apr 20:13 2016
Picon

github repo, picking up patches from this list

I've pushed some of my recent patches as well as a few others I picked
up from the list to my github repo https://github.com/cleech/open-iscsi

This is what's currently added there. If there's anything else that's
been reviewed on the list that needs to be applied let me know and I'll
add it.

Chris Leech (6):
      iscsi_tcp set SO_LINGER to abort connection for error handling
      iscsiadm: fix parallel rescan handling of exit codes
      iscsistart: support booting over a VLAN
      iscsid: safe_logout fix device path canonicalization by using libmount cache
      iscsid: make safe_logut session checks apply for flashnode session
      remove sysfs attr_list

Christian Seiler (1):
      Build system: sort object file lists

Lee Duncan (1):
      ARP table too small when switches involved.

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Chris Leech | 12 Apr 22:23 2016
Picon

[PATCH 1/5] iscsiadm: fix parallel rescan handling of exit codes

The parallel rescan patches work, in so much as the rescans happen, but
if a target is specified the non-matching cases cause warning to be
printed and a non-zero exit code.

To reproduce: have more than one session to different targets, issue a
node mode rescan command to one of them (-m node -T <iqn.target> -R).

The problem is that while exit() takes an int, only the low byte is part
of the exit code and it's combined with other exit status information.
iscsiadm tries to use exit(-1) to indicate a non-match (not a fatal
error). The value retrieved with wait() after an exit(-1) is actually
65280.

Fix this by making use of the wait.h macros for checking the exit code.

Signed-off-by: Chris Leech <cleech@...>
---
 include/iscsi_err.h |  2 ++
 usr/iscsi_err.c     |  1 +
 usr/iscsi_sysfs.c   | 20 +++++++++++++++++---
 3 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/include/iscsi_err.h b/include/iscsi_err.h
index 125f443..506bd8c 100644
--- a/include/iscsi_err.h
+++ b/include/iscsi_err.h
 <at>  <at>  -66,6 +66,8  <at>  <at>  enum {
 	ISCSI_ERR_AGAIN			= 29,
 	/* unknown discovery type */
 	ISCSI_ERR_UNKNOWN_DISCOVERY_TYPE = 30,
(Continue reading)

David Bond | 4 Apr 22:09 2016
Gravatar

Subject: [PATCH v2] ibft: Expose iBFT acpi header via sysfs


Some ethernet adapter vendors are supplying products which support optional
(payed license) features. On some adapters this includes a hardware iscsi
initiator.  The same adapters in a normal (no extra licenses) mode of
operation can be used as a software iscsi initiator.  In addition, software
iscsi boot initiators are becoming a standard part of many vendors uefi
implementations.  This is creating difficulties during early boot/install
determining the proper configuration method for these adapters when they
are used as a boot device.

The attached patch creates sysfs entries to expose information from the
acpi header of the ibft table.  This information allows for a method to
easily determining if an ibft table was created by a ethernet card's
firmware or the system uefi/bios.  In the case of a hardware initiator this
information in combination with the pci vendor and device id can be used
to ascertain any vendor specific behaviors that need to be accommodated.

Reviewed-by: Lee Duncan <lduncan@...>
Signed-off-by: David Bond <dbond@...>
---
 Documentation/ABI/testing/sysfs-ibft | 10 ++++++
 drivers/firmware/iscsi_ibft.c        | 67 +++++++++++++++++++++++++++++++++++-
 drivers/scsi/iscsi_boot_sysfs.c      | 62 +++++++++++++++++++++++++++++++++
 include/linux/iscsi_boot_sysfs.h     | 13 +++++++
 4 files changed, 151 insertions(+), 1 deletion(-)

diff --git a/Documentation/ABI/testing/sysfs-ibft b/Documentation/ABI/testing/sysfs-ibft
index cac3930..7d6725f 100644
--- a/Documentation/ABI/testing/sysfs-ibft
+++ b/Documentation/ABI/testing/sysfs-ibft
(Continue reading)

Richard Sharpe | 31 Mar 04:01 2016
Picon

Patch: It is not necessary to try to increase the priority of the wq thread from userspace

Hi folks,

We recently found that iscsid was iterating through /proc/≤pid>/stat
looking for the workqueue iscsi-q-NN and then setting its nice value
to -20.

Then we investigated some more because it seemed like this could be
more easily done from the kernel.

What we discovered is that with modern Linux kernels, at least since
3.10.0 and possibly earlier, the thread called <wq-name> is not the
actual workqueue thread, it is the rescue thread for the workqueue,
and it already runs at -20!

Indeed, the work items are handled on a pool of threads.

This patch removes that call and code as it is redundant and actually
causes things to take longer and is a problem when you are trying to
start hundreds of iSCSI sessions.

There is another patch for the LLD to use a WQ_HIGHPRI queue to
achieve the original intent.

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
(Continue reading)

Bart Van Assche | 28 Mar 22:39 2016

[PATCH 0/5] Fix several static checker warnings reported against the iSCSI kernel code

Hello Mike,

These five patches are what I came up with after analyzing the output of 
"make M=drivers/scsi W=1 C=2" for the iSCSI kernel code. Please consider 
these patches for inclusion in kernel v4.7. The actual patches are:

0001-libiscsi-Unexport-iscsi_eh_target_reset.patch
0002-libiscsi-Remove-set-but-not-used-variables.patch
0003-scsi_transport_iscsi-Remove-set-but-not-used-variabl.patch
0004-scsi_transport_iscsi-Unexport-iscsi_is_flashnode_con.patch
0005-scsi_transport_iscsi-Declare-local-symbols-static.patch

Thanks,

Bart.

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

zhdscuch | 17 Mar 14:32 2016
Picon

"iscsi-initiator-utils" cannot recognize NIC ports

Hi!

I'm in trouble with "iscsi-initiator-utils" and my iscsi target.
I have a Dell T420 server and a Dell SCv2000 storage.The server is installed with two NICs and "iscsi-initiator-utils" software.
The SCv2000 is the target I want to connect to.Each NIC has two ports,however, the target seems to recognize only one port.

After the installation of "iscsi-initiator-utils" , a file named initiatorname.iscsi are created.In my view,iscsi will assign an initiator name for the recognized port.
There is only one initiatorname in my file rather than four.I attemptted to add initiatornames into it,but it was of no use.

The initiator and the target were well configured once, but one of the two NICs has some quality problems.I changed a new one  and configured them as before,
they crashed.I don't know what to do next.Can you help me?
Thx.

--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
d.graham.welsh | 11 Mar 20:03 2016
Picon

Can not see my target

Hello folks,

I can not seem to get my open-iscsi intiator to see my target.

When I attempt to discover my target, I get the following :

root <at> control:/home/Administrator# iscsiadm -m discovery -t sendtargets -p 192.168.122.9
iscsiadm: No portals found

I can ping 192.168.122.9, and nmap shows the target listening at port 3260.

Starting Nmap 6.00 ( http://nmap.org ) at 2016-03-11 10:58 AST
Nmap scan report for NAS.seamine.local (192.168.122.9)
Host is up (0.000085s latency).
Not shown: 995 closed ports
PORT      STATE SERVICE
22/tcp    open  ssh
111/tcp   open  rpcbind
3260/tcp  open  iscsi <-------
6000/tcp  open  X11
10000/tcp open  snet-sensor-mgmt
MAC Address: 00:24:E8:10:EF:82 (Dell)

Nmap done: 1 IP address (1 host up) scanned in 0.26 seconds

Strangely enough, if I type just iscsiadm -m discovery I get this :

root <at> control:/home/Administrator# iscsiadm -m discovery
NAS.seamine.local:3260 via sendtargets
192.168.122.9:3260 via sendtargets

So, it seems as if it sees the target, but won't acknowledge its existence.

I'm running the initiator on a Univention 4.1 server (which is Debian, basically). The target is a CentOS 6.7 server.

I have disables iptables, firewalls, and CHAP authentication on the target, so none of that should be an issue. AFAIK I'm running the latest version of open-iscsi on both boxes.

Any ideas what I can do from here ? If you need more information out of me, just ask.

--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Gmane