LSZhu | 23 Jul 08:37 2015

Errors when log out a deleted target

Hi experts,

When I try to log out a target which is already deleted at the target server side, I can see a error :

Logging out of session [sid: 1, target: iqn.2015-07.com.example:test:844a36e0-e921-4988-9538-a32112aa40d4, portal: 147.2.207.200,3260]
iscsiadm: Could not logout of [sid: 1, target: iqn.2015-07.com.example:test:844a36e0-e921-4988-9538-a32112aa40d4, portal: 147.2.207.200,3260].
iscsiadm: initiator reported error (9 - internal error)
iscsiadm: Could not logout of all requested sessions

I think maybe the reason is that, the target is deleted, so the initiator can not get a logout response PDU, so errors.We would meet the same situation when target still alive but network down.
I have a proposal, can we set a time out values, for example 10 seconds, once time out, log out anyway, then print some message like "The target is not reachable, logged out". I think this operation is not harmful to the target side.
Do you experts think that make sense?


Thanks
BR
Zhu Lingshan

--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
leeman.duncan | 22 Jul 00:47 2015
Picon

[PATCH] Discovery daemon via non-tcp transport needs 'ipc' set

From: Lee Duncan <lduncan@...>

This patch allows iser transport to be used for the discovery
daemon. Otherwise, iscsid core dumps when attempting this.
---
 usr/discoveryd.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/usr/discoveryd.c b/usr/discoveryd.c
index 1e149771a50b..2d3ccbcd722f 100644
--- a/usr/discoveryd.c
+++ b/usr/discoveryd.c
 <at>  <at>  -1034,11 +1034,6  <at>  <at>  static void __do_st_disc_and_login(struct discovery_rec *drec)
 	drec->u.sendtargets.reopen_max = 0;

 	iface_link_ifaces(&setup_ifaces);
-	/*
-	 * disc code assumes this is not set and wants to use
-	 * the userspace IO code.
-	 */
-	ipc = NULL;

 	rc = idbm_bind_ifaces_to_nodes(discovery_sendtargets, drec,
 					&setup_ifaces, &rec_list);
-- 
2.1.4

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

LSZhu | 17 Jul 11:00 2015

Is it a valid bug : some errors when discover or delete targets if we manually create default file in folder sendtargets and nodes

Hi experts,

Our team find two bugs, please help me check whether they are valid, if they are, I am happy to fix them:

------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

(A) If we touch a empty default file in sendtargets, when we try to discover the targets, we would got a empty default file in sendtargets.
Here is the detailed information and how to reproduce.

(1) we have a target on 147.2.207.131. Target name: iqn.2015-07.com.example

(2) Create a folder like "/etc/iscsi/send_targets/147.2.207.131,3260/iqn.2015-07.com.example,147.2.207.131,3260,1,default" which matches the target name, here it is iqn.2015-07.com.example
linux-askc:/etc/iscsi # mkdir -p /etc/iscsi/send_targets/147.2.207.131,3260/iqn.2015-07.com.example,147.2.207.131,3260,1,default

(3) Create a empty default file in the folder created above.
linux-askc:/etc/iscsi # touch  /etc/iscsi/send_targets/147.2.207.131,3260/iqn.2015-07.com.example,147.2.207.131,3260,1,default/default

(4) Run discover command,
linux-askc:/etc/iscsi # iscsiadm -m discovery -t st -p 147.2.207.131
147.2.207.131:3260,1 iqn.2015-07.com.example (we got the target)
(5) check the default file in sendtargets:
linux-askc:/etc/iscsi # cat  /etc/iscsi/send_targets/147.2.207.131,3260/iqn.2015-07.com.example,147.2.207.131,3260,1,default/default   
Then we will find the default file : /etc/iscsi/send_targets/147.2.207.131,3260/iqn.2015-07.com.example,147.2.207.131,3260,1,default/default still a empty

(6) If we want to delete the target, we would see:

linux-askc:/etc/iscsi/nodes # iscsiadm -m node -o delete
iscsiadm: Could not remove link /etc/iscsi/send_targets/147.2.207.131,3260/iqn.2015-07.com.example,147.2.207.131,3260,1,default: Is a directory

iscsiadm: Could not execute operation on all records: encountered iSCSI database failure

(7) Then run discover command again, we would get a error:
linux-askc:/etc/iscsi # iscsiadm -m discovery -t st -p 147.2.207.131
iscsiadm: Could not remove link /etc/iscsi/send_targets/147.2.207.131,3260/iqn.2015-07.com.example,147.2.207.131,3260,1,default: Is a directory

iscsiadm: Could not add/update [tcp:[hw=,ip=,net_if=,iscsi_if=default] 147.2.207.131,3260,1 iqn.2015-07.com.example]
147.2.207.131:3260,1 iqn.2015-07.com.example
linux-askc:/etc/iscsi #

------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

(B) If we touch a empty default file in nodes when we try to discover the targets,
 
(1) we have a target on 147.2.207.131. Target name: iqn.2015-07.com.example

(2) Create a folder like "/etc/iscsi/nodes/iqn.2015-07.com.example/147.2.207.131,3260,1" which matches the target name, here it is iqn.2015-07.com.example
mkdir -p /etc/iscsi/nodes/iqn.2015-07.com.example/147.2.207.131,3260,1

(3) Create a empty default file in the folder created above.
linux-askc:/etc/iscsi # touch /etc/iscsi/nodes/iqn.2015-07.com.example/147.2.207.131,3260,1/default

(4) Run discover command, we will see a error:
linux-askc:/etc/iscsi # iscsiadm -m discovery -t st -p 147.2.207.131
iscsiadm: Could not stat /etc/iscsi/nodes//,3260,-1/default to delete node: No such file or directory

iscsiadm: Could not add/update [tcp:[hw=,ip=,net_if=,iscsi_if=default] 147.2.207.131,3260,1 iqn.2015-07.com.example]
147.2.207.131:3260,1 iqn.2015-07.com.example
linux-askc:/etc/iscsi #

------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

For now, the only way we know that can 100% trigger the bug is creating these files manually, but some guys had ever see the bugs randomly. Are they valid bugs? I think it is nice to enhance the code.


Thanks,
BR
Zhu Lingshan

--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
leeman.duncan | 14 Jul 23:01 2015
Picon

[PATCH 0/2] Remove local open-isns, using system-installed version

From: Lee Duncan <lduncan@...>

This set of patches tells open-iscsi to use the system-resident
open-isns files instead of the ones in utils/open-isns.

This patch *requires* that you've installed open-isns (from
git@...:gonzoleeman/open-isns.git).

The first patch tells open-iscsi to use the system-resident
include files and library from open-isns. The second patch
removes the local copy of same.

Questions:
- Should the documentation be updated? I didn't
  find anything that referenced open-isns
- Is it perhaps time to bump the minor version
  of open-iscsi? It's been a while.

Note: it is my intention to create an open-isns package
for SUSE. I assume other platforms will have to do the
same before they could incorporate this patch.

Lee Duncan (2):
  Use system-wide open-isns, not internal version.
  Remove local copy of open-isns.

 Makefile                                           |   10 +-
 usr/Makefile                                       |    7 +-
 usr/discovery.c                                    |    6 +-
 usr/discoveryd.c                                   |    8 +-
 usr/iscsiadm.c                                     |    2 +-
 utils/open-isns/COPYING                            |  504 --
 utils/open-isns/ChangeLog                          |   50 -
 utils/open-isns/HACKING                            |   30 -
 utils/open-isns/Makefile.in                        |   81 -
 utils/open-isns/README                             |  173 -
 utils/open-isns/TODO                               |  100 -
 utils/open-isns/aclocal/config.guess               | 1499 -----
 utils/open-isns/aclocal/config.sub                 | 1570 -----
 utils/open-isns/aclocal/install-sh                 |  251 -
 utils/open-isns/attrs.c                            | 1618 -----
 utils/open-isns/attrs.h                            |  262 -
 utils/open-isns/authblock.c                        |   62 -
 utils/open-isns/bitvector.c                        |  648 --
 utils/open-isns/buffer.c                           |  407 --
 utils/open-isns/buffer.h                           |  141 -
 utils/open-isns/callback.c                         |  148 -
 utils/open-isns/client.c                           |  205 -
 utils/open-isns/compat/my_getopt.c                 |  271 -
 utils/open-isns/compat/my_getopt.h                 |   69 -
 utils/open-isns/config.c                           |  278 -
 utils/open-isns/config.h.in                        |  103 -
 utils/open-isns/configure                          | 6727 --------------------
 utils/open-isns/configure.ac                       |  118 -
 utils/open-isns/db-file.c                          |  615 --
 utils/open-isns/db-policy.c                        |  187 -
 utils/open-isns/db.c                               |  994 ---
 utils/open-isns/db.h                               |  147 -
 utils/open-isns/dd.c                               | 1306 ----
 utils/open-isns/deregister.c                       |  271 -
 utils/open-isns/doc/isns_config.5                  |  387 --
 utils/open-isns/doc/isnsadm.8                      |  688 --
 utils/open-isns/doc/isnsd.8                        |   93 -
 utils/open-isns/doc/isnsdd.8                       |   75 -
 utils/open-isns/domain.c                           |  208 -
 utils/open-isns/entity.c                           |  127 -
 utils/open-isns/error.c                            |   65 -
 utils/open-isns/esi.c                              |  576 --
 utils/open-isns/etc/isnsadm.conf                   |   73 -
 utils/open-isns/etc/isnsd.conf                     |  129 -
 utils/open-isns/etc/isnsdd.conf                    |   72 -
 utils/open-isns/etc/openisns.init                  |   71 -
 utils/open-isns/export.c                           |  547 --
 utils/open-isns/getnext.c                          |  257 -
 utils/open-isns/internal.h                         |   16 -
 utils/open-isns/isns-proto.h                       |  259 -
 utils/open-isns/isns.h                             |  673 --
 utils/open-isns/isnsadm.c                          | 1151 ----
 utils/open-isns/isnsd.c                            |  299 -
 utils/open-isns/isnsdd.c                           | 1153 ----
 utils/open-isns/isnssetup                          |   52 -
 utils/open-isns/local.c                            |  353 -
 utils/open-isns/logging.c                          |  228 -
 utils/open-isns/mdebug.c                           |  295 -
 utils/open-isns/message.c                          |  681 --
 utils/open-isns/message.h                          |  196 -
 utils/open-isns/objects.c                          | 1320 ----
 utils/open-isns/objects.h                          |  168 -
 utils/open-isns/parser.c                           |  134 -
 utils/open-isns/paths.h                            |   22 -
 utils/open-isns/pidfile.c                          |   98 -
 utils/open-isns/pki.c                              |  536 --
 utils/open-isns/policy.c                           |  577 --
 utils/open-isns/portal-group.c                     |  307 -
 utils/open-isns/query.c                            |  238 -
 utils/open-isns/register.c                         |  934 ---
 utils/open-isns/relation.c                         |  281 -
 utils/open-isns/scn.c                              |  926 ---
 utils/open-isns/scope.c                            |  513 --
 utils/open-isns/security.c                         |  437 --
 utils/open-isns/security.h                         |  185 -
 utils/open-isns/server.c                           |  236 -
 utils/open-isns/simple.c                           |  727 ---
 utils/open-isns/slp.c                              |  242 -
 utils/open-isns/socket.c                           | 2304 -------
 utils/open-isns/socket.h                           |   95 -
 utils/open-isns/source.h                           |   32 -
 utils/open-isns/storage-node.c                     |  202 -
 utils/open-isns/sysdep-unix.c                      |  186 -
 utils/open-isns/tags.c                             |  740 ---
 utils/open-isns/tests/.cvsignore                   |    2 -
 utils/open-isns/tests/Makefile                     |   40 -
 utils/open-isns/tests/client.conf                  |    8 -
 utils/open-isns/tests/data/test01/01-enroll        |   18 -
 utils/open-isns/tests/data/test01/02-registration  |   42 -
 utils/open-isns/tests/data/test01/03-query         |   20 -
 utils/open-isns/tests/data/test01/03-registration  |   20 -
 .../open-isns/tests/data/test01/99-unregistration  |   18 -
 utils/open-isns/tests/data/test02/01-enroll        |   18 -
 utils/open-isns/tests/data/test02/02-enroll        |   24 -
 utils/open-isns/tests/data/test02/03-registration  |   72 -
 utils/open-isns/tests/data/test02/04-query         |   20 -
 utils/open-isns/tests/data/test02/05-query         |   20 -
 .../open-isns/tests/data/test02/06-dd-registration |   81 -
 utils/open-isns/tests/data/test02/07-query         |   40 -
 utils/open-isns/tests/data/test02/08-query         |   40 -
 utils/open-isns/tests/data/test02/09-query         |   20 -
 .../open-isns/tests/data/test02/10-dd-registration |   87 -
 utils/open-isns/tests/data/test02/11-query         |   10 -
 .../tests/data/test02/12-dd-deregistration         |   85 -
 .../tests/data/test02/13-dd-deregistration         |   83 -
 .../open-isns/tests/data/test02/14-dd-registration |   85 -
 .../tests/data/test02/15-dd-deregistration         |   76 -
 utils/open-isns/tests/data/test03/01-enroll        |   18 -
 utils/open-isns/tests/data/test03/02-registration  |   42 -
 .../open-isns/tests/data/test03/03-unregistration  |   42 -
 .../open-isns/tests/data/test03/04-unregistration  |   18 -
 .../open-isns/tests/data/test03/99-unregistration  |   13 -
 utils/open-isns/tests/data/test04/01-enroll        |   18 -
 utils/open-isns/tests/data/test04/02-registration  |   42 -
 utils/open-isns/tests/data/test04/03-restart       |   42 -
 utils/open-isns/tests/data/test04/04-query         |   20 -
 utils/open-isns/tests/data/test05/01-enroll        |   18 -
 utils/open-isns/tests/data/test05/02-registration  |   42 -
 utils/open-isns/tests/data/test05/03-expired       |   18 -
 utils/open-isns/tests/data/test06/01-enroll        |   18 -
 utils/open-isns/tests/data/test06/02-registration  |   42 -
 utils/open-isns/tests/data/test06/03-registration  |   42 -
 utils/open-isns/tests/data/test06/04-registration  |   42 -
 .../open-isns/tests/data/test06/05-dd-registration |   49 -
 utils/open-isns/tests/data/test06/06-registration  |   49 -
 .../open-isns/tests/data/test06/07-dd-registration |   52 -
 utils/open-isns/tests/data/test06/08-registration  |   64 -
 utils/open-isns/tests/data/test06/09-registration  |   64 -
 .../open-isns/tests/data/test06/10-unregistration  |   37 -
 utils/open-isns/tests/data/test06/11-registration  |   52 -
 utils/open-isns/tests/data/test07/01-enroll        |   19 -
 utils/open-isns/tests/data/test07/02-registration  |   45 -
 utils/open-isns/tests/data/test07/03-expired       |   19 -
 utils/open-isns/tests/data/test07/04-registration  |   57 -
 utils/open-isns/tests/data/test07/05-expired       |   19 -
 utils/open-isns/tests/data/test08/01-pauw1         |  100 -
 utils/open-isns/tests/data/test09/01-pauw2         |   31 -
 utils/open-isns/tests/data/test10/01-pauw3         |   31 -
 utils/open-isns/tests/data/test10/02-expired       |   31 -
 utils/open-isns/tests/data/test10/03-pauw3         |   31 -
 utils/open-isns/tests/data/test10/04-expired       |   31 -
 utils/open-isns/tests/data/test11/01-pauw4         |   32 -
 utils/open-isns/tests/genkey                       |  175 -
 utils/open-isns/tests/harness.pl                   |  929 ---
 utils/open-isns/tests/pauw1.c                      |  179 -
 utils/open-isns/tests/pauw2.c                      |  212 -
 utils/open-isns/tests/pauw3.c                      |  139 -
 utils/open-isns/tests/pauw4.c                      |  137 -
 utils/open-isns/tests/server.conf                  |   11 -
 utils/open-isns/tests/test01.pl                    |   30 -
 utils/open-isns/tests/test02.pl                    |   58 -
 utils/open-isns/tests/test03.pl                    |   27 -
 utils/open-isns/tests/test04.pl                    |   30 -
 utils/open-isns/tests/test05.pl                    |   25 -
 utils/open-isns/tests/test06.pl                    |   50 -
 utils/open-isns/tests/test07.pl                    |   37 -
 utils/open-isns/tests/test08.pl                    |   23 -
 utils/open-isns/tests/test09.pl                    |   23 -
 utils/open-isns/tests/test10.pl                    |   33 -
 utils/open-isns/tests/test11.pl                    |   23 -
 utils/open-isns/timer.c                            |  126 -
 utils/open-isns/types.h                            |   57 -
 utils/open-isns/util.c                             |  263 -
 utils/open-isns/util.h                             |  289 -
 utils/open-isns/vendor.c                           |   41 -
 utils/open-isns/vendor.h                           |   56 -
 166 files changed, 13 insertions(+), 44211 deletions(-)
 delete mode 100644 utils/open-isns/COPYING
 delete mode 100644 utils/open-isns/ChangeLog
 delete mode 100644 utils/open-isns/HACKING
 delete mode 100644 utils/open-isns/Makefile.in
 delete mode 100644 utils/open-isns/README
 delete mode 100644 utils/open-isns/TODO
 delete mode 100644 utils/open-isns/aclocal/config.guess
 delete mode 100644 utils/open-isns/aclocal/config.sub
 delete mode 100644 utils/open-isns/aclocal/install-sh
 delete mode 100644 utils/open-isns/attrs.c
 delete mode 100644 utils/open-isns/attrs.h
 delete mode 100644 utils/open-isns/authblock.c
 delete mode 100644 utils/open-isns/bitvector.c
 delete mode 100644 utils/open-isns/buffer.c
 delete mode 100644 utils/open-isns/buffer.h
 delete mode 100644 utils/open-isns/callback.c
 delete mode 100644 utils/open-isns/client.c
 delete mode 100644 utils/open-isns/compat/my_getopt.c
 delete mode 100644 utils/open-isns/compat/my_getopt.h
 delete mode 100644 utils/open-isns/config.c
 delete mode 100644 utils/open-isns/config.h.in
 delete mode 100755 utils/open-isns/configure
 delete mode 100644 utils/open-isns/configure.ac
 delete mode 100644 utils/open-isns/db-file.c
 delete mode 100644 utils/open-isns/db-policy.c
 delete mode 100644 utils/open-isns/db.c
 delete mode 100644 utils/open-isns/db.h
 delete mode 100644 utils/open-isns/dd.c
 delete mode 100644 utils/open-isns/deregister.c
 delete mode 100644 utils/open-isns/doc/isns_config.5
 delete mode 100644 utils/open-isns/doc/isnsadm.8
 delete mode 100644 utils/open-isns/doc/isnsd.8
 delete mode 100644 utils/open-isns/doc/isnsdd.8
 delete mode 100644 utils/open-isns/domain.c
 delete mode 100644 utils/open-isns/entity.c
 delete mode 100644 utils/open-isns/error.c
 delete mode 100644 utils/open-isns/esi.c
 delete mode 100644 utils/open-isns/etc/isnsadm.conf
 delete mode 100644 utils/open-isns/etc/isnsd.conf
 delete mode 100644 utils/open-isns/etc/isnsdd.conf
 delete mode 100644 utils/open-isns/etc/openisns.init
 delete mode 100644 utils/open-isns/export.c
 delete mode 100644 utils/open-isns/getnext.c
 delete mode 100644 utils/open-isns/internal.h
 delete mode 100644 utils/open-isns/isns-proto.h
 delete mode 100644 utils/open-isns/isns.h
 delete mode 100644 utils/open-isns/isnsadm.c
 delete mode 100644 utils/open-isns/isnsd.c
 delete mode 100644 utils/open-isns/isnsdd.c
 delete mode 100644 utils/open-isns/isnssetup
 delete mode 100644 utils/open-isns/local.c
 delete mode 100644 utils/open-isns/logging.c
 delete mode 100644 utils/open-isns/mdebug.c
 delete mode 100644 utils/open-isns/message.c
 delete mode 100644 utils/open-isns/message.h
 delete mode 100644 utils/open-isns/objects.c
 delete mode 100644 utils/open-isns/objects.h
 delete mode 100644 utils/open-isns/parser.c
 delete mode 100644 utils/open-isns/paths.h
 delete mode 100644 utils/open-isns/pidfile.c
 delete mode 100644 utils/open-isns/pki.c
 delete mode 100644 utils/open-isns/policy.c
 delete mode 100644 utils/open-isns/portal-group.c
 delete mode 100644 utils/open-isns/query.c
 delete mode 100644 utils/open-isns/register.c
 delete mode 100644 utils/open-isns/relation.c
 delete mode 100644 utils/open-isns/scn.c
 delete mode 100644 utils/open-isns/scope.c
 delete mode 100644 utils/open-isns/security.c
 delete mode 100644 utils/open-isns/security.h
 delete mode 100644 utils/open-isns/server.c
 delete mode 100644 utils/open-isns/simple.c
 delete mode 100644 utils/open-isns/slp.c
 delete mode 100644 utils/open-isns/socket.c
 delete mode 100644 utils/open-isns/socket.h
 delete mode 100644 utils/open-isns/source.h
 delete mode 100644 utils/open-isns/storage-node.c
 delete mode 100644 utils/open-isns/sysdep-unix.c
 delete mode 100644 utils/open-isns/tags.c
 delete mode 100644 utils/open-isns/tests/.cvsignore
 delete mode 100644 utils/open-isns/tests/Makefile
 delete mode 100644 utils/open-isns/tests/client.conf
 delete mode 100644 utils/open-isns/tests/data/test01/01-enroll
 delete mode 100644 utils/open-isns/tests/data/test01/02-registration
 delete mode 100644 utils/open-isns/tests/data/test01/03-query
 delete mode 100644 utils/open-isns/tests/data/test01/03-registration
 delete mode 100644 utils/open-isns/tests/data/test01/99-unregistration
 delete mode 100644 utils/open-isns/tests/data/test02/01-enroll
 delete mode 100644 utils/open-isns/tests/data/test02/02-enroll
 delete mode 100644 utils/open-isns/tests/data/test02/03-registration
 delete mode 100644 utils/open-isns/tests/data/test02/04-query
 delete mode 100644 utils/open-isns/tests/data/test02/05-query
 delete mode 100644 utils/open-isns/tests/data/test02/06-dd-registration
 delete mode 100644 utils/open-isns/tests/data/test02/07-query
 delete mode 100644 utils/open-isns/tests/data/test02/08-query
 delete mode 100644 utils/open-isns/tests/data/test02/09-query
 delete mode 100644 utils/open-isns/tests/data/test02/10-dd-registration
 delete mode 100644 utils/open-isns/tests/data/test02/11-query
 delete mode 100644 utils/open-isns/tests/data/test02/12-dd-deregistration
 delete mode 100644 utils/open-isns/tests/data/test02/13-dd-deregistration
 delete mode 100644 utils/open-isns/tests/data/test02/14-dd-registration
 delete mode 100644 utils/open-isns/tests/data/test02/15-dd-deregistration
 delete mode 100644 utils/open-isns/tests/data/test03/01-enroll
 delete mode 100644 utils/open-isns/tests/data/test03/02-registration
 delete mode 100644 utils/open-isns/tests/data/test03/03-unregistration
 delete mode 100644 utils/open-isns/tests/data/test03/04-unregistration
 delete mode 100644 utils/open-isns/tests/data/test03/99-unregistration
 delete mode 100644 utils/open-isns/tests/data/test04/01-enroll
 delete mode 100644 utils/open-isns/tests/data/test04/02-registration
 delete mode 100644 utils/open-isns/tests/data/test04/03-restart
 delete mode 100644 utils/open-isns/tests/data/test04/04-query
 delete mode 100644 utils/open-isns/tests/data/test05/01-enroll
 delete mode 100644 utils/open-isns/tests/data/test05/02-registration
 delete mode 100644 utils/open-isns/tests/data/test05/03-expired
 delete mode 100644 utils/open-isns/tests/data/test06/01-enroll
 delete mode 100644 utils/open-isns/tests/data/test06/02-registration
 delete mode 100644 utils/open-isns/tests/data/test06/03-registration
 delete mode 100644 utils/open-isns/tests/data/test06/04-registration
 delete mode 100644 utils/open-isns/tests/data/test06/05-dd-registration
 delete mode 100644 utils/open-isns/tests/data/test06/06-registration
 delete mode 100644 utils/open-isns/tests/data/test06/07-dd-registration
 delete mode 100644 utils/open-isns/tests/data/test06/08-registration
 delete mode 100644 utils/open-isns/tests/data/test06/09-registration
 delete mode 100644 utils/open-isns/tests/data/test06/10-unregistration
 delete mode 100644 utils/open-isns/tests/data/test06/11-registration
 delete mode 100644 utils/open-isns/tests/data/test07/01-enroll
 delete mode 100644 utils/open-isns/tests/data/test07/02-registration
 delete mode 100644 utils/open-isns/tests/data/test07/03-expired
 delete mode 100644 utils/open-isns/tests/data/test07/04-registration
 delete mode 100644 utils/open-isns/tests/data/test07/05-expired
 delete mode 100644 utils/open-isns/tests/data/test08/01-pauw1
 delete mode 100644 utils/open-isns/tests/data/test09/01-pauw2
 delete mode 100644 utils/open-isns/tests/data/test10/01-pauw3
 delete mode 100644 utils/open-isns/tests/data/test10/02-expired
 delete mode 100644 utils/open-isns/tests/data/test10/03-pauw3
 delete mode 100644 utils/open-isns/tests/data/test10/04-expired
 delete mode 100644 utils/open-isns/tests/data/test11/01-pauw4
 delete mode 100644 utils/open-isns/tests/genkey
 delete mode 100644 utils/open-isns/tests/harness.pl
 delete mode 100644 utils/open-isns/tests/pauw1.c
 delete mode 100644 utils/open-isns/tests/pauw2.c
 delete mode 100644 utils/open-isns/tests/pauw3.c
 delete mode 100644 utils/open-isns/tests/pauw4.c
 delete mode 100644 utils/open-isns/tests/server.conf
 delete mode 100644 utils/open-isns/tests/test01.pl
 delete mode 100644 utils/open-isns/tests/test02.pl
 delete mode 100644 utils/open-isns/tests/test03.pl
 delete mode 100644 utils/open-isns/tests/test04.pl
 delete mode 100644 utils/open-isns/tests/test05.pl
 delete mode 100644 utils/open-isns/tests/test06.pl
 delete mode 100644 utils/open-isns/tests/test07.pl
 delete mode 100644 utils/open-isns/tests/test08.pl
 delete mode 100644 utils/open-isns/tests/test09.pl
 delete mode 100644 utils/open-isns/tests/test10.pl
 delete mode 100644 utils/open-isns/tests/test11.pl
 delete mode 100644 utils/open-isns/timer.c
 delete mode 100644 utils/open-isns/types.h
 delete mode 100644 utils/open-isns/util.c
 delete mode 100644 utils/open-isns/util.h
 delete mode 100644 utils/open-isns/vendor.c
 delete mode 100644 utils/open-isns/vendor.h

-- 
2.1.4

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

leeman.duncan | 13 Jul 23:57 2015
Picon

[PATCH 0/3] open-isns: prepare for external use by open-iscsi

From: Lee Duncan <lduncan@...>

This group of patches is for open-isns, and the current procedure for
changes to open-isns is to share them on the open-iscsi mailing list.

The goal of these patches is to make open-isns a stand-alone package
that can be used by other (like open-iscsi). This way clients don't
have to have their own (possibly stale) copies of these files.

NOTE: there are NO FUNCTIONAL CHANGES here, just:
* moving some inclue files locally to include/libisns directory
* changing all users of include files to know new location
* Adding "install_lib" and "install_hdrs" Makefile targets

This has been tested with open-iscsn and seems to work.

Lee Duncan (3):
  Move public inlcude files to <libisns/*.h>
  Make one more include file public.
  Add test binaries as 'make clean' targets.

 Makefile.in                  |  27 +-
 attrs.c                      |   6 +-
 attrs.h                      | 262 -----------------
 authblock.c                  |   8 +-
 bitvector.c                  |   4 +-
 buffer.c                     |   4 +-
 buffer.h                     | 141 ---------
 callback.c                   |   6 +-
 client.c                     |   4 +-
 config.c                     |   6 +-
 db-file.c                    |   6 +-
 db-policy.c                  |   4 +-
 db.c                         |   4 +-
 db.h                         |   2 +-
 dd.c                         |   8 +-
 deregister.c                 |   8 +-
 domain.c                     |   4 +-
 entity.c                     |   4 +-
 error.c                      |   2 +-
 esi.c                        |   8 +-
 export.c                     |   8 +-
 getnext.c                    |   8 +-
 include/libisns/attrs.h      | 262 +++++++++++++++++
 include/libisns/buffer.h     | 141 +++++++++
 include/libisns/isns-proto.h | 259 +++++++++++++++++
 include/libisns/isns.h       | 676 +++++++++++++++++++++++++++++++++++++++++++
 include/libisns/message.h    | 196 +++++++++++++
 include/libisns/paths.h      |  24 ++
 include/libisns/source.h     |  32 ++
 include/libisns/types.h      |  57 ++++
 include/libisns/util.h       | 288 ++++++++++++++++++
 isns-proto.h                 | 259 -----------------
 isns.h                       | 676 -------------------------------------------
 isnsadm.c                    |   8 +-
 isnsd.c                      |   6 +-
 isnsdd.c                     |  10 +-
 local.c                      |  12 +-
 logging.c                    |   2 +-
 mdebug.c                     |   2 +-
 message.c                    |   8 +-
 message.h                    | 196 -------------
 objects.c                    |   8 +-
 objects.h                    |   4 +-
 parser.c                     |   2 +-
 paths.h                      |  24 --
 pidfile.c                    |   2 +-
 pki.c                        |   4 +-
 policy.c                     |   6 +-
 portal-group.c               |   6 +-
 query.c                      |   8 +-
 register.c                   |   8 +-
 relation.c                   |   4 +-
 scn.c                        |   8 +-
 scope.c                      |   8 +-
 security.c                   |   6 +-
 security.h                   |   4 +-
 server.c                     |   6 +-
 simple.c                     |   8 +-
 slp.c                        |   4 +-
 socket.c                     |   6 +-
 socket.h                     |   6 +-
 source.h                     |  32 --
 storage-node.c               |   4 +-
 sysdep-unix.c                |   4 +-
 tags.c                       |   6 +-
 tests/pauw1.c                |   8 +-
 tests/pauw2.c                |   8 +-
 tests/pauw3.c                |   8 +-
 tests/pauw4.c                |   8 +-
 timer.c                      |   4 +-
 types.h                      |  57 ----
 util.c                       |   2 +-
 util.h                       | 288 ------------------
 vendor.c                     |   6 +-
 vendor.h                     |   2 +-
 75 files changed, 2121 insertions(+), 2096 deletions(-)
 delete mode 100644 attrs.h
 delete mode 100644 buffer.h
 create mode 100644 include/libisns/attrs.h
 create mode 100644 include/libisns/buffer.h
 create mode 100644 include/libisns/isns-proto.h
 create mode 100644 include/libisns/isns.h
 create mode 100644 include/libisns/message.h
 create mode 100644 include/libisns/paths.h
 create mode 100644 include/libisns/source.h
 create mode 100644 include/libisns/types.h
 create mode 100644 include/libisns/util.h
 delete mode 100644 isns-proto.h
 delete mode 100644 isns.h
 delete mode 100644 message.h
 delete mode 100644 paths.h
 delete mode 100644 source.h
 delete mode 100644 types.h
 delete mode 100644 util.h

-- 
2.1.4

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

leeman.duncan | 10 Jul 21:08 2015
Picon

[PATCH] Read iBFT 'origin' as an integer, not a string

From: Lee Duncan <lduncan@...>

Recent patches have added support for iBFT 'origin' when determining
the source of the iBFT boot IP Address, but this value is an
enum (integer), not a string. This patch fixes the one place
it was read as a string.

Lee Duncan (1):
  iBFT 'origin' is an enum, not a string

 utils/fwparam_ibft/fwparam_ibft_sysfs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.1.4

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

adheer.chandravanshi | 9 Jul 13:38 2015

[PATCH v2 0/2] open-iscsi: Ping support in iscsiuio

From: Adheer Chandravanshi <adheer.chandravanshi@...>

Mike,

This is patchset v2 to add ping support in iscsiuio.
Please review and apply following patches to open-iscsi.git tree at your earliest convenience.

Changes with respect to first patchset:
- Removed the iface apply operation for bnx2i transport
  Now, iface config will be passed to iscsiuio during ping operation itself.

- Reduced the patchset to only two necessary patches for the required support

Adheer Chandravanshi (2):
  iscsid: Changes to support ping through iscsiuio
  iscsiuio: Add ping support through iscsiuio

Thanks,
Adheer

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Anish Bhatt | 7 Jul 02:40 2015

Using net_prio cgroups with iscsi transports

I was trying to use the sk_cgrp_prioidx value to find correct dcb priority for iscsi (using cgdcbxd + cgrulesengd as recommended by http://open-lldp.org/dcb_overview). The sk_cgrp_prioidx index into netprio_map hangs off of struck sock, and the particular iscsi offload driver I’m working with (cxgb4i) does not actually use struck sock at all. From a preliminary glance, other open-iscsi offload transports do not seem to use a struck sock either (don’t quote me on this ) leaving them unable to actually find the priority index into netprio_map.

 

Is there a suggested way for such drivers to use netprio_map ? cgdcbxd’s cgroup creation is working fine (using our firmware dcb state machine + dcbnl_ops, no open-lldp) and I can use I can call task_netprioidx() at connection time provided I use cgexec with iscsid to get the correct index into netprio_map. Not sure if this is the best approach however, does anyone have a better suggestion ? Would it make sense for the sk_cgrp_prioidx to hang off the skb or have libiscsi provide this value to open-iscsi transports for a more generic implementation ?

 

-Anish

 

One socket to bind them all.

 

--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

lokesharo | 1 Jul 15:25 2015
Picon

iSNS Fail Over Mechanism

I would like to know about the fail over mechanisms used by iSNS for ISCSI implementation. The RFC states that "Note that it is possible to create multiple physical iSNS servers to form a single logical iSNS server cluster, and thus to distribute iSNS transaction processing among multiple physical servers. However, a more detailed discussion of the interactions between physical servers within a logical iSNS server cluster is beyond the scope of this document."

I tried searching but most of the findings are related to Windows and that too does not explain what are the fail over techniques used or the implementation details.

Any links or documents about the same would be very useful. Thanks

--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
Christian Iversen | 29 Jun 16:40 2015
Picon

8 patches for review

Hello Open-iSCSI

(please CC as I'm not a regular on the list)

I've been working with iSCSI lately, and thought I could help with a few
patches.

Here's a description:

--> 0001-Enable-MaxOutstandingR2T-negotiation-support-in-iscs.patch

This patch enables MaxOutstandingR2T negotiation for sessions. 
Currently, max_r2t negotiation is in a weird, half-broken state. The 
kernel seems to support max_r2t > 1 just fine (at least it connects), 
but iscsiadm is hard-coded to use "1", regardless of the setting that 
the user sets in the config file, which is very confusing.

I spent more time than I'd like to admit on tracking this one down.. :)

There's even error handling in place for max_r2t > 1, but this is never 
triggered since the value "1" is hard-coded, and the config file is 
ignored. This is the worst of both worlds.

--> 0002-Removed-a-number-of-unused-variables.patch

Quick cleanup, to fix a number of compiler warnings.

--> 0003-Removed-unused-variable-and-computation.patch

Same as 0002.

--> 0004-Added-missing-pointer-dereferencing-memset-would-onl.patch
--> 0005-Added-missing-pointer-dereferencing-memset-would-onl.patch

In the duplicate(!) md5 function MD5Final(), there is a final

memset(ctx, 0, sizeof(ctx));

to clear the context of sensitive data after MD5 calculation - which is 
fine.

Unfortunately, they both refer to sizeof(ctx), which is a pointer, 
effectively nullifying (no pun intended) the effect of memset(). This is 
changed to sizeof(*ctx).

--> 0006-Removed-unused-variable-one.patch
--> 0007-Removed-unused-variable-pdu_text.patch
--> 0008-Removed-dead-code.patch

Should be self-explanatory.

These are all more or less just compile-tested. Any comments?

-- 
De bedste hilsner / Best Regards,
Christian Iversen

System Engineer

Meebox ApS
Store Kongensgade 40H,
1264 KĂžbenhavn K
T: +45 3841 3841

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
LSZhu | 26 Jun 08:31 2015
Picon

May I do some contributions for iSCSI multiqueue

Hi,
I have been working for iSCSI in SUSE for half a year, I have some basic knowledge of iSCSI. I did some debug  and performance analyze work before.I am quite interested in iSCSI-mq, I am not a expert here, but may I do some contributions for iSCSI-mq? If you need me in somewhere, please let me know.

In my view, there seems such works need to be done:

(1) open-iscsi should simulate a multi-queue block device on the initiator side, I mean, /dev/sdc, sdd which simulated by open-iscsi should be multi-queue, just like we want a multi-queue hardware device as a backstore.
(2)  I/O scheduler is needed in the block layer for multi-queue, for the simulated device mentioned above.
(3) open-iscsi should establish more than one connections to the target in a session, and a  I/O scheduler is needed here.
(4) some performance improve work like how to manage multi-queue threads on multiple CPU cores, how to reduce latency, how to create a better pipeline.

I have heard that on the target LIO side, multi-queue work is done.
If I am wrong  somewhere, please tell me, I would appreciate for that.

I know you have did a lot of work for multi-queue, so if you need me somewhere, or I can help in some work, please let me know.

Thanks
BR
Zhu Lingshan

--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Gmane