Manish Singh | 25 Aug 06:27 2015
Picon

Core Generated by iscsiuio

Dear All,

I have executed delete operation on a target for nodes database when some sessions are active. Now, when i execute following command, i get below error message.

[root <at> HN0101 ~]# iscsiadm -m session

tcp: [11667] 172.168.2.61:3260,4 iqn.2001-03.jp.nec:storage01:ist-m000-sn-0000000942901110.lx-ddsldset-0013.target0000 (non-flash)

tcp: [11668] 172.168.2.61:3260,4 iqn.2001-03.jp.nec:storage01:ist-m000-sn-0000000942901110.lx-ddsldset-0719.target0010 (non-flash)

tcp: [11669] 172.168.2.61:3260,4 iqn.2001-03.jp.nec:storage01:ist-m000-sn-0000000942901110.lx-ddsldset-0140.target0006 (non-flash)

tcp: [11670] 172.168.2.61:3260,4 iqn.2001-03.jp.nec:storage01:ist-m000-sn-0000000942901110.lx-ddsldset-0127.target0003 (non-flash)

tcp: [11671] 172.168.2.61:3260,4 iqn.2001-03.jp.nec:storage01:ist-m000-sn-0000000942901110.lx-ddsldset-0131.target0004 (non-flash)

tcp: [11672] 172.168.2.61:3260,4 iqn.2001-03.jp.nec:storage01:ist-m000-sn-0000000942901110.lx-ddsldset-0144.target0007 (non-flash)

tcp: [11673] 172.168.2.61:3260,4 iqn.2001-03.jp.nec:storage01:ist-m000-sn-0000000942901110.lx-ddsldset-0084.target0002 (non-flash)

iscsiadm: could not read session targetname: 5

iscsiadm: could not find session info for session3076


I have used RHEL 6.6 linux distro and my open iscsi initiator version is iscsi-initiator-utils-6.2.0.873-13.

In my environment, we have a RPC XML server which is written in python. When a client request for a operation(say operation1), we execute following iscsiadm command in  sequence using Popen() interface of subprocess module in some portion of the operation,

1> Logout all session for all target, Command   -    "/sbin/iscsiadm --mode node --logoutall=all"
2> modify iscsi.conf file
3> restart iscsid.
4> run discovery on all portals of storage device.
              If discovery fails on all portals(N/W down or other reasons), then delete the nodes database for each target using iscsiadm utility. 


 Now, after above error has occurred, when we go to execute operation1, My server generates core. The core is generated by iscsiuio. 

Can any one help me to understand the cause of the problem.

--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
Roi Dayan | 23 Aug 15:32 2015

[PATCH V2] discoveryd: Lock between forks

Since iscsi responses from the kernel are multicast we might get into
a situation where multiple discoveryd handle the same response.
With this commit we use a shared mutex to lock between the discoveryd forks
so each fork will handle its intended portal.
So we wait for login and stale logouts to finish between releasing the mutex.

Signed-off-by: Roi Dayan <roid@...>
---

Hi, 

The issue was discovered after working with discoveryd and offload driver 
which needed the following patch that was already submitted to the mailing list: 

[PATCH] Discovery daemon via non-tcp transport needs 'ipc' set 

Thanks, 
Roi 

V2:
    didn't actually need iscsi_login_portal_wait

 usr/Makefile     |  2 +-
 usr/discoveryd.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 56 insertions(+), 3 deletions(-)

diff --git a/usr/Makefile b/usr/Makefile
index e23fee1..dca7b6e 100644
--- a/usr/Makefile
+++ b/usr/Makefile
 <at>  <at>  -55,7 +55,7  <at>  <at>  all: $(PROGRAMS)

 iscsid: $(ISCSI_LIB_SRCS) $(INITIATOR_SRCS) $(DISCOVERY_SRCS) \
 	iscsid.o session_mgmt.o discoveryd.o
-	$(CC) $(CFLAGS) $(LDFLAGS) $^ -o $ <at>   -L../utils/open-isns -lisns -lrt -lmount
+	$(CC) $(CFLAGS) $(LDFLAGS) $^ -o $ <at>   -L../utils/open-isns -lisns -lrt -lmount -pthread

 iscsiadm: $(ISCSI_LIB_SRCS) $(DISCOVERY_SRCS) iscsiadm.o session_mgmt.o
 	$(CC) $(CFLAGS) $(LDFLAGS) $^ -o $ <at>  -L../utils/open-isns -lisns
diff --git a/usr/discoveryd.c b/usr/discoveryd.c
index 2d3ccbc..6943662 100644
--- a/usr/discoveryd.c
+++ b/usr/discoveryd.c
 <at>  <at>  -27,6 +27,10  <at>  <at> 
 #include <time.h>
 #include <sys/types.h>
 #include <sys/wait.h>
+#include <sys/mman.h>
+#include <sys/stat.h>
+#include <pthread.h>
+#include <fcntl.h>

 #include "discovery.h"
 #include "idbm.h"
 <at>  <at>  -47,6 +51,9  <at>  <at> 
 #include "iscsi_err.h"

 #define DISC_DEF_POLL_INVL	30
+#define MUTEX "/lock"
+
+pthread_mutex_t *mutex = NULL;

 static LIST_HEAD(iscsi_targets);
 static int stop_discoveryd;
 <at>  <at>  -62,6 +69,43  <at>  <at>  static void isns_reg_refresh_by_eid_qry(void *data);
 typedef void (do_disc_and_login_fn)(const char *def_iname,
 				    struct discovery_rec *drec, int poll_inval);

+static void discoveryd_create_shared_mutex(void)
+{
+	int mode = S_IRWXU | S_IRWXG;
+	int des_mutex;
+	pthread_mutexattr_t attr;
+
+	des_mutex = shm_open(MUTEX, O_CREAT | O_RDWR | O_TRUNC, mode);
+
+	if (des_mutex < 0) {
+	    log_error("Error creating mutex");
+	    return;
+	}
+
+	if (ftruncate(des_mutex, sizeof(pthread_mutex_t)) == -1) {
+		log_error("Error on truncate");
+		return;
+	}
+
+	mutex = (pthread_mutex_t*) mmap(NULL, sizeof(pthread_mutex_t),
+		    PROT_READ | PROT_WRITE, MAP_SHARED, des_mutex, 0);
+
+	if (mutex == MAP_FAILED ) {
+		log_error("Error on mmap");
+		return;
+	}
+
+	pthread_mutexattr_init(&attr);
+	pthread_mutexattr_setpshared(&attr, PTHREAD_PROCESS_SHARED);
+	pthread_mutex_init(mutex, &attr);
+	pthread_mutexattr_destroy(&attr);
+}
+
+static void discoveryd_destroy_shared_mutex(void)
+{
+	pthread_mutex_destroy(mutex);
+}
+
 static int logout_session(void *data, struct list_head *list,
 			  struct session_info *info)
 {
 <at>  <at>  -96,6 +140,7  <at>  <at>  static void discoveryd_stop(void)
 	}

 done:
+	discoveryd_destroy_shared_mutex();
 	exit(0);
 }

 <at>  <at>  -174,7 +219,7  <at>  <at>  static void update_sessions(struct list_head *new_rec_list,

 	list_for_each_entry_safe(rec, tmp_rec, new_rec_list, list) {
 		if (!iscsi_check_for_running_session(rec))
-			iscsi_login_portal_nowait(rec);
+			iscsi_login_portal(NULL, NULL, rec);

 		if (!idbm_find_rec_in_list(&iscsi_targets, rec->name,
 					   rec->conn[0].address,
 <at>  <at>  -190,7 +235,7  <at>  <at>  static void update_sessions(struct list_head *new_rec_list,
 	}

 	if (!list_empty(&stale_rec_list)) {
-		iscsi_logout_portals(&stale_rec_list, &nr_found, 0,
+		iscsi_logout_portals(&stale_rec_list, &nr_found, 1,
 				     logout_session);
 		list_for_each_entry_safe(rec, tmp_rec, &stale_rec_list, list) {
 			list_del(&rec->list);
 <at>  <at>  -1059,7 +1104,12  <at>  <at>  static void do_st_disc_and_login(const char *def_iname,
 		poll_inval = DISC_DEF_POLL_INVL;

 	do {
+		pthread_mutex_lock(mutex);
+		log_debug(1, "discoveryd start scan %s:%d", drec->address, drec->port);
 		__do_st_disc_and_login(drec);
+		pthread_mutex_unlock(mutex);
+		log_debug(1, "discoveryd end scan %s:%d", drec->address, drec->port);
+
 		if (!poll_inval)
 			break;
 	} while (!stop_discoveryd && !sleep(poll_inval));
 <at>  <at>  -1081,6 +1131,9  <at>  <at>  static int st_start(void *data, struct discovery_rec *drec)

 static void discoveryd_st_start(void)
 {
+	discoveryd_create_shared_mutex();
+	if (mutex == NULL)
+	    return;
 	idbm_for_each_st_drec(NULL, st_start);
 }

-- 
1.8.4.3

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Roi Dayan | 23 Aug 15:18 2015

[PATCH] discoveryd: Lock between forks

Since iscsi responses from the kernel are multicast we might get into
a situation where multiple discoveryd handle the same response.
With this commit we use a shared mutex to lock between the discoveryd forks
so each fork will handle its intended portal.
So we wait for login and stale logouts to finish between releasing the mutex.

Signed-off-by: Roi Dayan <roid@...>
---

Hi,

The issue was discovered after working with discoveryd and offload driver
which needed the following patch that was already submitted to the mailing list:

[PATCH] Discovery daemon via non-tcp transport needs 'ipc' set

Thanks,
Roi

 usr/Makefile       |  2 +-
 usr/discoveryd.c   | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++++--
 usr/session_mgmt.c | 10 ++++++++++
 3 files changed, 66 insertions(+), 3 deletions(-)

diff --git a/usr/Makefile b/usr/Makefile
index e23fee1..dca7b6e 100644
--- a/usr/Makefile
+++ b/usr/Makefile
 <at>  <at>  -55,7 +55,7  <at>  <at>  all: $(PROGRAMS)

 iscsid: $(ISCSI_LIB_SRCS) $(INITIATOR_SRCS) $(DISCOVERY_SRCS) \
 	iscsid.o session_mgmt.o discoveryd.o
-	$(CC) $(CFLAGS) $(LDFLAGS) $^ -o $ <at>   -L../utils/open-isns -lisns -lrt -lmount
+	$(CC) $(CFLAGS) $(LDFLAGS) $^ -o $ <at>   -L../utils/open-isns -lisns -lrt -lmount -pthread

 iscsiadm: $(ISCSI_LIB_SRCS) $(DISCOVERY_SRCS) iscsiadm.o session_mgmt.o
 	$(CC) $(CFLAGS) $(LDFLAGS) $^ -o $ <at>  -L../utils/open-isns -lisns
diff --git a/usr/discoveryd.c b/usr/discoveryd.c
index 2d3ccbc..e08143e 100644
--- a/usr/discoveryd.c
+++ b/usr/discoveryd.c
 <at>  <at>  -27,6 +27,10  <at>  <at> 
 #include <time.h>
 #include <sys/types.h>
 #include <sys/wait.h>
+#include <sys/mman.h>
+#include <sys/stat.h>
+#include <pthread.h>
+#include <fcntl.h>

 #include "discovery.h"
 #include "idbm.h"
 <at>  <at>  -47,6 +51,9  <at>  <at> 
 #include "iscsi_err.h"

 #define DISC_DEF_POLL_INVL	30
+#define MUTEX "/lock"
+
+pthread_mutex_t *mutex = NULL;

 static LIST_HEAD(iscsi_targets);
 static int stop_discoveryd;
 <at>  <at>  -62,6 +69,43  <at>  <at>  static void isns_reg_refresh_by_eid_qry(void *data);
 typedef void (do_disc_and_login_fn)(const char *def_iname,
 				    struct discovery_rec *drec, int poll_inval);

+static void discoveryd_create_shared_mutex(void)
+{
+	int mode = S_IRWXU | S_IRWXG;
+	int des_mutex;
+	pthread_mutexattr_t attr;
+
+	des_mutex = shm_open(MUTEX, O_CREAT | O_RDWR | O_TRUNC, mode);
+
+	if (des_mutex < 0) {
+	    log_error("Error creating mutex");
+	    return;
+	}
+
+	if (ftruncate(des_mutex, sizeof(pthread_mutex_t)) == -1) {
+		log_error("Error on truncate");
+		return;
+	}
+
+	mutex = (pthread_mutex_t*) mmap(NULL, sizeof(pthread_mutex_t),
+		    PROT_READ | PROT_WRITE, MAP_SHARED, des_mutex, 0);
+
+	if (mutex == MAP_FAILED ) {
+		log_error("Error on mmap");
+		return;
+	}
+
+	pthread_mutexattr_init(&attr);
+	pthread_mutexattr_setpshared(&attr, PTHREAD_PROCESS_SHARED);
+	pthread_mutex_init(mutex, &attr);
+	pthread_mutexattr_destroy(&attr);
+}
+
+static void discoveryd_destroy_shared_mutex(void)
+{
+	pthread_mutex_destroy(mutex);
+}
+
 static int logout_session(void *data, struct list_head *list,
 			  struct session_info *info)
 {
 <at>  <at>  -96,6 +140,7  <at>  <at>  static void discoveryd_stop(void)
 	}

 done:
+	discoveryd_destroy_shared_mutex();
 	exit(0);
 }

 <at>  <at>  -174,7 +219,7  <at>  <at>  static void update_sessions(struct list_head *new_rec_list,

 	list_for_each_entry_safe(rec, tmp_rec, new_rec_list, list) {
 		if (!iscsi_check_for_running_session(rec))
-			iscsi_login_portal_nowait(rec);
+			iscsi_login_portal_wait(rec);

 		if (!idbm_find_rec_in_list(&iscsi_targets, rec->name,
 					   rec->conn[0].address,
 <at>  <at>  -190,7 +235,7  <at>  <at>  static void update_sessions(struct list_head *new_rec_list,
 	}

 	if (!list_empty(&stale_rec_list)) {
-		iscsi_logout_portals(&stale_rec_list, &nr_found, 0,
+		iscsi_logout_portals(&stale_rec_list, &nr_found, 1,
 				     logout_session);
 		list_for_each_entry_safe(rec, tmp_rec, &stale_rec_list, list) {
 			list_del(&rec->list);
 <at>  <at>  -1059,7 +1104,12  <at>  <at>  static void do_st_disc_and_login(const char *def_iname,
 		poll_inval = DISC_DEF_POLL_INVL;

 	do {
+		pthread_mutex_lock(mutex);
+		log_debug(1, "discoveryd start scan %s:%d", drec->address, drec->port);
 		__do_st_disc_and_login(drec);
+		pthread_mutex_unlock(mutex);
+		log_debug(1, "discoveryd end scan %s:%d", drec->address, drec->port);
+
 		if (!poll_inval)
 			break;
 	} while (!stop_discoveryd && !sleep(poll_inval));
 <at>  <at>  -1081,6 +1131,9  <at>  <at>  static int st_start(void *data, struct discovery_rec *drec)

 static void discoveryd_st_start(void)
 {
+	discoveryd_create_shared_mutex();
+	if (mutex == NULL)
+	    return;
 	idbm_for_each_st_drec(NULL, st_start);
 }

diff --git a/usr/session_mgmt.c b/usr/session_mgmt.c
index 596085b..b397eaa 100644
--- a/usr/session_mgmt.c
+++ b/usr/session_mgmt.c
 <at>  <at>  -223,6 +223,16  <at>  <at>  int iscsi_login_portal_nowait(struct node_rec *rec)
 	return 0;
 }

+int iscsi_login_portal_wait(struct node_rec *rec)
+{
+	int err;
+
+	err = iscsi_login_portal(NULL, NULL, rec);
+	if (err > 0)
+		return err;
+	return 0;
+}
+
 /**
  * __iscsi_login_portals - login into portals on  <at> rec_list,
  *  <at> data: data to pass to login_fn
-- 
1.8.4.3

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Lee Duncan | 22 Aug 03:06 2015
Picon

[PATCH] open-isns: Allow setting server name for isnsadm.

The switch statement was falling through after
the server name was set, into the "version" code. So
setting the server name just printed the version and
exited. Added a break statement.
---
 utils/open-isns/isnsadm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/utils/open-isns/isnsadm.c b/utils/open-isns/isnsadm.c
index c170595372da..5b14f82b8ce9 100644
--- a/utils/open-isns/isnsadm.c
+++ b/utils/open-isns/isnsadm.c
 <at>  <at>  -141,6 +141,7  <at>  <at>  main(int argc, char **argv)

 		case 's':
 			opt_servername = optarg;
+			break;

 		case 'V':
 			printf("Open-iSNS version %s\n"
-- 
1.8.5.2

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Manish Singh | 18 Aug 14:10 2015
Picon

Updated iscsi timeout and retry values in iscsi.conf file are not getting effective

Dear All,

We are using RHEL 6.6 and iscsi-initiator-utils-6.2.0.873-13 in our test environment.

we have modified following iscsi timeout and retry values in iscsi.conf,

node.session.timeo.replacement_timeout = 30 (previously 180)

node.session.initial_login_retry_max = 1 

(previously 8, By Default)

node.session.err_timeo.abort_timeout = 5 (previously 15, By Default)

node.session.err_timeo.lu_reset_timeout = 10 

(previously 30, By Default)
node.session.err_timeo.tgt_reset_timeout = 10 (previously 30, By Default)


As per our understanding, the above changes should get effective for iscsiadm commands just after restarting iscsi daemon. 

But, these are not getting effective until we execute the discovery command( iscsiadm -m discovery --type sendtargets -p x.x.x.x) after restarting iscsi daemon. 


Can someone please respond to my following queries:

1> As iscsi database(/var/lib/iscsi/nodes) resides at initiator side, restarting iscsi daemon should update the database(/var/lib/iscsi/nodes).

Is the above understanding correct?

If not, is it always required to explicitly execute discovery command to make changes in iscsi.conf become effective ?

2> Is it possible to achieve the same without executing discovery command [Is there any other possible way] ?





--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
Frank Fegert | 5 Aug 22:33 2015
Picon
Picon

Setting firmware/offload engine parameter "Large_Frames" on QLogic HBAs

Hello all,

the short version of my question:

Is it possible to set firmware/offload engine parameters like e.g.
"Large_Frames" on QLogic HBAs via the "iscsiadm -m fw [...]" command?

The slightly longer version of my question ;-)

I'm having some difficulties trying to configure some HBA settings -
namely the IP address, subnet mask, iSCSI alias, iSCSI "Large_Frames"
and possibly other parameters too - from within the server OS using
the qaucli utility. The system parameters are:
 - HBAs: QME/QMD8262, Dell OEM, FW Version: 4.18.04
 - QConvergeConsole CLI "qaucli": Version 1.1.3 (Build 49)
 - OS:
   - Debian 7
   - open-iscsi-2.0.873-3 (also tried a newer version from GIT)
   - Kernel 3.16.7
   - Driver "qla4xxx" v5.04.00-k6

I try to set e.g. the "Large_Frames" parameter in the iSCSI offload
engine of a HBA, which is already configured like shown below in the
example output titled "Before qaucli", with the command:
  /opt/QLogic_Corporation/QConvergeConsoleCLI/qaucli -iscsi -n 0 LRGFRM on

After this, the "Large_Frames" parameter ends up being set correctly,
but in the process, the IP address, subnet mask, gateway and iSCSI
name become corrupted like shown below in the example output titled
"After qaucli".

From QLogic support i got a referral towards Dell, since it's a OEM
HBA. From Dell i got the answer that Debian isn't a supported OS. So
no help from the vendor side of this issue :-/

I'd rather refrain from using the qaucli utility altogether, but un-
fortunately i haven't been able to figure out if and how this can be
achieved with the "iscsiadm -m fw [...]" or a similar command.

Thanks & best regards,

    Frank Fegert

#### Before qaucli - Begin ###########################################
hostname:~# /opt/QLogic_Corporation/QConvergeConsoleCLI/qaucli -iscsi -c 0
Using config file: /opt/QLogic_Corporation/QConvergeConsoleCLI/qaucli.cfg
Installation directory: /opt/QLogic_Corporation/QConvergeConsoleCLI
Working dir: /root
Using config file: /opt/QLogic_Corporation/QConvergeConsoleCLI/iscli.cfg
Loading iSCSI Data ...
Loading iSCSI Instance: 1 HBA: 1 Physical Port: 1 (QME8262 , 84-8F-69-35-FC-70) ...
Loading iSCSI Instance: 2 HBA: 1 Physical Port: 2 (QME8262 , 84-8F-69-35-FC-71) ...

*******************************
*** Displaying Port inst=0 ***
*******************************
*** Displaying HBA (Adapter) Level Information inst=0 ***
HBA_Alias                           : 
*** Displaying Port General Summary Information inst=0 ***
 0. HBA: 0 Port: 0 HBA Port Instance: 0 HBA Model: QME8262
    HBA Serial Number: (RFE1449L34695) FW Version: 4.18.04 Type: Fiber
    IP Address: 10.0.0.5
    Alias:
    iSCSI Name: iqn.2000-04.com.qlogic:isp8214.000e1e37da2c.4 
    PCI Function Number: 4
User Defined IP Address.
IPv4 Address             : 10.0.0.5
Gateway                  : 0.0.0.0
Subnet Mask              : 255.255.255.0

iSNS                     : Disabled.
*** Displaying ISCSI Settings inst=0 ***
Force_Negotiate_Main_iSCSI_Keys     :  off
iSCSI_Send_Markers                  :  off(*)
iSCSI_Header_Digests                :  on
iSCSI_Data_Digests                  :  on
iSCSI_Immediate_Data                :  on
iSCSI_Initial_R2T                   :  on
iSCSI_Data_Seq_In_Order             :  on(*)
iSCSI_Data_PDU_In_Order             :  on(*)
iSCSI_CHAP_Auth                     :  off(*)
iSCSI_Bidi_CHAP_Auth                :  on(*)
iSCSI_Snack                         :  off
iSCSI_Discovery_Logout              :  on
iSCSI_Strict_Login                  :  off
iSCSI_Error_Recovery_Level          :  0(*)
iSCSI_Name                          :  iqn.2000-04.com.qlogic:isp8214.000e1e37da2c.4
iSCSI_Alias                         : 
*** Displaying Firmware Settings inst=0 ***
FW_Marker                           :  on(*)
FW_Stat_Alarm                       :  off(*)
FW_Accept_AEN                       :  off(*)
FW_Access_Control                   :  off(*)
FW_Session_Mode                     :  on(*)
FW_Initiator_Mode                   :  on(*)
FW_Target_Mode                      :  off(*)
FW_Fast_Posting                     :  off(*)
FW_Sense_Buffer_Desc                :  off(*)
AFW_Device_Timeouts                 :  on
AFW_AutoConnect                     :  off
AFW_Serlz_Task_Mngmt                :  on
Large_Frames                        :  on
DevType                             :  0(*)
ExeThrottle                         :  0
FirstBurstLen                       :  32764
KeepAliveTO                         :  0
DefaultTime2Retain                  :  0(*)
DefaultTime2Wait                    :  0(*)
MaxBurstLen                         :  32764
MaxOutstandingR2T                   :  0
MaxRxDataSegmentLen                 :  2016(*)
Port                                :  38368(*)
ACB_Version                         :  2(*)
*** Displaying IPv4 Settings inst=0 ***
AFW_Delayed_Ack                     :  on
IP_Fragmentation                    :  on(*)
IP_ARP_Redirect                     :  off
VLAN_Enable                         :  off
802.1pPriority                      :  4
VLAN_ID                             :  2000
Gratuitous_ARP                      :  off
Enable_Type_of_Service              :  off
TCP_DHCP                            :  off
TCP_Nagle                           :  on
TCP_Timer_Scale                     :  4(*)
TCP_Time_Stamp                      :  off
TCP_Window_Scale_Enable             :  off
TCP_Window_Scale                    :  165
Secondary_DNS                       :  (*)
Secondary_IP_Address                :  (*)
Task_Management_Timeout             :  10
IPv4TOS                             :  191
IPv4TTL                             :  6
P3P_TCP_Max_Window_Size             :  0
*** Displaying Remaining parameters inst=0 ***
ACB_Supported                       :  off(*)
Values noted with (*) are read only.
#### Before qaucli - End #############################################

#### After qaucli - Begin ############################################
hostname:~# /opt/QLogic_Corporation/QConvergeConsoleCLI/qaucli -iscsi -c 0            
Using config file: /opt/QLogic_Corporation/QConvergeConsoleCLI/qaucli.cfg
Installation directory: /opt/QLogic_Corporation/QConvergeConsoleCLI
Working dir: /root
Using config file: /opt/QLogic_Corporation/QConvergeConsoleCLI/iscli.cfg
Loading iSCSI Data ...
Loading iSCSI Instance: 1 HBA: 1 Physical Port: 1 (QME8262 , 84-8F-69-35-FC-70) ...
Loading iSCSI Instance: 2 HBA: 1 Physical Port: 2 (QME8262 , 84-8F-69-35-FC-71) ...

*******************************
*** Displaying Port inst=0 ***
*******************************
*** Displaying HBA (Adapter) Level Information inst=0 ***
HBA_Alias                           : 
*** Displaying Port General Summary Information inst=0 ***
 0. HBA: 0 Port: 0 HBA Port Instance: 0 HBA Model: QME8262
    HBA Serial Number: (RFE1449L34695) FW Version: 4.18.04 Type: Fiber
    IP Address: 252.127.0.0 (Not Active)
    Alias:
    iSCSI Name: <&=EF=BF=BDx 
    PCI Function Number: 4
User Defined IP Address.
IPv4 Address             : 252.127.0.0
Gateway                  : 66.130.0.0
Subnet Mask              : 166.107.209.120

iSNS                     : Disabled.
*** Displaying ISCSI Settings inst=0 ***
Force_Negotiate_Main_iSCSI_Keys     :  off
iSCSI_Send_Markers                  :  off(*)
iSCSI_Header_Digests                :  off
iSCSI_Data_Digests                  :  on
iSCSI_Immediate_Data                :  off
iSCSI_Initial_R2T                   :  off
iSCSI_Data_Seq_In_Order             :  on(*)
iSCSI_Data_PDU_In_Order             :  on(*)
iSCSI_CHAP_Auth                     :  off(*)
iSCSI_Bidi_CHAP_Auth                :  on(*)
iSCSI_Snack                         :  on
iSCSI_Discovery_Logout              :  off
iSCSI_Strict_Login                  :  on
iSCSI_Error_Recovery_Level          :  3(*)
iSCSI_Name                          :  <&=EF=BF=BDx
iSCSI_Alias                         : 
*** Displaying Firmware Settings inst=0 ***
FW_Marker                           :  on(*)
FW_Stat_Alarm                       :  off(*)
FW_Accept_AEN                       :  off(*)
FW_Access_Control                   :  off(*)
FW_Session_Mode                     :  on(*)
FW_Initiator_Mode                   :  on(*)
FW_Target_Mode                      :  off(*)
FW_Fast_Posting                     :  off(*)
FW_Sense_Buffer_Desc                :  off(*)
AFW_Device_Timeouts                 :  on
AFW_AutoConnect                     :  off
AFW_Serlz_Task_Mngmt                :  on
Large_Frames                        :  off
DevType                             :  0(*)
ExeThrottle                         :  0
FirstBurstLen                       :  0
KeepAliveTO                         :  0
DefaultTime2Retain                  :  0(*)
DefaultTime2Wait                    :  0(*)
MaxBurstLen                         :  0
MaxOutstandingR2T                   :  0
MaxRxDataSegmentLen                 :  128(*)
Port                                :  0(*)
ACB_Version                         :  2(*)
*** Displaying IPv4 Settings inst=0 ***
AFW_Delayed_Ack                     :  on
IP_Fragmentation                    :  on(*)
IP_ARP_Redirect                     :  off
VLAN_Enable                         :  off
802.1pPriority                      :  3
VLAN_ID                             :  2064
Gratuitous_ARP                      :  off
Enable_Type_of_Service              :  off
TCP_DHCP                            :  off
TCP_Nagle                           :  on
TCP_Timer_Scale                     :  0(*)
TCP_Time_Stamp                      :  on
TCP_Window_Scale_Enable             :  off
TCP_Window_Scale                    :  54
Secondary_DNS                       :  (*)
Secondary_IP_Address                :  (*)
Task_Management_Timeout             :  10
IPv4TOS                             :  2
IPv4TTL                             :  64
P3P_TCP_Max_Window_Size             :  0
*** Displaying Remaining parameters inst=0 ***
ACB_Supported                       :  off(*)
Values noted with (*) are read only.
#### After qaucli - End ##############################################

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

LSZhu | 23 Jul 08:37 2015

Errors when log out a deleted target

Hi experts,

When I try to log out a target which is already deleted at the target server side, I can see a error :

Logging out of session [sid: 1, target: iqn.2015-07.com.example:test:844a36e0-e921-4988-9538-a32112aa40d4, portal: 147.2.207.200,3260]
iscsiadm: Could not logout of [sid: 1, target: iqn.2015-07.com.example:test:844a36e0-e921-4988-9538-a32112aa40d4, portal: 147.2.207.200,3260].
iscsiadm: initiator reported error (9 - internal error)
iscsiadm: Could not logout of all requested sessions

I think maybe the reason is that, the target is deleted, so the initiator can not get a logout response PDU, so errors.We would meet the same situation when target still alive but network down.
I have a proposal, can we set a time out values, for example 10 seconds, once time out, log out anyway, then print some message like "The target is not reachable, logged out". I think this operation is not harmful to the target side.
Do you experts think that make sense?


Thanks
BR
Zhu Lingshan

--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
leeman.duncan | 22 Jul 00:47 2015
Picon

[PATCH] Discovery daemon via non-tcp transport needs 'ipc' set

From: Lee Duncan <lduncan@...>

This patch allows iser transport to be used for the discovery
daemon. Otherwise, iscsid core dumps when attempting this.
---
 usr/discoveryd.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/usr/discoveryd.c b/usr/discoveryd.c
index 1e149771a50b..2d3ccbcd722f 100644
--- a/usr/discoveryd.c
+++ b/usr/discoveryd.c
 <at>  <at>  -1034,11 +1034,6  <at>  <at>  static void __do_st_disc_and_login(struct discovery_rec *drec)
 	drec->u.sendtargets.reopen_max = 0;

 	iface_link_ifaces(&setup_ifaces);
-	/*
-	 * disc code assumes this is not set and wants to use
-	 * the userspace IO code.
-	 */
-	ipc = NULL;

 	rc = idbm_bind_ifaces_to_nodes(discovery_sendtargets, drec,
 					&setup_ifaces, &rec_list);
-- 
2.1.4

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

LSZhu | 17 Jul 11:00 2015

Is it a valid bug : some errors when discover or delete targets if we manually create default file in folder sendtargets and nodes

Hi experts,

Our team find two bugs, please help me check whether they are valid, if they are, I am happy to fix them:

------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

(A) If we touch a empty default file in sendtargets, when we try to discover the targets, we would got a empty default file in sendtargets.
Here is the detailed information and how to reproduce.

(1) we have a target on 147.2.207.131. Target name: iqn.2015-07.com.example

(2) Create a folder like "/etc/iscsi/send_targets/147.2.207.131,3260/iqn.2015-07.com.example,147.2.207.131,3260,1,default" which matches the target name, here it is iqn.2015-07.com.example
linux-askc:/etc/iscsi # mkdir -p /etc/iscsi/send_targets/147.2.207.131,3260/iqn.2015-07.com.example,147.2.207.131,3260,1,default

(3) Create a empty default file in the folder created above.
linux-askc:/etc/iscsi # touch  /etc/iscsi/send_targets/147.2.207.131,3260/iqn.2015-07.com.example,147.2.207.131,3260,1,default/default

(4) Run discover command,
linux-askc:/etc/iscsi # iscsiadm -m discovery -t st -p 147.2.207.131
147.2.207.131:3260,1 iqn.2015-07.com.example (we got the target)
(5) check the default file in sendtargets:
linux-askc:/etc/iscsi # cat  /etc/iscsi/send_targets/147.2.207.131,3260/iqn.2015-07.com.example,147.2.207.131,3260,1,default/default   
Then we will find the default file : /etc/iscsi/send_targets/147.2.207.131,3260/iqn.2015-07.com.example,147.2.207.131,3260,1,default/default still a empty

(6) If we want to delete the target, we would see:

linux-askc:/etc/iscsi/nodes # iscsiadm -m node -o delete
iscsiadm: Could not remove link /etc/iscsi/send_targets/147.2.207.131,3260/iqn.2015-07.com.example,147.2.207.131,3260,1,default: Is a directory

iscsiadm: Could not execute operation on all records: encountered iSCSI database failure

(7) Then run discover command again, we would get a error:
linux-askc:/etc/iscsi # iscsiadm -m discovery -t st -p 147.2.207.131
iscsiadm: Could not remove link /etc/iscsi/send_targets/147.2.207.131,3260/iqn.2015-07.com.example,147.2.207.131,3260,1,default: Is a directory

iscsiadm: Could not add/update [tcp:[hw=,ip=,net_if=,iscsi_if=default] 147.2.207.131,3260,1 iqn.2015-07.com.example]
147.2.207.131:3260,1 iqn.2015-07.com.example
linux-askc:/etc/iscsi #

------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

(B) If we touch a empty default file in nodes when we try to discover the targets,
 
(1) we have a target on 147.2.207.131. Target name: iqn.2015-07.com.example

(2) Create a folder like "/etc/iscsi/nodes/iqn.2015-07.com.example/147.2.207.131,3260,1" which matches the target name, here it is iqn.2015-07.com.example
mkdir -p /etc/iscsi/nodes/iqn.2015-07.com.example/147.2.207.131,3260,1

(3) Create a empty default file in the folder created above.
linux-askc:/etc/iscsi # touch /etc/iscsi/nodes/iqn.2015-07.com.example/147.2.207.131,3260,1/default

(4) Run discover command, we will see a error:
linux-askc:/etc/iscsi # iscsiadm -m discovery -t st -p 147.2.207.131
iscsiadm: Could not stat /etc/iscsi/nodes//,3260,-1/default to delete node: No such file or directory

iscsiadm: Could not add/update [tcp:[hw=,ip=,net_if=,iscsi_if=default] 147.2.207.131,3260,1 iqn.2015-07.com.example]
147.2.207.131:3260,1 iqn.2015-07.com.example
linux-askc:/etc/iscsi #

------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

For now, the only way we know that can 100% trigger the bug is creating these files manually, but some guys had ever see the bugs randomly. Are they valid bugs? I think it is nice to enhance the code.


Thanks,
BR
Zhu Lingshan

--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
leeman.duncan | 14 Jul 23:01 2015
Picon

[PATCH 0/2] Remove local open-isns, using system-installed version

From: Lee Duncan <lduncan@...>

This set of patches tells open-iscsi to use the system-resident
open-isns files instead of the ones in utils/open-isns.

This patch *requires* that you've installed open-isns (from
git@...:gonzoleeman/open-isns.git).

The first patch tells open-iscsi to use the system-resident
include files and library from open-isns. The second patch
removes the local copy of same.

Questions:
- Should the documentation be updated? I didn't
  find anything that referenced open-isns
- Is it perhaps time to bump the minor version
  of open-iscsi? It's been a while.

Note: it is my intention to create an open-isns package
for SUSE. I assume other platforms will have to do the
same before they could incorporate this patch.

Lee Duncan (2):
  Use system-wide open-isns, not internal version.
  Remove local copy of open-isns.

 Makefile                                           |   10 +-
 usr/Makefile                                       |    7 +-
 usr/discovery.c                                    |    6 +-
 usr/discoveryd.c                                   |    8 +-
 usr/iscsiadm.c                                     |    2 +-
 utils/open-isns/COPYING                            |  504 --
 utils/open-isns/ChangeLog                          |   50 -
 utils/open-isns/HACKING                            |   30 -
 utils/open-isns/Makefile.in                        |   81 -
 utils/open-isns/README                             |  173 -
 utils/open-isns/TODO                               |  100 -
 utils/open-isns/aclocal/config.guess               | 1499 -----
 utils/open-isns/aclocal/config.sub                 | 1570 -----
 utils/open-isns/aclocal/install-sh                 |  251 -
 utils/open-isns/attrs.c                            | 1618 -----
 utils/open-isns/attrs.h                            |  262 -
 utils/open-isns/authblock.c                        |   62 -
 utils/open-isns/bitvector.c                        |  648 --
 utils/open-isns/buffer.c                           |  407 --
 utils/open-isns/buffer.h                           |  141 -
 utils/open-isns/callback.c                         |  148 -
 utils/open-isns/client.c                           |  205 -
 utils/open-isns/compat/my_getopt.c                 |  271 -
 utils/open-isns/compat/my_getopt.h                 |   69 -
 utils/open-isns/config.c                           |  278 -
 utils/open-isns/config.h.in                        |  103 -
 utils/open-isns/configure                          | 6727 --------------------
 utils/open-isns/configure.ac                       |  118 -
 utils/open-isns/db-file.c                          |  615 --
 utils/open-isns/db-policy.c                        |  187 -
 utils/open-isns/db.c                               |  994 ---
 utils/open-isns/db.h                               |  147 -
 utils/open-isns/dd.c                               | 1306 ----
 utils/open-isns/deregister.c                       |  271 -
 utils/open-isns/doc/isns_config.5                  |  387 --
 utils/open-isns/doc/isnsadm.8                      |  688 --
 utils/open-isns/doc/isnsd.8                        |   93 -
 utils/open-isns/doc/isnsdd.8                       |   75 -
 utils/open-isns/domain.c                           |  208 -
 utils/open-isns/entity.c                           |  127 -
 utils/open-isns/error.c                            |   65 -
 utils/open-isns/esi.c                              |  576 --
 utils/open-isns/etc/isnsadm.conf                   |   73 -
 utils/open-isns/etc/isnsd.conf                     |  129 -
 utils/open-isns/etc/isnsdd.conf                    |   72 -
 utils/open-isns/etc/openisns.init                  |   71 -
 utils/open-isns/export.c                           |  547 --
 utils/open-isns/getnext.c                          |  257 -
 utils/open-isns/internal.h                         |   16 -
 utils/open-isns/isns-proto.h                       |  259 -
 utils/open-isns/isns.h                             |  673 --
 utils/open-isns/isnsadm.c                          | 1151 ----
 utils/open-isns/isnsd.c                            |  299 -
 utils/open-isns/isnsdd.c                           | 1153 ----
 utils/open-isns/isnssetup                          |   52 -
 utils/open-isns/local.c                            |  353 -
 utils/open-isns/logging.c                          |  228 -
 utils/open-isns/mdebug.c                           |  295 -
 utils/open-isns/message.c                          |  681 --
 utils/open-isns/message.h                          |  196 -
 utils/open-isns/objects.c                          | 1320 ----
 utils/open-isns/objects.h                          |  168 -
 utils/open-isns/parser.c                           |  134 -
 utils/open-isns/paths.h                            |   22 -
 utils/open-isns/pidfile.c                          |   98 -
 utils/open-isns/pki.c                              |  536 --
 utils/open-isns/policy.c                           |  577 --
 utils/open-isns/portal-group.c                     |  307 -
 utils/open-isns/query.c                            |  238 -
 utils/open-isns/register.c                         |  934 ---
 utils/open-isns/relation.c                         |  281 -
 utils/open-isns/scn.c                              |  926 ---
 utils/open-isns/scope.c                            |  513 --
 utils/open-isns/security.c                         |  437 --
 utils/open-isns/security.h                         |  185 -
 utils/open-isns/server.c                           |  236 -
 utils/open-isns/simple.c                           |  727 ---
 utils/open-isns/slp.c                              |  242 -
 utils/open-isns/socket.c                           | 2304 -------
 utils/open-isns/socket.h                           |   95 -
 utils/open-isns/source.h                           |   32 -
 utils/open-isns/storage-node.c                     |  202 -
 utils/open-isns/sysdep-unix.c                      |  186 -
 utils/open-isns/tags.c                             |  740 ---
 utils/open-isns/tests/.cvsignore                   |    2 -
 utils/open-isns/tests/Makefile                     |   40 -
 utils/open-isns/tests/client.conf                  |    8 -
 utils/open-isns/tests/data/test01/01-enroll        |   18 -
 utils/open-isns/tests/data/test01/02-registration  |   42 -
 utils/open-isns/tests/data/test01/03-query         |   20 -
 utils/open-isns/tests/data/test01/03-registration  |   20 -
 .../open-isns/tests/data/test01/99-unregistration  |   18 -
 utils/open-isns/tests/data/test02/01-enroll        |   18 -
 utils/open-isns/tests/data/test02/02-enroll        |   24 -
 utils/open-isns/tests/data/test02/03-registration  |   72 -
 utils/open-isns/tests/data/test02/04-query         |   20 -
 utils/open-isns/tests/data/test02/05-query         |   20 -
 .../open-isns/tests/data/test02/06-dd-registration |   81 -
 utils/open-isns/tests/data/test02/07-query         |   40 -
 utils/open-isns/tests/data/test02/08-query         |   40 -
 utils/open-isns/tests/data/test02/09-query         |   20 -
 .../open-isns/tests/data/test02/10-dd-registration |   87 -
 utils/open-isns/tests/data/test02/11-query         |   10 -
 .../tests/data/test02/12-dd-deregistration         |   85 -
 .../tests/data/test02/13-dd-deregistration         |   83 -
 .../open-isns/tests/data/test02/14-dd-registration |   85 -
 .../tests/data/test02/15-dd-deregistration         |   76 -
 utils/open-isns/tests/data/test03/01-enroll        |   18 -
 utils/open-isns/tests/data/test03/02-registration  |   42 -
 .../open-isns/tests/data/test03/03-unregistration  |   42 -
 .../open-isns/tests/data/test03/04-unregistration  |   18 -
 .../open-isns/tests/data/test03/99-unregistration  |   13 -
 utils/open-isns/tests/data/test04/01-enroll        |   18 -
 utils/open-isns/tests/data/test04/02-registration  |   42 -
 utils/open-isns/tests/data/test04/03-restart       |   42 -
 utils/open-isns/tests/data/test04/04-query         |   20 -
 utils/open-isns/tests/data/test05/01-enroll        |   18 -
 utils/open-isns/tests/data/test05/02-registration  |   42 -
 utils/open-isns/tests/data/test05/03-expired       |   18 -
 utils/open-isns/tests/data/test06/01-enroll        |   18 -
 utils/open-isns/tests/data/test06/02-registration  |   42 -
 utils/open-isns/tests/data/test06/03-registration  |   42 -
 utils/open-isns/tests/data/test06/04-registration  |   42 -
 .../open-isns/tests/data/test06/05-dd-registration |   49 -
 utils/open-isns/tests/data/test06/06-registration  |   49 -
 .../open-isns/tests/data/test06/07-dd-registration |   52 -
 utils/open-isns/tests/data/test06/08-registration  |   64 -
 utils/open-isns/tests/data/test06/09-registration  |   64 -
 .../open-isns/tests/data/test06/10-unregistration  |   37 -
 utils/open-isns/tests/data/test06/11-registration  |   52 -
 utils/open-isns/tests/data/test07/01-enroll        |   19 -
 utils/open-isns/tests/data/test07/02-registration  |   45 -
 utils/open-isns/tests/data/test07/03-expired       |   19 -
 utils/open-isns/tests/data/test07/04-registration  |   57 -
 utils/open-isns/tests/data/test07/05-expired       |   19 -
 utils/open-isns/tests/data/test08/01-pauw1         |  100 -
 utils/open-isns/tests/data/test09/01-pauw2         |   31 -
 utils/open-isns/tests/data/test10/01-pauw3         |   31 -
 utils/open-isns/tests/data/test10/02-expired       |   31 -
 utils/open-isns/tests/data/test10/03-pauw3         |   31 -
 utils/open-isns/tests/data/test10/04-expired       |   31 -
 utils/open-isns/tests/data/test11/01-pauw4         |   32 -
 utils/open-isns/tests/genkey                       |  175 -
 utils/open-isns/tests/harness.pl                   |  929 ---
 utils/open-isns/tests/pauw1.c                      |  179 -
 utils/open-isns/tests/pauw2.c                      |  212 -
 utils/open-isns/tests/pauw3.c                      |  139 -
 utils/open-isns/tests/pauw4.c                      |  137 -
 utils/open-isns/tests/server.conf                  |   11 -
 utils/open-isns/tests/test01.pl                    |   30 -
 utils/open-isns/tests/test02.pl                    |   58 -
 utils/open-isns/tests/test03.pl                    |   27 -
 utils/open-isns/tests/test04.pl                    |   30 -
 utils/open-isns/tests/test05.pl                    |   25 -
 utils/open-isns/tests/test06.pl                    |   50 -
 utils/open-isns/tests/test07.pl                    |   37 -
 utils/open-isns/tests/test08.pl                    |   23 -
 utils/open-isns/tests/test09.pl                    |   23 -
 utils/open-isns/tests/test10.pl                    |   33 -
 utils/open-isns/tests/test11.pl                    |   23 -
 utils/open-isns/timer.c                            |  126 -
 utils/open-isns/types.h                            |   57 -
 utils/open-isns/util.c                             |  263 -
 utils/open-isns/util.h                             |  289 -
 utils/open-isns/vendor.c                           |   41 -
 utils/open-isns/vendor.h                           |   56 -
 166 files changed, 13 insertions(+), 44211 deletions(-)
 delete mode 100644 utils/open-isns/COPYING
 delete mode 100644 utils/open-isns/ChangeLog
 delete mode 100644 utils/open-isns/HACKING
 delete mode 100644 utils/open-isns/Makefile.in
 delete mode 100644 utils/open-isns/README
 delete mode 100644 utils/open-isns/TODO
 delete mode 100644 utils/open-isns/aclocal/config.guess
 delete mode 100644 utils/open-isns/aclocal/config.sub
 delete mode 100644 utils/open-isns/aclocal/install-sh
 delete mode 100644 utils/open-isns/attrs.c
 delete mode 100644 utils/open-isns/attrs.h
 delete mode 100644 utils/open-isns/authblock.c
 delete mode 100644 utils/open-isns/bitvector.c
 delete mode 100644 utils/open-isns/buffer.c
 delete mode 100644 utils/open-isns/buffer.h
 delete mode 100644 utils/open-isns/callback.c
 delete mode 100644 utils/open-isns/client.c
 delete mode 100644 utils/open-isns/compat/my_getopt.c
 delete mode 100644 utils/open-isns/compat/my_getopt.h
 delete mode 100644 utils/open-isns/config.c
 delete mode 100644 utils/open-isns/config.h.in
 delete mode 100755 utils/open-isns/configure
 delete mode 100644 utils/open-isns/configure.ac
 delete mode 100644 utils/open-isns/db-file.c
 delete mode 100644 utils/open-isns/db-policy.c
 delete mode 100644 utils/open-isns/db.c
 delete mode 100644 utils/open-isns/db.h
 delete mode 100644 utils/open-isns/dd.c
 delete mode 100644 utils/open-isns/deregister.c
 delete mode 100644 utils/open-isns/doc/isns_config.5
 delete mode 100644 utils/open-isns/doc/isnsadm.8
 delete mode 100644 utils/open-isns/doc/isnsd.8
 delete mode 100644 utils/open-isns/doc/isnsdd.8
 delete mode 100644 utils/open-isns/domain.c
 delete mode 100644 utils/open-isns/entity.c
 delete mode 100644 utils/open-isns/error.c
 delete mode 100644 utils/open-isns/esi.c
 delete mode 100644 utils/open-isns/etc/isnsadm.conf
 delete mode 100644 utils/open-isns/etc/isnsd.conf
 delete mode 100644 utils/open-isns/etc/isnsdd.conf
 delete mode 100644 utils/open-isns/etc/openisns.init
 delete mode 100644 utils/open-isns/export.c
 delete mode 100644 utils/open-isns/getnext.c
 delete mode 100644 utils/open-isns/internal.h
 delete mode 100644 utils/open-isns/isns-proto.h
 delete mode 100644 utils/open-isns/isns.h
 delete mode 100644 utils/open-isns/isnsadm.c
 delete mode 100644 utils/open-isns/isnsd.c
 delete mode 100644 utils/open-isns/isnsdd.c
 delete mode 100644 utils/open-isns/isnssetup
 delete mode 100644 utils/open-isns/local.c
 delete mode 100644 utils/open-isns/logging.c
 delete mode 100644 utils/open-isns/mdebug.c
 delete mode 100644 utils/open-isns/message.c
 delete mode 100644 utils/open-isns/message.h
 delete mode 100644 utils/open-isns/objects.c
 delete mode 100644 utils/open-isns/objects.h
 delete mode 100644 utils/open-isns/parser.c
 delete mode 100644 utils/open-isns/paths.h
 delete mode 100644 utils/open-isns/pidfile.c
 delete mode 100644 utils/open-isns/pki.c
 delete mode 100644 utils/open-isns/policy.c
 delete mode 100644 utils/open-isns/portal-group.c
 delete mode 100644 utils/open-isns/query.c
 delete mode 100644 utils/open-isns/register.c
 delete mode 100644 utils/open-isns/relation.c
 delete mode 100644 utils/open-isns/scn.c
 delete mode 100644 utils/open-isns/scope.c
 delete mode 100644 utils/open-isns/security.c
 delete mode 100644 utils/open-isns/security.h
 delete mode 100644 utils/open-isns/server.c
 delete mode 100644 utils/open-isns/simple.c
 delete mode 100644 utils/open-isns/slp.c
 delete mode 100644 utils/open-isns/socket.c
 delete mode 100644 utils/open-isns/socket.h
 delete mode 100644 utils/open-isns/source.h
 delete mode 100644 utils/open-isns/storage-node.c
 delete mode 100644 utils/open-isns/sysdep-unix.c
 delete mode 100644 utils/open-isns/tags.c
 delete mode 100644 utils/open-isns/tests/.cvsignore
 delete mode 100644 utils/open-isns/tests/Makefile
 delete mode 100644 utils/open-isns/tests/client.conf
 delete mode 100644 utils/open-isns/tests/data/test01/01-enroll
 delete mode 100644 utils/open-isns/tests/data/test01/02-registration
 delete mode 100644 utils/open-isns/tests/data/test01/03-query
 delete mode 100644 utils/open-isns/tests/data/test01/03-registration
 delete mode 100644 utils/open-isns/tests/data/test01/99-unregistration
 delete mode 100644 utils/open-isns/tests/data/test02/01-enroll
 delete mode 100644 utils/open-isns/tests/data/test02/02-enroll
 delete mode 100644 utils/open-isns/tests/data/test02/03-registration
 delete mode 100644 utils/open-isns/tests/data/test02/04-query
 delete mode 100644 utils/open-isns/tests/data/test02/05-query
 delete mode 100644 utils/open-isns/tests/data/test02/06-dd-registration
 delete mode 100644 utils/open-isns/tests/data/test02/07-query
 delete mode 100644 utils/open-isns/tests/data/test02/08-query
 delete mode 100644 utils/open-isns/tests/data/test02/09-query
 delete mode 100644 utils/open-isns/tests/data/test02/10-dd-registration
 delete mode 100644 utils/open-isns/tests/data/test02/11-query
 delete mode 100644 utils/open-isns/tests/data/test02/12-dd-deregistration
 delete mode 100644 utils/open-isns/tests/data/test02/13-dd-deregistration
 delete mode 100644 utils/open-isns/tests/data/test02/14-dd-registration
 delete mode 100644 utils/open-isns/tests/data/test02/15-dd-deregistration
 delete mode 100644 utils/open-isns/tests/data/test03/01-enroll
 delete mode 100644 utils/open-isns/tests/data/test03/02-registration
 delete mode 100644 utils/open-isns/tests/data/test03/03-unregistration
 delete mode 100644 utils/open-isns/tests/data/test03/04-unregistration
 delete mode 100644 utils/open-isns/tests/data/test03/99-unregistration
 delete mode 100644 utils/open-isns/tests/data/test04/01-enroll
 delete mode 100644 utils/open-isns/tests/data/test04/02-registration
 delete mode 100644 utils/open-isns/tests/data/test04/03-restart
 delete mode 100644 utils/open-isns/tests/data/test04/04-query
 delete mode 100644 utils/open-isns/tests/data/test05/01-enroll
 delete mode 100644 utils/open-isns/tests/data/test05/02-registration
 delete mode 100644 utils/open-isns/tests/data/test05/03-expired
 delete mode 100644 utils/open-isns/tests/data/test06/01-enroll
 delete mode 100644 utils/open-isns/tests/data/test06/02-registration
 delete mode 100644 utils/open-isns/tests/data/test06/03-registration
 delete mode 100644 utils/open-isns/tests/data/test06/04-registration
 delete mode 100644 utils/open-isns/tests/data/test06/05-dd-registration
 delete mode 100644 utils/open-isns/tests/data/test06/06-registration
 delete mode 100644 utils/open-isns/tests/data/test06/07-dd-registration
 delete mode 100644 utils/open-isns/tests/data/test06/08-registration
 delete mode 100644 utils/open-isns/tests/data/test06/09-registration
 delete mode 100644 utils/open-isns/tests/data/test06/10-unregistration
 delete mode 100644 utils/open-isns/tests/data/test06/11-registration
 delete mode 100644 utils/open-isns/tests/data/test07/01-enroll
 delete mode 100644 utils/open-isns/tests/data/test07/02-registration
 delete mode 100644 utils/open-isns/tests/data/test07/03-expired
 delete mode 100644 utils/open-isns/tests/data/test07/04-registration
 delete mode 100644 utils/open-isns/tests/data/test07/05-expired
 delete mode 100644 utils/open-isns/tests/data/test08/01-pauw1
 delete mode 100644 utils/open-isns/tests/data/test09/01-pauw2
 delete mode 100644 utils/open-isns/tests/data/test10/01-pauw3
 delete mode 100644 utils/open-isns/tests/data/test10/02-expired
 delete mode 100644 utils/open-isns/tests/data/test10/03-pauw3
 delete mode 100644 utils/open-isns/tests/data/test10/04-expired
 delete mode 100644 utils/open-isns/tests/data/test11/01-pauw4
 delete mode 100644 utils/open-isns/tests/genkey
 delete mode 100644 utils/open-isns/tests/harness.pl
 delete mode 100644 utils/open-isns/tests/pauw1.c
 delete mode 100644 utils/open-isns/tests/pauw2.c
 delete mode 100644 utils/open-isns/tests/pauw3.c
 delete mode 100644 utils/open-isns/tests/pauw4.c
 delete mode 100644 utils/open-isns/tests/server.conf
 delete mode 100644 utils/open-isns/tests/test01.pl
 delete mode 100644 utils/open-isns/tests/test02.pl
 delete mode 100644 utils/open-isns/tests/test03.pl
 delete mode 100644 utils/open-isns/tests/test04.pl
 delete mode 100644 utils/open-isns/tests/test05.pl
 delete mode 100644 utils/open-isns/tests/test06.pl
 delete mode 100644 utils/open-isns/tests/test07.pl
 delete mode 100644 utils/open-isns/tests/test08.pl
 delete mode 100644 utils/open-isns/tests/test09.pl
 delete mode 100644 utils/open-isns/tests/test10.pl
 delete mode 100644 utils/open-isns/tests/test11.pl
 delete mode 100644 utils/open-isns/timer.c
 delete mode 100644 utils/open-isns/types.h
 delete mode 100644 utils/open-isns/util.c
 delete mode 100644 utils/open-isns/util.h
 delete mode 100644 utils/open-isns/vendor.c
 delete mode 100644 utils/open-isns/vendor.h

-- 
2.1.4

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

leeman.duncan | 13 Jul 23:57 2015
Picon

[PATCH 0/3] open-isns: prepare for external use by open-iscsi

From: Lee Duncan <lduncan@...>

This group of patches is for open-isns, and the current procedure for
changes to open-isns is to share them on the open-iscsi mailing list.

The goal of these patches is to make open-isns a stand-alone package
that can be used by other (like open-iscsi). This way clients don't
have to have their own (possibly stale) copies of these files.

NOTE: there are NO FUNCTIONAL CHANGES here, just:
* moving some inclue files locally to include/libisns directory
* changing all users of include files to know new location
* Adding "install_lib" and "install_hdrs" Makefile targets

This has been tested with open-iscsn and seems to work.

Lee Duncan (3):
  Move public inlcude files to <libisns/*.h>
  Make one more include file public.
  Add test binaries as 'make clean' targets.

 Makefile.in                  |  27 +-
 attrs.c                      |   6 +-
 attrs.h                      | 262 -----------------
 authblock.c                  |   8 +-
 bitvector.c                  |   4 +-
 buffer.c                     |   4 +-
 buffer.h                     | 141 ---------
 callback.c                   |   6 +-
 client.c                     |   4 +-
 config.c                     |   6 +-
 db-file.c                    |   6 +-
 db-policy.c                  |   4 +-
 db.c                         |   4 +-
 db.h                         |   2 +-
 dd.c                         |   8 +-
 deregister.c                 |   8 +-
 domain.c                     |   4 +-
 entity.c                     |   4 +-
 error.c                      |   2 +-
 esi.c                        |   8 +-
 export.c                     |   8 +-
 getnext.c                    |   8 +-
 include/libisns/attrs.h      | 262 +++++++++++++++++
 include/libisns/buffer.h     | 141 +++++++++
 include/libisns/isns-proto.h | 259 +++++++++++++++++
 include/libisns/isns.h       | 676 +++++++++++++++++++++++++++++++++++++++++++
 include/libisns/message.h    | 196 +++++++++++++
 include/libisns/paths.h      |  24 ++
 include/libisns/source.h     |  32 ++
 include/libisns/types.h      |  57 ++++
 include/libisns/util.h       | 288 ++++++++++++++++++
 isns-proto.h                 | 259 -----------------
 isns.h                       | 676 -------------------------------------------
 isnsadm.c                    |   8 +-
 isnsd.c                      |   6 +-
 isnsdd.c                     |  10 +-
 local.c                      |  12 +-
 logging.c                    |   2 +-
 mdebug.c                     |   2 +-
 message.c                    |   8 +-
 message.h                    | 196 -------------
 objects.c                    |   8 +-
 objects.h                    |   4 +-
 parser.c                     |   2 +-
 paths.h                      |  24 --
 pidfile.c                    |   2 +-
 pki.c                        |   4 +-
 policy.c                     |   6 +-
 portal-group.c               |   6 +-
 query.c                      |   8 +-
 register.c                   |   8 +-
 relation.c                   |   4 +-
 scn.c                        |   8 +-
 scope.c                      |   8 +-
 security.c                   |   6 +-
 security.h                   |   4 +-
 server.c                     |   6 +-
 simple.c                     |   8 +-
 slp.c                        |   4 +-
 socket.c                     |   6 +-
 socket.h                     |   6 +-
 source.h                     |  32 --
 storage-node.c               |   4 +-
 sysdep-unix.c                |   4 +-
 tags.c                       |   6 +-
 tests/pauw1.c                |   8 +-
 tests/pauw2.c                |   8 +-
 tests/pauw3.c                |   8 +-
 tests/pauw4.c                |   8 +-
 timer.c                      |   4 +-
 types.h                      |  57 ----
 util.c                       |   2 +-
 util.h                       | 288 ------------------
 vendor.c                     |   6 +-
 vendor.h                     |   2 +-
 75 files changed, 2121 insertions(+), 2096 deletions(-)
 delete mode 100644 attrs.h
 delete mode 100644 buffer.h
 create mode 100644 include/libisns/attrs.h
 create mode 100644 include/libisns/buffer.h
 create mode 100644 include/libisns/isns-proto.h
 create mode 100644 include/libisns/isns.h
 create mode 100644 include/libisns/message.h
 create mode 100644 include/libisns/paths.h
 create mode 100644 include/libisns/source.h
 create mode 100644 include/libisns/types.h
 create mode 100644 include/libisns/util.h
 delete mode 100644 isns-proto.h
 delete mode 100644 isns.h
 delete mode 100644 message.h
 delete mode 100644 paths.h
 delete mode 100644 source.h
 delete mode 100644 types.h
 delete mode 100644 util.h

-- 
2.1.4

--

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.


Gmane