Re: PATCH: two patches that update network state access for open-iscsi
On Sep 25, 2014, at 12:47 AM, open-iscsi@... wrote:
> Deviants will be sacrificed to ensure group solidarity.
> Mike Christie <michaelc@...>: Sep 24 11:58AM -0500
> On 09/24/2014 10:59 AM, Lee Duncan wrote:
> > 0002-Fixup-IPv6-iBFT-interface-description.patch -- This adds interface
> > prefix length to handle some kernels that have an issue with respect to
> > iBFT, as well as adding the code in open-iscsi to use this value, if present
> What is the prefix? Could you give me an example? We are reading this
> from the kernel right?
> + sysfs_get_int(id, subsys, "prefix-len", &context->prefix);
> I do not see that in the upstream kernel. Is it in one of Konrad's trees?
Hannes added this to the SUSE Kernel July of this year, and submitted it to LKML.
The issue is that IPv6 does not use a netmask, but instead exclusively uses a prefix length. I didn't realize
that this had not made it upstream yet.
> Also, it seems this second patch does several things. Could you separate
> out the coding style fixes (go ahead and include spelling changes in
> there) and coding style changes that you seem to prefer, the
> context->origin changes (what was the reason for them), and the flag
Yes, I will resubmit.
> And for the flag changes, did you test this patch with be2iscsi boot? It
> looks like it sets the flags to 2, so it will fail right?
I believe so, but I will make sure that is the case before I resubmit.
"Beer is proof that God loves us and wants us to be happy." -- Ben Franklin
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@...
To post to this group, send email to open-iscsi@...
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.