Linux-IrDA users help each other

Guennadi Liakhovetski | 4 Apr 2007 15:30

Picon

[PATCH] irda.ko debug parameter writable

Hi

How about making irda.ko debug module parameter run-time modifiable. It 
was quite useful in my debugging... Can it cause problems?

Thanks
Guennadi
---------------------------------
Guennadi Liakhovetski, Ph.D.
DSA Daten- und Systemtechnik GmbH
Pascalstr. 28
D-52076 Aachen
Germany

PATCH FOLLOWS

Make irda.ko debug module parameter read-writable. Notice, that it is only 
enabled when CONFIG_IRDA_DEBUG is set.

Signed-off-by: G. Liakhovetski <gl@...>

diff -u -r1.1.1.5 irmod.c
--- a/net/irda/irmod.c	15 Aug 2006 07:22:02 -0000	1.1.1.5
+++ b/net/irda/irmod.c	4 Apr 2007 13:13:04 -0000
 <at>  <at>  -60,7 +60,7  <at>  <at> 
  */
 #ifdef CONFIG_IRDA_DEBUG
 unsigned int irda_debug = IRDA_DEBUG_LEVEL;
-module_param_named(debug, irda_debug, uint, 0);
+module_param_named(debug, irda_debug, uint, S_IRUGO | S_IWUSR);

(Continue reading)

Samuel Ortiz | 4 Apr 2007 15:56

Re: [PATCH] irda.ko debug parameter writable


Hi Guennadi,

On 4/4/2007, "Guennadi Liakhovetski" <gl@...> wrote:

>Hi
>
>How about making irda.ko debug module parameter run-time modifiable. It
>was quite useful in my debugging... Can it cause problems?
Probably not, but how would that be different from setting
/proc/sys/net/irda/debug ?

Cheers,
Samuel.

>Thanks
>Guennadi
>---------------------------------
>Guennadi Liakhovetski, Ph.D.
>DSA Daten- und Systemtechnik GmbH
>Pascalstr. 28
>D-52076 Aachen
>Germany
>
>PATCH FOLLOWS
>
>Make irda.ko debug module parameter read-writable. Notice, that it is only
>enabled when CONFIG_IRDA_DEBUG is set.
>
>Signed-off-by: G. Liakhovetski <gl@...>

(Continue reading)

Guennadi Liakhovetski | 4 Apr 2007 16:02

Picon

Re: [PATCH] irda.ko debug parameter writable

On Wed, 4 Apr 2007, Samuel Ortiz wrote:

> >How about making irda.ko debug module parameter run-time modifiable. It
> >was quite useful in my debugging... Can it cause problems?
> Probably not, but how would that be different from setting
> /proc/sys/net/irda/debug ?

Ouch, I think, not at all, didn't notice it) Ok, forget about it

Thanks
Guennadi
---------------------------------
Guennadi Liakhovetski, Ph.D.
DSA Daten- und Systemtechnik GmbH
Pascalstr. 28
D-52076 Aachen
Germany

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Guennadi Liakhovetski | 5 Apr 2007 09:09

Picon

[BUG] 2.6.20.1-rt8 irnet + pppd recursive spinlock...

Hi all

As I came this morning to check the IrNET / PPP test, I started yesterday, 
the device was dead and OOM messages were scrolling up the terminal. I 
captured task trace, and the ftp process seems to have been the original 
culprit. Below is the backtrace. Which looks like a recursive spinlock, 
since, I assume, it is this BUG() that has triggered:

	BUG_ON(rt_mutex_owner(lock) == current);

and ppp is indeed entered recursively in the trace. I'll look if I can 
find the reason and a solution, but would also be greatful for any hints.

Thanks
Guennadi
---------------------------------
Guennadi Liakhovetski, Ph.D.
DSA Daten- und Systemtechnik GmbH
Pascalstr. 28
D-52076 Aachen
Germany

ftp           D [c3c9e460] C01E5838     0 18445      1         20756 14588 (L-TLB)
[<c01e5420>] (__schedule+0x0/0x7e8) from [<c01e5cfc>] (schedule+0x54/0x124)
[<c01e5ca8>] (schedule+0x0/0x124) from [<c017e69c>] (lock_sock_nested+0x94/0xd0)
 r5 = C329F06C  r4 = C14B9780 
[<c017e608>] (lock_sock_nested+0x0/0xd0) from [<c017b878>] (sock_fasync+0x40/0x154)
 r7 = C329F040  r6 = C2238A5C  r5 = C0AD8B60  r4 = C0AD8B60
[<c017b838>] (sock_fasync+0x0/0x154) from [<c017b9b0>] (sock_close+0x24/0x44)
[<c017b98c>] (sock_close+0x0/0x44) from [<c008dbbc>] (__fput+0x194/0x1c8)

(Continue reading)

Guennadi Liakhovetski | 5 Apr 2007 12:59

Picon

Re: [BUG] 2.6.20.1-rt8 irnet + pppd recursive spinlock...

Ok, a simple analysis reveals the recursive spinlock:

On Thu, 5 Apr 2007, Guennadi Liakhovetski wrote:

> [<bf12b220>] (ppp_channel_push+0x0/0xc8 [ppp_generic]) from [<bf12bf98>]
(ppp_output_wakeup+0x18/0x1c [ppp_generic])
===>		^^^^^^^^^^^^^^^^
>  r7 = C38F42BC  r6 = C38F4200  r5 = C38F4200  r4 = 00000000

===>	spin_lock_bh(&pch->downl);

> [<bf12bf80>] (ppp_output_wakeup+0x0/0x1c [ppp_generic]) from [<bf132c98>]
(irnet_flow_indication+0x38/0x3c [irnet])
> [<bf132c60>] (irnet_flow_indication+0x0/0x3c [irnet]) from [<bf104e4c>]
(irttp_run_tx_queue+0x1c0/0x1d4 [irda])
> [<bf104c8c>] (irttp_run_tx_queue+0x0/0x1d4 [irda]) from [<bf104f88>]
(irttp_data_request+0x128/0x4f8 [irda])
>  r8 = BF121560  r7 = 00000002  r6 = C38F4200  r5 = C21418B8
>  r4 = C21418B8 
> [<bf104e60>] (irttp_data_request+0x0/0x4f8 [irda]) from [<bf1321bc>]
(ppp_irnet_send+0x134/0x238 [irnet])
> [<bf132088>] (ppp_irnet_send+0x0/0x238 [irnet]) from [<bf12a600>] (ppp_push+0x80/0xb8 [ppp_generic])
>  r7 = C3A436E0  r6 = 00000000  r5 = C21418B8  r4 = C1489600
> [<bf12a580>] (ppp_push+0x0/0xb8 [ppp_generic]) from [<bf12a8d8>] (ppp_xmit_process+0x34/0x50c [ppp_generic])
===>		^^^^^^^^
>  r7 = 00000021  r6 = C21418B8  r5 = C1489600  r4 = 00000000

===>		spin_lock_bh(&pch->downl);

> [<bf12a8a4>] (ppp_xmit_process+0x0/0x50c [ppp_generic]) from [<bf12aed8>]

(Continue reading)

Guennadi Liakhovetski | 5 Apr 2007 17:11

Picon

Re: [BUG] 2.6.20.1-rt8 irnet + pppd recursive spinlock...

On Thu, 5 Apr 2007, Guennadi Liakhovetski wrote:

> Ok, a simple analysis reveals the recursive spinlock:
> 
> On Thu, 5 Apr 2007, Guennadi Liakhovetski wrote:
> 
> > [<bf12b220>] (ppp_channel_push+0x0/0xc8 [ppp_generic]) from [<bf12bf98>]
(ppp_output_wakeup+0x18/0x1c [ppp_generic])
> ===>		^^^^^^^^^^^^^^^^
> >  r7 = C38F42BC  r6 = C38F4200  r5 = C38F4200  r4 = 00000000
> 
> ===>	spin_lock_bh(&pch->downl);
> 
> > [<bf12bf80>] (ppp_output_wakeup+0x0/0x1c [ppp_generic]) from [<bf132c98>]
(irnet_flow_indication+0x38/0x3c [irnet])
> > [<bf132c60>] (irnet_flow_indication+0x0/0x3c [irnet]) from [<bf104e4c>]
(irttp_run_tx_queue+0x1c0/0x1d4 [irda])
> > [<bf104c8c>] (irttp_run_tx_queue+0x0/0x1d4 [irda]) from [<bf104f88>]
(irttp_data_request+0x128/0x4f8 [irda])
> >  r8 = BF121560  r7 = 00000002  r6 = C38F4200  r5 = C21418B8
> >  r4 = C21418B8 
> > [<bf104e60>] (irttp_data_request+0x0/0x4f8 [irda]) from [<bf1321bc>]
(ppp_irnet_send+0x134/0x238 [irnet])
> > [<bf132088>] (ppp_irnet_send+0x0/0x238 [irnet]) from [<bf12a600>] (ppp_push+0x80/0xb8 [ppp_generic])
> >  r7 = C3A436E0  r6 = 00000000  r5 = C21418B8  r4 = C1489600
> > [<bf12a580>] (ppp_push+0x0/0xb8 [ppp_generic]) from [<bf12a8d8>] (ppp_xmit_process+0x34/0x50c [ppp_generic])
> ===>		^^^^^^^^
> >  r7 = 00000021  r6 = C21418B8  r5 = C1489600  r4 = 00000000
> 
> ===>		spin_lock_bh(&pch->downl);

(Continue reading)

Samuel Ortiz | 7 Apr 2007 01:53

Re: [PATCH 1/4] [net-2.6.22] IrDA: IrLAP raw mode

On Fri, Mar 16, 2007 at 08:34:51PM -0700, David Miller wrote:
> From: Samuel Ortiz <samuel@...>
> Date: Sat, 17 Mar 2007 03:57:29 +0200
> 
> > This patch allows us to bypass the IrDA stack down to the IrLAP level.
> > Sending and receiving frames is done through a character device.
> > This is useful for e.g. doing real IrDA sniffing, testing external IrDA
> > stacks and for Lirc (once I will add the framing disabling switch).
> > 
> > Signed-off-by: Samuel Ortiz <samuel@...>
> 
> I understand the idea, but I fail to see any reason this should not be
> done with sockets.
> 
> Everywhere else we provide this kind of functionality it is either
> with netlink (nf_queue etc.) or raw sockets of some kind
> (AF_INET/SOCK_RAW, AF_PACKET, etc.)
> 
> Therefore IRDA should really provide this facility in some similar
> manner.
I definitely agree here. Actually, you can already sniff IrDA packets through
an AF_PACKET socket, that's what irdadump does. My patch was useless, forget
about it...

I have a question though: On top of the regular IrDA sniffing done with a
simple AF_PACKET socket, I also would like to be able to disable TX at the
IrLAP level (typically, this would allow an IrDA device to listen to all
the packets from an IrDA link without being noticed by the other devices).

I was thinking of adding a protocol private ioctl (as in SIOCPROTOPRIVATE) to

(Continue reading)

Samuel Ortiz | 7 Apr 2007 02:59

Re: [BUG] 2.6.20.1-rt8 irnet + pppd recursive spinlock...

Hi Guennadi,

On Thu, Apr 05, 2007 at 12:59:40PM +0200, Guennadi Liakhovetski wrote:
> Ok, a simple analysis reveals the recursive spinlock:
> 
> On Thu, 5 Apr 2007, Guennadi Liakhovetski wrote:
> 
> > [<bf12b220>] (ppp_channel_push+0x0/0xc8 [ppp_generic]) from [<bf12bf98>]
(ppp_output_wakeup+0x18/0x1c [ppp_generic])
> ===>		^^^^^^^^^^^^^^^^
> >  r7 = C38F42BC  r6 = C38F4200  r5 = C38F4200  r4 = 00000000
> 
> ===>	spin_lock_bh(&pch->downl);
> 
> > [<bf12bf80>] (ppp_output_wakeup+0x0/0x1c [ppp_generic]) from [<bf132c98>]
(irnet_flow_indication+0x38/0x3c [irnet])
> > [<bf132c60>] (irnet_flow_indication+0x0/0x3c [irnet]) from [<bf104e4c>]
(irttp_run_tx_queue+0x1c0/0x1d4 [irda])
> > [<bf104c8c>] (irttp_run_tx_queue+0x0/0x1d4 [irda]) from [<bf104f88>]
(irttp_data_request+0x128/0x4f8 [irda])
> >  r8 = BF121560  r7 = 00000002  r6 = C38F4200  r5 = C21418B8
> >  r4 = C21418B8 
> > [<bf104e60>] (irttp_data_request+0x0/0x4f8 [irda]) from [<bf1321bc>]
(ppp_irnet_send+0x134/0x238 [irnet])
> > [<bf132088>] (ppp_irnet_send+0x0/0x238 [irnet]) from [<bf12a600>] (ppp_push+0x80/0xb8 [ppp_generic])
> >  r7 = C3A436E0  r6 = 00000000  r5 = C21418B8  r4 = C1489600
> > [<bf12a580>] (ppp_push+0x0/0xb8 [ppp_generic]) from [<bf12a8d8>] (ppp_xmit_process+0x34/0x50c [ppp_generic])
> ===>		^^^^^^^^
> >  r7 = 00000021  r6 = C21418B8  r5 = C1489600  r4 = 00000000
>

(Continue reading)

Samuel Ortiz | 10 Apr 2007 20:10

Re: [irda-users] [BUG] 2.6.20.1-rt8 irnet + pppd recursive spinlock...

Hi Guennadi,

On Sat, Apr 07, 2007 at 03:59:26AM +0300, Samuel Ortiz wrote:
> IMHO, irnet_flow_indication() should be called asynchronously by
> irttp_run_tx_queue(), through some bottom-half mechanism. That would fix your
> locking issues, and that would reduce the time we spend in the IrDA code with
> this lock taken.
> 
> I will try to come up with some patches for you later this weekend.
The patch below schedules irnet_flow_indication() asynchronously. Could
you please give it a try (it builds, but I couldn't test it...) ? :

diff --git a/include/net/irda/irttp.h b/include/net/irda/irttp.h
index a899e58..941f0f1 100644
--- a/include/net/irda/irttp.h
+++ b/include/net/irda/irttp.h
 <at>  <at>  -128,6 +128,7  <at>  <at>  struct tsap_cb {

 	struct net_device_stats stats;
 	struct timer_list todo_timer; 
+	struct work_struct irnet_flow_work;   /* irttp asynchronous flow restart */

 	__u32 max_seg_size;     /* Max data that fit into an IrLAP frame */
 	__u8  max_header_size;
diff --git a/net/irda/irnet/irnet.h b/net/irda/irnet/irnet.h
diff --git a/net/irda/irttp.c b/net/irda/irttp.c
index 7069e4a..a0d0f26 100644
--- a/net/irda/irttp.c
+++ b/net/irda/irttp.c
 <at>  <at>  -367,6 +367,29  <at>  <at>  static int irttp_param_max_sdu_size(void *instance, irda_param_t *param,

(Continue reading)

Guennadi Liakhovetski | 11 Apr 2007 12:02

Picon

Re: [irda-users] [BUG] 2.6.20.1-rt8 irnet + pppd recursive spinlock...

On Tue, 10 Apr 2007, Samuel Ortiz wrote:

> The patch below schedules irnet_flow_indication() asynchronously. Could
> you please give it a try (it builds, but I couldn't test it...) ? :

I'm afraid, your patch makes it worse - with my patch to ppp_generic it 
worked 5 hours before Ir stopped, remaining at 4mbaud, and only discovery 
timer was expiring periodically without actually doing anything; with your 
patch the same happens in about 5 minutes.

I'll double-verify it, and then will try the same work-queue approach, but 
from ppp_generic, rather than from irttp, combining our 2 patches.

Thanks
Guennadi
---------------------------------
Guennadi Liakhovetski, Ph.D.
DSA Daten- und Systemtechnik GmbH
Pascalstr. 28
D-52076 Aachen
Germany
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Group

gmane.linux.irda.general.

Project Web Page

Linux-IrDA users help each other

Search Archive

Page

1 | 2 | 3 | 4 | 5

Articles in period: 40

April 2007

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

(no subject) (10 Apr 2013)
IrDA stack faulty on some connection delays? (15 Aug 2012)
mcs7780 + logitech harmony (5 Aug 2012)
(no subject) (14 May 2012)
(no subject) (14 May 2012)
(no subject) (14 May 2012)
(no subject) (13 May 2012)
(no subject) (13 May 2012)
(no subject) (11 May 2012)
(no subject) (9 May 2012)
(no subject) (9 May 2012)
(no subject) (28 Apr 2012)
(no subject) (27 Apr 2012)
(no subject) (27 Apr 2012)
Request for new MCS7784 infrared dongle linux driver - Technical info (14 Aug 2011)
Sending zero bytes on Linux IrDA stack returns error 107 (25 Aug 2010)
Simulating IrDa devices (12 May 2010)
Uwatec Aladin TEC2G (21 Jan 2010)
Access to IrDA PHY Level (20 Jan 2010)
irda: two branches in via_ircc_change_dongle_speed() are the same (17 Jan 2010)
[PATCH] [IRDA]: ensure that index is within bounds in stir421x_patch_d (14 Dec 2009)

Archives

1	April 2013
4	October 2012
6	August 2012
9	May 2012
3	April 2012
1	August 2011
1	June 2011
1	March 2011
1	August 2010
1	May 2010
1	March 2010
1	February 2010
5	January 2010
2	December 2009
3	October 2009
16	September 2009
2	August 2009
4	July 2009
3	June 2009
3	May 2009
2	April 2009
35	March 2009
5	January 2009
26	December 2008
13	November 2008
19	October 2008
1	September 2008
5	July 2008
7	June 2008
13	May 2008
8	April 2008
9	March 2008
18	January 2008
20	December 2007
15	November 2007
19	October 2007
5	September 2007
24	August 2007
61	July 2007
14	June 2007
31	May 2007
38	April 2007
76	March 2007
30	February 2007
21	January 2007
13	December 2006
22	November 2006
13	October 2006
117	September 2006
11	August 2006
18	July 2006
24	June 2006
56	May 2006
66	April 2006
18	March 2006
77	February 2006
22	January 2006
7	December 2005
6	November 2005
8	October 2005
36	September 2005
12	August 2005
15	July 2005
22	June 2005
36	May 2005
32	April 2005
23	March 2005
42	February 2005
71	January 2005
24	December 2004
31	November 2004
63	October 2004
75	September 2004
51	August 2004
66	July 2004

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template