Re: Ooops in irlmp_add_discovery

Hi,

On Sunday 26 November 2006 00:42, Sascha Sommer wrote:
> Hi,
>
> On Saturday 25 November 2006 16:33, Samuel Ortiz wrote:
> > Hi Sascha,
> >
> > On Tue, Nov 14, 2006 at 10:56:20PM +0100, Sascha Sommer wrote:
> > > What else do you need to fix this issue? Kernel version is 2.6.18.1
> >
> > We need the actual oops output, the stack dump.
> > Can you reproduce this bug and send this dump ?
>
> Sure, but I currently do not have a serial cable at hand.
>
> As far as I can tell it happens when the
> RECV_DISCOVERY_XID_CMD
> event is received in irlap_state_ndm
> whenever it reaches the block that contains the
>                         IRDA_DEBUG(1, "%s(), Receiving final discovery
> request, missed the discovery slots \n", __FUNCTION__);
>
> statement
>
> In irlap_recv_discovery_xid_cmd in irlap_frame.c you have got the following
> code:
>
>        /*
>          *  Check if last frame

[PATCH 1/2] [IrDA] PXA FIR code device model conversion

Hi Dave,

pxaficp_ir.c was not converted to the device model framework.

Signed-off-by: Paul Sokolovsky <pmiscml <at> gmail.com>
Cc: <stable <at> kernel.org>
Signed-off-by: Andrew Morton <akpm <at> osdl.org>
Signed-off-by: Samuel Ortiz <samuel <at> sortiz.org>
---
 drivers/net/irda/pxaficp_ir.c |   26 +++++++++++++-------------
 1 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/drivers/net/irda/pxaficp_ir.c b/drivers/net/irda/pxaficp_ir.c
index f9a1c88..9137e23 100644
--- a/drivers/net/irda/pxaficp_ir.c
+++ b/drivers/net/irda/pxaficp_ir.c
 <at>  <at>  -704,9 +704,9  <at>  <at>  static int pxa_irda_stop(struct net_devi
 	return 0;
 }

-static int pxa_irda_suspend(struct device *_dev, pm_message_t state)
+static int pxa_irda_suspend(struct platform_device *_dev, pm_message_t state)
 {
-	struct net_device *dev = dev_get_drvdata(_dev);
+	struct net_device *dev = platform_get_drvdata(_dev);
 	struct pxa_irda *si;

 	if (dev && netif_running(dev)) {
 <at>  <at>  -718,9 +718,9  <at>  <at>  static int pxa_irda_suspend(struct devic
 	return 0;

[PATCH 2/2] [IrDA] Incorrect TTP header reservation

We must reserve SAR + MAX_HEADER bytes for IrLMP to fit in.

Patch from Jeet Chaudhuri <jeetlinux <at> yahoo.co.in>
Signed-off-by: Samuel Ortiz <samuel <at> sortiz.org>
---
 net/irda/irttp.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/irda/irttp.c b/net/irda/irttp.c
index 252f110..03504f3 100644
--- a/net/irda/irttp.c
+++ b/net/irda/irttp.c
 <at>  <at>  -1100,7 +1100,7  <at>  <at>  int irttp_connect_request(struct tsap_cb
 			return -ENOMEM;

 		/* Reserve space for MUX_CONTROL and LAP header */
-		skb_reserve(tx_skb, TTP_MAX_HEADER);
+		skb_reserve(tx_skb, TTP_MAX_HEADER + TTP_SAR_HEADER);
 	} else {
 		tx_skb = userdata;
 		/*
 <at>  <at>  -1349,7 +1349,7  <at>  <at>  int irttp_connect_response(struct tsap_c
 			return -ENOMEM;

 		/* Reserve space for MUX_CONTROL and LAP header */
-		skb_reserve(tx_skb, TTP_MAX_HEADER);
+		skb_reserve(tx_skb, TTP_MAX_HEADER + TTP_SAR_HEADER);
 	} else {
 		tx_skb = userdata;
 		/*

Re: [PATCH 1/2] [IrDA] PXA FIR code device model conversion

From: Samuel Ortiz <samuel@...>
Date: Thu, 7 Dec 2006 02:50:53 +0200

> pxaficp_ir.c was not converted to the device model framework.
> 
> Signed-off-by: Paul Sokolovsky <pmiscml@...>
> Signed-off-by: Andrew Morton <akpm@...>
> Signed-off-by: Samuel Ortiz <samuel@...>

Applied.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: [PATCH 2/2] [IrDA] Incorrect TTP header reservation

From: Samuel Ortiz <samuel <at> sortiz.org>
Date: Thu, 7 Dec 2006 02:51:17 +0200

> We must reserve SAR + MAX_HEADER bytes for IrLMP to fit in.
> 
> Patch from Jeet Chaudhuri <jeetlinux <at> yahoo.co.in>
> Signed-off-by: Samuel Ortiz <samuel <at> sortiz.org>

Also applied.

Are you sending this patch to -stable?  Please do.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Can't receive file from phone

Hello,

   I try to transfer files from my phone (Mitsubishi m342i) to my
laptop without success. The laptop chipset is the smsc one, I use
a 2.6.18 kernel and can transfer files from/to my palm without
problem, so the link works and the driver part is correct.

Trying to get files from the phone, I start 'irxfer' on the
laptop and send the file from the phone. On the phone I get
an error (kind of 'host not found') and don't receive anything.
Running irdadump I get the following trace:

--------------------------------------------------------------------------------

16:20:13.966255 xid:rsp ec5f851e > 5165f21c S=6 s=1 babylon hint=0400 [ Computer ] (23)
16:20:14.123187 xid:cmd ffffffff < 5165f21c S=6 s=2 (14)
16:20:14.220123 xid:cmd ffffffff < 5165f21c S=6 s=3 (14)
16:20:14.317064 xid:cmd ffffffff < 5165f21c S=6 s=4 (14)
16:20:14.413998 xid:cmd ffffffff < 5165f21c S=6 s=5 (14)
16:20:14.519260 xid:cmd ffffffff < 5165f21c S=6 s=* M342i hint=9024 [ Modem IrCOMM IrOBEX ] (22)
16:20:14.571155 snrm:cmd ca=fe pf=1 ec5f851e < 5165f21c new-ca=88
        LAP QoS: Baud Rate=115200bps Max Turn Time=500ms Data Size=256B Window Size=1 Add BOFS=0 Min Turn
Time=10000us Link Disc=12s (32)
16:20:14.571184 ua:rsp ca=88 pf=1 ec5f851e > 5165f21c
        LAP QoS: Baud Rate=115200bps Max Turn Time=500ms Data Size=2048B Window Size=3 Add BOFS=0 Min Turn
Time=1000us Link Disc=12s (31)
16:20:14.634968 rr:cmd < ca=88 pf=1 nr=0 (2)
16:20:14.634987 rr:rsp > ca=88 pf=1 nr=0 (2)
16:20:14.649161 i:cmd  < ca=88 pf=1 nr=0 ns=0 LM slsap=01 dlsap=00 CONN_CMD (6)
16:20:14.649194 i:rsp  > ca=88 pf=1 nr=1 ns=0 LM slsap=00 dlsap=01 CONN_RSP (6)

Re: Can't receive file from phone

Francois BARRIERE wrote:
> Hello,
> 
>    I try to transfer files from my phone (Mitsubishi m342i) to my
> laptop without success. The laptop chipset is the smsc one, I use
> a 2.6.18 kernel and can transfer files from/to my palm without
> problem, so the link works and the driver part is correct.
> 
> Trying to get files from the phone, I start 'irxfer' on the
> laptop and send the file from the phone. On the phone I get
> an error (kind of 'host not found') and don't receive anything.
> Running irdadump I get the following trace:
> 
> --------------------------------------------------------------------------------
> 
> 16:20:13.966255 xid:rsp ec5f851e > 5165f21c S=6 s=1 babylon hint=0400 [ Computer ] (23)
> 16:20:14.123187 xid:cmd ffffffff < 5165f21c S=6 s=2 (14)
> 16:20:14.220123 xid:cmd ffffffff < 5165f21c S=6 s=3 (14)
> 16:20:14.317064 xid:cmd ffffffff < 5165f21c S=6 s=4 (14)
> 16:20:14.413998 xid:cmd ffffffff < 5165f21c S=6 s=5 (14)
> 16:20:14.519260 xid:cmd ffffffff < 5165f21c S=6 s=* M342i hint=9024 [ Modem IrCOMM IrOBEX ] (22)

IMHO, at this point both devices need to have hints identical - at least 
the ones desired in upcomming communication. I can see that you babylon 
computer host doesn't support IrOBEX which is why the phone can't 
establish the link and fails below...

> 16:20:14.571155 snrm:cmd ca=fe pf=1 ec5f851e < 5165f21c new-ca=88
>         LAP QoS: Baud Rate=115200bps Max Turn Time=500ms Data Size=256B Window Size=1 Add BOFS=0 Min Turn
Time=10000us Link Disc=12s (32)

Re: Can't receive file from phone

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
irda-users mailing list
irda-users@...
http://lists.sourceforge.net/lists/listinfo/irda-users

Re: Can't receive file from phone

On Mon, 18 Dec 2006 10:00:41 +0100
"hinko.kocevar@..."
<hinko.kocevar@...> wrote:

> > 16:20:14.519260 xid:cmd ffffffff < 5165f21c S=6 s=* M342i hint=9024 [ Modem IrCOMM IrOBEX ] (22)
> 
> IMHO, at this point both devices need to have hints identical - at least 
> the ones desired in upcomming communication. I can see that you babylon 
> computer host doesn't support IrOBEX which is why the phone can't 
> establish the link and fails below...

   now the stupid question: how do I change this (the hint)? How do I enable
IrCOMM on the computer side?
I have the ircomm module loaded, I tried with and without the ircomm_tty module
but still can get anything...

Another question: is there any command line tool to get/put files using
the irda link? I tried with the irxfer and ircp tools from an older irdautils
package but these tools are not in the latest version...

Francois.

--

-- 
Francois Barriere               (In the country of the mistral)
chili.palmer@...

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: Can't receive file from phone

On Mon, 18 Dec 2006 22:16:00 +0100
Francois BARRIERE <chili.palmer@...> wrote:

>    now the stupid question: how do I change this (the hint)? How do I enable
> IrCOMM on the computer side?
> I have the ircomm module loaded, I tried with and without the ircomm_tty module
> but still can get anything...
> 
> Another question: is there any command line tool to get/put files using
> the irda link? I tried with the irxfer and ircp tools from an older irdautils
> package but these tools are not in the latest version...

   OK, it was a stupid question... Forget it! I finally manage to get files
transfered from the phone... The ircp and irxfer tools are from the openobex
package and I seem to have an outdated version...

I compiled the latest openobex tools and the miracle occured!
Sorry for the noise and thank you for your help...

Francois.

--

-- 
Francois Barriere               (In the country of the mistral)
chili.palmer@...

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV