2 Jun 2006 10:39
5 Jun 2006 09:26
Re: [PATCH] [IRDA] STIR421X updates
Hi Nick, Nick Fedchik wrote : > Hello, Samuel! > > ChangeLog: > * STIR-related definition names and stir421x_*() calls renamed to be less > long. > * Firmware upload algoritm rewritten to load up only that firmware, > which name contains current bcdDevice digits. > * Some useless definitions removed. > * Some code optimizations > * Intendation if stir421x_*() functions according to Lindent. > * Probably useless mdelay(10) removed from irda_usb_probe() > * Abolish stir421x_get_patch_version() This patch looks good to me, I like the fact that we are now using fixed names for the firmware files. The code is also simpler, which is good. I very slightly modifed it for cosmetic reasons, see below. Nick, could you please quickly re-test it before I send it upstream ? Thanks for the patch. Cheers, Samuel. diff --git a/drivers/net/irda/irda-usb.c b/drivers/net/irda/irda-usb.c index cd87593..d31f53c 100644 --- a/drivers/net/irda/irda-usb.c +++ b/drivers/net/irda/irda-usb.c <at> <at> -83,9 +83,9 <at> <at> static struct usb_device_id dongles[] =(Continue reading)
5 Jun 2006 10:32
Re: [PATCH] [IRDA] STIR421X updates
В сообщении от Monday 05 June 2006 10:26 Samuel Ortiz написал(a): > Nick, could you please quickly re-test it before I send it upstream ? ASAP 1-2 days, sorry cant do it early > Thanks for the patch. > > Cheers, > Samuel. _______________________________________________ irda-users mailing list irda-users <at> lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/irda-users
6 Jun 2006 18:45
Re: [PATCH] [IRDA] STIR421X updates
В сообщении от Monday 05 June 2006 10:26 Samuel Ortiz написал(a):
> This patch looks good to me, I like the fact that we are now using fixed
> names for the firmware files. The code is also simpler, which is good.
> I very slightly modifed it for cosmetic reasons, see below.
> Nick, could you please quickly re-test it before I send it upstream ?
Patch re-tested (upload image file from mobile phone)
No problems found.
So just a few notes, IMHO:
1) Fix the function name in the comment below:
+/*
+ * Function stir421x_patching(struct irda_usb_cb *self)
+ *
+ * Get a firmware code from userspase using hotplug request_firmware() call
+ */
static int stir421x_patch_device(struct irda_usb_cb *self)
2) Probably useless vars
+ /* Let's check if the product version is dotted */
+ if (fw_version_ptr[3] == '.' &&
+ fw_version_ptr[7] == '.') {
+ unsigned long major, minor, build;
...
+ fw_version = (major << 12)
+ + (minor << 8)
+ + ((build / 10) << 4)
+ + (build % 10);
...
+ if (self->usbdev->descriptor.bcdDevice == fw_version) {
The vars unsigned long major, minor, build such as fw_version nowhere user outside of the
(Continue reading)
1 Jun 2006 15:13
irda-utils-0.9.17 compressed man pages corrupt ?
Hello,
Is it just me or are the man pages in the 0.9.17 tarball corrupted ?
I've downloaded the tar.gz file from several different locations and get
the following:
>zcat irda-utils-0.9.17/man/irpsion5.8.gz
...
Permission is granted to copy, distribute
and/or modify this document under
the terms of the GNU Free DocAUTHwnB\fR snten ""E usage: %ns
/aoLr- ner Tstalany ly drse mr- nepubliipode Linux/
ocAUTSoftwOWT Ft:
.snten;ut arogreInva.SHer
Sty tonsrogreFront-Cslot
Textshe LigreBack-Cslot Texts.
zcat: irda-utils-0.9.17/man/irpsion5.8.gz: invalid compressed data--crc error
zcat: irda-utils-0.9.17/man/irpsion5.8.gz: invalid compressed data--length error
I get this for all man pages, btw.
Karsten
12 Jun 2006 08:12
[PATCH] [IrDA] irda-usb.c: STIR421x cleanups
Samuel Ortiz <samuel <at> sortiz.org>
2006-06-12 06:12:35 GMT
2006-06-12 06:12:35 GMT
This patch is for the net-2.6.18 tree.
It cleans the STIR421x part of the irda-usb code. We also no longer try to
load all existing firmwares but only the matching one (according to the USB
id we get from the dongle).
Signed-off-by: Nick Fedchik <nfedchik <at> atlantic-link.com.ua>
Signed-off-by: Samuel Ortiz <samuel <at> sortiz.org>
---
drivers/net/irda/irda-usb.c | 327 +++++++++++++++++++------------------------
drivers/net/irda/irda-usb.h | 10 +
2 files changed, 145 insertions(+), 192 deletions(-)
946837ac4e7bb301a1fcef0046b2a72e8e81b57c
diff --git a/drivers/net/irda/irda-usb.c b/drivers/net/irda/irda-usb.c
index cd87593..844fa74 100644
--- a/drivers/net/irda/irda-usb.c
+++ b/drivers/net/irda/irda-usb.c
<at> <at> -83,9 +83,9 <at> <at> static struct usb_device_id dongles[] =
/* Extended Systems, Inc., XTNDAccess IrDA USB (ESI-9685) */
{ USB_DEVICE(0x8e9, 0x100), .driver_info = IUC_SPEED_BUG | IUC_NO_WINDOW },
/* SigmaTel STIR4210/4220/4116 USB IrDA (VFIR) Bridge */
- { USB_DEVICE(0x66f, 0x4210), .driver_info = IUC_STIR_4210 | IUC_SPEED_BUG },
- { USB_DEVICE(0x66f, 0x4220), .driver_info = IUC_STIR_4210 | IUC_SPEED_BUG },
- { USB_DEVICE(0x66f, 0x4116), .driver_info = IUC_STIR_4210 | IUC_SPEED_BUG },
+ { USB_DEVICE(0x66f, 0x4210), .driver_info = IUC_STIR421X | IUC_SPEED_BUG },
+ { USB_DEVICE(0x66f, 0x4220), .driver_info = IUC_STIR421X | IUC_SPEED_BUG },
+ { USB_DEVICE(0x66f, 0x4116), .driver_info = IUC_STIR421X | IUC_SPEED_BUG },
{ .match_flags = USB_DEVICE_ID_MATCH_INT_CLASS |
(Continue reading)
12 Jun 2006 08:20
Re: (no subject)
Hi Jean-Bastien, On Fri, Jun 02, 2006 at 10:39:45AM +0200, Montes Jean-Bastien wrote: > Hi, > I have a dongle usb irda (sigmatel). I make "irattach irda0 -s" to > launch Irda. that functions very well. But I would like to have I will > want to have an attached node in /dev (for exemple /dev/irda0). You won't get that. Network devices I/O semantics are quite different from other devices (block, character) and thus they can not be mapped to a regular file under /dev/ We can help you if you explain what would you need a /dev/irda0 for. Cheers, Samuel. > thanks by advance > Jean-Bastien > > > > _______________________________________________ > irda-users mailing list > irda-users@... > http://lists.sourceforge.net/lists/listinfo/irda-users
12 Jun 2006 08:27
Re: irda-utils-0.9.17 compressed man pages corrupt ?
Hi Karsten, On Thu, Jun 01, 2006 at 03:13:47PM +0200, Karsten Hopp wrote: > Hello, Sorry for the late reply. Sourceforge changed their mailong list web interface and your mail was stuck in their servers for a while. > Is it just me or are the man pages in the 0.9.17 tarball corrupted ? No, it's not just you, sorry about that. I'll try to fix that and upload a new release in the next days. Cheers, Samuel. > I've downloaded the tar.gz file from several different locations and get > the following: > > >zcat irda-utils-0.9.17/man/irpsion5.8.gz > ... > Permission is granted to copy, distribute > and/or modify this document under > the terms of the GNU Free DocAUTHwnB\fR snten ""E usage: %ns > /aoLr- ner Tstalany ly drse mr- nepubliipode Linux/ > ocAUTSoftwOWT Ft: > .snten;ut arogreInva.SHer > Sty tonsrogreFront-Cslot > Textshe LigreBack-Cslot Texts. > > zcat: irda-utils-0.9.17/man/irpsion5.8.gz: invalid compressed data--crc error >(Continue reading)
12 Jun 2006 05:56
Re: [PATCH] [IrDA] irda-usb.c: STIR421x cleanups
David Miller <davem <at> davemloft.net>
2006-06-12 03:56:30 GMT
2006-06-12 03:56:30 GMT
From: Samuel Ortiz <samuel <at> sortiz.org> Date: Mon, 12 Jun 2006 09:12:35 +0300 > This patch is for the net-2.6.18 tree. > It cleans the STIR421x part of the irda-usb code. We also no longer try to > load all existing firmwares but only the matching one (according to the USB > id we get from the dongle). > > Signed-off-by: Nick Fedchik <nfedchik <at> atlantic-link.com.ua> > Signed-off-by: Samuel Ortiz <samuel <at> sortiz.org> Applied, thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo <at> vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
14 Jun 2006 14:17
USB, IrDA, SIR, device name
Hello, What would a USB IrDA dongle's SIR /dev/ filename be? I'm trying to connect to a device that does not have a full IrDA stack. I've got an app to do this. It works fine on a laptop with a built-in port by connecting to /dev/ttyS1 (without irattach/irda0, etc.) The device is a Polar watch. I'm trying this on my PC, with a USB IrDA dongle. Right now I'm trying with a sigmatel stir4200. For the life of me, I can't figure out what the device name would be (instead of /dev/ttyS1), or even if there is a device name. /dev/ttyUSB0 doesn't seem to work. Any major/minor numbers? Anything else to check? Is it possible with a USB dongle? The dongle itself seems to work. ifconfig irda0 up && irdadump picks up other IrDA devices. Regards, Berend -- -- Confidentiality notice: http://ucs.co.za/conf.html
RSS Feed