headers
Tomas Lund | 1 Aug 2010 16:27
Picon

Re: sata_sil24 failed command: READ FPDMA QUEUED

On Fri, 30 Jul 2010, Robert Hancock wrote:

> On 07/21/2010 06:38 AM, Tomas Lund wrote:
>> On Wed, 21 Jul 2010, Tomas Lund wrote:
>> 
>>> Put the "LYCOM SATA PE-103 2-CH" back in the server with the Gigabyte 
>>> 965P-DS4 motherboard and installed the debian backports kernel 
>>> 2.6.32-bpo.5-amd64.
>>> 
>>> Problem persists and a dmesg and console output (since dmesg buffer is 
>>> too small to fit everything) is available at:
>>> 
>>> http://tlund.pp.se/sil24/console_2.6.32-bpo.5-amd64.txt
>>> http://tlund.pp.se/sil24/dmesg_2.6.32-bpo.5-amd64.txt
>> 
>> Tested Debian 2.6.26-2-amd64, files at the same place.
>
> What does "hdparm -I" show when run on the drive attached to that controller?

# hdparm -I /dev/sdb

/dev/sdb:

ATA device, with non-removable media
         Model Number:       SAMSUNG HD103SJ
         Serial Number:      S246J90Z321275
         Firmware Revision:  1AJ10001
         Transport:          Serial, ATA8-AST, SATA 1.0a, SATA II Extensions, SATA Rev 2.5
Standards:
         Used: unknown (minor revision code 0x0028)
(Continue reading)

Permalink | Reply | 7 comments |
headers
Tomas Lund | 1 Aug 2010 18:55
Picon

Re: sata_sil24 failed command: READ FPDMA QUEUED

Upgraded motherboard (965P-DS4) BIOS to latest version. Booted 2.6.27.48 
with one disk attached to motherboard sata controller (with root 
filesystem) and two disks (different vendors Samsung/WDC) on the 
SIL-controler:

<..>

sata_sil24 0000:03:00.0: version 1.1
sata_sil24 0000:03:00.0: PCI INT A -> GSI 17 (level, low) -> IRQ 17
sata_sil24 0000:03:00.0: setting latency timer to 64
scsi8 : sata_sil24
scsi9 : sata_sil24
ata9: SATA max UDMA/100 host m128 <at> 0xf8004000 port 0xf8000000 irq 17
ata10: SATA max UDMA/100 host m128 <at> 0xf8004000 port 0xf8002000 irq 17
ata9: SATA link up 3.0 Gbps (SStatus 123 SControl 0)
ata9.00: ATA-8: SAMSUNG HD103SJ, 1AJ10001, max UDMA/133
ata9.00: 1953525168 sectors, multi 16: LBA48 NCQ (depth 31/32)
ata9.00: configured for UDMA/100
ata10: SATA link up 3.0 Gbps (SStatus 123 SControl 0)
ata10.00: ATA-8: WDC WD20EARS-00S8B1, 80.00A80, max UDMA/133
ata10.00: 3907029168 sectors, multi 16: LBA48 NCQ (depth 31/32)
ata10.00: configured for UDMA/100
scsi 8:0:0:0: Direct-Access     ATA      SAMSUNG HD103SJ  1AJ1 PQ: 0 ANSI: 5
sd 8:0:0:0: [sdb] 1953525168 512-byte hardware sectors (1000205 MB)
sd 8:0:0:0: [sdb] Write Protect is off
sd 8:0:0:0: [sdb] Mode Sense: 00 3a 00 00
sd 8:0:0:0: [sdb] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
sd 8:0:0:0: [sdb] 1953525168 512-byte hardware sectors (1000205 MB)
sd 8:0:0:0: [sdb] Write Protect is off
sd 8:0:0:0: [sdb] Mode Sense: 00 3a 00 00
(Continue reading)

Permalink | Reply | 0 comments |
headers
Robert Hancock | 1 Aug 2010 23:15
Picon

Re: sata_sil24 failed command: READ FPDMA QUEUED

On Sun, Aug 1, 2010 at 8:27 AM, Tomas Lund <tlund <at> nxs.se> wrote:
> On Fri, 30 Jul 2010, Robert Hancock wrote:
>
>> On 07/21/2010 06:38 AM, Tomas Lund wrote:
>>>
>>> On Wed, 21 Jul 2010, Tomas Lund wrote:
>>>
>>>> Put the "LYCOM SATA PE-103 2-CH" back in the server with the Gigabyte
>>>> 965P-DS4 motherboard and installed the debian backports kernel
>>>> 2.6.32-bpo.5-amd64.
>>>>
>>>> Problem persists and a dmesg and console output (since dmesg buffer is
>>>> too small to fit everything) is available at:
>>>>
>>>> http://tlund.pp.se/sil24/console_2.6.32-bpo.5-amd64.txt
>>>> http://tlund.pp.se/sil24/dmesg_2.6.32-bpo.5-amd64.txt
>>>
>>> Tested Debian 2.6.26-2-amd64, files at the same place.
>>
>> What does "hdparm -I" show when run on the drive attached to that
>> controller?
>
> # hdparm -I /dev/sdb
>
> /dev/sdb:
>
> ATA device, with non-removable media
>        Model Number:       SAMSUNG HD103SJ
>        Serial Number:      S246J90Z321275
>        Firmware Revision:  1AJ10001
(Continue reading)

Permalink | Reply | 5 comments |
headers
Jeff Garzik | 2 Aug 2010 01:47
Favicon

Re: [PATCH 1/2 #upstream] sata_fsl,mv,nv: prepare for NCQ command completion update

On 06/25/2010 09:02 AM, Tejun Heo wrote:
> Make the following changes to prepare for NCQ command completion
> update.  Changes made by this patch don't cause any functional
> difference.
>
> * sata_fsl_host_intr(): rename the local variable qc_active to
>    done_mask as that's what it is.
>
> * mv_process_crpb_response(): restructure if clause for easier update.
>
> * nv_adma_interrupt(): drop unnecessary error variable.
>
> * nv_swncq_sdbfis(): drop unnecessary nr_done and return 0 on success.
>    Typo fix.
>
> * nv_swncq_dmafis(): drop unused return value and return void.
>
> * nv_swncq_host_interrupt(): drop unnecessary return value handling.
>
> Signed-off-by: Tejun Heo<tj <at> kernel.org>
> Cc: Ashish Kalra<ashish.kalra <at> freescale.com>
> Cc: Saeed Bishara<saeed <at> marvell.com>
> Cc: Mark Lord<liml <at> rtr.ca>
> Cc: Robert Hancock<hancockr <at> shaw.ca>
> ---
> So, something like this.  I tested both flavors of sata_nv but don't
> have access to sata_mv or sata_fsl, but the conversion is pretty
> straight forward and failures should be pretty easy to catch.

applied
(Continue reading)

Permalink | Reply | 2 comments |
headers
Jeff Garzik | 2 Aug 2010 01:48
Picon
Favicon

Re: [PATCH 04/25] ata: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)

On 07/15/2010 02:39 PM, Peter Huewe wrote:
> From: Peter Huewe<peterhuewe <at> gmx.de>
>
> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
> PCI_VDEVICE macro, and thus improves readability.
>
> Signed-off-by: Peter Huewe<peterhuewe <at> gmx.de>
> ---
>   drivers/ata/pata_scc.c |    3 +--
>   1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/pata_scc.c b/drivers/ata/pata_scc.c
> index d9db3f8..fe36966 100644
> --- a/drivers/ata/pata_scc.c
> +++ b/drivers/ata/pata_scc.c
>  <at>  <at>  -168,8 +168,7  <at>  <at>  static const unsigned long JCACTSELtbl[2][7] = {
>   };
>
>   static const struct pci_device_id scc_pci_tbl[] = {
> -	{PCI_VENDOR_ID_TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_SCC_ATA,
> -	 PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> +	{ PCI_VDEVICE(TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_SCC_ATA), 0},
>   	{ }	/* terminate list */

applied

I would prefer to leave ata_piix as it is, though.  It's nice and 
manageable :)
(Continue reading)

Permalink | Reply | 0 comments |
headers
Jeff Garzik | 2 Aug 2010 01:48
Favicon

Re: [PATCH #upstream-fixes] libata: more PCI IDs for jmicron controllers

On 07/30/2010 05:42 AM, Tejun Heo wrote:
> Add support for JMB364 and 369.
>
> Patch-originally-from: Aries Lee<arieslee <at> jmicron.com>
> Signed-off-by: Tejun Heo<tj <at> kernel.org>
> ---
>   drivers/pci/quirks.c    |    6 ++++++
>   include/linux/pci_ids.h |    2 ++
>   2 files changed, 8 insertions(+)

applied

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Jeff Garzik | 2 Aug 2010 01:48
Favicon

Re: [PATCH #upstream-fixes] ata_piix: fix locking around SIDPR access

On 07/20/2010 10:20 AM, Tejun Heo wrote:
> SIDPR window registers are shared across ports and as each access is
> done in two steps, accesses to different ports under EH may race.
> This primarily is caused by incorrect host locking in EH context and
> should be fixed by defining locking requirements for each EH operation
> which can be used during EH and enforcing them but for now work around
> the problem by adding a dedicated SIDPR lock and grabbing it for each
> SIDPR access.
>
> Signed-off-by: Tejun Heo<tj <at> kernel.org>
> Reported-by: Mark Knecht<markknecht <at> gmail.com>
> Reported-by: Paul Check<paul <at> thechecks.ca>
> Cc: stable <at> kernel.org
> ---
>   drivers/ata/ata_piix.c |    8 ++++++++
>   1 file changed, 8 insertions(+)

applied

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Tejun Heo | 2 Aug 2010 09:18

Re: [PATCH 1/2 #upstream] sata_fsl,mv,nv: prepare for NCQ command completion update

Hello, Jeff.

On 08/02/2010 01:47 AM, Jeff Garzik wrote:
>> So, something like this.  I tested both flavors of sata_nv but don't
>> have access to sata_mv or sata_fsl, but the conversion is pretty
>> straight forward and failures should be pretty easy to catch.
> 
> applied

Are you planning on applying the second patch too?

Thanks.

--

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 1 comment |
headers
Tomas Lund | 2 Aug 2010 09:21
Picon

Re: sata_sil24 failed command: READ FPDMA QUEUED (resolved)

On Sun, 1 Aug 2010, Robert Hancock wrote:

> The output above shows that the drive has security enabled and locked, 
> so it seems that must be the case, and it won't be accessible unless 
> it's unlocked. hdparm should be able to disable it, though it seems you 
> may need a valid password to do it..

There is something I did not mention in any of my earlier posts, and that 
is the fact that the server also has had a 3ware controller installed 
(removed as part of fault isolation) and some of the disks has been 
attached to that controller. In the case of the samsung 1tb disk, it was 
attached to the 3ware conroller after it was successfully tested on the 
motherboard sata-controller.

Some googling and testing found that yes, the 3ware controller does indeed 
lock the drives, even if they are just automatically exported as "JBOD".

The following command successfully unlocked my devices:

hdparm --user-master u --security-disable "3wareUserPassword               " /dev/sdb

I have unlocked and tested a total of 4 disks now, both the samsung 1TB 
and 3 of the WDC 2TB disks. Thank you very much! Left to do: test that 
everything is working with the PMP aswell.

Question: Would it be unreasonable to request that the kernel would issue 
the apropriate ATA-commands to a disk as soon as it is detected, and not 
try to read from it if it is locked? It would have been really, really 
nice to just get the error message "drive is locked".
(Continue reading)

Permalink | Reply | 4 comments |
headers
Tao Ma | 2 Aug 2010 11:22
Picon
Favicon

[PATCH] ide: Use kzalloc in idedisk_prepare_flush.

Signed-off-by: Tao Ma <tao.ma <at> oracle.com>
---
 drivers/ide/ide-disk.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c
index 33d6503..127a5a2 100644
--- a/drivers/ide/ide-disk.c
+++ b/drivers/ide/ide-disk.c
 <at>  <at>  -430,12 +430,11  <at>  <at>  static void ide_disk_unlock_native_capacity(ide_drive_t *drive)
 static void idedisk_prepare_flush(struct request_queue *q, struct request *rq)
 {
 	ide_drive_t *drive = q->queuedata;
-	struct ide_cmd *cmd = kmalloc(sizeof(*cmd), GFP_ATOMIC);
+	struct ide_cmd *cmd = kzalloc(sizeof(*cmd), GFP_ATOMIC);

 	/* FIXME: map struct ide_taskfile on rq->cmd[] */
 	BUG_ON(cmd == NULL);

-	memset(cmd, 0, sizeof(*cmd));
 	if (ata_id_flush_ext_enabled(drive->id) &&
 	    (drive->capacity64 >= (1UL << 28)))
 		cmd->tf.command = ATA_CMD_FLUSH_EXT;
--

-- 
1.7.1.571.gba4d01

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Permalink | Reply | 2 comments |

Gmane