David Miller | 1 Aug 07:46 2009
Picon

Re: cmd64x: irq 14: nobody cared - system is dreadfully slow

From: Frans Pop <elendil <at> planet.nl>
Date: Fri, 31 Jul 2009 16:08:59 +0200

> On Tuesday 23 June 2009, David Miller wrote:
>> From: Frans Pop <elendil <at> planet.nl> Date: Mon, 22 Jun 2009:
>> > On Monday 22 June 2009, you wrote:
>> >> From: Bartlomiej Zolnierkiewicz <bzolnier <at> gmail.com>
>> >> Subject: [PATCH] ide: fix handling of unexpected IRQs vs
>> >> request_irq()
>> >>
>> > Thanks Bart. This does solve the "nobody cared" problem.
>> > Tested-by: Frans Pop <elendil <at> planet.nl>
>>
>> I've applied this patch to my tree, thanks everyone!
> 
> Please consider the following two patches for the next stable update:
> 
> commit ffc36c7610731115c77700dcc53901920361c235
> Author: Bartlomiej Zolnierkiewicz <bzolnier <at> gmail.com>
> ide: fix handling of unexpected IRQs vs request_irq()
> 
> commit 346c17a6cf60375323adfaa4b8a9d841049f890e
> Author: Bartlomiej Zolnierkiewicz <bzolnier <at> gmail.com>
> ide: relax DMA info validity checking
> 
> The current 2.6.30 Debian kernel (based on .30.3) is still failing on my
> Sparc Ultra 10 because those patches are missing.

Agreed, these should be applied.
--
(Continue reading)

Julia Lawall | 1 Aug 10:55 2009
Picon

[PATCH 9/10] drivers/ata: introduce missing kfree

From: Julia Lawall <julia <at> diku.dk>

Error handling code following a kzalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
 <at> r exists <at> 
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
 <at>  <at> 

x <at> p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(Continue reading)

bugzilla-daemon | 1 Aug 12:12 2009

[Bug 13886] New: Suspend to disk no longer works in 2.6.30.2 with an EIDE drive

http://bugzilla.kernel.org/show_bug.cgi?id=13886

           Summary: Suspend to disk no longer works in 2.6.30.2 with an
                    EIDE drive
           Product: IO/Storage
           Version: 2.5
    Kernel Version: 2.6.30.2
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: high
          Priority: P1
         Component: IDE
        AssignedTo: io_ide <at> kernel-bugs.osdl.org
        ReportedBy: akwatts <at> ymail.com
        Regression: No

s2disk worked in 2.6.28 and no longer works in 2.6.30.2

(s2disk here means: echo disk > /sys/power/state).

Screen blanks and system hangs with no writes to disk. Hard restart
required afterwards.

Bisection identifies problem commit has hash 
295f00042aaf6b553b5f37348f89bab463d4a469.

--

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
(Continue reading)

bugzilla-daemon | 1 Aug 12:22 2009

[Bug 13886] Suspend to disk no longer works in 2.6.30.2 with an EIDE drive

http://bugzilla.kernel.org/show_bug.cgi?id=13886

Andrew Morton <akpm <at> linux-foundation.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |akpm <at> linux-foundation.org,
                   |                            |pavel <at> suse.cz, rjw <at> sisk.pl
         Regression|No                          |Yes

--- Comment #1 from Andrew Morton <akpm <at> linux-foundation.org>  2009-08-01 10:22:03 ---
marked as regression, cc'ed s2d developers.

--

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

bugzilla-daemon | 1 Aug 12:50 2009

[Bug 13886] Suspend to disk no longer works in 2.6.30.2 with an EIDE drive

http://bugzilla.kernel.org/show_bug.cgi?id=13886

Rafael J. Wysocki <rjw <at> sisk.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bzolnier <at> gmail.com
             Blocks|                            |13070, 7216

--

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

bugzilla-daemon | 1 Aug 12:52 2009

[Bug 13886] Suspend to disk no longer works in 2.6.30.2 with an EIDE drive

http://bugzilla.kernel.org/show_bug.cgi?id=13886

--- Comment #2 from Rafael J. Wysocki <rjw <at> sisk.pl>  2009-08-01 10:52:07 ---
Caused by:

commit 295f00042aaf6b553b5f37348f89bab463d4a469
Author: Bartlomiej Zolnierkiewicz <bzolnier <at> gmail.com>
Date:   Fri Jan 2 16:12:48 2009 +0100

    ide: don't execute the next queued command from the hard-IRQ context (v2)

First-Bad-Commit : 295f00042aaf6b553b5f37348f89bab463d4a469

--

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

bugzilla-daemon | 1 Aug 14:50 2009

[Bug 13886] Suspend to disk no longer works in 2.6.30.2 with an EIDE drive

http://bugzilla.kernel.org/show_bug.cgi?id=13886

--- Comment #3 from Bartlomiej Zolnierkiewicz <bzolnier <at> gmail.com>  2009-08-01 12:50:21 ---
On Saturday 01 August 2009 12:52:08 bugzilla-daemon <at> bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=13886
> 
> 
> 
> 
> 
> --- Comment #2 from Rafael J. Wysocki <rjw <at> sisk.pl>  2009-08-01 10:52:07 ---
> Caused by:
> 
> commit 295f00042aaf6b553b5f37348f89bab463d4a469
> Author: Bartlomiej Zolnierkiewicz <bzolnier <at> gmail.com>
> Date:   Fri Jan 2 16:12:48 2009 +0100
> 
>     ide: don't execute the next queued command from the hard-IRQ context (v2)
> 
> First-Bad-Commit : 295f00042aaf6b553b5f37348f89bab463d4a469

Hi Rafal,

We have been through one similar case already, please see:

    http://bugzilla.kernel.org/show_bug.cgi?id=13371

s2d bisection will always point to this commit because it really broke s2d 
for the "whole" 12 days during early -rc phase.  The fix:

(Continue reading)

bugzilla-daemon | 1 Aug 17:13 2009

[Bug 13886] Suspend to disk no longer works in 2.6.30.2 with an EIDE drive

http://bugzilla.kernel.org/show_bug.cgi?id=13886

--- Comment #4 from akwatts <at> ymail.com  2009-08-01 15:13:32 ---
The fix mentioned above (commit 2ea5521022ac8f4f528dcbae02668e02a3501a5a) does
not address the problem I am encountering (which is present in 2.6.30.2).

There is no e100 hardware present here.

I am more than willing to help with the debugging process from this end.

Might we test by reverting his commit on 2.6.30.2?

--

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Marcin Slusarz | 1 Aug 18:32 2009
Picon

Re: Bug report (suspend to disk is broken in 2.6.29+ with EIDE drive)

Andrew Watts wrote:
> Description: s2disk worked in 2.6.28 and no longer works in 2.6.30.2
> (s2disk here means: echo disk > /sys/power/state); screen blanks but
> system hangs.
> 
> Bisection reveals that the problem commit has hash:
> 295f00042aaf6b553b5f37348f89bab463d4a469.
> 
> ~Andy
> 
> PS I wrote some months ago about a thermal problem on my HW with
> 2.6.28 (needed noapic, nolapic to have it not run hot  <at>  idle).
> This problem has disappeared in 2.6.30.2. Any devs have an idea what
> commit fixed this?

Adding CCs
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Robert Hancock | 1 Aug 20:36 2009
Picon

Re: Bug report (suspend to disk is broken in 2.6.29+ with EIDE drive)

On 07/31/2009 12:22 AM, Andrew Watts wrote:
> Description: s2disk worked in 2.6.28 and no longer works in 2.6.30.2
> (s2disk here means: echo disk>  /sys/power/state); screen blanks but
> system hangs.
>
> Bisection reveals that the problem commit has hash:
> 295f00042aaf6b553b5f37348f89bab463d4a469.

That would be:

author	Bartlomiej Zolnierkiewicz <bzolnier <at> gmail.com>
	Fri, 2 Jan 2009 15:12:48 +0000 (16:12 +0100)
committer	Bartlomiej Zolnierkiewicz <bzolnier <at> gmail.com>
	Fri, 2 Jan 2009 15:12:48 +0000 (16:12 +0100)
commit	295f00042aaf6b553b5f37348f89bab463d4a469
tree	cbd56955f148f0e175d5b6b779c2888bf2645382
parent	ebdab07dad3d3a008e519b0a028e1e1ad5ecaef0

ide: don't execute the next queued command from the hard-IRQ context (v2)

CCing Bart and linux-ide.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Gmane