headers
Martin K. Petersen | 1 Jun 2009 07:08
Picon
Favicon

Re: [PATCH 02/13] block: Use accessor functions for queue limits

>>>>> "Bart" == Bartlomiej Zolnierkiewicz <bzolnier <at> gmail.com> writes:

>> Convert all external users of queue limits to using wrapper functions
>> instead of poking the request queue variables directly.

Did bisect this?

The patch you mention didn't touch the bounce limits at all.  One of my
other patches moved portions of the queue limits to an embedded struct.
However, it was purely variable renaming.  I have not touched anything
related to memory allocations.

[...]

Bart>  init_emergency_isa_pool+0x22/0x42 [<c0221e26>]
Bart>  blk_queue_bounce_limit+0x2c/0x41 [<c0309813>]

[...]

--

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 4 comments |
headers
Jens Axboe | 1 Jun 2009 07:15
Picon
Favicon

Re: [PATCH 02/13] block: Use accessor functions for queue limits

On Mon, Jun 01 2009, Martin K. Petersen wrote:
> >>>>> "Bart" == Bartlomiej Zolnierkiewicz <bzolnier <at> gmail.com> writes:
> 
> >> Convert all external users of queue limits to using wrapper functions
> >> instead of poking the request queue variables directly.
> 
> Did bisect this?
> 
> The patch you mention didn't touch the bounce limits at all.  One of my
> other patches moved portions of the queue limits to an embedded struct.
> However, it was purely variable renaming.  I have not touched anything
> related to memory allocations.

It replaces

        q->bounce_pfn = t->limits.bounce_pfn;

with

        blk_queue_bounce_limit(q, t->limits.bounce_pfn);

which are definitely not a functionally equivalent change.

--

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Permalink | Reply | 2 comments |
headers
Martin K. Petersen | 1 Jun 2009 07:28
Picon
Favicon

Re: [PATCH 02/13] block: Use accessor functions for queue limits

>>>>> "Jens" == Jens Axboe <jens.axboe <at> oracle.com> writes:

Jens> It replaces

Jens> q-> bounce_pfn = t->limits.bounce_pfn;

Jens> with

Jens>         blk_queue_bounce_limit(q, t->limits.bounce_pfn);

Jens> which are definitely not a functionally equivalent change.

Ah, now I see it.  Yeah, that's a bug.  I must have thought
blk_queue_bounce_limit() was one of my wrapper functions when I made
that change.  It follows the same naming scheme.

Will fix.

--

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Greg Freemyer | 1 Jun 2009 14:59
Picon
Gravatar

Re: [PATCH 0/4] partitions/ide: improve Host Protected Area handling

On Sun, May 31, 2009 at 10:39 AM, Bartlomiej Zolnierkiewicz
<bzolnier <at> gmail.com> wrote:
>
<snip>
> Additionally HPA can also
> be disabled using the "nohpa" module parameter (i.e. "ide_core.nohpa=0.0"
> to disable HPA on /dev/hda).

If we use that parameter on older kernels, is it just ignored?  I'm
hoping I can just make that a default for my live CDs, etc..

Also, how is that handled in libata?  (ie. we typically want to force
exposing the HPA regardless of driver selection.)

Alan, given your emphatic ack, is libata likely to follow the same
model.  Any chance we could have a single boot param that handled both
drivers?  I mean instead of having 2 module params.

Thanks
Greg
--

-- 
Greg Freemyer
Head of EDD Tape Extraction and Processing team
Litigation Triage Solutions Specialist
http://www.linkedin.com/in/gregfreemyer
First 99 Days Litigation White Paper -
http://www.norcrossgroup.com/forms/whitepapers/99%20Days%20whitepaper.pdf

The Norcross Group
The Intersection of Evidence & Technology
(Continue reading)

Permalink | Reply | 4 comments |
headers
Greg Freemyer | 1 Jun 2009 15:02
Picon
Gravatar

Re: [PATCH 0/4] partitions/ide: improve Host Protected Area handling

On Sun, May 31, 2009 at 11:34 AM, Bartlomiej Zolnierkiewicz
<bzolnier <at> gmail.com> wrote:
> On Sunday 31 May 2009 17:24:03 Andries E. Brouwer wrote:
>> On Sun, May 31, 2009 at 04:39:11PM +0200, Bartlomiej Zolnierkiewicz wrote:
>>
>> [HPA stuff deleted]
>>
>> Hi Bartlomiej,
>>
>> Apart from HPA one also has DCO, which functions rather similarly.
>> (I have not checked whether the current kernel knows anything about DCO.)
>> Have you thought about DCO?
>> Probably the kernel should by default not touch any such setting.
>> Maybe it should be reported?
>> A user space utility might change this setting - thus a disk can change size.
>
> We leave DCO handling entirely to user-space currently.

And to the best of my knowledge user-space leaves it entirely to the kernel.

ie. There is no opensource Linux solution I know of.

Greg
--

-- 
Greg Freemyer
Head of EDD Tape Extraction and Processing team
Litigation Triage Solutions Specialist
http://www.linkedin.com/in/gregfreemyer
First 99 Days Litigation White Paper -
http://www.norcrossgroup.com/forms/whitepapers/99%20Days%20whitepaper.pdf
(Continue reading)

Permalink | Reply | 0 comments |
headers
Alan Cox | 1 Jun 2009 15:06
Picon

Re: [PATCH 0/4] partitions/ide: improve Host Protected Area handling

On Mon, 1 Jun 2009 08:59:29 -0400
Greg Freemyer <greg.freemyer <at> gmail.com> wrote:

> Alan, given your emphatic ack, is libata likely to follow the same
> model.  Any chance we could have a single boot param that handled both

If the patches get in then it makes no sense not to implement them
identically in libata.

> drivers?  I mean instead of having 2 module params.

No because the modules have different names so it will always be
ide_core.something and libata.something

Bartlomiej - thinking about this I question "nohpa=" because we get into
unneccessary negatives ide_core.hpa= is one less inversion to figure out.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 2 comments |
headers
Alan Cox | 1 Jun 2009 15:41
Picon

Re: [PATCH] (2.6.20) pata_oldpiix: fix PIO2 underclocking

On Sun, 31 May 2009 17:25:14 +0400
Sergei Shtylyov <sshtylyov <at> ru.mvista.com> wrote:

> Hello, I wrote:
> 
> > Fix the PIO mode 2 using mode 0 timings -- this driver should enable the
> > fast timing bank starting with PIO2, just like the ata_piix driver does.
> > Also, fix/rephrase some comments while at it.
> >
> > Signed-off-by: Sergei Shtylyov <sshtylyov <at> ru.mvista.com>
> 
>    Hm, looks like pata_efar still needs the same fix...

I can't find the original email (not in my archive for 2008 or 2009) but
the comment makes sense
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 1 comment |
headers
Sergei Shtylyov | 1 Jun 2009 16:21

Re: [PATCH] (2.6.20) pata_oldpiix: fix PIO2 underclocking

Alan Cox wrote:

>>Hello, I wrote:

>>>Fix the PIO mode 2 using mode 0 timings -- this driver should enable the
>>>fast timing bank starting with PIO2, just like the ata_piix driver does.
>>>Also, fix/rephrase some comments while at it.

>>>Signed-off-by: Sergei Shtylyov <sshtylyov <at> ru.mvista.com>

>>   Hm, looks like pata_efar still needs the same fix...

> I can't find the original email (not in my archive for 2008 or 2009) but
> the comment makes sense

    It was the patch merged back in 2007. I'll submit the pata_efar patch 
shortly.

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Sergei Shtylyov | 1 Jun 2009 21:31

Re: [PATCH 2/2 resend] libata-sff: avoid byte swapping in ata_sff_data_xfer()

Hello, I wrote:

>> Handling of the trailing byte in ata_sff_data_xfer() is suboptimal 
>> bacause:

>> - it always initializes the padding buffer to 0 which is not really 
>> needed in
>>   both the read and write cases;

>> - it has to use memcpy() to transfer a single byte from/to the padding 
>> buffer;

>> - it uses io{read|write}16() accessors which swap bytes on the big 
>> endian CPUs
>>   and so have to additionally convert the data from/to the little 
>> endian format
>>   instead of using io{read|write}16_rep() accessors which are not 
>> supposed to
>>   change the byte ordering.
>>
>> Signed-off-by: Sergei Shtylyov <sshtylyov <at> ru.mvista.com>

>   Jeff, have you forgotten about this one?

    PING.

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
(Continue reading)

Permalink | Reply | 4 comments |
headers
Sergei Shtylyov | 1 Jun 2009 21:42

[PATCH] pata_efar: fix PIO2 underclocking

Fix the PIO mode 2 using mode 0 timings -- this driver should enable the
fast timing bank starting with PIO2, just like the PIIX/ICH drivers do.
Also, fix/rephrase some comments while at it.

Signed-off-by: Sergei Shtylyov <sshtylyov <at> ru.mvista.com>

---
Overlooked this while fixing pata_oldpiix/pata_mpiix 2 years ago...

 drivers/ata/pata_efar.c |   17 ++++++++---------
 1 files changed, 8 insertions(+), 9 deletions(-)

Index: linux-2.6/drivers/ata/pata_efar.c
===================================================================
--- linux-2.6.orig/drivers/ata/pata_efar.c
+++ linux-2.6/drivers/ata/pata_efar.c
 <at>  <at>  -22,7 +22,7  <at>  <at> 
 #include <linux/ata.h>

 #define DRV_NAME	"pata_efar"
-#define DRV_VERSION	"0.4.4"
+#define DRV_VERSION	"0.4.5"

 /**
  *	efar_pre_reset	-	Enable bits
 <at>  <at>  -98,18 +98,17  <at>  <at>  static void efar_set_piomode (struct ata
 			    { 2, 1 },
 			    { 2, 3 }, };

-	if (pio > 2)
(Continue reading)

Permalink | Reply | 1 comment |

Gmane