Jeff Garzik | 1 May 01:36 2009

Re: Implementing NVMHCI...

Jörn Engel wrote:
> But like it or not, the market seems to be moving in that direction.
> Which means we will have "block devices" that have all the interfaces of
> disks and behave much like flash - modulo the crap FTL.

One driving goal behind NVMHCI was to avoid disk-originated interfaces, 
because they are not as well suited to flash storage.

The NVMHCI command set (distinguished from NVMHCI, the silicon) is 
specifically targetted towards flash.

	Jeff

Robert Hancock | 1 May 03:49 2009
Picon

Re: No NCQ support on X61s Ultrabay? (Intel ICH8 SATA controller question)

Matthew Garrett wrote:
> On Thu, Apr 30, 2009 at 08:35:08AM -0700, Matthew Wilcox wrote:
>> On Thu, Apr 30, 2009 at 02:47:02PM +0100, Alan Cox wrote:
>>>> So, at the point of driver load, there just isn't much we can do about
>>>> the missing ABAR.  It's sad.  Dunno why some laptop manufacturers
>>>> still program the thing into piix mode.  :-(
>>> Forcing out of PIIX mode would need to go into the PCI quirks and be a
>>> boot option not a module one - at that point its doable as a header quirk.
>> I think Matthew Garrett already has code to do this.
> 
> Yeah, but some testers reported that it broke after using it for a 
> while. The most recent version I have is this:

We should likely have something like this in the kernel, but it should 
default to off. For one thing, some machines seem to have BIOS code that 
tries to poke the controller for some reason during suspend/shutdown 
events, etc. which would likely go nuts if the controller was 
unexpectedly in AHCI mode..

> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index a807797..9e7b460 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
>  <at>  <at>  -893,6 +893,52  <at>  <at>  DECLARE_PCI_FIXUP_RESUME(PCI_VENDOR_ID_ATI,
PCI_DEVICE_ID_ATI_IXP600_SATA, quirk
>  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_SATA, quirk_amd_ide_mode);
>  DECLARE_PCI_FIXUP_RESUME(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_SATA, quirk_amd_ide_mode);
>  
> +static void __devinit quirk_ahci_sata(struct pci_dev *pdev)
(Continue reading)

Robert Hancock | 1 May 03:51 2009
Picon

Re: No NCQ support on X61s Ultrabay? (Intel ICH8 SATA controller question)

Theodore Tso wrote:
> On Thu, Apr 30, 2009 at 07:34:45AM -0400, Theodore Tso wrote:
>> On Thu, Apr 30, 2009 at 08:33:09AM +0100, Alex Buell wrote:
>>> On Wed, 29 Apr 2009 22:27:46 -0400, I waved a wand and this message
>>> magically appears in front of Jeff Garzik:
>>>
>>>> As Tejun noted, try switching to AHCI mode in BIOS.
>>> But is there a way to switch modes without needing to go through the
>>> BIOS? Some laptops won't let you do that through BIOS. 
>> The BIOS setting already is in AHCI mode, and not in "compatibility
>> mode".  
> 
> Thinking about this a bit more, I'll bet the problem is the BIOS
> setting is only affecting the primary SATA ports (which are being
> grabed by ahci) and not the SATA port in the Ultrabay slot (which is
> being picked up by either the ata_piix or piix driver).  Sigh...

dmesg and lspci -vv output might be useful..
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Theodore Tso | 1 May 04:51 2009
Picon
Picon

Re: No NCQ support on X61s Ultrabay? (Intel ICH8 SATA controller question)

On Thu, Apr 30, 2009 at 07:51:28PM -0600, Robert Hancock wrote:
>> Thinking about this a bit more, I'll bet the problem is the BIOS
>> setting is only affecting the primary SATA ports (which are being
>> grabed by ahci) and not the SATA port in the Ultrabay slot (which is
>> being picked up by either the ata_piix or piix driver).  Sigh...
>
> dmesg and lspci -vv output might be useful..

Here you go...

[    0.000000] Initializing cgroup subsys cpuset
[    0.000000] Linux version 2.6.30-rc3-00369-ga774073 (root <at> closure) (gcc version 4.3.2 (Ubuntu
4.3.2-1ubuntu12) ) #27 SMP Sun Apr 26 23:54:09 EDT 2009
[    0.000000] KERNEL supported cpus:
[    0.000000]   Intel GenuineIntel
[    0.000000]   AMD AuthenticAMD
[    0.000000]   NSC Geode by NSC
[    0.000000]   Cyrix CyrixInstead
[    0.000000]   Centaur CentaurHauls
[    0.000000]   Transmeta GenuineTMx86
[    0.000000]   Transmeta TransmetaCPU
[    0.000000]   UMC UMC UMC UMC
[    0.000000] BIOS-provided physical RAM map:
[    0.000000]  BIOS-e820: 0000000000000000 - 000000000009d800 (usable)
[    0.000000]  BIOS-e820: 000000000009d800 - 00000000000a0000 (reserved)
[    0.000000]  BIOS-e820: 00000000000d2000 - 00000000000d4000 (reserved)
[    0.000000]  BIOS-e820: 00000000000e0000 - 0000000000100000 (reserved)
[    0.000000]  BIOS-e820: 0000000000100000 - 00000000bf6b0000 (usable)
(Continue reading)

Robert Hancock | 1 May 06:21 2009
Picon

Re: No NCQ support on X61s Ultrabay? (Intel ICH8 SATA controller question)

Theodore Tso wrote:
> On Thu, Apr 30, 2009 at 07:51:28PM -0600, Robert Hancock wrote:
>>> Thinking about this a bit more, I'll bet the problem is the BIOS
>>> setting is only affecting the primary SATA ports (which are being
>>> grabed by ahci) and not the SATA port in the Ultrabay slot (which is
>>> being picked up by either the ata_piix or piix driver).  Sigh...
>> dmesg and lspci -vv output might be useful..
> 
> Here you go...

I'm suspecting that that Ultrabay slot might be using the PATA ports on 
the chipset, with a PATA-SATA bridge chip or something. I haven't seen 
an Intel chipset with some SATA ports using AHCI and some in PIIX mode 
before, the ones I've seen with both had the PIIX mode driving PATA 
ports. If it is indeed bridged through PATA on that laptop, there's no 
way you're going to get any NCQ support on that slot.

I don't know why Lenovo would do that, as it would kind of cripple SATA 
drives in that slot, but hardware people do some bizarre things sometimes..
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Jeff Garzik | 1 May 09:26 2009

Re: [PATCH 1/2] Add support for Designware SATA controller driver

Feng Kan wrote:
> Signed-off-by: Feng Kan <fkan <at> amcc.com>
> ---
>  drivers/ata/Kconfig    |   76 +-
>  drivers/ata/Makefile   |    1 +
>  drivers/ata/sata_dwc.c | 2047 ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 2091 insertions(+), 33 deletions(-)
>  create mode 100644 drivers/ata/sata_dwc.c

I don't see a patch 2/2 ?

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Benjamin Herrenschmidt | 1 May 10:49 2009

Re: [PATCH 1/2] Add support for Designware SATA controller driver

On Fri, 2009-05-01 at 03:26 -0400, Jeff Garzik wrote:
> Feng Kan wrote:
> > Signed-off-by: Feng Kan <fkan <at> amcc.com>
> > ---
> >  drivers/ata/Kconfig    |   76 +-
> >  drivers/ata/Makefile   |    1 +
> >  drivers/ata/sata_dwc.c | 2047 ++++++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 2091 insertions(+), 33 deletions(-)
> >  create mode 100644 drivers/ata/sata_dwc.c
> 
> I don't see a patch 2/2 ?

Patch 2/2 is just adding the device-tree bits to the platform for
this driver to match against, so it's no big deal. However, Feng,
we already mentioned that you do a lot of unrelated changes to the
Kconfig file that shouldn't be part of this patch, just add the
entry for this chip, don't move stuff around in Kconfig, unless I
missed a good reason why this is done that way.

Cheers,
Ben.

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Matthew Wilcox | 1 May 13:35 2009
Picon

Re: No NCQ support on X61s Ultrabay? (Intel ICH8 SATA controller question)

On Thu, Apr 30, 2009 at 10:21:08PM -0600, Robert Hancock wrote:
> I'm suspecting that that Ultrabay slot might be using the PATA ports on  
> the chipset, with a PATA-SATA bridge chip or something. I haven't seen  
> an Intel chipset with some SATA ports using AHCI and some in PIIX mode  
> before, the ones I've seen with both had the PIIX mode driving PATA  
> ports. If it is indeed bridged through PATA on that laptop, there's no  
> way you're going to get any NCQ support on that slot.
>
> I don't know why Lenovo would do that, as it would kind of cripple SATA  
> drives in that slot, but hardware people do some bizarre things 
> sometimes..

I have to agree with Robert.  If you look at the ich8 data sheet
(313056-003), the mobile version has 3 ATA ports and 1 IDE port "that
can be electrically isolated".  See pages 41, 43, and 50-51.  on page 41,
it says the IDE port has "Tri-state modes to enable swap bay".

So I don't blame Lenovo for hooking up the Ultrabay slot using the IDE
port.  They were pretty much told to do it.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Theodore Tso | 1 May 15:14 2009
Picon
Picon

Re: No NCQ support on X61s Ultrabay? (Intel ICH8 SATA controller question)

On Fri, May 01, 2009 at 04:35:33AM -0700, Matthew Wilcox wrote:
> On Thu, Apr 30, 2009 at 10:21:08PM -0600, Robert Hancock wrote:
> > I'm suspecting that that Ultrabay slot might be using the PATA ports on  
> > the chipset, with a PATA-SATA bridge chip or something. I haven't seen  
> > an Intel chipset with some SATA ports using AHCI and some in PIIX mode  
> > before, the ones I've seen with both had the PIIX mode driving PATA  
> > ports. If it is indeed bridged through PATA on that laptop, there's no  
> > way you're going to get any NCQ support on that slot.
> >
> > I don't know why Lenovo would do that, as it would kind of cripple SATA  
> > drives in that slot, but hardware people do some bizarre things 
> > sometimes..
> 
> I have to agree with Robert.  If you look at the ich8 data sheet
> (313056-003), the mobile version has 3 ATA ports and 1 IDE port "that
> can be electrically isolated".  See pages 41, 43, and 50-51.  on page 41,
> it says the IDE port has "Tri-state modes to enable swap bay".
> 
> So I don't blame Lenovo for hooking up the Ultrabay slot using the IDE
> port.  They were pretty much told to do it.

Gaah.... so basically a SATA device (the X25-M) is talking to a
SATA-PATA bridge chip, which is then talking the IDE port in the ICH8
chipset, which shows up as piix, which we're then pretending is SATA
at the OS level via the ata_piix driver.  Did I get that right?
(Excuse me while I go find a barf bag....)

The sad thing is there doesn't seem to be a good reason to do that,
since SATA is designed to be hot-swapping, so it's not like they need
to use tri-state modes on the IDE port --- especially if said IDE is
(Continue reading)

Matthew Garrett | 1 May 15:59 2009

Re: No NCQ support on X61s Ultrabay? (Intel ICH8 SATA controller question)

On Fri, May 01, 2009 at 09:14:59AM -0400, Theodore Tso wrote:

> Oh.... and I suspect I know why they did it; I'm guessing they wanted
> to support PATA Ultrabay devices for backwards compatibility on the
> X60, and perhaps they were running out of connector pins on the
> docking station (the Ultrabay slot is on the X61's "media slice"), and
> they didn't have enough wires to run both PATA and SATA interfaces to
> the docking station, *and* they wanted to use the same docking station
> for the X60 and X61 Thinkpads.

SATA ultrabays have a standard SATA connector, which is in the same 
physical location as the PATA connector on the older bays - it's not 
possible for a single bay to support both PATA and SATA devices. Bear in 
mind that the usual use for one of these bays is for optical drives, and 
SATA slimline drives have only started appearing recently.

--

-- 
Matthew Garrett | mjg59 <at> srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Gmane