headers
Shane McDonald | 1 Jan 2009 03:35
Picon
Gravatar

Re: [PATCH v4] Resurrect IT8172 IDE controller driver

Sergei,

On Wed, Dec 31, 2008 at 6:07 AM, Sergei Shtylyov
<sshtylyov <at> ru.mvista.com> wrote:
> Shane McDonald wrote:
>> Signed-off-by: Shane McDonald <mcdonald.shane <at> gmail.com>
> Acked-by: Sergei Shtylyov <sshtylyov <at> ru.mvista.com>

Please forgive my ignorance -- this is my first non-trivial patch...
I have made a new patch incorporating your suggestions as described below.
Do I include your Acked-by line in my re-spun patch, or do I need you
to Ack it again?
I will post the new patch when I receive guidance on this.

>> diff -uprN a/drivers/ide/it8172.c b/drivers/ide/it8172.c
>> --- a/drivers/ide/it8172.c      1969-12-31 18:00:00.000000000 -0600
>> +++ b/drivers/ide/it8172.c      2008-12-30 20:55:29.000000000 -0600
>> +                                       { 7, 4 },
>> +                                       { 3, 3 },
>> +                                       { 2, 2 },
>> +                                       { 1, 2 }, };
>> +       /*
>> +        * The highest value of DIOR/DIOW pulse width and recovery time
>> +        * that can be set in the IT8172 is 8 PCI clock cycles.  As a
>> result,
>> +        * it cannot be configured for PIO mode 0.  This table sets these
>> +        * parameters to the maximum supported by the IT8172.
>> +        */
>
>  This comment seems somewhat mispalced...
(Continue reading)

Permalink | Reply | 2 comments |
headers
Jody Belka | 1 Jan 2009 06:10

marvell sata status?

Hi,

I'm looking at buying some new hard drives within the next few months, and
along with them an sata card. One of the cards I've spotted is an Adaptec
that apparently has a Marvell chipset on it (88SX7042), so I was wondering
what the current state of sata_mv is. Is it stable enough for everyday use,
or should I look for something using a different chipset?

Please cc me, as not subscribed to lkml, thanks.

J
--

-- 
Jody Belka
knew (at) pimb (dot) org
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 15 comments |
headers
Justin Piszcz | 1 Jan 2009 10:54

Re: marvell sata status?


On Thu, 1 Jan 2009, Jody Belka wrote:

> Hi,
>
> I'm looking at buying some new hard drives within the next few months, and
> along with them an sata card. One of the cards I've spotted is an Adaptec
> that apparently has a Marvell chipset on it (88SX7042), so I was wondering
> what the current state of sata_mv is. Is it stable enough for everyday use,
> or should I look for something using a different chipset?
>
> Please cc me, as not subscribed to lkml, thanks.
>

Hi,

I cannot comment on that Adaptec card but other cards (without fake-raid 
controllers built on-top of them) with that chipset work great:

Starttech/Rosewill come to mind.

01:00.0 SCSI storage controller: Marvell Technology Group Ltd. 88SX7042 PCI-e 4-port SATA-II (rev 02)

Star Tech is the "brand-card" I have.

Works as a regular SATA controller.

Justin.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
(Continue reading)

Permalink | Reply | 14 comments |
headers
Mark Lord | 1 Jan 2009 15:07
Picon
Favicon

Re: marvell sata status?

Justin Piszcz wrote:
> On Thu, 1 Jan 2009, Jody Belka wrote:
> .. One of the cards I've spotted is an Adaptec
>> that apparently has a Marvell chipset on it (88SX7042), so I was 
>> wondering
>> what the current state of sata_mv is. Is it stable enough for everyday 
>> use, or should I look for something using a different chipset?
..
> I cannot comment on that Adaptec card but other cards (without fake-raid 
> controllers built on-top of them) with that chipset work great:
..

The Marvell 7042 (PCIe) and 6042 (PCI) chips are very stable
and full-featured with the current sata_mv driver in Linux.

The older 6081 and 6041 chips still have issues with Linux,
something I'm working on fixing early in 2009.

Cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 13 comments |
headers
Jody Belka | 1 Jan 2009 19:44

Re: marvell sata status?

On Thu, Jan 01, 2009 at 09:07:11AM -0500, Mark Lord wrote:
> The Marvell 7042 (PCIe) and 6042 (PCI) chips are very stable
> and full-featured with the current sata_mv driver in Linux.
> 
> The older 6081 and 6041 chips still have issues with Linux,
> something I'm working on fixing early in 2009.

Cool, I think I'll go for that card then (Adaptec 1430SA). They're
x4, so good bandwidth, and i'll use the x16 slots on my board for
them. Only need one for now, but two eventually. And they're a good
price, at only £77 each.

J
--

-- 
Jody Belka
knew (at) pimb (dot) org
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 12 comments |
headers
Justin Piszcz | 1 Jan 2009 20:11

Re: marvell sata status?


On Thu, 1 Jan 2009, Jody Belka wrote:

> On Thu, Jan 01, 2009 at 09:07:11AM -0500, Mark Lord wrote:
>> The Marvell 7042 (PCIe) and 6042 (PCI) chips are very stable
>> and full-featured with the current sata_mv driver in Linux.
>>
>> The older 6081 and 6041 chips still have issues with Linux,
>> something I'm working on fixing early in 2009.
>
> Cool, I think I'll go for that card then (Adaptec 1430SA). They're
> x4, so good bandwidth, and i'll use the x16 slots on my board for
> them. Only need one for now, but two eventually. And they're a good
> price, at only £77 each.
>
>
> J
> -- 
> Jody Belka
> knew (at) pimb (dot) org
>

Does the card 'recognize' disks as SATA or do you have to export them as 
JBOD? The star tech card allows you to see the sata drives directly.

Justin.
Permalink | Reply | 11 comments |
headers
Jody Belka | 1 Jan 2009 20:43

Re: marvell sata status?

On Thu, Jan 01, 2009 at 02:11:37PM -0500, Justin Piszcz wrote:
> On Thu, 1 Jan 2009, Jody Belka wrote:
> >Cool, I think I'll go for that card then (Adaptec 1430SA). They're
> >x4, so good bandwidth, and i'll use the x16 slots on my board for
> >them. Only need one for now, but two eventually. And they're a good
> >price, at only £77 each.
> 
> Does the card 'recognize' disks as SATA or do you have to export them as 
> JBOD? The star tech card allows you to see the sata drives directly.

Well, it's just fake-raid, so surely you can always see the individual drives?
Are there actually cards out there that don't? *boggle*

Hmm.... ok, checking the Adaptec knowledgebase:

Q: Can drives be used on an Adaptec RAID controller but not be used as
   part of a RAID array?

A: Hard drives attached to an Adaptec RAID controller do not have to be
   configured as an array member to work properly. The RAID controller
   will recognize and access single disks. Please refer to your controller
   documentation for instructions on accessing drives that are not a member
   of any RAID array. 

J
--

-- 
Jody Belka
knew (at) pimb (dot) org
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
(Continue reading)

Permalink | Reply | 10 comments |
headers
Tejun Heo | 2 Jan 2009 03:36

Re: [git patches] libata hibernation fixes

Jeff Garzik wrote:
> This adds code at a late stage (heading towards -rc4), but does
> eliminate a particular spin-up overcycling behavior associated with
> hibernation.
> 
> Rafael's extended description below...  Separated to make it easier to
> pull-or-not, separate from the other libata fixes.  There shouldn't be
> any merge trouble between the two.
> 
> SATA: Blacklist systems that spin off disks during ACPI power off

Jeff, I think this should be merged into 2.6.29 unless Linus still
objects.  Linus, as discussed in this thread, this is workaround for a
hardware / firmware problem and vanilla windows also suffers the
problem, so as ugly as it is, we need this to prevent double spin down
on the machine.

Thanks and happy new year.

--

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 58 comments |
headers
Tejun Heo | 2 Jan 2009 04:04

[PATCH #upstream-fixes] ata_piix: save, use saved and restore IOCFG

Certain ACPI implementations mess up IOCFG on _STM making libata
detect cable type incorrectly after a suspend/resume cycle.  This
patch makes ata_piix save IOCFG on attach, use the saved value for
things which aren't dynamic and restore it on detach so that the next
driver also gets the BIOS initialized value.

This patch contains the following changes.

* makes ich_pata_cable_detect() use saved_iocfg.

* make piix_iocfg_bit18_quirk() take  <at> host and use saved_iocfg.

* hpriv allocation moved upwards to save iocfg before doing anything
  else.

This fixes bz#11879.  Andreas Mohr reported and diagnosed the problem.

Signed-off-by: Tejun Heo <tj <at> kernel.org>
Cc: Andreas Mohr <andi <at> lisas.de>
---
 drivers/ata/ata_piix.c |   49 ++++++++++++++++++++++++++++++++++---------------
 1 file changed, 34 insertions(+), 15 deletions(-)

diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index c11936e..be4d4bd 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
 <at>  <at>  -154,11 +154,13  <at>  <at>  struct piix_map_db {

 struct piix_host_priv {
(Continue reading)

Permalink | Reply | 3 comments |
headers
Tejun Heo | 2 Jan 2009 04:12

Re: AHCI problem with hotplug

Hello,

Tejun Heo wrote:
> This is consistent with the BIOS tristating those ports.  I don't
> remember the name of the register.  I'll look it up later.

Yeah, the PCS register.  From ICH8 datasheet (ICH7 datasheet doesn't
have the following paragraph but it's what the BIOS is supposed to do
all the same).

  If an AHCI-aware or RAID enabled operating system is being booted
  then system BIOS shall insure that all supported SATA ports are
  enabled prior to passing control to the OS. Once the AHCI aware OS
  is booted it becomes the enabling/disabling policy owner for the
  individual SATA ports. This is accomplished by manipulating a port’s
  PxSCTL and PxCMD fields. Because an AHCI or RAID aware OS will
  typically not have knowledge of the PxE bits and because the PxE
  bits act as master on/off switches for the ports, pre- boot software
  must insure that these bits are set to ‘1’ prior to booting the OS,
  regardless as to whether or not a device is currently on the port.

Can you please post the output of "lpsci -nnvvvxxx"?

--

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Permalink | Reply | 10 comments |

Gmane