Jeff Garzik | 1 Nov 02:37 2006
Picon

Re: [Patch] SCSI: Add nvidia AHCI controllers of MCP67 support to ahci.c

Peer Chen wrote:
> Resend the patch.
> Signed-off-by: Peer Chen <pchen <at> nvidia.com>

ACK everything Andrew Morton said:  this patch doesn't apply to the 
current kernel (2.6.19-rc4-gitX).  Please resend.

libata moves fast :)

Also, a related question:  does NVIDIA hardware use the PCI class code 
for AHCI?

	Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Jeff Garzik | 1 Nov 02:39 2006

Re: [PATCH] SCSI: Add the SGPIO support for sata_nv.c

Peer Chen wrote:
> The following SGPIO patch for sata_nv.c is based on 2.6.18 kernel.
> Signed-off by: Kuan Luo <kluo <at> nvidia.com>

ACK what Christoph Hellwig said:  please describe in detail what sgpio 
is, and why it is needed.

This is a non-trivial patch, with basically no explanation at all.

	Jeff

Jeff Garzik | 1 Nov 02:37 2006
Picon

Re: [Patch 1/2] SCSI: Add nvidia SATA controllers of MCP67 support to sata_nv.c

Peer Chen wrote:
> Signed-off-by:  Peer Chen <pchen <at> nvidia.com>

ACK what Andrew Morton said:  please resend, diff'd against latest 
kernel (2.6.19-rcX-gitY).

	Jeff

Jeff Garzik | 1 Nov 02:52 2006

Re: [PATCH] sata_vsc: Add MSI support to sata_vsc driver (resubmit) (fixed attachment)

Wolstenholme, Daniel E wrote:
> Ok, hopefully I can get the attachment right here.
> 
> Here's a resubmission of my MSI patch for the sata_vsc driver.
> 
> I've added a new vsc_sata_host_priv data structure (basically copied
> from the sata_mv driver) which has an hp_flags bitfield with a bit to
> indicate whether MSI is being used. This is used in the new
> vsc_sata_host_stop() routine to call
> pci_disable_msi() if MSI is on, pci_intx() if not.
> 
> Signed-off-by: Daniel Wolstenholme <daniel.e.wolstenholme <at> intel.com>

ACK the patch technical content.

Unfortunately, the patch was corrupted, and tabs were converted to 
spaces, which makes it impossible to apply the patch.

-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Jeff Garzik | 1 Nov 02:57 2006
Picon

Re: [PATCH 1/4] libata: implement ATA_EHI_PRINTINFO

Tejun Heo wrote:
> Implement ehi flag ATA_EHI_PRINTINFO.  This flag is set when device
> configuration needs to print out device info.  This used to be handled
> by  <at> print_info argument to ata_dev_configure() but LLDs also need to
> know about it in ->dev_config() callback.
> 
> This patch replaces  <at> print_info w/ ATA_EHI_PRINTINFO and make sata_sil
> print workaround messages only on the initial configuration.
> 
> Signed-off-by: Tejun Heo <htejun <at> gmail.com>

ACK patches 1-3.  I would apply them to #upstream, if I knew they would 
apply directly.  As it is, they are at least reviewed... :)

-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Jeff Garzik | 1 Nov 02:59 2006
Picon

Re: [PATCH 4/4] sata_sil: implement Mod15Write workaround by split request processing

Tejun Heo wrote:
> Instead of limiting max_sectors to 15 unconditionally, this patch
> leaves max_sectors at the default value and process write requests
> larger than 15 sectors by processing them in <= 15 sectors chunks.
> This results in unhamplered read performance and better write
> performance.
> 
> Split request processing is performed only for DMA write requests > 15
> sectors.  dev->max_sectors is limited to 15 sectors when the device is
> put into PIO mode.
> 
> Signed-off-by: Tejun Heo <htejun <at> gmail.com>

I'm still put off by the complexity that this adds to each transfer, and 
to the overall driver itself.

It's largely older chips and drives, so I don't think it's worth 
carrying this code for decades to come, just for some early SATA screwups.

-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Jeff Garzik | 1 Nov 03:03 2006
Picon

Re: [PATCH] libata: fix ATA passthrough handling for ATAPI devices

Tejun Heo wrote:
> libata used to pass all SCSI commands directly to ATAPI devices.
> However, this is incorrect for ATA passthrough commands as they must
> be handled by the SAT layer in libata.  Also, regardless of the
> attached ATAPI device's supported packet length, SAT says that both
> flavors of passthrough commands (ATA12 and ATA16) should work.
> 
> This patch makes the following changes to fix ATA passthrough handling
> for ATAPI devices.
> 
> * implement atapi_get_xlat_func() and make libata handle ATA12 and
>   ATA16 in SAT layer instead of passing it directly to the target
>   device even if the device is ATAPI.
> 
> * Always allow 16byte CDBs for ATAPI devices.  This makes
>   ata_set_port_max_cmd_len() unnecessary and dev->cdb_len meaningless
>   for ATA devices.  Both are stripped away.  Note that this doesn't
>   breach error checking in any substantial way.  shost->max_cmd_len
>   has never beena ble to properly protect CDB length violation anyway.
> 
> This problem has been spotted by Doublas Gilbert <dougg <at> torque.net>.
> 
> Signed-off-by: Tejun Heo <htejun <at> gmail.com>
> Cc: Douglas Gilbert <dougg <at> torque.net>

Resuming from the thread:

* Regarding CDB length:  DEPENDING ON IMPLEMENTATION DETAILS AND HOT 
PATH IMPACT, I think Douglas's comment about CDB lengths is fair:  we 
could unconditionally set the limit to 16 bytes, and then filter out 
(Continue reading)

Jeff Garzik | 1 Nov 03:07 2006
Picon

Re: [PATCHSET] hotplug polling, take 5

Tejun Heo wrote:
> Hello, all.
> 
> This is the fifth take of hotplug polling patchset.  This take doesn't
> contain any real change than rebasing over the current upstream[U].
> PMP patchset will be posted soon on top of this patchset and I wanted
> to avoid confusion by posting patchsets in order.
> 
> As the name implies, this patchset implements hotplug by polling.
> hp-poll is used to
> 
> * Monitor ports EH gave up.  When EH gives up on a port, it freezes
>   the port to protect the rest of the system from it.  The user used
>   to have to issue manual scan to retry the port.  hp-poll can monitor
>   such port and retry it when hotplug event is detected.  This is also
>   used by PMP support.
> 
> * Support hotplug on controllers which can report hotplug conditions
>   but cannot raise interrupt.

Patchset seems sane.  I'll need to re-read patch #1 in depth, but I give 
everything a tentative ACK for now.

My biggest concern is power usage.  On laptops for example, the 99% 
common case is that the user will never hot[un]plug a drive, so we 
shouldn't waste power bothering with poking disabled ports.

	Jeff

-
(Continue reading)

Jeff Garzik | 1 Nov 03:08 2006
Picon

Re: [Patch] SCSI: Add nvidia AHCI controllers of MCP67 support to ahci.c

Peer Chen wrote:
> Yes,we use 0x010601 for AHCI controller.  But we also want AHCI driver take care our 'RAID'  controller,so
Device IDs field in AHCI driver is necessary.

Agreed.  Just taking a survey of vendors :)  Most vendors similarly use
the RAID class code.

	Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Jeff Garzik | 1 Nov 03:13 2006

[git patches] libata fixes


Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus

to receive the following updates:

 drivers/ata/ata_piix.c    |   38 ++++++--------------------------------
 drivers/ata/libata-core.c |    1 -
 drivers/ata/libata.h      |    1 +
 drivers/ata/sata_sis.c    |   21 ++++++++++-----------
 include/linux/libata.h    |    1 -
 5 files changed, 17 insertions(+), 45 deletions(-)

Jens Axboe:
      Add 0x7110 piix to ata_piix.c

Tejun Heo:
      sata_sis: fix flags handling for the secondary port
      libata: unexport ata_dev_revalidate()
      ata_piix: allow 01b MAP for both ICH6M and ICH7M

diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index 5250187..8385387 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
 <at>  <at>  -126,8 +126,7  <at>  <at>  enum {
 	ich6_sata		= 7,
 	ich6_sata_ahci		= 8,
 	ich6m_sata_ahci		= 9,
-	ich7m_sata_ahci		= 10,
(Continue reading)


Gmane