headers
Tejun Heo | 1 Feb 2006 03:01
Picon

Re: [PATCH] ata_piix: ignore all zero PCS value on ICH5's

Jeff Garzik wrote:
> Tejun Heo wrote:
> 
>> Some ICH5's report 0 for PCS even when they have active working ports.
>> This patch makes piix_sata_probe() ignore 0 PCS value on ICH5's and
>> probe all ports in such cases.  And while at it, remove bogus
>> assignment to mask.
>>
> 
> I'm just not too thrilled about this.  I wonder if its an isolated 
> incident related to power or something.  I would wait for more problem 
> reports, before applying this.
> 

I'm not too sure about this one either, but we have two independent 
consistent bug reports and PCS handling in ata_piix isn't that necessary 
or strict to begin with, so....

How about making it a driver option?  ata_piix.ignore_PCS maybe?

--

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 1 comment |
headers
Jeff Garzik | 1 Feb 2006 05:14
Picon
Favicon

[git patches] libata updates


Please pull from 'upstream-fixes' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git

to receive the following updates:

 drivers/scsi/ahci.c |   19 +++++++++++++++----
 1 files changed, 15 insertions(+), 4 deletions(-)

Jeff Garzik:
      [libata ahci] Isolate Intel-ism, add JMicron JMB360 support
      [libata ahci] add another JMicron pci id

diff --git a/drivers/scsi/ahci.c b/drivers/scsi/ahci.c
index 19bd346..a800fb5 100644
--- a/drivers/scsi/ahci.c
+++ b/drivers/scsi/ahci.c
 <at>  <at>  -286,6 +286,10  <at>  <at>  static const struct pci_device_id ahci_p
 	  board_ahci }, /* ICH8M */
 	{ PCI_VENDOR_ID_INTEL, 0x282a, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
 	  board_ahci }, /* ICH8M */
+	{ 0x197b, 0x2360, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
+	  board_ahci }, /* JMicron JMB360 */
+	{ 0x197b, 0x2363, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
+	  board_ahci }, /* JMicron JMB363 */
 	{ }	/* terminate list */
 };

 <at>  <at>  -802,7 +806,6  <at>  <at>  static int ahci_host_init(struct ata_pro
 	struct pci_dev *pdev = to_pci_dev(probe_ent->dev);
(Continue reading)

Permalink | Reply | 0 comments |
headers
Tejun Heo | 1 Feb 2006 06:13
Picon

Re: [PATCH] ata_piix: fix MAP VALUE interpretation for for ICH6/7

On Thu, Jan 26, 2006 at 09:57:39PM -0500, Jeff Garzik wrote:
> Tejun Heo wrote:
> >Unlike their older siblings, ICH6 and 7 use different scheme for MAP
> >VALUE.  This patch makes ata_piix interpret MV properly on ICH6/7.
> >
> >Pre-ICH6/7
> >
> > The value of these bits indicate the address range the SATA port
> > responds to, and whether or not the SATA and IDE functions are
> > combined.
> >
> > 000 = Non-combined. P0 is primary master. P1 is secondary master.
> > 001 = Non-combined. P0 is secondary master. P1 is primary master.
> > 100 = Combined. P0 is primary master. P1 is primary slave. P-ATA is
> >       2:0 Map Value secondary.
> > 101 = Combined. P0 is primary slave. P1 is primary master. P-ATA is
> >       secondary.
> > 110 = Combined. P-ATA is primary. P0 is secondary master. P1 is
> >       secondary slave.
> > 111 = Combined. P-ATA is primary. P0 is secondary slave. P1 is
> >       secondary master.
> >
> >ICH6/7
> >
> > Map Value - R/W. Map Value (MV): The value in the bits below indicate
> >the address range the SATA ports responds to, and whether or not the
> >PATA and SATA functions are combined. When in combined mode, the AHCI
> >memory space is not available and AHCI may not be used.
> >
> > 00 = Non-combined. P0 is primary master, P2 is the primary slave. P1
(Continue reading)

Permalink | Reply | 0 comments |
headers
Michael Spiegle | 1 Feb 2006 06:21
Gravatar

AHCI driver for ICH6M

Hello Jeff,
I was trying to use the AHCI driver included in kernel 2.6.15 to drive
the SATA controller on my Asus Z71V laptop which supposedly has an ICH6M
controller.  I noticed that the PCI ID of my controller shows up in the
AHCI source code, so I assume that means I should have support.  I'm not
terribly good with linux or C, but I think I was able to troubleshoot my
issue down to a specific line of code.  Ultimately, I get the error:

ahci: probe of 0000:00:1f.2 failed with error -12

in my dmesg output.  I was trying to debug the AHCI driver code by
inserting print statements.  I found that the driver stops processing at
this point in the code:

ahci.c:
mmio_base = pci_iomap(pdev, AHCI_PCI_BAR, 0);

Specifically, the pci_iomap function seems to check for
pci_resource_start and pci_resource_len which both return false.
Looking at the code, if either len or start is false, the code returns
NULL, then I get the error observed above in dmesg.

Is this a possible bug, or is AHCI support somehow stripped from my
chipset?

Thank you for your time.  If this is not the proper way to contact you
about issues regarding the driver, I am sorry.  I am very new to these
things.

Michael Spiegle
(Continue reading)

Permalink | Reply | 2 comments |
headers
Kumar Gala | 1 Feb 2006 08:19

RFC: Compact Flash True IDE Mode Driver

I was hoping to get some comments on this work in progress driver for
using a compact flash device running in True IDE Mode connect via a MMIO
interface.  The driver is working, however the embedded system I'm running
on need some HW fixes to address the fact that the byte lanes for the data
are swapped.  I figured now was a good time to incorporate any changes
while I wait for the HW fixes (which will allow me to remove the 
cfide_outsw & cfide_insw).

- kumar

diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig
index 1c81174..8334baf 100644
--- a/drivers/ide/Kconfig
+++ b/drivers/ide/Kconfig
 <at>  <at>  -930,6 +930,12  <at>  <at>  config BLK_DEV_Q40IDE
 	  normally be on; disable it only if you are running a custom hard
 	  drive subsystem through an expansion card.

+config BLK_DEV_CFIDE
+	tristate "Compact Flash in True IDE mode"
+	help
+	  This is the IDE driver for a Memory Mapped Compact Flash Device
+	  running in True IDE mode.
+
 config BLK_DEV_MPC8xx_IDE
 	bool "MPC8xx IDE support"
 	depends on 8xx && IDE=y && BLK_DEV_IDE=y
diff --git a/drivers/ide/Makefile b/drivers/ide/Makefile
index 569fae7..09ed3aa 100644
--- a/drivers/ide/Makefile
(Continue reading)

Permalink | Reply | 28 comments |
headers
Erik Slagter | 1 Feb 2006 11:25
Gravatar

Re: [PATCH] amd76x_pm: C3 powersaving for AMD K7

On Tue, 2006-01-31 at 19:34 -0800, Andrew Morton wrote:
> > This is a processor idle module for AMD SMP 760MP(X) based systems.
> >  The patch was originally written by Tony Lindgren and has been around
> >  since 2002.  It enables C2 mode on AMD SMP systems and thus saves
> >  about 70 - 90 W of energy in the idle mode compared to the default idle
> >  mode.  The idle function has been rewritten and is now free of locking
> >  issues and is independent from the number of CPUs.  The impact
> >  from this module on the system clock and on i/o transfer are now fairly
> >  low.

Very nice, but I do have problems with it (last tested version about a
month ago).

I have a Tyan S2466 (760/8MPX) motherboard with a Promise PDC20575
(SATAII150 TX2plus), with two disks configured as raid-1. As soon as C2
starts to kick in (or C3 that doesn't matter) my syslog/dmesg starts to
fill up with error messages from the attached disks and one of the two
(at random) disks is kicked out of the raid. It looks like the other
disk keeps functioning although it keeps spewing lots of error messages.

To me it looks like the Promise controller goes totally bunkus when one
single interrupt is not served, or when it cannot bus master within a
certain time interval. I have tried to work around this problem by using
_very_ conservative values for the irq-watcher. This works well for some
time, but sooner or later the problem re-appears.

So it looks like the only way is to tackle the source of the problem. I
already reported this on linux-ide, but no response. I assume they think
it's a amd76x_pm specific issue.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Mathieu Chouquet-Stringer | 1 Feb 2006 11:31
X-Face
Picon
Favicon

libata-core and pccard CF card reader

	Hello,

During the last couple of month I've been using extensively Mark Lord's
driver for my flash card reader (downloadable at [1]).

Not too long ago he posted an skeleton [2] that was close to work with
the lastest libata release...

In a private email, he made me aware that because of time constraint, he
wasn't sure when he would have the time to fix it.

So I started hacking and made some progress, I fixed a bunch of
functions whose prototypes had changed, add some more bits here and
there and was finally able to compile and to load my kernel module.

The host now registers itself with libata (using standard function
ata_device_add), I see it in dmesg but it fails to register the CF card:

ata1: dev 0 not supported, ignoring

Browsing the source, here's what happens:
- the code call ata_device_add (I guess it was originally coded like
  this because ata_pci_init_one which calls ata_pci_init_native_mode or
  ata_pci_init_native_mode would overwrite the special cmd_addr,
  altstatus_addr and ctl_addr)
- this function does some processing then calls ata_bus_probe
- which itself calls ata_dev_identify

I put some debug statements and found my 'problem' in
drivers/scsi/libata-core.c, function ata_dev_identify, around line 1329
(Continue reading)

Permalink | Reply | 0 comments |
headers
Erik Slagter | 1 Feb 2006 12:29
Gravatar

Re: AHCI driver for ICH6M

> I was trying to use the AHCI driver included in kernel 2.6.15 to drive
> the SATA controller on my Asus Z71V laptop which supposedly has an ICH6M
> controller.  I noticed that the PCI ID of my controller shows up in the
> AHCI source code, so I assume that means I should have support.  I'm not
> terribly good with linux or C, but I think I was able to troubleshoot my
> issue down to a specific line of code.  Ultimately, I get the error:
> 
> ahci: probe of 0000:00:1f.2 failed with error -12

A very familiar problem. It means that your bios configures your ICH
chipset for legacy (or whatever name it has) mode, which means it will
respond to the old-fashioned IDE ports and IRQs. This also means you
cannot drive it in AHCI mode :-( unless there is an option in your BIOS
to switch between legacy and ahci mode, but afaik no single laptop has
this option. So you're on your own here :-( (just like me, btw).
Attachment (smime.p7s): application/x-pkcs7-signature, 2771 bytes
Permalink | Reply | 1 comment |
headers
Dominic ES. Ijichi | 1 Feb 2006 12:33

Re: AHCI driver for ICH6M


----- Erik Slagter <erik <at> slagter.name> wrote:
> > I was trying to use the AHCI driver included in kernel 2.6.15 to
> drive
> > the SATA controller on my Asus Z71V laptop which supposedly has an
> ICH6M
> > controller.  I noticed that the PCI ID of my controller shows up in
> the
> > AHCI source code, so I assume that means I should have support.  I'm
> not
> > terribly good with linux or C, but I think I was able to
> troubleshoot my
> > issue down to a specific line of code.  Ultimately, I get the
> error:
> > 
> > ahci: probe of 0000:00:1f.2 failed with error -12
> 
> A very familiar problem. It means that your bios configures your ICH
> chipset for legacy (or whatever name it has) mode, which means it
> will
> respond to the old-fashioned IDE ports and IRQs. This also means you
> cannot drive it in AHCI mode :-( unless there is an option in your
> BIOS
> to switch between legacy and ahci mode, but afaik no single laptop
> has
> this option. So you're on your own here :-( (just like me, btw).

i had same problem - fujitsu laptop with ich6 sata controller but with pata disk putting it into
'legacy/ide' mode.  ahci module would drive the controller/disk but suspend didn't work.  removing ahci
module and adding ata_piix module resolved this issue for me, now i get full s3 suspend as well :)  device
(Continue reading)

Permalink | Reply | 0 comments |
headers
Michal Sojka | 1 Feb 2006 15:43
Picon
Picon
Favicon
Gravatar

sata_mv and MV88SX6041 don't work

Hello,

we have problems with this SATA controller:

0000:03:03.0 RAID bus controller: Marvell Technology Group Ltd. MV88SX6041 
4-port SATA II PCI-X Controller (rev 03)

Is there any chance that this hardware will be supported by sata_mv in near 
future? Can we help somehow with debugging? Here is the excerpt from 
2.6.16-rc1 boot messages (the full boot log is attached):

sata_mv 0000:03:03.0: version 0.5
...
sata_mv 0000:03:03.0: Applying B2 workarounds to unknown rev
sata_mv 0000:03:03.0: 32 slots 4 ports unknown mode IRQ via MSI
ata1: SATA max UDMA/133 cmd 0x0 ctl 0xFFFFC200000A2120 bmdma 0x0 irq 185
...
ata1: dev 0 ATA-6, max UDMA/133, 72303840 sectors: LBA48
ata1: qc timeout (cmd 0xef)
ata1: failed to set xfermode, disabled
ata1: dev 0 configured for UDMA/133

We are currently using GPL driver from Marvell 
(http://www.keffective.com/mvsata/FC3/mvSata_Linux_3.6.1.tgz) but we are able 
to compile it only under 2.6.11. This driver had to be patched to support our 
revision 3. The original driver supports only revisions greater than 9. Does 
anybody know whether this is a bug of the driver or there is some reason why 
lower revisions are not supported?

We tried it also under 2.6.14 but we did not succeed. It would be nice if we
(Continue reading)

Permalink | Reply | 4 comments |

Gmane