sean | 1 May 03:12 2005
Picon

Re: ahci or ata-piix for ich6?

John W. Linville wrote:
> On Sat, Apr 30, 2005 at 09:55:17AM -0400, sean wrote:
> 
>>I have a mobo with the 915G, 82801FB/FBW (ICH6/ICH6W) SATA 
>>controller. Which SATA driver in 2.6.12-rc3?
> 
> 
> If you configured AHCI in the BIOS, then ahci should work.  Otherwise
> ata_piix is the choice.  In fact, for ICH6 ata_piix is smart enough
> to disable AHCI on its own, if it gets loaded.  So, ata_piix is the
> safe choice (ignoring any issues favoring AHCI).
> 
> For those observing, the reason this is an issue is because Intel
> used the same PCI ID for ICH6 in either IDE or AHCI mode.  So, there
> is no obvious choice for kudzu and the like to make.
> 
> John

Aha!  I don't have ( or least can't find ) any ahci option 
in my bios for the gigabyte GA-8i915g board. I've asked on 
the alt gigabyte newgroup.

thanks

sean

-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Alan Cox | 1 May 15:37 2005
Picon

Re: [2.6 patch] drivers/ide/: possible cleanups

On Sad, 2005-04-30 at 21:07, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - pci/cy82c693.c: make a needlessly global function static
> - remove the following unneeded EXPORT_SYMBOL's:
>   - ide-taskfile.c: do_rw_taskfile
>   - ide-iops.c: default_hwif_iops
>   - ide-iops.c: default_hwif_transport
>   - ide-iops.c: wait_for_ready

default_*_ops are very much API items not currently used. You need them
if you
want to switch from mmio back to pio (eg doing S3 resume) although
nobody is currently doing that.

wait_for_ready used to be used by ide-probe as a module so seems sane.

-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Adrian Bunk | 1 May 16:29 2005
Picon

Re: [2.6 patch] drivers/ide/: possible cleanups

On Sun, May 01, 2005 at 02:37:43PM +0100, Alan Cox wrote:
> On Sad, 2005-04-30 at 21:07, Adrian Bunk wrote:
> > This patch contains the following possible cleanups:
> > - pci/cy82c693.c: make a needlessly global function static
> > - remove the following unneeded EXPORT_SYMBOL's:
> >   - ide-taskfile.c: do_rw_taskfile
> >   - ide-iops.c: default_hwif_iops
> >   - ide-iops.c: default_hwif_transport
> >   - ide-iops.c: wait_for_ready
> 
> default_*_ops are very much API items not currently used. You need them
> if you
> want to switch from mmio back to pio (eg doing S3 resume) although
> nobody is currently doing that.

My patch only removes the EXPORT_SYMBOL's.

The functions themselves stay (since they are used), and if someone 
wants at some time in the future use them from a module, re-adding them 
will be trivial.

> wait_for_ready used to be used by ide-probe as a module so seems sane.

cu
Adrian

--

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
(Continue reading)

Jens Axboe | 1 May 17:49 2005
Picon

Re: [PATCH 2.6.11.6] ide-scsi: kmap scatter/gather before doing PIO

On Fri, Apr 29 2005, Stuart_Hayes <at> Dell.com wrote:
> > With more testing, I've discovered a problem with thin patch--I used
> > the "KM_USER0" window for kmap_atomic(), but that's apparently not
> > safe to use in an interrupt handler, because there are places in the
> > kernel where KM_USER0 is used without masking interrupts (see
> > include/linux/highmem.h for several examples).  This patch is
> > identical to the previous one I sent in, except it uses the KM_IRQ0
> > window, which I verified is not used anywhere without IRQs masked.   
> > 
> > This patch is against 2.6.11.7... the latest kernel on kernel.org
> > didn't yet have the previous patch I submitted.  If it would be more
> > useful, I can make this patch against an ide-scsi.c that already has
> > my previous patch applied--I wasn't sure which would be better.   

(you should inline the patch so one can comment on it...)

The IO code typically uses the BIO defines for this.

diff -purN linux-2.6.11.7/drivers/scsi/ide-scsi.c linux-2.6.11.7mods/drivers/scsi/ide-scsi.c
--- linux-2.6.11.7/drivers/scsi/ide-scsi.c	2005-04-07 14:57:46.000000000 -0400
+++ linux-2.6.11.7mods/drivers/scsi/ide-scsi.c	2005-04-29 11:46:55.000000000 -0400
 <at>  <at>  -143,6 +143,9  <at>  <at>  static void idescsi_input_buffers (ide_d
 {
 	int count;
 	char *buf;
+#ifdef CONFIG_HIGHMEM
+	unsigned long flags;
+#endif

 	while (bcount) {
(Continue reading)

Richard Purdie | 1 May 19:59 2005
Picon

IDE problems in 2.6.12-rc1-bk1 onwards (was Re: 2.6.12-rc3-mm1)

I've switched back to 2.6.12-rc3-mm1 and added some debuging to all the ide 
functions to trace the order functions are getting called. I've shown the 
result below for two different oops. There is more than one problem. The 
first problem was introduced in 2.6.12-rc1-bk1 in the ide-disk changes. The 
second has been around for a while but is showing up again.

The problem is idedisk_cleanup() gets called twice from ide_unregister(). 
Once here:

 for (unit = 0; unit < MAX_DRIVES; ++unit) {
  drive = &hwif->drives[unit];
  if (!drive->present)
   continue;
  DRIVER(drive)->cleanup(drive);
 }

and secondly in ide_unregister indirectly via:

  blk_cleanup_queue(drive->queue);
  printk(KERN_ERR "ide_unregister4()\n");
  device_unregister(&drive->gendev);
  down(&drive->gendev_rel_sem);
  spin_lock_irq(&ide_lock);
  drive->queue = NULL;
  printk(KERN_ERR "ide_unregister5()\n");

device_unregister()  triggers ide_drive_remove() which calls 
DRIVER(drive)->cleanup(drive);

In the first call to idedisk_cleanup(), ide_disk_put(idkp) is called which 
(Continue reading)

Bartlomiej Zolnierkiewicz | 1 May 20:41 2005
Picon

Re: IDE problems in 2.6.12-rc1-bk1 onwards (was Re: 2.6.12-rc3-mm1)

On 5/1/05, Richard Purdie <rpurdie <at> rpsys.net> wrote:
> I've switched back to 2.6.12-rc3-mm1 and added some debuging to all the ide
> functions to trace the order functions are getting called. I've shown the
> result below for two different oops. There is more than one problem. The
> first problem was introduced in 2.6.12-rc1-bk1 in the ide-disk changes. The
> second has been around for a while but is showing up again.
>  
> The problem is idedisk_cleanup() gets called twice from ide_unregister().
> Once here:
> 
>  for (unit = 0; unit < MAX_DRIVES; ++unit) {
>   drive = &hwif->drives[unit];
>   if (!drive->present)
>    continue;
>   DRIVER(drive)->cleanup(drive);
>  }
> 
> and secondly in ide_unregister indirectly via:
> 
>   blk_cleanup_queue(drive->queue);
>   printk(KERN_ERR "ide_unregister4()\n");
>   device_unregister(&drive->gendev);
>   down(&drive->gendev_rel_sem);
>   spin_lock_irq(&ide_lock);
>   drive->queue = NULL;
>   printk(KERN_ERR "ide_unregister5()\n");
> 
> device_unregister()  triggers ide_drive_remove() which calls
> DRIVER(drive)->cleanup(drive);
> 
(Continue reading)

Benjamin Herrenschmidt | 2 May 03:27 2005

Re: [2.6 patch] drivers/ide/: possible cleanups

On Sun, 2005-05-01 at 16:29 +0200, Adrian Bunk wrote:
> On Sun, May 01, 2005 at 02:37:43PM +0100, Alan Cox wrote:
> > On Sad, 2005-04-30 at 21:07, Adrian Bunk wrote:
> > > This patch contains the following possible cleanups:
> > > - pci/cy82c693.c: make a needlessly global function static
> > > - remove the following unneeded EXPORT_SYMBOL's:
> > >   - ide-taskfile.c: do_rw_taskfile
> > >   - ide-iops.c: default_hwif_iops
> > >   - ide-iops.c: default_hwif_transport
> > >   - ide-iops.c: wait_for_ready
> > 
> > default_*_ops are very much API items not currently used. You need them
> > if you
> > want to switch from mmio back to pio (eg doing S3 resume) although
> > nobody is currently doing that.
> 
> My patch only removes the EXPORT_SYMBOL's.
> 
> The functions themselves stay (since they are used), and if someone 
> wants at some time in the future use them from a module, re-adding them 
> will be trivial.

Hrm... well, that means if I ever want ide-pmac for example to be a
module, I'll have to add them back...

On the other hand, I agree that their names aren't very nice for
exported symbols... they should have been ide_* 

Ben.

(Continue reading)

Richard Purdie | 2 May 14:24 2005
Picon

Re: IDE problems in 2.6.12-rc1-bk1 onwards (was Re: 2.6.12-rc3-mm1)

Bartlomiej Zolnierkiewicz:
> Both problems should be fixed by "convert IDE device drivers to
> driver-model" patch but I need to resync it against latest kernels.

Thanks for the tip. I found that patch and applied the parts for the drivers 
I use. This cured the oops and also allowed "hot unplugging" to finally work 
under 2.6 for CF cards! Is there a timeline for when this goes into mainline 
and/or -mm?

I can still get an oops from the vfs layer if I try to access a card just 
after I remove it suggesting there are some timeout issues somewhere but 
this is a *massive* improvement on where things were before! I'm really 
pleased to see this :)

Thanks,

Richard 

-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Stuart_Hayes | 2 May 17:17 2005
Picon

RE: [PATCH 2.6.11.6] ide-scsi: kmap scatter/gather before doing PIO

Jens Axboe wrote:
> On Fri, Apr 29 2005, Stuart_Hayes <at> Dell.com wrote:
>>> With more testing, I've discovered a problem with thin patch--I used
>>> the "KM_USER0" window for kmap_atomic(), but that's apparently not
>>> safe to use in an interrupt handler, because there are places in the
>>> kernel where KM_USER0 is used without masking interrupts (see
>>> include/linux/highmem.h for several examples).  This patch is
>>> identical to the previous one I sent in, except it uses the KM_IRQ0
>>> window, which I verified is not used anywhere without IRQs masked.
>>> 
>>> This patch is against 2.6.11.7... the latest kernel on kernel.org
>>> didn't yet have the previous patch I submitted.  If it would be more
>>> useful, I can make this patch against an ide-scsi.c that already has
>>> my previous patch applied--I wasn't sure which would be better.
> 
> (you should inline the patch so one can comment on it...)
> 
> The IO code typically uses the BIO defines for this.
> 
> diff -purN linux-2.6.11.7/drivers/scsi/ide-scsi.c
> linux-2.6.11.7mods/drivers/scsi/ide-scsi.c ---
> linux-2.6.11.7/drivers/scsi/ide-scsi.c	2005-04-07
14:57:46.000000000
> -0400 +++ linux-2.6.11.7mods/drivers/scsi/ide-scsi.c	2005-04-29
>  	11:46:55.000000000 -0400  <at>  <at>  -143,6 +143,9  <at>  <at>  static void
>  	idescsi_input_buffers (ide_d  { int count; char *buf;
> +#ifdef CONFIG_HIGHMEM
> +	unsigned long flags;
> +#endif
> 
(Continue reading)

Bartlomiej Zolnierkiewicz | 2 May 17:46 2005
Picon

Re: [PATCH 2.6.11.6] ide-scsi: kmap scatter/gather before doing PIO

Hi,

On 5/2/05, Stuart_Hayes <at> dell.com <Stuart_Hayes <at> dell.com> wrote:
> Jens Axboe wrote:
> > On Fri, Apr 29 2005, Stuart_Hayes <at> Dell.com wrote:
> >>> With more testing, I've discovered a problem with thin patch--I used
> >>> the "KM_USER0" window for kmap_atomic(), but that's apparently not
> >>> safe to use in an interrupt handler, because there are places in the
> >>> kernel where KM_USER0 is used without masking interrupts (see
> >>> include/linux/highmem.h for several examples).  This patch is
> >>> identical to the previous one I sent in, except it uses the KM_IRQ0
> >>> window, which I verified is not used anywhere without IRQs masked.
> >>>
> >>> This patch is against 2.6.11.7... the latest kernel on kernel.org
> >>> didn't yet have the previous patch I submitted.  If it would be more
> >>> useful, I can make this patch against an ide-scsi.c that already has
> >>> my previous patch applied--I wasn't sure which would be better.
> >
> > (you should inline the patch so one can comment on it...)
> >
> > The IO code typically uses the BIO defines for this.
> >
> > diff -purN linux-2.6.11.7/drivers/scsi/ide-scsi.c
> > linux-2.6.11.7mods/drivers/scsi/ide-scsi.c ---
> > linux-2.6.11.7/drivers/scsi/ide-scsi.c        2005-04-07
> 14:57:46.000000000
> > -0400 +++ linux-2.6.11.7mods/drivers/scsi/ide-scsi.c  2005-04-29
> >       11:46:55.000000000 -0400  <at>  <at>  -143,6 +143,9  <at>  <at>  static void
> >       idescsi_input_buffers (ide_d  { int count; char *buf;
> > +#ifdef CONFIG_HIGHMEM
(Continue reading)


Gmane