Re: [PATCH v4 2/3] pwm: iproc: Add support for Broadcom iproc pwm controller

Hi Brian,

On Wed, Jun 22, 2016 at 11:01 PM, Brian Norris
<computersforpeace <at> gmail.com> wrote:
> On Wed, Jun 22, 2016 at 07:29:46AM -0400, Yendapally Reddy Dhananjaya Reddy wrote:
>> Add support for the PWM controller present in Broadcom's iProc
>> family of SoCs. This driver is derived from the pwm-bcm-kona
>> driver, with changes to the register offsets and bit positions.
>> It has been tested on the  Northstar+ bcm958625HR board.
>>
>> Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy <at> broadcom.com>
>> ---
>>  drivers/pwm/Kconfig         |  10 ++
>>  drivers/pwm/Makefile        |   1 +
>>  drivers/pwm/pwm-bcm-iproc.c | 327 ++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 338 insertions(+)
>>  create mode 100644 drivers/pwm/pwm-bcm-iproc.c
>>
> [...]
>> diff --git a/drivers/pwm/pwm-bcm-iproc.c b/drivers/pwm/pwm-bcm-iproc.c
>> new file mode 100644
>> index 0000000..952c457
>> --- /dev/null
>> +++ b/drivers/pwm/pwm-bcm-iproc.c
>>  <at>  <at>  -0,0 +1,327  <at>  <at> 
> [...]
>> +static const struct pwm_ops iproc_pwm_ops = {
>> +     .config = iproc_pwmc_config_check,
>> +     .set_polarity = iproc_pwmc_set_polarity,
>> +     .enable = iproc_pwmc_enable,
(Continue reading)

Hannes Reinecke | 20 Jun 13:39 2016
Picon

[PATCH 0/6] libata: Fixup ATA NCQ NON-DATA commands

Hi Tejun,

Damien pointed out that we're not handling ATA NCQ NON-Data commands
correctly. This patchset fixes this.

As usual, comments and reviews are welcome.

Hannes Reinecke (6):
  libata: use ata_is_ncq() accessors
  libsas: use ata_is_ncq() and ata_has_dma() accessors
  ata: add ata_is_fpdma() accessor
  ata: fixup ATA_PROT_NODATA
  libata-eh: decode all taskfile protocols
  ata: Handle ATA NCQ NO-DATA commands correctly

 drivers/ata/libahci.c         |  2 +-
 drivers/ata/libata-core.c     |  8 ++++----
 drivers/ata/libata-eh.c       |  8 ++++++--
 drivers/ata/libata-scsi.c     |  9 ++++++---
 drivers/ata/sata_dwc_460ex.c  |  2 ++
 drivers/ata/sata_fsl.c        |  4 ++--
 drivers/ata/sata_mv.c         |  5 ++---
 drivers/ata/sata_nv.c         | 11 +++++------
 drivers/scsi/libsas/sas_ata.c |  9 ++-------
 include/linux/ata.h           |  1 +
 include/linux/libata.h        |  8 ++++++++
 include/trace/events/libata.h |  1 +
 12 files changed, 40 insertions(+), 28 deletions(-)

--

-- 
(Continue reading)

[PATCH 0/7] Add SATA3 support for Broadcom NSP SoC

This patch set adds support for SATA3 interface available in Broadcom
NSP SoC.

The first patch removes the "stb" references in the ahci documentation
to make it generic for Broadcom SoC's. The second patch adds NSP support
to the ahci documentation. The third patch adds the NSP SATA phy
documentation.

The fourth patch renames the Broadcom stb ahci driver to common Broadcom
ahci driver and fifth patch supports NSP ahci. The sixth patch adds
support for NSP SATA3 phy.

The seventh patch contains the device tree changes for NSP SoC.

This patch set has been tested on NSP bcm958625HR board.
This patch set is based on v4.7.0-rc1 and is available from github
repo: https://github.com/Broadcom/cygnus-linux.git
branch: nsp-sata-v1

Yendapally Reddy Dhananjaya Reddy (7):
  dt-bindings: ata: rename brcm,sata-brcmstb.txt to brcm,sata-brcm.txt
  dt-bindings: ata: add support for Broadcom NSP SoC ahci
  dt-bindings: phy: Add documentation for NSP SATA PHY
  ata: ahci_brcmstb: rename to support across Broadcom SoC's
  ata: ahci_brcm: Add support for Broadcom NSP SoC
  phy: Add SATA3 PHY support for Broadcom NSP SoC
  ARM: dts: nsp: Add sata device tree entry

 .../{brcm,sata-brcmstb.txt => brcm,sata-brcm.txt}  |  9 +--
 .../devicetree/bindings/phy/brcm-sata-phy.txt      |  4 +-
(Continue reading)

DingXiang | 15 Jun 11:15 2016

[PATCH resend] libata:fix kernel panic when hotplug

From: Miao Xie <miaoxie <at> huawei.com>

In normal condition,if we use sas protocol and hotplug a sata disk on a port,
the sas driver will send event "PORTE_BYTES_DMAED" and call function "sas_porte_bytes_dmaed".
But if a sata disk is run io and unplug it,then plug a new sata disk,this operation may cause
a kernel panic like this:
[ 2366.923208] Unable to handle kernel NULL pointer dereference at virtual address 000007b8
[ 2366.949253] pgd = ffffffc00121d000
[ 2366.971164] [000007b8] *pgd=00000027df893003, *pud=00000027df893003, *pmd=00000027df894003, *pte=006000006d000707
[ 2367.022822] Internal error: Oops: 96000005 [#1] SMP
[ 2367.048490] Modules linked in: dm_mirror(E) dm_region_hash(E) dm_log(E) dm_mod(E) crc32_arm64(E)
aes_ce_blk(E) ablk_helper(E) cryptd(E) aes_ce_cipher(E) ghash_ce(E) sha2_ce(E) sha1_ce(E) ses(E)
enclosure(E) shpchp(E) marvell(E)
[ 2367.144808] CPU: 16 PID: 710 Comm: kworker/16:1 Tainted: G            E   4.1.23-next.aarch64 #1
[ 2367.180161] Hardware name: Huawei Taishan 2280 /BC11SPCC, BIOS 1.28 05/14/2016
[ 2367.213305] Workqueue: events ata_scsi_hotplug
[ 2367.244296] task: ffffffe7db9b5e00 ti: ffffffe7db1a0000 task.ti: ffffffe7db1a0000
[ 2367.279949] PC is at sas_find_dev_by_rphy+0x48/0x118
[ 2367.312045] LR is at sas_find_dev_by_rphy+0x40/0x118
[ 2367.341970] pc : [<ffffffc00065c3b0>] lr : [<ffffffc00065c3a8>] pstate: 00000145
...
[ 2368.766334] Call trace:
[ 2368.781712] [<ffffffc00065c3b0>] sas_find_dev_by_rphy+0x48/0x118
[ 2368.800394] [<ffffffc00065c4a8>] sas_target_alloc+0x28/0x98
[ 2368.817975] [<ffffffc00063e920>] scsi_alloc_target+0x248/0x308
[ 2368.835570] [<ffffffc000640080>] __scsi_add_device+0xb8/0x160
[ 2368.853034] [<ffffffc0006e52d8>] ata_scsi_scan_host+0x190/0x230
[ 2368.871614] [<ffffffc0006e54b0>] ata_scsi_hotplug+0xc8/0xe8
[ 2368.889152] [<ffffffc0000da75c>] process_one_work+0x164/0x438
[ 2368.908003] [<ffffffc0000dab74>] worker_thread+0x144/0x4b0
(Continue reading)

weiyj_lk | 14 Jun 02:26 2016

[PATCH] ata: fix return value check in ahci_seattle_get_port_info()

From: Wei Yongjun <yongjun_wei <at> trendmicro.com.cn>

In case of error, the function devm_kzalloc() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Signed-off-by: Wei Yongjun <yongjun_wei <at> trendmicro.com.cn>
---
 drivers/ata/ahci_seattle.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/ahci_seattle.c b/drivers/ata/ahci_seattle.c
index 6e702ab..1d31c0c 100644
--- a/drivers/ata/ahci_seattle.c
+++ b/drivers/ata/ahci_seattle.c
 <at>  <at>  -137,7 +137,7  <at>  <at>  static const struct ata_port_info *ahci_seattle_get_port_info(
 	u32 val;

 	plat_data = devm_kzalloc(dev, sizeof(*plat_data), GFP_KERNEL);
-	if (IS_ERR(plat_data))
+	if (!plat_data)
 		return &ahci_port_info;

 	plat_data->sgpio_ctrl = devm_ioremap_resource(dev,

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)

Shaun Tancheff | 10 Jun 09:10 2016
Gravatar

[PATCH v3 0/3] Block layer support ZAC/ZBC commands

Hi Jens,

This series is on your for-next branch.

As Host Aware drives are becoming available we would like to be able
to make use of such drives. This series is also intended to be suitable
for use by Host Managed drives.

ZAC/ZBC drives add new commands for discovering and working with Zones.

This extends the ZAC/ZBC support up to the block layer.

Patches for util-linux can be found here:
https://github.com/Seagate/ZDM-Device-Mapper/tree/master/patches/util-linux

Using BIOs to issue ZBC commands allows DM targets (such as ZDM) or
file-systems such as btrfs or nilfs2 to extend their block allocation
schemes and issue discards that are zone aware.

A perhaps non-obvious approach is that a conventional drive will 
returns a descriptor with a single large conventional zone.

The last patch dealing with ata16 passthrough is to workaround HBA SAS 
controllers that don't support ZBC. It will be dropped now that firmware
updates are starting to appear.

V3:
 - Rebase on Mike Cristie's separate bio operations
 - Update blkzoned_api.h to include report zones PARTIAL bit.
 - Use zoned report reserved bit for ata-passthrough flag.
(Continue reading)

Stephan Linz | 10 Jun 07:59 2016
Picon
Gravatar

[PATCH v4 1/7] leds: convert IDE trigger to common disk trigger

This patch converts the IDE specific LED trigger to a generic disk
activity LED trigger. The libata core is now a trigger source just
like before the IDE disk driver. It's merely a replacement of the
string ide by disk.

The patch is taken from http://dev.gentoo.org/~josejx/ata.patch and is
widely used by any ibook/powerbook owners with great satisfaction.
Likewise, it is very often used successfully on different ARM platforms.

Unlike the original patch, the existing 'ide-disk' trigger is still
available for backward compatibility. That reduce the amount of patches
in affected device trees out of the mainline kernel. For further
development, the new name 'disk-activity' should be used.

Cc: Joseph Jezak <josejx <at> gentoo.org>
Cc: Jörg Sommer <joerg <at> alea.gnuu.de>
Cc: Richard Purdie <rpurdie <at> rpsys.net>
Cc: Jacek Anaszewski <j.anaszewski <at> samsung.com>
Signed-off-by: Stephan Linz <linz <at> li-pro.net>
---
Changes in v4:
  - Keep the 'ide-disk' trigger and add a second one
    for 'disk-activity'.

Changes in v3:
  - Port to kernel 4.x
  - Split into platform independent and dependent parts.

v2: https://patchwork.ozlabs.org/patch/117485/
v1: http://dev.gentoo.org/~josejx/ata.patch
(Continue reading)

Shaun Tancheff | 7 Jun 22:02 2016
Gravatar

[PATCH v2 0/4] Block layer support ZAC/ZBC commands

As Host Aware drives are becoming available we would like to be able
to make use of such drives. This series is also intended to be suitable
for use by Host Managed drives.

ZAC/ZBC drives add new commands for discovering and working with Zones.

This extends the ZAC/ZBC support up to the block layer.

Thie first patch in the series is a place-holder for Mike Christi's
separate operations from flags ...
https://lkml.kernel.org/r/1465155145-10812-1-git-send-email-mchristi <at> redhat.com
Once that work is completed the first patch can be dropped.

Patches for util-linux can be found here:
https://github.com/Seagate/ZDM-Device-Mapper/tree/master/patches/util-linux

Using BIOs to issue ZBC commands allows DM targets (such as ZDM) or
file-systems such as btrfs or nilfs2 to extend their block allocation
schemes and issue discards that are zone aware.

A perhaps non-obvious approach is that a conventional drive will 
returns a descriptor with a single large conventional zone.

This patch is also at
https://github.com/stancheff/linux.git
git <at> github.com:stancheff/linux.git
branch: v4.7-rc2+bio.zbc.v2

V2:
 - Changed bi_rw to op_flags clarify sepeartion of bio op from flags.
(Continue reading)

Ben Dooks | 7 Jun 18:49 2016
Picon
Gravatar

[PATCH] ata: sata_mv: fix mis-conversion in mv_write_cached_reg()

Fix the signed issue in mv_write_cached_reg() where the laddr
is assigned from a (long)addr instead of (unsigned long)addr.

Fixes the following warnings:

drivers/ata/sata_mv.c:989:26: warning: cast removes address space of expression
drivers/ata/sata_mv.c:989:26: warning: cast removes address space of expression
drivers/ata/sata_mv.c:989:26: warning: cast removes address space of expression
drivers/ata/sata_mv.c:989:26: warning: cast removes address space of expression

Signed-off-by: Ben Dooks <ben.dooks <at> codethink.co.uk>
---
Cc: Tejun Heo <tj <at> kernel.org>
Cc: linux-ide <at> vger.kernel.org
Cc: linux-arm-kernel <at> lists.infradead.org
---
 drivers/ata/sata_mv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index bd74ee5..745489a 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
 <at>  <at>  -986,7 +986,7  <at>  <at>  static inline void mv_write_cached_reg(void __iomem *addr, u32 *old, u32 new)
 		 * Looks like a lot of fuss, but it avoids an unnecessary
 		 * +1 usec read-after-write delay for unaffected registers.
 		 */
-		laddr = (long)addr & 0xffff;
+		laddr = (unsigned long)addr & 0xffff;
 		if (laddr >= 0x300 && laddr <= 0x33c) {
(Continue reading)

Wei Fang | 7 Jun 08:53 2016

[PATCH v4 1/2] scsi: fix race between simultaneous decrements of ->host_failed

sas_ata_strategy_handler() adds the works of the ata error handler
to system_unbound_wq. This workqueue asynchronously runs work items,
so the ata error handler will be performed concurrently on different
CPUs. In this case, ->host_failed will be decreased simultaneously in
scsi_eh_finish_cmd() on different CPUs, and become abnormal.

It will lead to permanently inequal between ->host_failed and
 ->host_busy, and scsi error handler thread won't become running.
IO errors after that won't be handled forever.

Since all scmds must have been handled in the strategy handle, just
remove the decrement in scsi_eh_finish_cmd() and zero ->host_busy
after the strategy handle to fix this race.

This fixes the problem introduced in
commit 50824d6c5657 ("[SCSI] libsas: async ata-eh").

Reviewed-by: James Bottomley <jejb <at> linux.vnet.ibm.com>
Signed-off-by: Wei Fang <fangwei1 <at> huawei.com>
---
Changes v1->v2:
- update Documentation/scsi/scsi_eh.txt about ->host_failed
Changes v2->v3:
- don't use atomic type, just zero ->host_failed after the strategy handle
Changes v3->v4:
- add new concurrency rules of ->host_failed in scsi_eh.txt

 drivers/ata/libata-eh.c   |    2 +-
 drivers/scsi/scsi_error.c |    4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)
(Continue reading)

Shaun Tancheff | 6 Jun 19:58 2016
Gravatar

[PATCH] Add support for Write Same via SCT

At some point the method of issuing Write Same for ATA drives changed.
Currently write same is commonly available via SCT so expose the SCT
capabilities and use SCT Write Same if available.

This is useful for zoned based media that prefers to support discard
with lbprz set, aka discard zeroes data by mapping discard operations to 
reset write pointer operations. Conventional zones that do not support 
reset write pointer can still honor the discard zeroes data by issuing
a write same over the zone.

Cc: "James E.J. Bottomley" <jejb <at> linux.vnet.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen <at> oracle.com>
Cc: Tejun Heo <tj <at> kernel.org>

Shaun Tancheff (1):
  Add support for SCT Write Same

 drivers/ata/libata-scsi.c  | 32 ++++++++++++++++++++++++++++++++
 drivers/scsi/sd.c          | 21 +++++++++++++--------
 include/linux/ata.h        | 43 +++++++++++++++++++++++++++++++++++++++++++
 include/scsi/scsi_device.h |  1 +
 4 files changed, 89 insertions(+), 8 deletions(-)

--

-- 
2.8.1

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)


Gmane