Re: [PATCH 1/2] crypto: Add new test cases for Blackfin CRC crypto driver.

Acked-by: Mike Frysinger <vapier@...>
-mike

_______________________________________________
Uclinux-dist-devel mailing list
Uclinux-dist-devel@...
https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel

[PATCH] spi: add spi controller master driver for Blackfin 6xx processor

New spi controller is integrated into Blackfin 6xx processor.
Comparing to bf5xx spi controller, we support 32 bits word size
and independent receive and transmit DMA channels now.
Also mode 0 and 2 (CPHA = 0) can get fully supported
becasue cs line may be controlled by the software.
---
 drivers/spi/Kconfig       |    8 +-
 drivers/spi/Makefile      |    1 +
 drivers/spi/spi-bfin6xx.c | 1254 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 1262 insertions(+), 1 deletions(-)
 create mode 100644 drivers/spi/spi-bfin6xx.c

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 00c0240..7c9a235 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
 <at>  <at>  -76,10 +76,16  <at>  <at>  config SPI_ATMEL

 config SPI_BFIN5XX
 	tristate "SPI controller driver for ADI Blackfin5xx"
-	depends on BLACKFIN
+	depends on BLACKFIN && !BF60x
 	help
 	  This is the SPI controller master driver for Blackfin 5xx processor.

+config SPI_BFIN6XX
+	tristate "SPI controller driver for ADI Blackfin6xx"
+	depends on BLACKFIN && BF60x
+	help
+	  This is the SPI controller master driver for Blackfin 6xx processor.

XIP test issue on bf609-ezkit

Hi Stuart,

I am testing a XIP program(file xip_test.c below) on bf609-ezkit. 
After xip_test compiled i use genromfs and write the romfs.img to norflash.

Then in linux kernel:

root:/> mount -t romfs /dev/mtdblock2 /mnt/
root:/> /mnt/xip_test
Code is at 0x040c815c!
root:/>

The result is wrong since norflash range on bf609-ezkit is above 0xb0080000.

Do you have any idea? Thank you.

file xip_test.c:
  1 #include <stdio.h>
  2 
  3 int test_func(void)
  4 {
  5     return 1;
  6 }
  7 
  8 int main(void)
  9 {
 10 #ifdef __BFIN_FDPIC__
 11     int (**pf)(void);
 12 
 13     pf = test_func;

Re: XIP test issue on bf609-ezkit

I've fixed that issue, sorry for the noise.

Regards,
-Bob
________________________________________
From: Liu, Bob
Sent: Tuesday, June 05, 2012 1:27 PM
To: Henderson, Stuart; Zhang, Jie;
uclinux-dist-devel@...; Zhang, Sonic
Subject: XIP test issue on bf609-ezkit

Hi Stuart,

I am testing a XIP program(file xip_test.c below) on bf609-ezkit.
After xip_test compiled i use genromfs and write the romfs.img to norflash.

Then in linux kernel:

root:/> mount -t romfs /dev/mtdblock2 /mnt/
root:/> /mnt/xip_test
Code is at 0x040c815c!
root:/>

The result is wrong since norflash range on bf609-ezkit is above 0xb0080000.

Do you have any idea? Thank you.

file xip_test.c:
  1 #include <stdio.h>
  2

[PATCH 6/8 v2] i2c:i2c-bfin-twi: include twi head file

From: Sonic Zhang <sonic.zhang@...>

TWI bit mask macros are moved to twi head file.
Depend on commit 61c16b5c7414b6d0511dc384e0ea994e250e6339

Signed-off-by: Sonic Zhang <sonic.zhang@...>
Signed-off-by: Bob Liu <lliubbo@...>
---
 drivers/i2c/busses/i2c-bfin-twi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c
index e75ee91..5be1dc2 100644
--- a/drivers/i2c/busses/i2c-bfin-twi.c
+++ b/drivers/i2c/busses/i2c-bfin-twi.c
 <at>  <at>  -25,6 +25,7  <at>  <at> 
 #include <asm/blackfin.h>
 #include <asm/portmux.h>
 #include <asm/irq.h>
+#include <asm/bfin_twi.h>

 /* SMBus mode*/
 #define TWI_I2C_MODE_STANDARD		1
--

-- 
1.7.0.4

[PATCH 1/8 v2] i2c: i2c-bfin-twi: Illegal i2c bus lock upon certain transfer scenarios.

From: Michael Hennerich <michael.hennerich@...>

For transfer counts > 255 bytes i2c-bfin-twi sets the data
transfer counter DCNT to 0xFF indicating unlimited transfers.
It then uses a flag iface->manual_stop to manually issue the STOP
condition, once the required amount of bytes are received.

We found that on I2C receive operation issuing the STOP condition
together with a FULL RCV FIFO (2bytes) will cause SDA and SCL be
constantly driven low.

Temporary workaround until further investigation:
Discard the RCV FIFO before issuing the STOP condition.

Signed-off-by: Michael Hennerich <michael.hennerich@...>
Signed-off-by: Sonic Zhang <sonic.zhang@...>
---
 drivers/i2c/busses/i2c-bfin-twi.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c
index cdb59e5..33031f0 100644
--- a/drivers/i2c/busses/i2c-bfin-twi.c
+++ b/drivers/i2c/busses/i2c-bfin-twi.c
 <at>  <at>  -131,6 +131,10  <at>  <at>  static void bfin_twi_handle_interrupt(struct bfin_twi_iface *iface,
 			iface->transPtr++;
 			iface->readNum--;
 		} else if (iface->manual_stop) {
+			/* Temporary workaround to avoid possible bus stall -
+			 * Flush FIFO before issuing the STOP condition

[PATCH 4/8 v2] i2c: i2c-bfin-twi: Tighten condition when failing I2C transfer if MEN bit is reset unexpectedly.

From: Sonic Zhang <sonic.zhang@...>

In order to mark I2C transfer fail when MEN bit in I2C controller is reset unexpeced
in MCOMP interrupt, interrupt status bits XMTSERV or RCVSERV should be checked.

Master Transfer Complete (MCOMP).
[1] The initiated master transfer has completed. In the absence of a
repeat start, the bus has been released.
[0] The completion of a transfer has not been detected.

Signed-off-by: Sonic Zhang <sonic.zhang@...>
---
 drivers/i2c/busses/i2c-bfin-twi.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c
index a5ab454..2e59bbd 100644
--- a/drivers/i2c/busses/i2c-bfin-twi.c
+++ b/drivers/i2c/busses/i2c-bfin-twi.c
 <at>  <at>  -201,7 +201,8  <at>  <at>  static void bfin_twi_handle_interrupt(struct bfin_twi_iface *iface,
 		return;
 	}
 	if (twi_int_status & MCOMP) {
-		if ((read_MASTER_CTL(iface) & MEN) == 0 &&
+		if (twi_int_status & (XMTSERV|RCVSERV) &&
+			(read_MASTER_CTL(iface) & MEN) == 0 &&
 			(iface->cur_mode == TWI_I2C_MODE_REPEAT ||
 			iface->cur_mode == TWI_I2C_MODE_COMBINED)) {
 			iface->result = -1;
--

-- 

Re: [PATCH 1/2 v2] asoc: add sport driver for bf6xx soc

On Wed, Jun 20, 2012 at 05:00:30PM -0400, Scott Jiang wrote:

Applied, thanks.  There is one minor fixup below - please send an
incremental patch for that.

> The SPORT(Serial Port) module on bf6xx soc has a totally different ip comparing to bf5xx
> soc. An individual SPORT module consists of two independently configurable SPORT halves
> with identical functionality. Each SPORT half can be configured for either transmitter
> or receiver.

Please take more care with the formatting of your changelogs, they
should be wrapped to within 80 columns and the subject line should
correspond to the subsystem style.  I reflowed.

> +static irqreturn_t sport_err_irq(int irq, void *dev_id)
> +{
> +	struct sport_device *sport = dev_id;
> +	struct device *dev = &sport->pdev->dev;
> +
> +	if (sport->tx_regs->spctl & SPORT_CTL_DERRPRI)
> +		dev_dbg(dev, "sport error: TUVF\n");
> +	if (sport->rx_regs->spctl & SPORT_CTL_DERRPRI)
> +		dev_dbg(dev, "sport error: ROVF\n");

These should be dev_err() not dev_dbg() - they're errors.

_______________________________________________
Uclinux-dist-devel mailing list
Uclinux-dist-devel@...