headers
David Miller | 1 Oct 2009 01:44
Favicon

Re: [PATCH] ax25: Fix possible oops in ax25_make_new

From: Jarek Poplawski <jarkao2 <at> gmail.com>
Date: Sun, 27 Sep 2009 22:57:02 +0200

> In ax25_make_new, if kmemdup of digipeat returns an error, there would
> be an oops in sk_free while calling sk_destruct, because sk_protinfo
> is NULL at the moment; move sk->sk_destruct initialization after this.
> 
> BTW of reported-by: Bernard Pidoux F6BVP <f6bvp <at> free.fr>
> 
> Signed-off-by: Jarek Poplawski <jarkao2 <at> gmail.com>

Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Matti Aarnio | 1 Oct 2009 13:58
Favicon

mkiss kernel driver problems

Mostly the mkiss line discipline module seems to work, but..

  mkiss: ax0: crc mode is auto.
  mkiss: ax0: Switchting to crc-smack

that typo (extra 't') is obvious, but I am wondering,
why it has growing error counter:

ax0       Link encap:AMPR AX.25  HWaddr OH2MQK-1
          UP BROADCAST RUNNING NOARP  MTU:512  Metric:1
          RX packets:9325 errors:152 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:10
          RX bytes:622232 (607.6 KiB)  TX bytes:0 (0.0 b)

I am feeding this interface from my own software via pty interface,
where the client side is turned on to KISS line discipline.

My own software is not complaining about incomplete writes,
thus I wonder what the kernel is doing ?  Also my software
is sending on only AX.25 frames that it considers to be valid.

Does anybody remember how the  mkiss.c  is supposed to work?

  73 de Matti, OH2MQK
--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Permalink | Reply | 1 comment |
headers
Matti Aarnio | 1 Oct 2009 16:33
Favicon

Re: mkiss kernel driver problems

On Thu, Oct 01, 2009 at 02:58:09PM +0300, Matti Aarnio wrote:
> Mostly the mkiss line discipline module seems to work, but..
> 
>   mkiss: ax0: crc mode is auto.
>   mkiss: ax0: Switchting to crc-smack
> 
> that typo (extra 't') is obvious, but I am wondering,
> why it has growing error counter:

Aargh..  error rate is near 4/256 - meaning I forgot to KISS encode
the SMACK CRC bytes...  

But this Brown Paper Bag  type "user error" is no excuse for
that kernel typo.

Why do I need to feed AX.25 frames from user program to kernel
with SMACK code variant?  My  aprx  software reads async serial
ports itself, and does all manner of port re-init in case of
for example an USB serial dongle needing it.

To live with kernel AX.25 network, serial ports that are not
attached to kernel with kissattach/mkiss do need to be fed
to kernel.  However the feed method may sometimes write incomplete
frame to kernel, and having 1-(2^-16) change of spotting that
is better than without SMACK -- plain KISS has 0 change of spotting
incomplete frame.

What I really would like is to use socket to feed to kernel
AX.25 packets that I got from somewhere, but somehow it does
look like it is not possible at all.  I would do AX.25 socket
(Continue reading)

Permalink | Reply | 0 comments |
headers
Ken Koster | 4 Oct 2009 00:54
Favicon

Re: soundmodem on OpenWRT on ASUS WL-520gU router with USB audio

On Saturday 26 September 2009 07:39:17 am Curt, WE7U wrote:
> On Sat, 26 Sep 2009, Alan Crosswell wrote:
> 
> > This sounds like a great platform for aprsdigi (http://aprsdigi.sf.net), 
> > aprsd, etc.
> 
> Same for the stuff at wetnet.net!  I don't think he's done a
> soundmodem config there yet.  I believe he told me it was just a
> matter of writing a web config setup for it so that one could bypass
> the soundmodem GUI setup program.

Correct,

I've taken Frank's soundmodem files and am integrating them with the stuff 
on wetnet.net.  My next release (do RSN :-)) will add soundmodem with the
ability to do a manual config but not a web config.  I want to get a new 
release out first to fix the known problems with what is currently up 
there. (aprsd and digi_ned config files and scripts are broken).

Ken, N7IPB

--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Jeremiah | 4 Oct 2009 20:46

Linux NetRom Node Question

Hello all,

I am still working on setting up our RMS to send out NetRom Broadcasts. I have 
added a "dummy" entry into the nrports file for connection outbound from the 
node. I also corrected the entry for the RMS. Running nrattach it comes back 
with "NET/ROM port winl2k bound to device nr0", but it never shows up when I 
run ifconfig. There are no errors in the system logs when I run nrattach. 
Does anyone have an example nrports file they would be willing to share? I'm 
a bit stuck on this because the nr0 interface does not come up and the system 
gives me no errors in /var/log/messages.

Thanks

Jeremiah 
KD7DMP

nrports-------------
# /etc/ax25/nrports
#
# The format of this file is:
#
# name callsign alias paclen description
#
switch  WR7VHF-14       #WINL2k 235     dummy for the RMS
winl2k  WR7VHF-10       WINL2K  235     RMS

nrbroadcast------------
# /etc/ax25/nrbroadcast
#
# The format of this file is:
(Continue reading)

Permalink | Reply | 2 comments |
headers
John Ronan | 4 Oct 2009 21:32
Favicon

Re: Linux NetRom Node Question

Hi,

I don't use netrom as it was causing segfaults at one stage and as no  
one around here uses netrom anymore I stopped.

however just out of curiosity I had a look

firstly
modprobe netrom
then
root <at> ns1:~# cat /etc/ax25/nrports
# /etc/ax25/nrports
#
# The format of this file is:
#
# name callsign alias paclen description
#
netrom  EI7IG-14 #TMRE  235     Switch Port
netnod  EI7IG-1  TMRE   235     Node
root <at> ns1:~# nrattach -i 44.155.6.12 -m 236 netrom
NET/ROM port netrom bound to device nr0
root <at> ns1:~# ifconfig nr0
nr0       Link encap:AMPR NET/ROM  HWaddr EI7IG-14
           inet addr:44.155.6.12  Mask:255.0.0.0
           UP RUNNING NOARP  MTU:236  Metric:1
           RX packets:0 errors:0 dropped:0 overruns:0 frame:0
           TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
           collisions:0 txqueuelen:0
           RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)
(Continue reading)

Permalink | Reply | 1 comment |
headers
Jeremiah | 5 Oct 2009 06:32

Re: Linux NetRom Node Question


Hello,

Thanks for the Reply John.
I have tried just has you showed and I get the "NET/ROM port netrom bound to 
device nr0". But when I if ifconfig nr0 it does not have the node call after 
the HWaddr. 
I'm running OpenSuse 11.1 below is the out put of uname.

Linux wr7vhf-rms 2.6.27.25-0.1-pae #1 SMP 2009-07-01 15:37:09 +0200 i686 i686 
i386 GNU/Linux

That is really the only glitch I'm running into is that the nr0 port neve 
attaches to the call for the node.

Thanks
Jeremiah
KD7DMP

On Sunday 04 October 2009 12:32:21 John Ronan wrote:
> Hi,
>
> I don't use netrom as it was causing segfaults at one stage and as no
> one around here uses netrom anymore I stopped.
>
> however just out of curiosity I had a look
>
> firstly
> modprobe netrom
> then
(Continue reading)

Permalink | Reply | 0 comments |
headers
Curt, WE7U | 10 Oct 2009 20:50
Favicon

Xastir stable release 1.9.6


Xastir stable release 1.9.6 is out.  Fetch it at:

   http://sourceforge.net/projects/xastir/

--

-- 
Curt, WE7U.                         <http://www.eskimo.com/~archer>
    APRS:  Where it's at!                    <http://www.xastir.org>
   Lotto:  A tax on people who are bad at math. - unknown
Windows:  Microsoft's tax on computer illiterates. - WE7U.
The world DOES revolve around me:  I picked the coordinate system!"
--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Roel Kluin | 10 Oct 2009 23:22
Picon
Gravatar

[PATCH] ax25: unsigned cannot be less than 0 in ax25_ctl_ioctl()

struct ax25_ctl_struct member `arg' is unsigned and cannot be less
than 0.

Signed-off-by: Roel Kluin <roel.kluin <at> gmail.com>
---
If the ax25_ctl.arg limit is known to be lower, please suggest
other values.

diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
index f454607..0d99704 100644
--- a/net/ax25/af_ax25.c
+++ b/net/ax25/af_ax25.c
 <at>  <at>  -398,14 +398,14  <at>  <at>  static int ax25_ctl_ioctl(const unsigned int cmd, void __user *arg)
 		break;

 	case AX25_T1:
-		if (ax25_ctl.arg < 1)
+		if (ax25_ctl.arg < 1 || ax25_ctl.arg * HZ > ULONG_MAX)
 			goto einval_put;
 		ax25->rtt = (ax25_ctl.arg * HZ) / 2;
 		ax25->t1  = ax25_ctl.arg * HZ;
 		break;

 	case AX25_T2:
-		if (ax25_ctl.arg < 1)
+		if (ax25_ctl.arg < 1 || ax25_ctl.arg * HZ > ULONG_MAX)
 			goto einval_put;
 		ax25->t2 = ax25_ctl.arg * HZ;
 		break;
 <at>  <at>  -418,13 +418,13  <at>  <at>  static int ax25_ctl_ioctl(const unsigned int cmd, void __user *arg)
(Continue reading)

Permalink | Reply | 7 comments |
headers
walter harms | 12 Oct 2009 17:37
Picon
Favicon

Re: [PATCH] ax25: unsigned cannot be less than 0 in ax25_ctl_ioctl()


what is about something like:

 tmp_arg=ax25_ctl.arg * HZ;

  if (arg == 0 || arg >  ULONG_MAX )
		goto einval_put;

re,
 wh

Roel Kluin schrieb:
> struct ax25_ctl_struct member `arg' is unsigned and cannot be less
> than 0.
> 
> Signed-off-by: Roel Kluin <roel.kluin <at> gmail.com>
> ---
> If the ax25_ctl.arg limit is known to be lower, please suggest
> other values.
> 
> diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
> index f454607..0d99704 100644
> --- a/net/ax25/af_ax25.c
> +++ b/net/ax25/af_ax25.c
>  <at>  <at>  -398,14 +398,14  <at>  <at>  static int ax25_ctl_ioctl(const unsigned int cmd, void __user *arg)
>  		break;
>  
>  	case AX25_T1:
> -		if (ax25_ctl.arg < 1)
> +		if (ax25_ctl.arg < 1 || ax25_ctl.arg * HZ > ULONG_MAX)
(Continue reading)

Permalink | Reply | 6 comments |

Gmane