Ralf Baechle | 2 Jul 20:38 2015

Bpqether broken in 4.1

Eric's Commit 1d5da757da860a6916adbf68b09e868062b4b3b8 (ax25: Stop using
magic neighbour cache operations.) breaks IP traffic over the AX.25 bpqether
driver.

Here's how to reproduce the issue if you don't have an AX.25 setup.  The
arp command is there to fudge things if you don't have a peer that would
answer ARP requests.

# modprobe bpqether
# ifconfig bpq0 hw ax25 abcdef-7 172.20.4.1/24
# arp -H ax25 -s 172.20.4.2 uvwxyz-9
# ping 172.20.4.2

Result in one "Dead loop on virtual device bpq0, fix it urgently!" message
per ping packet.  With the following little debug patch

diff --git a/net/core/dev.c b/net/core/dev.c
index aa82f9a..5fef868 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
 <at>  <at>  -3011,6 +3011,7  <at>  <at>  static int __dev_queue_xmit(struct sk_buff *skb, void *accel_priv)
 recursion_alert:
 			net_crit_ratelimited("Dead loop on virtual device %s, fix it urgently!\n",
 					     dev->name);
+			WARN_ON(1);
 		}
 	}

I get the following backtrace:

(Continue reading)

Sasnett_Karen | 1 Jul 13:53 2015

(unknown)


Haben Sie einen Investor brauchen?

Haben Sie geschäftliche oder persönliche Darlehen benötigen?

Wir geben Darlehen an eine natürliche Person und Unternehmen bei 3% Zinsen jährlich. Weitere
Informationen Kontaktieren Sie uns per E-Mail: omfcreditspa <at> hotmail.com<mailto:omfcreditspa <at> hotmail.com>

HINWEIS: Leiten Sie Ihre Antwort nur an diese E-Mail: omfcreditspa <at> hotmail.com<mailto:omfcreditspa <at> hotmail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

me | 28 Jun 05:04 2015

PTY Improvements for kissattach, kissnetd

This is a re-based patchset for ax25-tools based on commit
18fa7fa6776da35da34a7e148fa2d96be8921e2.  It adds command line options to
kissattach and kissnet to permit two things:

- symbolic linking of pseudo TTYs to consistent names for referencing in
  configuration files.
- changing ownership/mode of pseudo TTYs so that they can be accessed by
  designated users/groups.

These patches have been in successful operation on my APRS digipeater here
in Brisbane.  http://aprs.fi/info/a/VK4MSL-1

--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

'LEUNG CHEUNG' | 21 Jun 19:05 2015
Picon

Hello


I need your assistance to transfer $22,500,000.00 Dollars from Hong Kong 
--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in

Steve | 20 Jun 21:29 2015
Picon

USB Linux Multimeter?

Does anyone have any recent experience with multimeter with a USB
interface, of course with some sort of command line Linux support?

I have a whole bunch of data acquisition uses if something like this exists.
--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in

Ralf Baechle | 19 Jun 00:46 2015

[PATCH] NET: ROSE: Don't dereference NULL neighbour pointer.

A ROSE socket doesn't necessarily always have a neighbour pointer so check
if the neighbour pointer is valid before dereferencing it.

Signed-off-by: Ralf Baechle <ralf <at> linux-mips.org>
Tested-by: Bernard Pidoux <f6bvp <at> free.fr>
Cc: stable <at> vger.kernel.org #2.6.11+

diff --git a/net/rose/af_rose.c b/net/rose/af_rose.c
index 8ae6030..dd304bc 100644
--- a/net/rose/af_rose.c
+++ b/net/rose/af_rose.c
 <at>  <at>  -192,7 +192,8  <at>  <at>  static void rose_kill_by_device(struct net_device *dev)

 		if (rose->device == dev) {
 			rose_disconnect(s, ENETUNREACH, ROSE_OUT_OF_ORDER, 0);
-			rose->neighbour->use--;
+			if (rose->neighbour)
+				rose->neighbour->use--;
 			rose->device = NULL;
 		}
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

f6bvp | 17 Jun 11:12 2015
Picon

Re: kernel crash when device rose set down

Hello Ralf,

This is to publicize the patch you made against an important
bug responsible of kernel panic when seting rose device down..

Bernard

Le 15/06/2015 12:39, f6bvp a écrit :
> Bingo Ralf !
>
> You have found the bug.
>
> 73 de Bernard, f6bvp
>
>
> Le 15/06/2015 03:21, Ralf Baechle a écrit :
>> On Sun, Jun 14, 2015 at 12:06:53AM +0200, f6bvp wrote:
>>
>>> After neutralizing the three lines I could execute command
>>> "ifconfig rose down" without any issue.
>>> I guess the loop ran through the list of possible rose devices
>>> from rose9 to rose0.
>>> -----------------------
>>> [  214.831371] DEBUG: Passed rose_close 131
>>> [  214.831462] DEBUG: Passed rose_device_event 217
>>> [  214.831465] DEBUG: Passed rose_kill_by_device 192
>>> [  214.831467] DEBUG: Passed rose_kill_by_device 192
>>> [  214.831470] DEBUG: Passed rose_kill_by_device 192
>>> [  214.831472] DEBUG: Passed rose_kill_by_device 192
>>> [  214.831474] DEBUG: Passed rose_kill_by_device 192
(Continue reading)

Ralf Baechle DL5RB | 15 Jun 21:16 2015

[PATCH] NET: ROSE: Fix neighbour reference counting issues. signoff

Richard,

I think there's another reference counting issues involving the
rose_neighbour structures' use member which was only a 16 bit integer.
The increment/decrement operations on this element will compile into
single instructions on x86 so will be atomic on uniprocessor systems
but bad things might happen on multiprocessor systems or load/store
architectures or just because GCC feels like it.

Signed-off-by: Ralf Baechle <ralf <at> linux-mips.org>

diff --git a/include/net/rose.h b/include/net/rose.h
index 50811fe..ad163c1 100644
--- a/include/net/rose.h
+++ b/include/net/rose.h
 <at>  <at>  -7,6 +7,7  <at>  <at> 
 #ifndef _ROSE_H
 #define _ROSE_H 

+#include <linux/atomic.h>
 #include <linux/rose.h>
 #include <net/sock.h>

 <at>  <at>  -94,7 +95,7  <at>  <at>  struct rose_neigh {
 	ax25_cb			*ax25;
 	struct net_device		*dev;
 	unsigned short		count;
-	unsigned short		use;
+	atomic_t		use;
 	unsigned int		number;
(Continue reading)

linux-hams@vger.kernel.org | 11 Jun 03:55 2015

Klientskie bazi tel +79133913837 Email: nonen22pp <at> gmail.com ICQ:6288862 Yznaite podrobnee!!!

Klientskie bazi tel +79133913837 Email: nonen22pp <at> gmail.com ICQ:6288862 Yznaite podrobnee!!!
--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Richard Stearn | 9 Jun 14:34 2015
Picon
Picon

Re: [PATCH net-next 1/1] - ROSE device usage count

Hi Bernard

Thank you for confirming the issue and the fix.

Bug raised as:
	https://bugzilla.kernel.org/show_bug.cgi?id=99711

--

-- 
Regards
	Richard

--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Vaishali Thakkar | 6 Jun 06:22 2015
Picon

[PATCH] net: rose: Use mod_timer

Use mod_timer instead of del_timer followed by add_timer to update
the expire field of the active timer.

The semantic patch that performs this transformation is as follows:

 <at> change <at> 
expression e1, e2, e3, e4;
 <at>  <at> 

- del_timer(&e1);
... when != e1 = e3
- e1.expires = e2;
... when != e1 = e4
- add_timer (&e1);
+ mod_timer (&e1, e2);

Signed-off-by: Vaishali Thakkar <vthakkar1994 <at> gmail.com>
---
 net/rose/rose_link.c     | 16 ++++------------
 net/rose/rose_loopback.c |  6 +-----
 net/rose/rose_timer.c    | 30 +++++-------------------------
 3 files changed, 10 insertions(+), 42 deletions(-)

diff --git a/net/rose/rose_link.c b/net/rose/rose_link.c
index e873d7d..a2409bb 100644
--- a/net/rose/rose_link.c
+++ b/net/rose/rose_link.c
 <at>  <at>  -36,26 +36,18  <at>  <at>  static void rose_transmit_restart_request(struct rose_neigh *neigh);

 void rose_start_ftimer(struct rose_neigh *neigh)
(Continue reading)


Gmane