The Journaling Flash File System for Linux

KaiGai Kohei | 2 Jul 16:08

Picon

Re: unused fs/jffs2/acl.c:jffs2_clear_acl()

[JFFS2][XATTR] Fix memory leak in POSIX-ACL support

* jffs2-xattr-v6.2-02-fix-posix_acl-memory-leak.patch

jffs2_clear_acl() which releases acl caches allocated by kmalloc()
was defined but it was never called. Thus, we faced to the risk
of memory leaking.

This patch plugs jffs2_clear_acl() into jffs2_do_clear_inode().
It ensures to release acl cache when inode is cleared.

Signed-off-by: KaiGai Kohei <kaigai <at> ak.jp.nec.com>

Thanks,

KaiGai Kohei wrote:
> David Woodhouse wrote:
> 
>>On Thu, 2006-06-29 at 15:01 +0200, Adrian Bunk wrote:
>>
>>
>>>it might not have been intended that jffs2_clear_acl() in Linus' tree
>>>is unused?
>>
>>
>>I suspect you're right -- thanks for pointing it out.
>>
>>Kaigai-san?
> 
>

(Continue reading)

Adrian Bunk | 6 Jul 22:37

Picon

[2.6 patch] make fs/jffs2/nodelist.c:jffs2_obsolete_node_frag() static

This patch makes the needlessly global jffs2_obsolete_node_frag() 
static.

Signed-off-by: Adrian Bunk <bunk <at> stusta.de>

---

 fs/jffs2/nodelist.c |    6 +++++-
 fs/jffs2/nodelist.h |    1 -
 2 files changed, 5 insertions(+), 2 deletions(-)

--- linux-2.6.17-mm6-full/fs/jffs2/nodelist.h.old	2006-07-06 22:12:01.000000000 +0200
+++ linux-2.6.17-mm6-full/fs/jffs2/nodelist.h	2006-07-06 22:12:08.000000000 +0200
@@ -334,7 +334,6 @@
 struct rb_node *rb_next(struct rb_node *);
 struct rb_node *rb_prev(struct rb_node *);
 void rb_replace_node(struct rb_node *victim, struct rb_node *new, struct rb_root *root);
-void jffs2_obsolete_node_frag(struct jffs2_sb_info *c, struct jffs2_node_frag *this);
 int jffs2_add_full_dnode_to_inode(struct jffs2_sb_info *c, struct jffs2_inode_info *f, struct
jffs2_full_dnode *fn);
 void jffs2_truncate_fragtree (struct jffs2_sb_info *c, struct rb_root *list, uint32_t size);
 int jffs2_add_older_frag_to_fragtree(struct jffs2_sb_info *c, struct jffs2_inode_info *f, struct
jffs2_tmp_dnode_info *tn);
--- linux-2.6.17-mm6-full/fs/jffs2/nodelist.c.old	2006-07-06 22:12:17.000000000 +0200
+++ linux-2.6.17-mm6-full/fs/jffs2/nodelist.c	2006-07-06 22:12:55.000000000 +0200
@@ -21,6 +21,9 @@
 #include <linux/pagemap.h>
 #include "nodelist.h"

+static void jffs2_obsolete_node_frag(struct jffs2_sb_info *c,

(Continue reading)

lba292 | 11 Jul 23:52

Block size

Does jffs2 support block size larger than 4KB?

Thanks,

Lan

_________________________________________________________
This message was sent through the NU ECE webmail gateway.

To unsubscribe from this list: send the line "unsubscribe jffs-dev" in
the body of a message to majordomo <at> axis.com

Josh Boyer | 12 Jul 13:56

Picon

Re: Block size

On Tue, 2006-07-11 at 16:52 -0500, lba292 <at> ece.northwestern.edu wrote:
> Does jffs2 support block size larger than 4KB?

Depends on what you mean by block size.  If you mean eraseblock size,
yes.  If you mean the maximum size of a JFFS2 data node, no.

josh

To unsubscribe from this list: send the line "unsubscribe jffs-dev" in
the body of a message to majordomo <at> axis.com

takis | 21 Jul 13:50

[PATCH] fs: Memory allocation cleanups

From: Panagiotis Issaris <takis <at> issaris.org>

- Remove useless casts from k(m|z)alloc and vmallocs
- One conversion of kmalloc+memset to kzalloc

Signed-off-by: Panagiotis Issaris <takis <at> issaris.org>
---
 fs/autofs4/inode.c      |    4 +---
 fs/befs/btree.c         |    2 +-
 fs/befs/debug.c         |    6 +++---
 fs/binfmt_misc.c        |    2 +-
 fs/binfmt_som.c         |    2 +-
 fs/cifs/cifssmb.c       |    3 +--
 fs/cifs/misc.c          |    8 ++------
 fs/file.c               |    8 ++++----
 fs/jffs/inode-v23.c     |    4 ++--
 fs/jffs/intrep.c        |   14 +++++++-------
 fs/jfs/jfs_dtree.c      |   14 ++++----------
 fs/jfs/jfs_imap.c       |    2 +-
 fs/lockd/svcshare.c     |    3 +--
 fs/nfs/nfs4proc.c       |    2 +-
 fs/reiserfs/xattr_acl.c |    3 +--
 15 files changed, 31 insertions(+), 46 deletions(-)

diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c
index fde78b1..8e40bc1 100644
--- a/fs/autofs4/inode.c
+++ b/fs/autofs4/inode.c
@@ -305,13 +305,11 @@ int autofs4_fill_super(struct super_bloc
 	struct autofs_sb_info *sbi;

(Continue reading)

takis | 21 Jul 16:06

[PATCH 3/4] fs: Removing useless casts

From: Panagiotis Issaris <takis <at> issaris.org>

* Removing useless casts
* Removing useless wrapper
* Conversion from kmalloc+memset to kzalloc

Signed-off-by: Panagiotis Issaris <takis <at> issaris.org>
---
 fs/coda/dir.c               |    2 +-
 fs/ext2/acl.c               |    4 ++--
 fs/ext3/acl.c               |    4 ++--
 fs/ext3/resize.c            |    4 ++--
 fs/hpfs/buffer.c            |    2 +-
 fs/jffs/inode-v23.c         |    8 ++++----
 fs/jffs/intrep.c            |   11 ++++-------
 fs/jffs/jffs_fm.c           |    6 ++----
 fs/jfs/jfs_txnmgr.c         |    4 ++--
 fs/lockd/clntproc.c         |    2 +-
 fs/ncpfs/symlink.c          |    4 ++--
 fs/nfs/delegation.c         |    7 +------
 fs/nfs/inode.c              |    2 +-
 fs/nfs/nfs3proc.c           |    2 +-
 fs/nfs/proc.c               |    2 +-
 fs/ntfs/dir.c               |    5 ++---
 fs/ntfs/inode.c             |    2 +-
 fs/ntfs/mft.c               |    4 ++--
 fs/ntfs/unistr.c            |    4 ++--
 fs/xfs/linux-2.6/xfs_file.c |    2 +-
 fs/xfs/linux-2.6/xfs_iops.c |    4 ++--
 21 files changed, 37 insertions(+), 48 deletions(-)

(Continue reading)

Frederik Deweerdt | 21 Jul 16:37

Picon

Re: [PATCH] fs: Memory allocation cleanups

On Fri, Jul 21, 2006 at 01:50:55PM +0200, takis <at> issaris.org wrote:
> -		dnotify_req = (struct dir_notify_req *) kmalloc(
> -						sizeof(struct dir_notify_req),
> +		dnotify_req = kmalloc(sizeof(struct dir_notify_req),
>  						 GFP_KERNEL);
						^^^^^ 
Should be aligned with the kmalloc?
> -	ext_acl = (reiserfs_acl_header *) kmalloc(sizeof(reiserfs_acl_header) +
> -						  acl->a_count *
> +	ext_acl = kmalloc(sizeof(reiserfs_acl_header) + acl->a_count *
>  						  sizeof(reiserfs_acl_entry),
>  						  GFP_NOFS);
						^^^^^
This should be aligned too, I think.

Regards,
Frederik

Dave Kleikamp | 24 Jul 16:41

Picon

Re: [PATCH] fs: Memory allocation cleanups

On Fri, 2006-07-21 at 13:50 +0200, takis <at> issaris.org wrote:
> From: Panagiotis Issaris <takis <at> issaris.org>
> 
> - Remove useless casts from k(m|z)alloc and vmallocs
> - One conversion of kmalloc+memset to kzalloc
> 
> Signed-off-by: Panagiotis Issaris <takis <at> issaris.org>

Acked-by: Dave Kleikamp <shaggy <at> austin.ibm.com>

The jfs part looks good.

Shaggy
--

-- 
David Kleikamp
IBM Linux Technology Center

Dave Kleikamp | 24 Jul 16:48

Picon

Re: [PATCH 3/4] fs: Removing useless casts

On Fri, 2006-07-21 at 16:06 +0200, takis <at> issaris.org wrote:
> From: Panagiotis Issaris <takis <at> issaris.org>
> 
> * Removing useless casts
> * Removing useless wrapper
> * Conversion from kmalloc+memset to kzalloc
> 
> Signed-off-by: Panagiotis Issaris <takis <at> issaris.org> 

Acked-by: Dave Kleikamp <shaggy <at> austin.ibm.com>

The jfs bit is okay.

Shaggy
--

-- 
David Kleikamp
IBM Linux Technology Center

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Group

gmane.linux.file-systems.jffs.

Project Web Page

The Journaling Flash File System for Linux

Search Archive

Page

1

Articles in period: 9

July 2006

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

[AT91RM9200] further run-time problems (jffs2, Oops in __update_rq_clo (12 Nov 15:45)
jffs2_init_acl_post() can return uninitialized variable (27 Oct 16:18)
[2.6 patch] make jffs2_get_acl() static (24 Oct 18:27)
BUG at mm/filemap.c:1749 (2.6.24, jffs2, unionfs) (19 Oct 08:05)
jffs2 deadlock introduced in linux 2.6.22.5 (30 Aug 20:23)
[PATCH] Prefix each line of multiline printk(KERN_ "foo\nbar") (25 Aug 01:44)
[PATCH 2/4] Fix mainline filesystems to handle ATTR_KILL_ bits correct (20 Aug 22:53)
[PATCH 1/4] VFS: move ATTR_KILL handling from notify_change into helpe (20 Aug 22:53)
[PATCH 0/4] move handling of setuid/gid bits from VFS into individual (20 Aug 22:53)
[PATCH] [270/2many] MAINTAINERS - JOURNALLING FLASH FILE SYSTEM V2 (JF (13 Aug 08:30)
[PATCH 14/25] JFFS2: call attr_kill_to_mode from jffs2_do_setattr (6 Aug 15:54)
[PATCH 01/25] VFS: move attr_kill logic from notify_change into helper (6 Aug 15:54)
[PATCH 00/25] move handling of setuid/gid bits from VFS into individua (6 Aug 15:54)
[PATCH 14/25] JFFS2: call attr_kill_to_mode from jffs2_do_setattr (24 Jul 19:00)
[PATCH 01/25] VFS: move attr_kill logic from notify_change into helper (25 Jul 18:47)
[PATCH 00/25] move handling of setuid/gid bits from VFS into individua (25 Jul 18:47)
[2.6 patch] remove fs/jffs2/ioctl.c (29 Jul 17:02)
[RFC: 2.6 patch] make the *FS_SECURITY options no longer user visible (29 Jul 17:02)
jffs2 statfs issue (19 Jul 12:01)
[1/3] 2.6.22-rc3: known regressions with patches v2 (1 Jun 21:41)
[1/3] 2.6.22-rc3: known regressions with patches v2 (1 Jun 14:21)

Archives

2	November 2007
11	October 2007
7	September 2007
38	August 2007
9	July 2007
2	June 2007
4	May 2007
1	April 2007
2	March 2007
2	February 2007
6	January 2007
19	December 2006
2	November 2006
3	October 2006
4	September 2006
2	August 2006
9	July 2006
6	June 2006
8	May 2006
2	January 2006
6	December 2005
8	November 2005
2	October 2005
9	September 2005
8	August 2005
4	July 2005
10	May 2005
9	April 2005
9	March 2005
10	February 2005
6	January 2005
22	December 2004
12	November 2004
39	October 2004
24	September 2004
6	August 2004
17	July 2004
5	June 2004
28	May 2004
14	April 2004
11	March 2004
12	February 2004
8	December 2003
6	November 2003
22	October 2003
22	September 2003
22	August 2003
9	July 2003
9	June 2003
5	April 2003
13	March 2003
1	January 2002

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template