Felix Oxley | 8 Oct 2005 17:45

[KJ] [PATCH] intrep.c char -> unsigned char


Hi,
IANAKH but I believe you need the following patch.
As suggested on the Kernel Janitors To Do list, I have been searching for 
chars > 127.
I only found this one!

If the fix is correct please, ACK and push upstream.

regards,
Felix

--- fs/jffs/intrep.c.orig	2005-10-08 15:47:13.000000000 +0100
+++ fs/jffs/intrep.c	2005-10-08 16:13:16.000000000 +0100
 <at>  <at>  -1969,7 +1969,7  <at>  <at>  retry:
 		iovec_cnt++;

 		if (JFFS_GET_PAD_BYTES(raw_inode->nsize)) {
-			static char allff[3]={255,255,255};
+			static unsigned char allff[3]={255,255,255};
 			/* Add some extra padding if necessary */
 			node_iovec[iovec_cnt].iov_base = allff;
 			node_iovec[iovec_cnt].iov_len =

Signed-off-by: Felix Oxley <lkml <at> oxley.org>
Attachment (patch-intrep.c-2.6.13): text/x-diff, 428 bytes
_______________________________________________
Kernel-janitors mailing list
(Continue reading)

Jesper Juhl | 13 Oct 2005 21:29
Picon

[PATCH 10/14] Big kfree NULL check cleanup - fs

This is the fs/ part of the big kfree cleanup patch.

Remove pointless checks for NULL prior to calling kfree() in fs/.

Sorry about the long Cc: list, but I wanted to make sure I included everyone
who's code I've changed with this patch.

Signed-off-by: Jesper Juhl <jesper.juhl <at> gmail.com>
---

Please see the initial announcement mail on LKML with subject
"[PATCH 00/14] Big kfree NULL check cleanup"
for additional details.

 fs/9p/trans_sock.c      |    3 -
 fs/affs/super.c         |   16 +++------
 fs/afs/file.c           |    3 -
 fs/autofs/waitq.c       |    6 +--
 fs/autofs4/inode.c      |    6 +--
 fs/autofs4/waitq.c      |    6 +--
 fs/befs/linuxvfs.c      |   12 ++-----
 fs/binfmt_elf.c         |    3 -
 fs/binfmt_elf_fdpic.c   |   15 ++------
 fs/cifs/asn1.c          |    3 -
 fs/cifs/connect.c       |   81 ++++++++++++++++--------------------------------
 fs/cifs/link.c          |   23 ++++---------
 fs/cifs/misc.c          |   15 ++------
 fs/cifs/xattr.c         |   15 ++------
 fs/compat_ioctl.c       |    3 +
 fs/devfs/base.c         |    6 +--
(Continue reading)


Gmane