headers
Nigel Cunningham | 18 Jul 06:14
Picon

Fix missing refrigerator invocation in jffs2.

Hi.

Here's a patch to fix a missing refrigerator call in jffs2.

Regards,

Nigel

Signed-off by: Nigel Cunningham <nigel <at> suspend2.net>

 intrep.c |    3 +++
 1 files changed, 3 insertions(+)
diff -ruNp 235-jffs-intrep.patch-old/fs/jffs/intrep.c 235-jffs-intrep.patch-new/fs/jffs/intrep.c
--- 235-jffs-intrep.patch-old/fs/jffs/intrep.c	2005-07-18 06:36:59.000000000 +1000
+++ 235-jffs-intrep.patch-new/fs/jffs/intrep.c	2005-07-18 14:02:27.000000000 +1000
@@ -3397,6 +3397,9 @@ jffs_garbage_collect_thread(void *ptr)
 			siginfo_t info;
 			unsigned long signr = 0;

+			if (try_to_freeze())
+				continue;
+
 			spin_lock_irq(&current->sighand->siglock);
 			signr = dequeue_signal(current, &current->blocked, &info);
 			spin_unlock_irq(&current->sighand->siglock);

--

-- 
Evolution.
Enumerate the requirements.
Consider the interdependencies.
(Continue reading)

Permalink | Reply | 4 comments |
headers
Jörn Engel | 18 Jul 20:18
Picon

Re: Fix missing refrigerator invocation in jffs2.

On Mon, 18 July 2005 14:14:53 +1000, Nigel Cunningham wrote:
> 
> Here's a patch to fix a missing refrigerator call in jffs2.
                                                           ^
You should shorten the description by one letter, roughly. ;)

> 
> Signed-off by: Nigel Cunningham <nigel <at> suspend2.net>
> 
>  intrep.c |    3 +++
>  1 files changed, 3 insertions(+)
> diff -ruNp 235-jffs-intrep.patch-old/fs/jffs/intrep.c 235-jffs-intrep.patch-new/fs/jffs/intrep.c
> --- 235-jffs-intrep.patch-old/fs/jffs/intrep.c	2005-07-18 06:36:59.000000000 +1000
> +++ 235-jffs-intrep.patch-new/fs/jffs/intrep.c	2005-07-18 14:02:27.000000000 +1000
> @@ -3397,6 +3397,9 @@ jffs_garbage_collect_thread(void *ptr)
>  			siginfo_t info;
>  			unsigned long signr = 0;
>  
> +			if (try_to_freeze())
> +				continue;
> +
>  			spin_lock_irq(&current->sighand->siglock);
>  			signr = dequeue_signal(current, &current->blocked, &info);
>  			spin_unlock_irq(&current->sighand->siglock);
> 
> -- 
> Evolution.
> Enumerate the requirements.
> Consider the interdependencies.
> Calculate the probabilities.
(Continue reading)

Permalink | Reply | 2 comments |
headers
Nigel Cunningham | 19 Jul 14:13
Picon

Re: Fix missing refrigerator invocation in jffs2.

Hi.

On Tue, 2005-07-19 at 04:18, Jörn Engel wrote:
> On Mon, 18 July 2005 14:14:53 +1000, Nigel Cunningham wrote:
> > 
> > Here's a patch to fix a missing refrigerator call in jffs2.
>                                                            ^
> You should shorten the description by one letter, roughly. ;)

Oh oops! Sorry!

Nigel

> > 
> > Signed-off by: Nigel Cunningham <nigel <at> suspend2.net>
> > 
> >  intrep.c |    3 +++
> >  1 files changed, 3 insertions(+)
> > diff -ruNp 235-jffs-intrep.patch-old/fs/jffs/intrep.c 235-jffs-intrep.patch-new/fs/jffs/intrep.c
> > --- 235-jffs-intrep.patch-old/fs/jffs/intrep.c	2005-07-18 06:36:59.000000000 +1000
> > +++ 235-jffs-intrep.patch-new/fs/jffs/intrep.c	2005-07-18 14:02:27.000000000 +1000
> > @@ -3397,6 +3397,9 @@ jffs_garbage_collect_thread(void *ptr)
> >  			siginfo_t info;
> >  			unsigned long signr = 0;
> >  
> > +			if (try_to_freeze())
> > +				continue;
> > +
> >  			spin_lock_irq(&current->sighand->siglock);
> >  			signr = dequeue_signal(current, &current->blocked, &info);
(Continue reading)

Permalink | Reply | 0 comments |
headers
Adrian Bunk | 31 Jul 19:00
Picon
Favicon

[2.6 patch] jffs/jffs2: remove wrong function prototypes

This patch removes prototypes for the generic_file_open and 
generic_file_llseek functions.

Besides being superfluous because they are already present in fs.h, they 
were also wrong because the actual functions aren't weak functions.

Signed-off-by: Adrian Bunk <bunk <at> stusta.de>

---

 fs/jffs/inode-v23.c |    3 ---
 fs/jffs2/file.c     |    3 ---
 2 files changed, 6 deletions(-)

--- linux-2.6.13-rc4-mm1-full/fs/jffs/inode-v23.c.old	2005-07-31 18:43:46.000000000 +0200
+++ linux-2.6.13-rc4-mm1-full/fs/jffs/inode-v23.c	2005-07-31 18:44:15.000000000 +0200
@@ -1629,9 +1629,6 @@
 }

 
-extern int generic_file_open(struct inode *, struct file *) __attribute__((weak));
-extern loff_t generic_file_llseek(struct file *, loff_t, int) __attribute__((weak));
-
 static struct file_operations jffs_file_operations =
 {
 	.open		= generic_file_open,
--- linux-2.6.13-rc4-mm1-full/fs/jffs2/file.c.old	2005-07-31 18:44:31.000000000 +0200
+++ linux-2.6.13-rc4-mm1-full/fs/jffs2/file.c	2005-07-31 18:44:40.000000000 +0200
@@ -21,9 +21,6 @@
 #include <linux/jffs2.h>
(Continue reading)

Permalink | Reply | 0 comments |

Gmane