Linux in-kernel CIFS client for attaching to Samba or Windows servers

Steve French | 1 Apr 2009 07:34

Picon

Re: endianness of uniqueid value in, FILE_UNIX_BASIC_INFO

As requested, updated cifs-2.6.git with patch which converts all
"UniqueId" fields (on the wire) to le64 and adds conversion
le64_to_cpu
Seems reasonable that we had to fix it - if a big endian client backs
up a file which it thinks is one inode number, this should match what
the server thinks the inode number is. Let me know if you notice
anything else that needs to be changed there.

--

-- 
Thanks,

Steve

Igor Mammedov | 1 Apr 2009 16:02

Picon

[PATCH 2/3] [CIFS] Remote DFS root support. Try 2, fixed

Jeff Layton wrote:
> On Tue, 17 Mar 2009 19:41:15 +0300
> Igor Mammedov <niallain <at> gmail.com> wrote:
> 
> Sorry for the delay in reviewing this.
> 
>> Subject: [PATCH 2/3] [CIFS] Remote DFS root support.
>>
>>  Allows to mount share on a server that returns -EREMOTE
>>  at the tree connect stage or at the check on a full path
>>  accessibility.
>>
>> Signed-off-by: Igor Mammedov <niallain <at> gmail.com>
>> ---
>>  fs/cifs/connect.c |  159 ++++++++++++++++++++++++++++++++++++++++++-----------
>>  1 files changed, 127 insertions(+), 32 deletions(-)
>>
>> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
>> index cd4ccc8..abe54d2 100644
>> --- a/fs/cifs/connect.c
>> +++ b/fs/cifs/connect.c
>>  <at>  <at>  -2214,9 +2214,63  <at>  <at>  is_path_accessible(int xid, struct cifsTconInfo *tcon,
>>  	return rc;
>>  }
>>  
>> +static void
>> +cleanup_volume_info(struct smb_vol **pvolume_info)
>> +{
>> +	struct smb_vol *volume_info;
>> +

(Continue reading)

Igor Mammedov | 1 Apr 2009 16:06

Picon

[PATCH 2/3] [CIFS] Remote DFS root support. Try 2, fixed

Sorry, I'm forgot to attach a patch.

Jeff Layton wrote:
> > On Tue, 17 Mar 2009 19:41:15 +0300
> > Igor Mammedov <niallain <at> gmail.com> wrote:
> > 
> > Sorry for the delay in reviewing this.
> > 
>> >> Subject: [PATCH 2/3] [CIFS] Remote DFS root support.
>> >>
>> >>  Allows to mount share on a server that returns -EREMOTE
>> >>  at the tree connect stage or at the check on a full path
>> >>  accessibility.
>> >>
>> >> Signed-off-by: Igor Mammedov <niallain <at> gmail.com>
>> >> ---
>> >>  fs/cifs/connect.c |  159 ++++++++++++++++++++++++++++++++++++++++++-----------
>> >>  1 files changed, 127 insertions(+), 32 deletions(-)
>> >>
>> >> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
>> >> index cd4ccc8..abe54d2 100644
>> >> --- a/fs/cifs/connect.c
>> >> +++ b/fs/cifs/connect.c
>> >>  <at>  <at>  -2214,9 +2214,63  <at>  <at>  is_path_accessible(int xid, struct cifsTconInfo *tcon,
>> >>  	return rc;
>> >>  }
>> >>  
>> >> +static void
>> >> +cleanup_volume_info(struct smb_vol **pvolume_info)
>> >> +{

(Continue reading)

Shirish Pargaonkar | 1 Apr 2009 21:33

Picon

Re: [linux-cifs-client][patch] utilize lookup intents to open in lookup

On Tue, Mar 31, 2009 at 11:57 AM, Shirish Pargaonkar
<shirishpargaonkar <at> gmail.com> wrote:
> Hi,
>
> Patch to expolint lookup intents in cifs lookup during open, thus
> reducing network traffick and speedier opens
> Have also converted a semphore to mutex as per Jeff Layton's comments.
>
> Trong, Al, your feedback is really appreciated.
>
> Regards,
>
> Shirish
>

Forgot to take out two debug lines.  Did test this patch while
creating regular files, directories, symbolic links,
exclusive create against older and newer version of samba and so far it works.

Regards,

Shirish

Attachment (li.5.patch): application/octet-stream, 10 KiB

Jeff Layton | 1 Apr 2009 21:38

Picon

Re: [PATCH 2/3] [CIFS] Remote DFS root support. Try 2, fixed

On Wed, 01 Apr 2009 18:06:58 +0400
Igor Mammedov <niallain <at> gmail.com> wrote:

> >From 44c0a1740dd9f22f861152b0a17e637ee301362e Mon Sep 17 00:00:00 2001  
> From: Igor Mammedov <niallain <at> gmail.com>
> Date: Wed, 1 Apr 2009 17:54:42 +0400
> Subject: [PATCH 2/3] [CIFS] Remote DFS root support.
> 
> Allows to mount share on a server that returns -EREMOTE
>  at the tree connect stage or at the check on a full path
>  accessibility.
> 
> Signed-off-by: Igor Mammedov <niallain <at> gmail.com>
> ---
>  fs/cifs/connect.c |  152 +++++++++++++++++++++++++++++++++++++++++-----------
>  1 files changed, 120 insertions(+), 32 deletions(-)
> 
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index b173b01..7f3b6c2 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
>  <at>  <at>  -2214,9 +2214,56  <at>  <at>  is_path_accessible(int xid, struct cifsTconInfo *tcon,
>  	return rc;
>  }
>  
> +static void
> +cleanup_volume_info(struct smb_vol **pvolume_info)
> +{
> +	struct smb_vol *volume_info;
> +

(Continue reading)

Steve French | 2 Apr 2009 06:22

Picon

Re: [PATCH 3/3] [CIFS] Enable dfs submounts to handle remote referrals.

I merged your updated patch 2 (patch 1 was merged earlier), but was
not clear in the following patch (patch 3) why we no longer need to
check flags for DFSREF_STORAGE_SERVER, are other types (both
DFSREF_REFERRAL_SERVER and DFSREF_TARGET_FAILBACK) now ok and do not
require special handling (I wasn't sure about what TARGET_FAILBACK
does).

On Fri, Mar 27, 2009 at 11:43 AM, Jeff Layton <jlayton <at> redhat.com> wrote:
> On Tue, 17 Mar 2009 19:44:32 +0300
> Igor Mammedov <niallain <at> gmail.com> wrote:
>
>> From 73352e0f001d32812f9b18ae85aec35026b7a194 Mon Sep 17 00:00:00 2001
>> From: Igor Mammedov <niallain <at> gmail.com>
>> Date: Tue, 17 Mar 2009 19:00:30 +0300
>> Subject: [PATCH 3/3] [CIFS] Enable dfs submounts to handle remote referrals.
>>
>> Having remote dfs root support in cifs_mount, we can
>> afford to pass into it UNC that is remote.
>>
>> Signed-off-by: Igor Mammedov <niallain <at> gmail.com>
>> ---
>>  fs/cifs/cifs_dfs_ref.c |   32 ++++++++++++++------------------
>>  1 files changed, 14 insertions(+), 18 deletions(-)
>>
>> diff --git a/fs/cifs/cifs_dfs_ref.c b/fs/cifs/cifs_dfs_ref.c
>> index 5fdbf8a..896b08f 100644
>> --- a/fs/cifs/cifs_dfs_ref.c
>> +++ b/fs/cifs/cifs_dfs_ref.c
>>  <at>  <at>  -341,27 +341,23  <at>  <at>  cifs_dfs_follow_mountpoint(struct dentry *dentry, struct nameidata *nd)
>>

(Continue reading)

Jeff Layton | 2 Apr 2009 17:32

Picon

[PATCH] cifs: make cifs_writepages use longer timeout

We've had a lot of changes to the socket sending and buffered write code
in recent months and I've just noticed some breakage due to it. The
"bigfile2" connectathon test does writes at 2G and 4G offsets in a file.
When running this test against a windows server, this is timing out
after 45s and throwing a -EAGAIN error back to userspace.

The following patch "fixes" it, but I'm not entirely thrilled with it.
It would be nice to detect that we are writing past the EOF and only
increase the timeout in that situation. The problem is that by the time
we're writing back pages i_size has already been updated.

Signed-off-by: Jeff Layton <jlayton <at> redhat.com>
---
 fs/cifs/file.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 81747ac..e86e7b5 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
 <at>  <at>  -1532,7 +1532,7  <at>  <at>  retry:
 						   open_file->netfid,
 						   bytes_to_write, offset,
 						   &bytes_written, iov, n_iov,
-						   CIFS_LONG_OP);
+						   CIFS_VLONG_OP);
 				atomic_dec(&open_file->wrtPending);
 				if (rc || bytes_written < bytes_to_write) {
 					cERROR(1, ("Write2 ret %d, wrote %d",
--

--

(Continue reading)

Snefru | 2 Apr 2009 18:04

Samba4 client question


Hello,

Question regarding samba4.  Outside of the howto file in the root of the
samba-4.0.0alpha7 tarball I found little to no samba4 documentation.

At this time it appears the only samab4 client command is smbclient.  Does
anyone know when smbmount/mount.cifs will be available in samba4?

Thanks

--

-- 
View this message in context: http://www.nabble.com/Samba4-client-question-tp22850651p22850651.html
Sent from the Samba - linux-cifs-client mailing list archive at Nabble.com.

Igor Mammedov | 2 Apr 2009 18:10

Picon

Re: [PATCH 3/3] [CIFS] Enable dfs submounts to handle remote referrals.

Steve French wrote:
> I merged your updated patch 2 (patch 1 was merged earlier), but was
> not clear in the following patch (patch 3) why we no longer need to
> check flags for DFSREF_STORAGE_SERVER, are other types (both
> DFSREF_REFERRAL_SERVER and DFSREF_TARGET_FAILBACK) now ok and do not
> require special handling (I wasn't sure about what TARGET_FAILBACK
> does).

Now cifs supports only V3 style referrals only and by ms docs
TARGET_FAILBACK should be ignored by a client except for V4 referrals.

So we could ignore it for a while till we decide to add support for
V4 referrals.

> 
> On Fri, Mar 27, 2009 at 11:43 AM, Jeff Layton <jlayton <at> redhat.com> wrote:
>> On Tue, 17 Mar 2009 19:44:32 +0300
>> Igor Mammedov <niallain <at> gmail.com> wrote:
>>
>>> From 73352e0f001d32812f9b18ae85aec35026b7a194 Mon Sep 17 00:00:00 2001
>>> From: Igor Mammedov <niallain <at> gmail.com>
>>> Date: Tue, 17 Mar 2009 19:00:30 +0300
>>> Subject: [PATCH 3/3] [CIFS] Enable dfs submounts to handle remote referrals.
>>>
>>> Having remote dfs root support in cifs_mount, we can
>>> afford to pass into it UNC that is remote.
>>>
>>> Signed-off-by: Igor Mammedov <niallain <at> gmail.com>
>>> ---
>>>  fs/cifs/cifs_dfs_ref.c |   32 ++++++++++++++------------------

(Continue reading)

Steve French | 2 Apr 2009 20:15

Picon

Re: [PATCH] cifs: make cifs_writepages use longer timeout

When file is extended in write we could save the (previous) offset in
cifs_file struct ...?  And then increase the saved offset to match the
last write (past previous end of file).   Whenever we attempt a write
more than a few megabytes past the saved range, we can use long op?
Thoughts?

On Thu, Apr 2, 2009 at 10:32 AM, Jeff Layton <jlayton <at> redhat.com> wrote:
> We've had a lot of changes to the socket sending and buffered write code
> in recent months and I've just noticed some breakage due to it. The
> "bigfile2" connectathon test does writes at 2G and 4G offsets in a file.
> When running this test against a windows server, this is timing out
> after 45s and throwing a -EAGAIN error back to userspace.
>
> The following patch "fixes" it, but I'm not entirely thrilled with it.
> It would be nice to detect that we are writing past the EOF and only
> increase the timeout in that situation. The problem is that by the time
> we're writing back pages i_size has already been updated.
>
> Signed-off-by: Jeff Layton <jlayton <at> redhat.com>
> ---
>  fs/cifs/file.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> index 81747ac..e86e7b5 100644
> --- a/fs/cifs/file.c
> +++ b/fs/cifs/file.c
>  <at>  <at>  -1532,7 +1532,7  <at>  <at>  retry:
>                                                   open_file->netfid,
>                                                   bytes_to_write, offset,

(Continue reading)

Group

gmane.linux.file-systems.cifs.

Advertisement

Project Web Page

Linux in-kernel CIFS client for attaching to Samba or Windows servers

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 35

Articles in period: 348

April 2009

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

problems with signing and new crypto code (17 Jun 2011)
can someone please explain the performance difference between mount.ci (27 Jan 2011)
[PATCH 0/4] cifs: CONFIG_CIFS_EXPERIMENTAL removal (7 Dec 2010)
REMINDER: the old linux-cifs-client list is now deprecated (19 Jun 2010)
[PATCH] cifs: remove bogus first_time check in NTLMv2 session setup co (16 Jun 2010)
REMINDER: linux-cifs-client@lists.samba.org is moving to linux-cifs@vg (12 Jun 2010)
[PATCH] cifs: hard mount option behaviour (8 Jun 2010)
Question about fsid. (5 Jun 2010)
linux-cifs-client@lists.samba.org is moving to linux-cifs@vger.kernel. (5 Jun 2010)
test email of forwarding to new list (5 Jun 2010)
[PATCH] accept all supported values for dir_mode (3 Jun 2010)
[PATCH 0/8] cifs: patches for 2.6.35 (1 Jun 2010)
Multiple mounts on same mount points (31 May 2010)
[PATCH] mount.cifs: fix parsing of "cred=" option (30 May 2010)
[PATCH] cifs: don't ignore cifs_posix_open_inode_helper return value (28 May 2010)
Some issues. (27 May 2010)
linux-cifs-client Digest, Vol 78, Issue 17 (11 May 2010)
Slow CIFS navigation due to excessive use of QUERY_PATH_INFO (1 Apr 2010)
Cifs mount hangs from time to time (12 Apr 2010)
Slow CIFS navigation due to excessive use of QUERY_PATH_INFO (24 Mar 2010)
Slow CIFS navigation due to excessive use of QUERY_PATH_INFO (1 Mar 2010)

Archives

2	June 2011
1	February 2011
2	January 2011
6	December 2010
30	June 2010
155	May 2010
198	April 2010
144	March 2010
34	February 2010
69	January 2010
34	December 2009
27	November 2009
84	October 2009
98	September 2009
129	August 2009
107	July 2009
144	June 2009
222	May 2009
333	April 2009
113	March 2009
139	February 2009
99	January 2009
121	December 2008
146	November 2008
155	October 2008
123	September 2008
188	August 2008
118	July 2008
45	June 2008
145	May 2008
86	April 2008
119	March 2008
59	February 2008
89	January 2008
43	December 2007
146	November 2007
84	October 2007
81	September 2007
87	August 2007
54	July 2007
55	June 2007
63	May 2007
40	April 2007
130	March 2007
60	February 2007
42	January 2007
54	December 2006
36	November 2006
53	October 2006
48	September 2006
32	August 2006
45	July 2006
33	June 2006
61	May 2006
38	April 2006
46	March 2006
29	February 2006
36	January 2006
34	December 2005
55	November 2005
56	October 2005
21	September 2005
49	August 2005
26	July 2005
33	June 2005
59	May 2005
65	April 2005
42	March 2005
28	February 2005
30	January 2005
114	December 2004
47	November 2004
73	October 2004
23	September 2004
78	August 2004
35	July 2004
35	June 2004
60	May 2004
38	April 2004
44	March 2004
29	February 2004
26	January 2004
24	December 2003
1	January 1998

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template