headers
Adrian Bunk | 1 Jan 2008 14:46

[2.6 patch] CIFS: #if 0 mode_to_access_flags()

This patch #if 0's the unused mode_to_access_flags(), fixing the 
following compile warning:

<--  snip  -->

...
  CC      fs/cifs/cifsacl.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/cifs/cifsacl.c:200: warning:
‘mode_to_access_flags’ defined but not used
...

<--  snip  -->

Signed-off-by: Adrian Bunk <bunk <at> kernel.org>

---

 fs/cifs/cifsacl.c |    2 ++
 1 file changed, 2 insertions(+)

0cf530f754b974ee5e58b3346828bb5586440c92 
diff --git a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c
index c312adc..771a22f 100644
--- a/fs/cifs/cifsacl.c
+++ b/fs/cifs/cifsacl.c
 <at>  <at>  -189,6 +189,7  <at>  <at>  static void access_flags_to_mode(__le32 ace_flags, int type, umode_t *pmode,
 	return;
 }

+#if 0
(Continue reading)

Permalink | Reply | 4 comments |
headers
Christoph Hellwig | 1 Jan 2008 19:10
Favicon

Re: [2.6 patch] CIFS: #if 0 mode_to_access_flags()

On Tue, Jan 01, 2008 at 03:46:44PM +0200, Adrian Bunk wrote:
> This patch #if 0's the unused mode_to_access_flags(), fixing the 
> following compile warning:

Please remove it completely instead.
Permalink | Reply | 2 comments |
headers
Steve French | 2 Jan 2008 00:46
Picon
Gravatar

Re: [2.6 patch] CIFS: #if 0 mode_to_access_flags()

The cifsacl code which uses that function was not ready in time for
2.6.24 but is in the cifs development tree now..

On Jan 1, 2008 12:10 PM, Christoph Hellwig <hch <at> infradead.org> wrote:
> On Tue, Jan 01, 2008 at 03:46:44PM +0200, Adrian Bunk wrote:
> > This patch #if 0's the unused mode_to_access_flags(), fixing the
> > following compile warning:
>
> Please remove it completely instead.
>

--

-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Permalink | Reply | 0 comments |
headers
Stefan Rijnhart | 2 Jan 2008 12:27
Picon
Favicon

Acls and cifs mounted shares

Hi,

Recently, we have tried to get started with acls on our cifs mounted 
shares, but permissions do not seem to be honoured yet on a stock Debian 
server and Ubuntu (Feisty) clients, although acls can be inspected using 
getfacl when running with CONFIG_CIFS_XATTR=y and CONFIG_CIFS_POSIX=y on 
the client.

There seems to be a lot of activity in the cifs development team with 
respect to acls. Does this mean that we can look forward to functional 
acl permissions in a recent or forthcoming kernel?

Regards,
Stefan.
Permalink | Reply | 0 comments |
headers
Jeff Layton | 2 Jan 2008 14:53
Picon
Favicon

Re: [PATCH] [CIFS] only use krb5 session key from first SMB session on socket

On Sun, 30 Dec 2007 22:27:45 -0600
"Steve French" <smfrench <at> gmail.com> wrote:

> Has anyone tried the same scenario with ntlmv2 to see if that has a
> similar problem?
> 

sec=ntlmv2i does seem to have a similar problem, at least when talking
to win2k3. I did a couple of quick stabs at a patch to fix it, but
neither seemed to work. When I get some more time, I'll have a closer
look and see if I can figure out what's supposed to happen in this
case...

--

-- 
Jeff Layton <jlayton <at> redhat.com>
Permalink | Reply | 0 comments |
headers
Jeff Layton | 2 Jan 2008 15:00
Picon
Favicon

Re: [Fwd: latest patches...]

On Mon, 31 Dec 2007 10:48:01 -0500
Jeff Layton <jlayton <at> redhat.com> wrote:

> On Sun, 30 Dec 2007 22:00:18 -0600
> "Steve French" <smfrench <at> gmail.com> wrote:
> 
> > Jeff,
> > On patch 3, I was questioning whether cifs_setup_session could be
> > racing with another thread since the check for session disconnected
> > is outside of the down(sesSesm)  (which is held in the reconnect
> > code in cifssmb.c)
> > 
> > Probably fine though - have checked this in and patch 4 and patch 2
> > (so far).  On patch 2, I am wondering whether we need the same kind
> > of fix for NTLMv2 though - the code in sess.c around line 490 looks
> > wrong (see below):
> > 
> 
> Thanks. I wasn't sure whether the state was really protected by the
> sesSem, but if it is then we should probably hold it when testing it.
> I'll roll up and test a patch to make sure we hold the sem when
> testing the var when I get some time. You're probably right that it's
> an unlikely race, but those can be the most maddening to catch
> sometimes ;-)
> 

Here's a patch to fix up the earlier patch. This makes it so that we
hold the sesSem when checking the status of the existing connection. We
might as well go ahead and patch up this potential race now than wait
until someone hits it.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Steve French (smfltc | 4 Jan 2008 19:23
Picon
Favicon

Re: Acls and cifs mounted shares

> There seems to be a lot of activity in the cifs development team with
> respect to acls. Does this mean that we can look forward to functional
> acl permissions in a recent or forthcoming kernel?

Yes.  2.6.24 will have support for returning a more accurate mode for a file on a cifs mount based on its cifs
ACL.  This requires mounting with the new "cifsacl" mount option and it requires that the Linux cifs module
be configured/built with CONFIG_CIFS_EXPERIMENTAL.  This is not needed for Samba and other servers
which support the CIFS Unix extensions to the protocol since they already support returning the mode of a
file from the server (and they also support getting and setting POSIX ACLs).

The current cifs development tree (which is also picked up by -mm) includes code to allow users to change the
mode of a file via changing the cifs ACL (when mounted with the "cifsacl" mount option), but additional
testing is needed on that before it will be ready to merge into mainline.

The next step is to allow getting and changing the CIFS ACL directly - today that can be done via the samba
client utility "smbcacls" for example but it may be helpful to allow changes to CIFS/NTFS/NFSv4 ACLs
(which are similar) from a tool like setfacl so that CIFS and NFS and NTFS modules can use similar tool on the
client.   Andreas Gruenbacher has had some proposals for this (e.g. see http://www.suse.de/~agruen/agruen-nfs4acl.pdf)

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Suresh Jayaraman | 7 Jan 2008 16:37
Picon

[PATCH 0/2]: Introduction: Helper utilities for CIFS VFS client

This patchset provides utilities to configure/display cifs proc settings
and display cifs Debug information and Statistics.

There are two patches:

[PATCH 1/2]: Utility program that allows configuration of cifs client
settings
[PATCH 2/2]: Utility program to dump cifs Debug data and Statistics

This can be considered for inclusion along with mount.cifs helper and
others. I have done some amount of testing and it works without issues.

TODO
----
* Man page for cifsconfig and cifsinfo.

Comments welcome!

Thanks,

--

-- 
Suresh Jayaraman
Permalink | Reply | 3 comments |
headers
Suresh Jayaraman | 7 Jan 2008 16:38
Picon

[PATCH 1/2]: Utility program that allows configuration of cifs client settings

This patch provides a utility program that allows configuration 
of cifs VFS client settings using the /proc interface.

Signed-off-by: Suresh Jayaraman <sjayaraman <at> suse.de>
---

/*
 * cifsconfig.c - Simple program that allows run-time cifs configuration using
 * the proc interface
 *
 * Copyright (C) 2008 Suresh Jayaraman (sjayaraman <at> suse.de)
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 */

#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Suresh Jayaraman | 7 Jan 2008 16:39
Picon

[PATCH 2/2]: Utility program to dump cifs Debug data and Statistics

This patch provides a utility program that allows to display
cifs debug data (active sessions and shares) and statistics
that are available in /proc/fs/cifs.

Signed-off-by: Suresh Jayaraman <sjayaraman <at> suse.de>
---

/*
 * cifsinfo.c - Dump cifs statistics from /proc/fs/cifs.
 *
 * Copyright (C) 2008 Suresh Jayaraman (sjayaraman <at> suse.de)
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 */

#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
(Continue reading)

Permalink | Reply | 0 comments |

Gmane