Re: cifs and kthread_run / kernel_thread

>Hi all,
>
>I would like to use cifs inside linux-vserver guests. Discussion this with the 
>vserver people, we found that cifs is using the new kthread_run and the old 
>kernel_thread interface for starting kernel-threads. The old-style interface 
>renders cifs unusable inside a vserver-guest 
>
>My questions:
>
>i) Are there newer versions of cifs, where only kthread_run is used in all 
>places?
>
>  
>
No - IIRC the original patch (for the switch of cifs from kernel_thread 
to kthread) had a
minor implementation problem in handling the cifs_demultiplex thread, so 
this one small
area was left with the old style.

>iii) Is it difficult to switch to the new interface?
>  
>
No, I don't think so, but I have not investigated it.  We would be happy
to review and test a patch for this though.

>gs cifs # grep kthread_run *.[ch]
>cifsfs.c:       oplockThread = kthread_run(cifs_oplock_thread, 
>NULL, "cifsoplockd");

Re: Re: cifs and kthread_run / kernel_thread

Steve French (smfltc) wrote:
> 
>> Hi all,
>>
>> I would like to use cifs inside linux-vserver guests. Discussion this 
>> with the vserver people, we found that cifs is using the new 
>> kthread_run and the old kernel_thread interface for starting 
>> kernel-threads. The old-style interface renders cifs unusable inside a 
>> vserver-guest 
>>
>> My questions:
>>
>> i) Are there newer versions of cifs, where only kthread_run is used in 
>> all places?
>>
>>  
>>
> No - IIRC the original patch (for the switch of cifs from kernel_thread 
> to kthread) had a
> minor implementation problem in handling the cifs_demultiplex thread, so 
> this one small
> area was left with the old style.
> 
>> iii) Is it difficult to switch to the new interface?
>>  
>>
> No, I don't think so, but I have not investigated it.  We would be happy
> to review and test a patch for this though.
> 
>> gs cifs # grep kthread_run *.[ch]

Re: Re: cifs and kthread_run / kernel_thread

Hi Steve, hi Igor,

Am Montag, 2. April 2007 schrieb Q (Igor Mammedov):
> >
> > No - IIRC the original patch (for the switch of cifs from kernel_thread
> > to kthread) had a
> > minor implementation problem in handling the cifs_demultiplex thread, so
> > this one small
> > area was left with the old style.

can you remember what the problems (if any) were with this patch from Igor?

>
> It seems to me that I rewrote cifs_demultiplex_thread to use kthread_run
> in DFS patch.

o.k., I found the patch on the list. Will do some testing with it.

-
Wilhelm

Re: Re: cifs and kthread_run / kernel_thread

Q (Igor Mammedov) wrote:

> Steve French (smfltc) wrote:
>
>> No - IIRC the original patch (for the switch of cifs from 
>> kernel_thread to kthread) had a
>> minor implementation problem in handling the cifs_demultiplex thread, 
>> so this one small
>> area was left with the old style.
>>
>>> iii) Is it difficult to switch to the new interface?
>>>  
>>>
>> No, I don't think so, but I have not investigated it.  We would be happy
>> to review and test a patch for this though.
>>
>>> ***************************
>>
>
> It seems to me that I rewrote cifs_demultiplex_thread to use 
> kthread_run in DFS patch.
>
Yes - Q's  patch has the final change to kthread (as part of a larger 
DFS change).  The original
patch which switched to kthread was done long before this.

I have not broken all the large dfs patch into small pieces but will 
look to see if just this part
can be done easily

Re: Re: cifs and kthread_run / kernel_thread

Am Montag, 2. April 2007 schrieb Wilhelm Meier:
>
> > It seems to me that I rewrote cifs_demultiplex_thread to use kthread_run
> > in DFS patch.
>
> o.k., I found the patch on the list. Will do some testing with it.

o.k., the patch seems to be fine for linux-vserver. cifs-mounting inside the 
guest is now possible.

Do you see any possiblility to include this part of Igors work (not the whole 
DFS thing) to the mainline? It fixes the use of the deprecated api.

-
Wilhelm

_______________________________________________
linux-cifs-client mailing list
linux-cifs-client <at> lists.samba.org
https://lists.samba.org/mailman/listinfo/linux-cifs-client

Re: cifs and kthread_run / kernel_thread

Wilhelm Meier wrote:

>m Montag, 2. April 2007 schrieb Wilhelm Meier:
>  
>
>>>It seems to me that I rewrote cifs_demultiplex_thread to use kthread_run
>>>in DFS patch.
>>>      
>>>
>>o.k., I found the patch on the list. Will do some testing with it.
>>    
>>
>
>o.k., the patch seems to be fine for linux-vserver. cifs-mounting inside the 
>guest is now possible.
>
>Do you see any possiblility to include this part of Igors work (not the whole 
>DFS thing) to the mainline? It fixes the use of the deprecated api.
>
>-
>Wilhelm
>  
>
>------------------------------------------------------------------------
>
>Index: connect.c
>===================================================================
>--- connect.c	(.../2.6.19.1)	(revision 20)
>+++ connect.c	(.../kthread_support)	(revision 20)
> <at>  <at>  -30,6 +30,7  <at>  <at> 

Re: cifs and kthread_run / kernel_thread

Wilhelm Meier wrote:

>>m Montag, 2. April 2007 schrieb Wilhelm Meier:
>>  
>>
>  
>
>>>>>>It seems to me that I rewrote cifs_demultiplex_thread to use kthread_run
>>>>>>in DFS patch.
>>>>>>      
>>>>>>
>>>      
>>>
>>>>o.k., I found the patch on the list. Will do some testing with it.
>>>>    
>>>>
>>    
>>
>>
>>o.k., the patch seems to be fine for linux-vserver. cifs-mounting inside the 
>>guest is now possible.
>>
>>Do you see any possiblility to include this part of Igors work (not the whole 
>>DFS thing) to the mainline? It fixes the use of the deprecated api.
>
Now merged into cifs-2.6 git tree.  Thanks to Q and Wilhelm

Re: Re: cifs and kthread_run / kernel_thread

On Tue, Apr 03, 2007 at 02:17:59PM -0500, Steve French wrote:

> Now merged into cifs-2.6 git tree.  Thanks to Q and Wilhelm

Up to date SVN please ! .

Jeremy.

newer cifs version backported to old kernels

http://pserver.samba.org/samba/ftp/cifs-cvs/cifs-1.48a.tar.gz

Let me know if you have an older 2.6 kernel that this does not build on 
(I tried 2.6.21 and 2.6.18)

Samba, inotify on a Windows share

Hi everyone,

    Here's what I try to do. I want to monitor from a Linux Gentoo 
machine with inotify enabled on a directory for new files hosted by a 
windows share(Windows server, not Samba).

    I know there is a new support for iNotify in Samba 3.0.25 
pre-release. I don't know if this new feature can help me, but I'll be 
happy to find a way to solve my problem.

I tried with 3.0.25pr2, << mount.cifs >> utility without any results.

Thanks for you attention!

Bruno Auger