Jan Engelhardt | 30 Oct 17:05 2014
Picon

[PATCH] overlay: typographical corrections to documentation

Commas, periods, and so on.

Signed-off-by: Jan Engelhardt <jengelh <at> inai.de>
---
 Documentation/filesystems/overlayfs.txt | 86 ++++++++++++++++-----------------
 1 file changed, 43 insertions(+), 43 deletions(-)

diff --git a/Documentation/filesystems/overlayfs.txt b/Documentation/filesystems/overlayfs.txt
index 530850a..a1ce7cb 100644
--- a/Documentation/filesystems/overlayfs.txt
+++ b/Documentation/filesystems/overlayfs.txt
 <at>  <at>  -4,24 +4,24  <at>  <at>  Overlay Filesystem
 ==================

 This document describes a prototype for a new approach to providing
-overlay-filesystem functionality in Linux (sometimes referred to as
-union-filesystems).  An overlay-filesystem tries to present a
+overlay filesystem functionality in Linux (sometimes referred to as
+union filesystems).  An overlay filesystem tries to present a
 filesystem which is the result over overlaying one filesystem on top
-of the other.
+of another.

 The result will inevitably fail to look exactly like a normal
 filesystem for various technical reasons.  The expectation is that
 many use cases will be able to ignore these differences.

-This approach is 'hybrid' because the objects that appear in the
+This approach is "hybrid" because the objects that appear in the
 filesystem do not all appear to belong to that filesystem.  In many
(Continue reading)

Dr. Shri G. Mahalingam | 29 Oct 22:47 2014
Picon

Attn:

I am getting in touch with you regarding a business deal, Reply me if interested.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Dr. Shri G. Mahalingam | 29 Oct 21:43 2014
Picon

Attn:

I am getting in touch with you regarding a business deal, Reply me if interested.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Dr. Shri G. Mahalingam | 29 Oct 22:54 2014
Picon

Attn:

I am getting in touch with you regarding a business deal, Reply me if interested.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Namjae Jeon | 30 Oct 06:04 2014

[PATCH] fat: fix data past EOF resulting from fsx testsuite

When running FSX with direct I/O mode, fsx resulted in DATA past EOF issues.

fsx ./file2 -Z -r 4096 -w 4096
...
..
truncating to largest ever: 0x907c
fallocating to largest ever: 0x11137
truncating to largest ever: 0x2c6fe
truncating to largest ever: 0x2cfdf
fallocating to largest ever: 0x40000
Mapped Read: non-zero data past EOF (0x18628) page offset 0x629 is 0x2a4e
...
..

The reason being, it is doing a truncate down, but the zeroing does
not happen on the last block boundary when offset is not aligned.
Even though it calls truncate_setsize()->truncate_inode_pages()->
truncate_inode_pages_range() and considers the partial zeroout but it
retrieves the page using find_lock_page() - which only looks the page in
the cache. So, zeroing out does not happen in case of direct IO.

Make a truncate page based around block_truncate_page for FAT filesystem and
invoke that helper to zerout in case the offset is not aligned with
the blocksize.

Signed-off-by: Namjae Jeon <namjae.jeon <at> samsung.com>
Signed-off-by: Amit Sahrawat <a.sahrawat <at> samsung.com>
---
 fs/fat/fat.h   |  1 +
 fs/fat/file.c  |  2 ++
(Continue reading)

Dan Carpenter | 27 Oct 14:54 2014
Picon

re: overlay filesystem

Hello Miklos Szeredi,

The patch e9be9d5e76e3: "overlay filesystem" from Oct 24, 2014, leads
to the following static checker warning:

	fs/overlayfs/readdir.c:392 ovl_iterate()
	warn: this array is probably non-NULL. 'p->name'

fs/overlayfs/readdir.c
   387          while (od->cursor.l_node.next != &od->cache->entries) {
   388                  struct ovl_cache_entry *p;
   389  
   390                  p = list_entry(od->cursor.l_node.next, struct ovl_cache_entry, l_node);
   391                  /* Skip cursors */
   392                  if (p->name) {
                            ^^^^^^^
The "Skip cursors" comment suggests that some other check was intended?

   393                          if (!p->is_whiteout) {
   394                                  if (!dir_emit(ctx, p->name, p->len, p->ino, p->type))
   395                                          break;
   396                          }
   397                          ctx->pos++;
   398                  }
   399                  list_move(&od->cursor.l_node, &p->l_node);
   400          }

There are a couple others as well.

fs/overlayfs/readdir.c:254 ovl_dir_mark_whiteouts() warn: this array is probably non-NULL. 'p->name'
(Continue reading)

Jan Kara | 27 Oct 10:58 2014
Picon

[PATCH RESEND] mm: Remove false WARN_ON from pagecache_isize_extended()

The WARN_ON checking whether i_mutex is held in
pagecache_isize_extended() was wrong because some filesystems (e.g.
XFS) use different locks for serialization of truncates / writes. So
just remove the check.

Signed-off-by: Jan Kara <jack <at> suse.cz>
---
 mm/truncate.c | 1 -
 1 file changed, 1 deletion(-)

  Ted can you please merge this patch? I originally sent this patch in a
reply to Fengguangs report and apparently you missed it. Thanks!

diff --git a/mm/truncate.c b/mm/truncate.c
index 261eaf6e5a19..c646084e5eec 100644
--- a/mm/truncate.c
+++ b/mm/truncate.c
 <at>  <at>  -755,7 +755,6  <at>  <at>  void pagecache_isize_extended(struct inode *inode, loff_t from, loff_t to)
 	struct page *page;
 	pgoff_t index;

-	WARN_ON(!mutex_is_locked(&inode->i_mutex));
 	WARN_ON(to > inode->i_size);

 	if (from >= to || bsize == PAGE_CACHE_SIZE)
--

-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
(Continue reading)

Omar Sandoval | 26 Oct 19:07 2014

Race condition in btrfs_releasepage?

So I may be completely wrong here and someone might come in and tell me why
this doesn't matter, but I'm just trying to understand the BTRFS code and I
came across something that confused me.

try_release_extent_mapping appears to access page->mapping->host->i_size
without any sort of serialization. It's used in the implementation of
btrfs_releasepage, and aops->releasepage, as far as I can tell, isn't called
with any locks held. Should we be grabbing i_mutex or using i_size_read here
instead? I'm not too familiar with the locking rules for inodes or releasepage.

Thanks!
--

-- 
Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Finance Department | 24 Oct 13:59 2014
Picon

Payment

Dear Recipient,

You have been awarded the sum of  8,000,000.00 (Eight Million Pounds sterling) with reference number
77100146 by office of the ministry of finance UK.Send us your personal details to deliver your funds.

Gloria Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Nicolas Dichtel | 24 Oct 14:05 2014

[PATCH linux-next] fs/proc: use rb_entry_safe() instead of rb_entry()

Better to use existing macro that rewriting them.

Signed-off-by: Nicolas Dichtel <nicolas.dichtel <at> 6wind.com>
---
 fs/proc/generic.c | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index 9f8fa1e5e8aa..371ae5ceab0d 100644
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
 <at>  <at>  -41,22 +41,14  <at>  <at>  static int proc_match(unsigned int len, const char *name, struct proc_dir_entry

 static struct proc_dir_entry *pde_subdir_first(struct proc_dir_entry *dir)
 {
-	struct rb_node *node = rb_first(&dir->subdir);
-
-	if (node == NULL)
-		return NULL;
-
-	return rb_entry(node, struct proc_dir_entry, subdir_node);
+	return rb_entry_safe(rb_first(&dir->subdir), struct proc_dir_entry,
+			     subdir_node);
 }

 static struct proc_dir_entry *pde_subdir_next(struct proc_dir_entry *dir)
 {
-	struct rb_node *node = rb_next(&dir->subdir_node);
-
-	if (node == NULL)
(Continue reading)

Jan Kara | 23 Oct 14:31 2014
Picon

[PATCH] befs: Remove dead code

Coverity-id: 1042674
Signed-off-by: Jan Kara <jack <at> suse.cz>
---
 fs/befs/linuxvfs.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
index 4cf61ec6b7a8..89b89ef7a84e 100644
--- a/fs/befs/linuxvfs.c
+++ b/fs/befs/linuxvfs.c
 <at>  <at>  -271,10 +271,6  <at>  <at>  more:
 	}
 	ctx->pos++;
 	goto more;
-
-	befs_debug(sb, "<--- %s pos %lld", __func__, ctx->pos);
-
-	return 0;
 }

 static struct inode *
--

-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)


Gmane