headers
hermann pitton | 1 Apr 2010 02:31
Picon
Favicon

Re: [PATCH] Fix default state Beholder H6 tuner.

Hi Dimitry,

Am Mittwoch, den 31.03.2010, 13:14 +1000 schrieb Dmitri Belimov:
> Hi Hermann
> 
> > Hi,
> > 
> > Am Dienstag, den 30.03.2010, 16:02 +1000 schrieb Dmitri Belimov:
> > > Hi
> > > 
> > > The hybrid tuner FMD1216MEX_MK3 after cold start has disabled IF.
> > > This tuner has internal I2C switch. This switch switch I2C bus
> > > between DVB-T and IF part. Default state is DVB-T. When module
> > > saa7134 is load it can't find IF tda9887 and disable analog TV mode.
> > > 
> > > This patch set internal I2C switch of the tuner to IF by send
> > > special value to the tuner as for receive analog TV from low band.
> > > It can be usefule for other cards.
> > > 
> > > I didn't set configure a tuner by a tuner model because this tuner
> > > can has different I2C address. May be we can do it later after
> > > discuss for more robust support a tuners.
> > 
> > just as a reminder. It is the same for the FMD1216ME hybrid MK3.
> > After every boot, analog mode fails with missing tda9887.
> > 
> > Currently, after tuner modules are not independent anymore, one has to
> > reload the saa7134 driver once.
> > 
> > Relevant code in tuner.core.c.
(Continue reading)

Permalink | Reply | 3 comments |
headers
Dmitri Belimov | 1 Apr 2010 06:33
Picon

Re: [PATCH] Fix default state Beholder H6 tuner.

Hi Hermann

> Hi Dimitry,
> 
> Am Mittwoch, den 31.03.2010, 13:14 +1000 schrieb Dmitri Belimov:
> > Hi Hermann
> > 
> > > Hi,
> > > 
> > > Am Dienstag, den 30.03.2010, 16:02 +1000 schrieb Dmitri Belimov:
> > > > Hi
> > > > 
> > > > The hybrid tuner FMD1216MEX_MK3 after cold start has disabled
> > > > IF. This tuner has internal I2C switch. This switch switch I2C
> > > > bus between DVB-T and IF part. Default state is DVB-T. When
> > > > module saa7134 is load it can't find IF tda9887 and disable
> > > > analog TV mode.
> > > > 
> > > > This patch set internal I2C switch of the tuner to IF by send
> > > > special value to the tuner as for receive analog TV from low
> > > > band. It can be usefule for other cards.
> > > > 
> > > > I didn't set configure a tuner by a tuner model because this
> > > > tuner can has different I2C address. May be we can do it later
> > > > after discuss for more robust support a tuners.
> > > 
> > > just as a reminder. It is the same for the FMD1216ME hybrid MK3.
> > > After every boot, analog mode fails with missing tda9887.
> > > 
> > > Currently, after tuner modules are not independent anymore, one
(Continue reading)

Permalink | Reply | 2 comments |
headers
Hans Verkuil | 1 Apr 2010 09:36
Picon
Picon
Favicon

Re: [PATCH] s2255drv: removal of big kernel lock

On Wednesday 31 March 2010 16:41:51 Dean A. wrote:
> # HG changeset patch
> # User Dean Anderson <dean <at> sensoray.com>
> # Date 1270046291 25200
> # Node ID c72bdc8732abc0cf7bc376babfd06b2d999bdcf4
> # Parent  2ab296deae938864b06b29cc224eb4b670ae3aa9
> s2255drv: removal of BKL
> 
> From: Dean Anderson <dean <at> sensoray.com>
> 
> big kernel lock removed from open function.
> v4l2 code does not require locking the open function except
> to check asynchronous firmware load state, which is protected
> by a mutex

Can you do the same for the go7007 driver?

And for both drivers you can also switch to using unlocked_ioctl.

Regards,

	Hans

--

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG
Permalink | Reply | 0 comments |
headers
Hans Verkuil | 1 Apr 2010 10:01
Picon
Picon
Favicon

V4L-DVB drivers and BKL

Hi all,

I just read on LWN that the core kernel guys are putting more effort into
removing the BKL. We are still using it in our own drivers, mostly V4L.

I added a BKL column to my driver list:

http://www.linuxtv.org/wiki/index.php/V4L_framework_progress#Bridge_Drivers

If you 'own' one of these drivers that still use BKL, then it would be nice
if you can try and remove the use of the BKL from those drivers.

The other part that needs to be done is to move from using the .ioctl file op
to using .unlocked_ioctl. Very few drivers do that, but I suspect almost no
driver actually needs to use .ioctl.

On the DVB side there seem to be only two sources that use the BKL:

linux/drivers/media/dvb/bt8xx/dst_ca.c: lock_kernel();
linux/drivers/media/dvb/bt8xx/dst_ca.c: unlock_kernel();
linux/drivers/media/dvb/dvb-core/dvbdev.c:      lock_kernel();
linux/drivers/media/dvb/dvb-core/dvbdev.c:              unlock_kernel();
linux/drivers/media/dvb/dvb-core/dvbdev.c:      unlock_kernel();

At first glance it doesn't seem too difficult to remove them, but I leave
that to the DVB experts.

Regards,

	Hans
(Continue reading)

Permalink | Reply | 31 comments |
headers
Hiremath, Vaibhav | 1 Apr 2010 10:20
Picon
Favicon
Gravatar

RE: [PATCH v3 0/2] Mem-to-mem device framework


> -----Original Message-----
> From: Pawel Osciak [mailto:p.osciak <at> samsung.com]
> Sent: Monday, March 29, 2010 1:07 PM
> To: linux-media <at> vger.kernel.org
> Cc: p.osciak <at> samsung.com; m.szyprowski <at> samsung.com;
> kyungmin.park <at> samsung.com; Hiremath, Vaibhav
> Subject: [PATCH v3 0/2] Mem-to-mem device framework
> 
> Hello,
> 
> this is the third version of the mem-to-mem memory device framework.
> It addresses previous comments and issues raised in Norway as well.
> 
> It is rather independent from videobuf so I believe it can be merged
> separately.
> 
> Changes in v3:
> - streamon, streamoff now have to be called for both queues separately
> - added automatic rescheduling of an instance after finish (if ready)
> - tweaked up locking
> - addressed Andy Walls' comments
> 
> We have been using v2 for three different devices on an embedded system.
> I did some additional testing of v3 on a 4-core SMP as well.
> 
> The series contains:
> 
> [PATCH v3 1/2] v4l: Add memory-to-memory device helper framework for
> videobuf.
(Continue reading)

Permalink | Reply | 0 comments |
headers
hvaibhav | 1 Apr 2010 10:20
Picon
Favicon
Gravatar

[PATCH 1/2] v4l2-mem2mem: Code cleanup

From: Vaibhav Hiremath <hvaibhav <at> ti.com>

Signed-off-by: Vaibhav Hiremath <hvaibhav <at> ti.com>
---
 drivers/media/video/v4l2-mem2mem.c |   40 ++++++++++++++---------------------
 1 files changed, 16 insertions(+), 24 deletions(-)

diff --git a/drivers/media/video/v4l2-mem2mem.c b/drivers/media/video/v4l2-mem2mem.c
index a78157f..4cd79ba 100644
--- a/drivers/media/video/v4l2-mem2mem.c
+++ b/drivers/media/video/v4l2-mem2mem.c
 <at>  <at>  -23,12 +23,12  <at>  <at>  MODULE_DESCRIPTION("Mem to mem device framework for videobuf");
 MODULE_AUTHOR("Pawel Osciak, <p.osciak <at> samsung.com>");
 MODULE_LICENSE("GPL");

-static int debug;
-module_param(debug, int, 0644);
+static bool debug;
+module_param(debug, bool, 0644);

 #define dprintk(fmt, arg...)						\
 	do {								\
-		if (debug >= 1)						\
+		if (debug)						\
 			printk(KERN_DEBUG "%s: " fmt, __func__, ## arg);\
 	} while (0)

 <at>  <at>  -215,12 +215,10  <at>  <at>  EXPORT_SYMBOL(v4l2_m2m_dst_buf_remove);
 void *v4l2_m2m_get_curr_priv(struct v4l2_m2m_dev *m2m_dev)
 {
(Continue reading)

Permalink | Reply | 1 comment |
headers
hvaibhav | 1 Apr 2010 10:20
Picon
Favicon
Gravatar

[PATCH 2/2] mem2mem_testdev: Code cleanup

From: Vaibhav Hiremath <hvaibhav <at> ti.com>

Signed-off-by: Vaibhav Hiremath <hvaibhav <at> ti.com>
---
 drivers/media/video/mem2mem_testdev.c |   58 ++++++++++++++------------------
 1 files changed, 25 insertions(+), 33 deletions(-)

diff --git a/drivers/media/video/mem2mem_testdev.c b/drivers/media/video/mem2mem_testdev.c
index 05630e3..1f35b7e 100644
--- a/drivers/media/video/mem2mem_testdev.c
+++ b/drivers/media/video/mem2mem_testdev.c
 <at>  <at>  -98,11 +98,10  <at>  <at>  static struct m2mtest_fmt formats[] = {
 };

 /* Per-queue, driver-specific private data */
-struct m2mtest_q_data
-{
-	unsigned int		width;
-	unsigned int		height;
-	unsigned int		sizeimage;
+struct m2mtest_q_data {
+	u32			width;
+	u32			height;
+	u32			sizeimage;
 	struct m2mtest_fmt	*fmt;
 };

 <at>  <at>  -123,11 +122,10  <at>  <at>  static struct m2mtest_q_data *get_q_data(enum v4l2_buf_type type)
 		return &q_data[V4L2_M2M_DST];
 	default:
(Continue reading)

Permalink | Reply | 2 comments |
headers
Hans Verkuil | 1 Apr 2010 10:32
Picon
Picon
Favicon

Re: [PATCH 12/24] media/video: fix dangling pointers

On Tuesday 30 March 2010 14:39:12 Wolfram Sang wrote:
> Hans,
> 
> > But this just feels like an i2c core thing to me. After remove() is called
> > the core should just set the client data to NULL. If there are drivers that
> > rely on the current behavior, then those drivers should be reviewed first as
> > to the reason why they need it.
> 
> It will be done this way now. As you have taken part in the discussion, I guess
> the media-subsystem never really considered picking those patches up ;)

I remember that there was one patch in your patch series where the client data
was set after it was freed.

That should still be fixed (by just removing the i2c_set_clientdata).

Can you post that one again?

Regards,

	Hans

> 
> Regards,
> 
>    Wolfram
> 
> 

--

--
(Continue reading)

Permalink | Reply | 0 comments |
headers
Hans Verkuil | 1 Apr 2010 11:06
Picon
Picon
Favicon

Re: [PATCH v3 1/2] v4l: Add memory-to-memory device helper framework for videobuf.

Here is my review...

On Monday 29 March 2010 09:36:46 Pawel Osciak wrote:
> A mem-to-mem device is a device that uses memory buffers passed by
> userspace applications for both their source and destination data. This
> is different from existing drivers, which utilize memory buffers for either
> input or output, but not both.
> 
> In terms of V4L2 such a device would be both of OUTPUT and CAPTURE type.
> 
> Examples of such devices would be: image 'resizers', 'rotators',
> 'colorspace converters', etc.
> 
> This patch adds a separate Kconfig sub-menu for mem-to-mem devices as well.
> 
> Signed-off-by: Pawel Osciak <p.osciak <at> samsung.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski <at> samsung.com>
> Reviewed-by: Kyungmin Park <kyungmin.park <at> samsung.com>
> ---
>  drivers/media/video/Kconfig        |   14 +
>  drivers/media/video/Makefile       |    2 +
>  drivers/media/video/v4l2-mem2mem.c |  685 ++++++++++++++++++++++++++++++++++++
>  include/media/v4l2-mem2mem.h       |  154 ++++++++
>  4 files changed, 855 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/media/video/v4l2-mem2mem.c
>  create mode 100644 include/media/v4l2-mem2mem.h
> 
> diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
> index f8fc865..5fd041e 100644
> --- a/drivers/media/video/Kconfig
(Continue reading)

Permalink | Reply | 4 comments |
headers
Hans Verkuil | 1 Apr 2010 11:11
Picon
Picon
Favicon

Re: [PATCH v3 1/2] v4l: Add memory-to-memory device helper framework for videobuf.

On Thursday 01 April 2010 11:06:51 Hans Verkuil wrote:
> Here is my review...
> 
> > +/**
> > + * v4l2_m2m_release() - cleans up and frees a m2m_dev structure
> > + *
> > + * Usually called from driver's remove() function.
> > + */
> > +void v4l2_m2m_release(struct v4l2_m2m_dev *m2m_dev)
> > +{
> > +	kfree(m2m_dev);
> > +}
> > +EXPORT_SYMBOL_GPL(v4l2_m2m_release);
> 
> Wouldn't it make sense to embed this struct in a filehandle structure?

That should be the top-level device structure, not the filehandle struct
of course.

Regards,

	Hans

> Then there is no need to allocate anything, you just need an init function.
> 
> I like embedding structures: it's quite clean.

--

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG
(Continue reading)

Permalink | Reply | 0 comments |

Gmane