Andre Prendel | 1 Sep 2009 19:56
Picon
Picon

Re: [lm-sensors] [PATCH] hwmon: Driver for Texas Instruments amc6821 chip

On Mon, Aug 31, 2009 at 10:24:50PM +0200, tomaz.mertelj <at> guest.arnes.si wrote:

Hello Tomaz,

> I have crafted a hwmon driver for Texas Instruments amc6821 SMB-bus 2-
> channel temperature sensor, pwm controller. This is my first linux project 
> so some corrections will be necessary.

First thing, please send the patch inline attached that one can
comment the source code.

> T. Mertelj
> 

Regards,
Andre

> _______________________________________________
> lm-sensors mailing list
> lm-sensors <at> lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Hubert Kario | 1 Sep 2009 20:26
Picon
Favicon

Re: "No sensors found!" on Intel Entry Storage System SS4200

On Saturday 29 August 2009 18:03:36 Tech2009 wrote:
> > Message: 3
> > Date: Sat, 29 Aug 2009 10:30:25 +0200
> > From: Hubert Kario <hka <at> qbs.com.pl>
> > Subject: Re: [lm-sensors] "No sensors found!" on Intel Entry Storage
> > System SS4200
> > To: lm-sensors <at> lm-sensors.org
> > Message-ID: <200908291030.25637.hka <at> qbs.com.pl>
> > Content-Type: text/plain;  charset="iso-8859-2"
> >
> >
> >
> > and what shows dmesg?
>
> dmesg output after sensors-detect:
> [ 1815.988770] i2c /dev entries driver
>
> dmesg output after sensors:
> (blank)
So there doesn't appear to be any problem...
>
>
> The bundled Linux image does not appear to use the dme1737 module or
> lmsensors. The web interface loads several closed source libraries, and
> I'm not sure how they access the hardware.
They may access the hardware directly, is the web interface running as root?
Also, you may check /sys file system, look in /sys/bus/platform/drivers/ for 
it, the module may be compiled in in the bundled image
>
> Is there something I should try to determine why sensors-detect sees the
(Continue reading)

Tech2009 | 1 Sep 2009 23:27

Re: "No sensors found!" on Intel Entry Storage System SS4200

Thank you for the suggestions.

I looked in sysfs on the factory distro, no sign of dme1737 there (see
attached). However there are other i2c devices not on my debian
install...you could be right about the direct port io, but without
disassembling the library it's hard to tell.

I tried loading dme1737 with force_start, but that made no difference
for me.

I'm going to have to determine whether the problem is with the sensors
program or the dme1737 driver. Is there a way to make the dme1737 module
dump out the debug information present in the source code?

I'm going to see if I can use the dme1737.c module source to read the
information via standard i2c calls in userland (ie i2ctools). If this
does work, I will be at a loss as to why the dme1737 module + sensors
program aren't working, but at least I'll have a viable alternative.

I will let you know if it works.

On Tue, 2009-09-01 at 20:26 +0200, Hubert Kario wrote:
> On Saturday 29 August 2009 18:03:36 Tech2009 wrote:
> > > Message: 3
> > > Date: Sat, 29 Aug 2009 10:30:25 +0200
> > > From: Hubert Kario <hka <at> qbs.com.pl>
> > > Subject: Re: [lm-sensors] "No sensors found!" on Intel Entry Storage
> > > System SS4200
> > > To: lm-sensors <at> lm-sensors.org
> > > Message-ID: <200908291030.25637.hka <at> qbs.com.pl>
(Continue reading)

Hubert Kario | 2 Sep 2009 02:23
Picon
Favicon

Re: "No sensors found!" on Intel Entry Storage System SS4200

On Tuesday 01 September 2009 23:27:28 Tech2009 wrote:
> Thank you for the suggestions.
>
> I looked in sysfs on the factory distro, no sign of dme1737 there (see
> attached). However there are other i2c devices not on my debian
> install...you could be right about the direct port io, but without
> disassembling the library it's hard to tell.
>
> I tried loading dme1737 with force_start, but that made no difference
> for me.
I was thinking about using the 'force' parameter to givie the address 
explicitly to the module, the device may be on non standard port.
sensors-detect is usually more capable of detecting devices than kernel 
modules
>
> I'm going to have to determine whether the problem is with the sensors
> program or the dme1737 driver. Is there a way to make the dme1737 module
> dump out the debug information present in the source code?
Haven't read the source of this module, but you'll probably have to compile 
kernel (or at least the module) with different .config (one that enables 
debugging messages)
>
> I'm going to see if I can use the dme1737.c module source to read the
> information via standard i2c calls in userland (ie i2ctools). If this
> does work, I will be at a loss as to why the dme1737 module + sensors
> program aren't working, but at least I'll have a viable alternative.
>
> I will let you know if it works.
I'm just a random lm-sensors user, so it's more of the blind leading the blind 
case and educated guess than real inside knowledge about lm-sensors...
(Continue reading)

Juerg Haefliger | 2 Sep 2009 04:10
Picon

Re: "No sensors found!" on Intel Entry Storage System SS4200

Hi

>> and what shows dmesg?
>
>
> dmesg output after sensors-detect:
> [ 1815.988770] i2c /dev entries driver
>
> dmesg output after sensors:
> (blank)

Please send the output of dmesg after you load the dme1737 driver. It
should at least spit out a message like "Found a SCH5027 chip at xyz".

...juerg

>
> The bundled Linux image does not appear to use the dme1737 module or
> lmsensors. The web interface loads several closed source libraries, and
> I'm not sure how they access the hardware.
>
> Is there something I should try to determine why sensors-detect sees the
> chip but sensors does not?
>
>
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors <at> lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
(Continue reading)

Tomaz Mertelj | 2 Sep 2009 10:20
Picon

Re: [PATCH] hwmon: Driver for Texas Instruments amc6821 chip

At 19:56 1. 9. 2009 +0200, you wrote:

>First thing, please send the patch inline attached that one can
>comment the source code.

Sorry, it was filtered out due to a wrong attchment format.

Tomaz

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 2d50166..d231a28 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
 <at>  <at>  -777,6 +777,16  <at>  <at>  config SENSORS_ADS7828
           This driver can also be built as a module.  If so, the module
           will be called ads7828.

+config SENSORS_AMC6821
+       tristate "Texas Instruments AMC6821"
+       depends on I2C
+       help
+         If you say yes here you get support for the Texas Instruments
+         AMC6821 hardware monitoring chips.
+
+         This driver can also be build as a module.  If so, the module
+         will be called amc6821.
+
  config SENSORS_THMC50
         tristate "Texas Instruments THMC50 / Analog Devices ADM1022"
         depends on I2C && EXPERIMENTAL
(Continue reading)

corentin.labbe | 2 Sep 2009 10:45
Picon

Re: [PATCH] hwmon: Driver for Texas Instruments amc6821 chip

tomaz.mertelj <at> guest.arnes.si a écrit :
> I have crafted a hwmon driver for Texas Instruments amc6821 SMB-bus 2-
> channel temperature sensor, pwm controller. This is my first linux project 
> so some corrections will be necessary.
> 
> T. Mertelj

Hello

I have some warnings

  CC      drivers/hwmon/amc6821.o
drivers/hwmon/amc6821.c: In function `set_temp1_auto_point_temp':
drivers/hwmon/amc6821.c:390: warning: comparison is always true due to limited range of data type
drivers/hwmon/amc6821.c: In function `set_temp2_auto_point_temp':
drivers/hwmon/amc6821.c:391: warning: comparison is always true due to limited range of data type
drivers/hwmon/amc6821.c: In function `set_pwm1_auto_point_pwm':
drivers/hwmon/amc6821.c:408: warning: comparison is always true due to limited range of data type
drivers/hwmon/amc6821.c:419: warning: comparison is always true due to limited range of data type

you use tmp as a unsigned 8 bit so it is always >= 0 (it can't be below 0)
Prefer use:
s8 tmp;

Cordially

_______________________________________________
lm-sensors mailing list
lm-sensors <at> lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
(Continue reading)

Jean Delvare | 2 Sep 2009 14:51
Gravatar

Re: Ambient Light sensor for Intersil-ISL29020 device

On Thu, 13 Aug 2009 16:22:29 +0530, Trisal, Kalhan wrote:
> This driver used Hwmon interface ,

No, it doesn't. It registers as a hwmon device but it doesn't implement
_any_ feature listed in Documentation/hwmon/sysfs-interface. Which can
be easily explained: your device is not a hardware monitoring device.

> I don't find the ils29003 registering with hwmon. I still believe
> this should be part of hwmon group.

No, it shouldn't. hwmon is for hardware monitoring. Other sensor types
must find a different home.

--

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors <at> lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Jean Delvare | 2 Sep 2009 14:56
Gravatar

Re: w83781d - Unable to set fan1_div

On Fri, 14 Aug 2009 06:09:41 +0900, clubsoda <at> hushmail.com wrote:
> Board is ASUS P4T requiring i2c-i801 and w83781d modules, with 
> sensors reporting as99127f-i2c-0-2d.  Tried setting fan1_div, 
> fan2_div and fan3_div to 8 in sensors3.conf and sensors.conf but 
> even after reboot div=2 so the minimum reportable fan speed is 2657 
> RPM.

In order to set the new limits you must run "sensors -s" as root. It's
in the FAQ.

Rebooting will not help at all, quite to the contrary: settings are
almost always lost on reboot, so you have to run "sensors -s" again.
Some distributions include this step in their init scripts, some do not.

> 
> BIOS is not too great at displaying low fan speeds either but ASUS 
> Probe in Windows goes down to 900 RPM or lower so the hardware is 
> capable.
> 
> Xubuntu Karmic alpha 3 system plus all updates.
> sensors, libsensors v3.0.2
> kernel 2.6.31-5-generic

--

-- 
Jean Delvare
http://khali.linux-fr.org/wishlist.html

_______________________________________________
lm-sensors mailing list
lm-sensors <at> lm-sensors.org
(Continue reading)

Jean Delvare | 2 Sep 2009 15:04
Gravatar

Re: [PATCH] hwmon: include <linux/io.h> instead of <asm/io.h>

On Thu, 13 Aug 2009 16:56:56 -0400, H Hartley Sweeten wrote:
> Drivers should be including <linux/io.h> instead of <asm/io.h>.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten <at> visionengravers.com>
> Cc: Alistair John Strachan <alistair <at> devzero.co.uk>
> Cc: Nicolas Boichat <nicolas <at> boichat.ch>
> Cc: Juerg Haefliger <juergh <at> gmail.com>
> Cc: Jean Delvare <khali <at> linux-fr.org>
> Cc: Frank Seidel <frank <at> f-seidel.de>
> Cc: Jim Cromie <jim.cromie <at> gmail.com>
> Cc: "Mark M. Hoffman" <mhoffman <at> lightlink.com>
> Cc: Roger Lucas <vt8231 <at> hiddenengine.co.uk>

Applied, thanks.

--

-- 
Jean Delvare

Gmane