[PATCH 1/2 RESEND 4] hwmon: new vt1211 driver

This is a new driver for the VIA vt1211 Super-IO chip. It is a rewrite
of the existing vt1211 driver (by Mark D. Studebaker and Lars Ekman)
which has been around for a while but never made it into the main
kernel tree.

It is implemented as a platform driver and therefore requires the
latest CVS version of lm_sensors to function properly.

Signed-off-by: Juerg Haefliger <juergh at gmail.com>

_______________________________________________
lm-sensors mailing list
lm-sensors <at> lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

[PATCH 2/2 RESEND 4] hwmon: add vt1211 documentation

This patch adds documentation for the new VIA vt1211 Super-IO driver.

Signed-off-by: Juerg Haefliger <juergh at gmail.com

_______________________________________________
lm-sensors mailing list
lm-sensors <at> lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [RFC PATCH 2.6.18-rc4-mm1] hwmon: unchecked return status fixes

Hi David,

Back to the mailing-list, as I doubt you replied to me privately on
purpose?

> Patch attached.

Applied, with two minor edits:

* Moved the "Register sysfs hooks" comment back to where it belongs.
* In w83627ehf_detach_client, call hwmon_device_unregister before
w83627ehf_device_remove_files. It probably doesn't matter much as
everything ends up being removed, but it looks less confusing for
userspace that way.

Thanks,
--

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors <at> lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: Call for testers: sis5595, via686a, vt8231

Hi Roger,

> Apologies for my late reply on this.

No worries :)

> I will be checking these patches next week - the VT8231 platform that I have
> is currently in a live system and cannot be played with.  It should be
> coming off-line next week (permanently) and I can then use it to test the
> detection changes.

OK, great. This is good because I also would like the vt8231 driver to
be converted to a platform (or pci?) driver in a near future. It would
be nice if you could help with testing, or even convert the driver
yourself if you have time for this.

Old server being replaced by brand new shiny hardware?

Thanks,
--

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors <at> lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: Is the Intel i945G supported/planned?

Sunil,

> yeah, I messed up a bit. i2c-dev is indeed a module and I didn't modprobe it
> before I ran sensors-detect.
> 
> But doesn't make much difference. I re-ran the sensors-detect and this time
> I asked it to load the i2c-dev. Didn't find any chip this time either.

It may not make much difference for your old sensors-detect and for
you, but it may make for us especially if you use the latest version of
sensors-detect:
http://www.lm-sensors.org/browser/lm-sensors/trunk/prog/detect/sensors-detect?format=txt

So please give it a try and report the full output. Maybe it won't find
anything, maybe you just don't have sensors on that system, but at
least we'll be sure.

Is there any hardware monitoring information reported by the BIOS?

--

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors <at> lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: Call for testers: sis5595, via686a, vt8231

> -----Original Message-----
> From: Jean Delvare [mailto:khali <at> linux-fr.org]
> Sent: 01 September 2006 11:26
> To: Roger Lucas
> Cc: 'LM Sensors'
> Subject: Re: [lm-sensors] Call for testers: sis5595, via686a, vt8231
> 
> Hi Roger,
> 
> > Apologies for my late reply on this.
> 
> No worries :)
> 
> > I will be checking these patches next week - the VT8231 platform that I
> have
> > is currently in a live system and cannot be played with.  It should be
> > coming off-line next week (permanently) and I can then use it to test
> the
> > detection changes.
> 
> OK, great. This is good because I also would like the vt8231 driver to
> be converted to a platform (or pci?) driver in a near future. It would
> be nice if you could help with testing, or even convert the driver
> yourself if you have time for this.

No problem.

> 
> Old server being replaced by brand new shiny hardware?

Re: [PATCH] Add VT8237A and VT8251 southbridges to i2c-viapro driver

Hi Rudolf,

(Wrong mailing list...)

> This patch adds VT8237A and VT8251 southbridges to our i2c-viapro driver. 
> Documentation update included.
> 
> Compile tested.

Applied, thanks. Can you please update
http://www.lm-sensors.org/wiki/NewDrivers ?

> diff -uprN linux-2.6.18-rc2/Documentation/i2c/busses/i2c-viapro linux-2.6.18-rc2-patched/Documentation/i2c/busses/i2c-viapro
> --- linux-2.6.18-rc2/Documentation/i2c/busses/i2c-viapro	2006-07-15 23:53:08.000000000 +0200
> +++ linux-2.6.18-rc2-patched/Documentation/i2c/busses/i2c-viapro	2006-08-31
23:03:57.990895500 +0200
>  <at>  <at>  -7,7 +7,7  <at>  <at>  Supported adapters:
>    * VIA Technologies, Inc. VT82C686A/B
>      Datasheet: Sometimes available at the VIA website
>  
> -  * VIA Technologies, Inc. VT8231, VT8233, VT8233A, VT8235, VT8237R
> +  * VIA Technologies, Inc. VT8231, VT8233, VT8233A, VT8235, VT8237R, VT8237A, VT8251
>      Datasheet: available on request from VIA

Line too long, I've fixed it.

You also forgot to update the device list in
drivers/i2c/busses/Kconfig, I've fixed that as well.

--

-- 

Re: [PATCH 1/2 RESEND 4] hwmon: new vt1211 driver

Hi Juerg,

> This is a new driver for the VIA vt1211 Super-IO chip. It is a rewrite
> of the existing vt1211 driver (by Mark D. Studebaker and Lars Ekman)
> which has been around for a while but never made it into the main
> kernel tree.
> 
> It is implemented as a platform driver and therefore requires the
> latest CVS version of lm_sensors to function properly.
> 
> Signed-off-by: Juerg Haefliger <juergh at gmail.com>

There are still a few things not correct:

> +	/* Create sysfs interface files */
> +	for (i = 0; i < ARRAY_SIZE(vt1211_sysfs_in_input); i++) {
> +		if (ISVOLT(i, data->uch_config)) {
> +			if ((err = device_create_file(dev,
> +				&vt1211_sysfs_in_input[i].dev_attr)) ||
> +			    (err = device_create_file(dev,
> +				&vt1211_sysfs_in_min[i].dev_attr)) ||
> +			    (err = device_create_file(dev,
> +				&vt1211_sysfs_in_max[i].dev_attr)) ||
> +			    (err = device_create_file(dev,
> +				&vt1211_sysfs_in_alarm[i].dev_attr))) {
> +				goto EXIT_DEV_REMOVE;
> +		  }
> +		}
> +	}

Re: [PATCH 2/2 RESEND 4] hwmon: add vt1211 documentation

> This patch adds documentation for the new VIA vt1211 Super-IO driver.
> 
> Signed-off-by: Juerg Haefliger <juergh at gmail.com

Missing ">" ;)

Applied, thanks.

--

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors <at> lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [PATCH] Add VT8237A and VT8251 southbridges to i2c-viapro driver

Jean Delvare wrote:
> Hi Rudolf,
> Jean Delvare wrote:
> Hi Rudolf,
> 
> (Wrong mailing list...)

Yeah I know sorry about that.  "The habbit is an iron shirt"

> 
>> This patch adds VT8237A and VT8251 southbridges to our i2c-viapro driver. 
>> Documentation update included.
>>
>> Compile tested.
> 
> Applied, thanks. Can you please update
> http://www.lm-sensors.org/wiki/NewDrivers ?

Yes this is still in todo.

>> diff -uprN linux-2.6.18-rc2/Documentation/i2c/busses/i2c-viapro linux-2.6.18-rc2-patched/Documentation/i2c/busses/i2c-viapro
>> --- linux-2.6.18-rc2/Documentation/i2c/busses/i2c-viapro	2006-07-15 23:53:08.000000000 +0200
>> +++ linux-2.6.18-rc2-patched/Documentation/i2c/busses/i2c-viapro	2006-08-31
23:03:57.990895500 +0200
>>  <at>  <at>  -7,7 +7,7  <at>  <at>  Supported adapters:
>>    * VIA Technologies, Inc. VT82C686A/B
>>      Datasheet: Sometimes available at the VIA website
>>  
>> -  * VIA Technologies, Inc. VT8231, VT8233, VT8233A, VT8235, VT8237R
>> +  * VIA Technologies, Inc. VT8231, VT8233, VT8233A, VT8235, VT8237R, VT8237A, VT8251