headers
David Brownell | 1 Jun 2005 02:24

Re: Re: [patch 2.6.12-rc3+] i2c driver for TPS6501x

On Friday 27 May 2005 2:54 pm, Jean Delvare wrote:
> Hi Dave,
> 
> > The "isp1301_omap" driver uses even more kernel features, FWIW, but
> > it's not exactly a "hardware monitoring" driver either.
> 
> And as a matter of fact it was not posted for review on the lm-sensors
> list.

It was posted a few times on the USB and OMAP lists.  There are some
patches lurking to split it into two parts (now that there's finally
some point to doing that, meaning a component that needs swapping),
which if you like I'll post to the sensors list for review.  (That's
still the only Linux I2C list, AFAIK...)

> > (...) why
> > remove everything from the I2C stack except hardware monitoring
> > support??
> 
> Non-i2c hardware monitoring drivers != non-hardware-monitoring i2c
> drivers. Not all hardware monitoring chips are I2C/SMBus based, and I
> would like to have these which are not moved to their respective
> subsystem rather than cluttering the i2c subsystem. We're far from that
> though.

I'll not disagree with that.  Good -- you weren't saying what I
was afraid you were saying!

> > > You should be using dev_dbg() instead. Ditto in show_regstatus() and
> > > show_chgconfig().
(Continue reading)

Permalink | Reply | 0 comments |
headers
Grant Coady | 1 Jun 2005 03:36
Picon

Re: lm_sensors 2.9.1 sensord compile failure on 2.6.11.11

Hi Khali,
On Tue, 31 May 2005 16:27:38 +0200 (CEST), "Jean Delvare" <khali <at> linux-fr.org> wrote:
>> Can't compile sensord 2.9.1 with 2.6.11.11 -- neither can my test user,
>> and he's done it before.
>>
>> make clean; make PROG_EXTRA:=sensord
>>
>> make: *** No rule to make target `linux/i2c-proc.h', needed by
>> `kernel/chips/xeontemp.d'.  Stop.
>>
>> Does anyone know a fix?  Or magical incantation?
>>
>> It is probably something stupid, but I cannot see it, make user; make
>> user_install work fine, why not other stuff?
>
>Try:
>make PROG_EXTRA:=sensord user
>
Quoting Dave, the tester:
>Put your DS1780 stuff back into a fresh copy of 2.9.1,

(http://scatter.mine.nu/hwmon/adm9240/libsensors-2.9.1-fix-ds1780.diff.gz)

>uncomment PROG_EXTRA
>change to PREFIX=/usr (my setup)
>compile and install.
>'sensord' runs as advertised.
>
>Thank you, Grant!
(Continue reading)

Permalink | Reply | 0 comments |
headers
Huang0 | 1 Jun 2005 09:38
Picon

RE: future feature request - detection issue

Hi CY

This Chunhao in PI14, in charge of the linux driver for 792 chip.

Would you please give us some guidance when you have time? I think
maybe we can improve our design if possible.

Thanks
Best Regards
Chunhao

> -----Original Message-----
> From: Rudolf Marek [mailto:r.marek <at> sh.cvut.cz]
> Sent: 2005529 18:40
> To: PI32 CYChen16
> Cc: PI14 HUANG0; lm-sensors <at> lm-sensors.org
> Subject: future feature request - detection issue
> 
> Hello,
> 
> We are lm_sensors group that develops drivers for Winbond chip in Linux
> environment.
> Our drivers are "motherboard indepent" so we have to implement very
> sophisticated chip detection methods.
> 
> Your chips like w83781d and compatible and also your new one w83792d have chip
> ID and manufacturer ID in bank0 register.
> What if bios left the bank switched to other one? Then it is not possible to
> detect your chips.
>
(Continue reading)

Permalink | Reply | 0 comments |
headers
CYChen16 | 1 Jun 2005 10:02
Picon

RE: future feature request - detection issue

Dear Rudolf,
  That's a good idea. We will implement it in next generation chips.

CY

-----Original Message-----
From: PI14 HUANG0 
Sent: Wednesday, June 01, 2005 3:39 PM
To: PI32 CYChen16
Cc: Rudolf Marek; lm-sensors <at> lm-sensors.org
Subject: RE: future feature request - detection issue

Hi CY

This Chunhao in PI14, in charge of the linux driver for 792 chip.

Would you please give us some guidance when you have time? I think
maybe we can improve our design if possible.

Thanks
Best Regards
Chunhao

> -----Original Message-----
> From: Rudolf Marek [mailto:r.marek <at> sh.cvut.cz]
> Sent: 2005年5月29日 18:40
> To: PI32 CYChen16
> Cc: PI14 HUANG0; lm-sensors <at> lm-sensors.org
> Subject: future feature request - detection issue
>
(Continue reading)

Permalink | Reply | 1 comment |
headers
Grant Coady | 1 Jun 2005 10:37
Picon

PATCH i2c: adm9240 driver doc

Greetings,

This patch adds adm9240 driver documentation, it is new file 
so does not interfere with Rudolf Marek's documentation series.

Was partially reviewed earlier during driver development and is 
now updated to match the completed driver.

--Grant.

Signed-off-by: Grant Coady <gcoady <at> gmail.com>

---
 adm9240 |  214 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 214 insertions(+)

diff -X dontdiff -Nrup linux-2.6.12-rc5-mm1/Documentation/i2c/chips/adm9240 linux-2.6.12-rc5-mm1a/Documentation/i2c/chips/adm9240
--- linux-2.6.12-rc5-mm1/Documentation/i2c/chips/adm9240	1970-01-01 10:00:00.000000000 +1000
+++ linux-2.6.12-rc5-mm1a/Documentation/i2c/chips/adm9240	2005-06-01 18:27:51.000000000 +1000
 <at>  <at>  -0,0 +1,214  <at>  <at> 
+Kernel driver adm9240
+=====================
+
+Supported chips:
+  * Analog Devices ADM9240
+    Prefix `adm9240'
+    Addresses scanned: I2C 0x2c - 0x2f
+    Datasheet: Publicly available at the Analog Devices website
+	       http://www.analog.com/
+
(Continue reading)

Permalink | Reply | 4 comments |
headers
Rudolf Marek | 1 Jun 2005 10:44
Picon
Picon

Re: W83792 review and testing

Hi all,

I created the patch for 2.6.x kernels with Makefile Kconfig and documentation.
I'm inviting you to test it, we need to check everyting so please play with it for a while.
Set the limits, fan divisors, observe how it changes and how it should change. Please report back
any problems or things that you did not expect even after reading documentation :)
You can try also the automatic fan regulation interface as described in documenation.
(I wrote it with the help of source code so I dont know if it is correct please check it too)

You will need for that latest lm-sensors CVS version.
You can get it here: http://secure.netroedge.com/~lm78/archive/lm_sensors-daily.tar.gz
The patch is in attachment. I think it does not matter if you apply against 2.6.12 or 2.6.11
or even any other 2.6 kernel. As long it does not say HUNK failed than it is OK.

Rest of people here please help me with documentation review.

Documenation file follows here so it will be easy to correct my mistakes.
This is second version, because I accidently overwrote the first one in late night yesterday.

Thanks for the help,

regards

Rudolf

Kernel driver w83792d
=====================

Supported chips:
  * Winbond W83792D
(Continue reading)

Permalink | Reply | 2 comments |
headers
Huang0 | 1 Jun 2005 11:03
Picon

RE: W83792 review and testing

Hi Rudolf, Rafi, Jean

> You will need for that latest lm-sensors CVS version.
> You can get it here:
> http://secure.netroedge.com/~lm78/archive/lm_sensors-daily.tar.gz

To test the 792 driver for linux-2.6, you need the latest lm-sensors
CVS version, But I checked the above daily version, as well as the one
in
http://secure.netroedge.com/~lm78/cvs/browse.cgi/lm_sensors2/kernel/chip
s/w83792d.c
find that the version in CVS is NOT the lastest! Please patch the
attachment
into lm_sensors as soon as possible, otherwise you will NOT be able to
test
the 792 driver for linux-2.6

For more detail, please refer to my mail with subject
"RE: Fix one bug of w83792d under linux-2.4"

To Rudolf
Thank you for all kinds of help to me, I will check the document in the
near
future.

Thanks

Best
Regards
Chunhao
(Continue reading)

Permalink | Reply | 0 comments |
headers
Grant Coady | 1 Jun 2005 11:37
Picon

Re: W83792 review and testing

On Wed, 01 Jun 2005 10:44:21 +0200, Rudolf Marek <r.marek <at> sh.cvut.cz> wrote:

>Hi all,
>
>I created the patch for 2.6.x kernels with Makefile Kconfig and documentation.
...
>or even any other 2.6 kernel. As long it does not say HUNK failed than it is OK.
Does not compile on 2.6.12-rc5-mm1 due to sysfs changes, was 
going to create patchset but I got distracted with 2.4.31 
coming out today. 

>Rest of people here please help me with documentation review.
Wish I could, chicken & egg --> me waiting for doc review too.
Cannot test the driver itself anyway :(

--Grant.

_______________________________________________
lm-sensors mailing list
lm-sensors <at> lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Permalink | Reply | 0 comments |
headers
Greg KH | 1 Jun 2005 01:32
Gravatar

Re: [RFC] SPI core

On Tue, May 31, 2005 at 08:09:16PM +0400, dmitry pervushin wrote:
> Hello guys,
> 
> In order to support the specific board, we have ported the generic SPI
> core to the 2.6 kernel. This core provides basic API to create/manage
> SPI devices like the I2C core does. We need to continue providing
> support of SPI devices and would like to maintain the SPI subtree. It
> would be nice if SPI core patch were applied to the vanilla kernel.
> I2C people do not like to mainain this code as well as I2C, so...

What do you mean by this?  Which i2c people?

Is this code intergrated into the driver model?
What does the /sys/ tree look like?
Why are you using a char device node?

> +/**
> + * spi_add_adapter - register a new SPI bus adapter
> + *  <at> adap: spi_adapter structure for the registering adapter
> + *
> + * Make the adapter available for use by clients using name adap->name.
> + * The adap->adapters list is initialised by this function.
> + *
> + * Returns 0;

You have this a lot.  If the function can not fail, just make it a void
type :)

> +int spi_add_adapter(struct spi_adapter *adap)
> +{
(Continue reading)

Permalink | Reply | 0 comments |
headers
Greg KH | 1 Jun 2005 07:09
Picon

[GIT PATCH] I2C bugfix for 2.6.12-rc5

Here is a single i2c patch for the 2.6.12-rc5 tree that fixes a bug.
This patch has been in the -mm tree for quite some time.

Please pull from:
	rsync://rsync.kernel.org/pub/scm/linux/kernel/git/gregkh/i2c-2.6.git/

The full patch will be sent to the linux-kernel and sensors mailing
list, if anyone wants to see them.

thanks,

greg k-h

 MAINTAINERS                      |    6 +++++
 drivers/i2c/busses/i2c-ali1563.c |   46 ++++++++++++++++++++++++++-------------
 2 files changed, 37 insertions(+), 15 deletions(-)

------------

Rudolf Marek:
  o I2C: ALI1563 SMBus driver fix

_______________________________________________
lm-sensors mailing list
lm-sensors <at> lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Permalink | Reply | 0 comments |

Gmane