mailing list for Linux RDMA and InfiniBand development ()

Sasha Khapyorsky | 2 Jan 2011 16:53

Re: [PATCH] Further timeout paramater verification (Was: [PATCH] infiniband-diags: Verify timeout value specified to diagnostics)

On 11:47 Wed 22 Dec     , Ira Weiny wrote:
> On Mon, 20 Dec 2010 13:57:36 -0800
> Jay Fenlason <fenlason@...> wrote:
> 
> > Sorry if you get this more than once, I seem to have outgoing mail misconfiguration here.
> > 
> > On Wed, Dec 15, 2010 at 11:47:09AM -0800, Ira Weiny wrote:
> > >
> > > Verify timeout value specified to diagnostics
> > >
> > >
> > > Signed-off-by: Ira Weiny <weiny2@...>
> > > ---
> > >  infiniband-diags/src/ibdiag_common.c |   10 +++++++---
> > >  1 files changed, 7 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/infiniband-diags/src/ibdiag_common.c b/infiniband-diags/src/ibdia
> > +g_common.c
> > > index 99861f1..8ccf2fc 100644
> > > --- a/infiniband-diags/src/ibdiag_common.c
> > > +++ b/infiniband-diags/src/ibdiag_common.c
> > >  <at>  <at>  -175,9 +175,13  <at>  <at>  static int process_opt(int ch, char *optarg)
> > >               ibd_dest_type = IB_DEST_GUID;
> > >               break;
> > >       case 't':
> > > -             val = strtoul(optarg, 0, 0);
> > > -             madrpc_set_timeout(val);
> > > -             ibd_timeout = val;
> > > +             val = (int)strtol(optarg, NULL, 0);
> > > +             if (val > 0) {

(Continue reading)

Bart Van Assche | 2 Jan 2011 18:16

Picon

Re: [RFC 5/8] IB/srp: reduce local coverage for command submission and EH

On Thu, Dec 23, 2010 at 10:31 PM, David Dillow <dillowda@...> wrote:
>
> We only need locks to protect our lists and number of credits available.
> By pre-consuming the credit for the request, we can reduce our lock
> coverage to just those areas. If we don't actually send the request,
> we'll need to put the credit back into the pool.
>
> [ ... ]
>
> -       iu->type = iu_type;
> +       list_del_init(&iu->list);

Hello Dave,

As far as I can see the above call of list_del_init() can be modified
into a list_del() call. The same holds for the other list_del_init()
call introduced by this patch.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

David Dillow | 3 Jan 2011 09:44

Picon

Re: [RFC 6/8] IB/srp: reduce lock coverage of command completion

On Sun, 2011-01-02 at 18:27 +0100, Bart Van Assche wrote:
> Before this patch target->req_lim was updated both when receiving a
> response for a regular SRP command and when receiving a response for
> an SRP task management command. This patch modifies that in only
> updating target->req_lim in the former case. Are you sure that's
> correct ?

No, that's a bug. Good catch, thanks.
--

-- 
Dave Dillow
National Center for Computational Science
Oak Ridge National Laboratory
(865) 241-6602 office

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

David Dillow | 3 Jan 2011 09:45

Picon

Re: [RFC 5/8] IB/srp: reduce local coverage for command submission and EH

On Sun, 2011-01-02 at 18:16 +0100, Bart Van Assche wrote:
> On Thu, Dec 23, 2010 at 10:31 PM, David Dillow <dillowda@...> wrote:
> >
> > We only need locks to protect our lists and number of credits available.
> > By pre-consuming the credit for the request, we can reduce our lock
> > coverage to just those areas. If we don't actually send the request,
> > we'll need to put the credit back into the pool.
> >
> > [ ... ]
> >
> > -       iu->type = iu_type;
> > +       list_del_init(&iu->list);
> 
> Hello Dave,
> 
> As far as I can see the above call of list_del_init() can be modified
> into a list_del() call. The same holds for the other list_del_init()
> call introduced by this patch.

Most likely; there are several such instances that I've corrected from
by misinterpretation of the list debug code.

Thanks,

--

-- 
Dave Dillow
National Center for Computational Science
Oak Ridge National Laboratory
(865) 241-6602 office

(Continue reading)

Nir Muchtar | 3 Jan 2011 16:33

[PATCH V4 0/6] IB Netlink Interface and RDMA CM exports

IB Netlink infrastructure and module for rdma_cm

This patch set provides means for communicating internal data from
IB modules to the userspace.
It is composed of two components:
1. The main ib_netlink infrastructure which lives and is initialized by ib_core.
2. additional clients which are implemented inside existing IB modules.
   Clients are responsible for adding/removing their modules during init/exit
   to/from the infrastructure.
   They also supply an array of callbacks for the infrastructure to call
   based on the module/operation type. 

ib_netlink uses the standard Netlink module and defines a new Netlink unit
(NETLINK_INFINIBAND) in netlink.h.
Upon receiving a request from userspace, it finds the target client
using the add/remove mechanism, and then uses client's callback table to call
the callback which is associated with the requested op, using the 
netlink_dump_start helper function.
The callbacks must be of the form:
int (*dump)(struct sk_buff *skb, struct netlink_callback *cb)
and must use the netlink_callback context in order to save state when called 
multiple times.
There is no guarantee that the returned data will be consistent as data
structures can change between calls.
The exact format of the returned data is unknown to ib_netlink itself.
It is shared between the kernel and userspace in the form of common headers.

Changelog:
1. Allowing for additional callback types in the cb_table.
2. sockaddr Attributes are not passed as sockaddr_storage structs.

(Continue reading)

Nir Muchtar | 3 Jan 2011 16:33

[PATCH V4 1/6] IB Netlink Infrastructure

The basic IB netlink infrastructure.
It allows for registration of IB clients for which data is to be exported.
It supplies message construction callbacks.

Signed-off-by: Nir Muchtar <nirm@...>
---
 drivers/infiniband/core/netlink.c |  178 +++++++++++++++++++++++++++++++++++++
 include/linux/netlink.h           |    1 +
 include/rdma/ib_netlink.h         |   62 +++++++++++++
 3 files changed, 241 insertions(+), 0 deletions(-)
 create mode 100644 drivers/infiniband/core/netlink.c
 create mode 100644 include/rdma/ib_netlink.h

diff --git a/drivers/infiniband/core/netlink.c b/drivers/infiniband/core/netlink.c
new file mode 100644
index 0000000..66cbd45
--- /dev/null
+++ b/drivers/infiniband/core/netlink.c
 <at>  <at>  -0,0 +1,178  <at>  <at> 
+/*
+ * Copyright (c) 2010 Voltaire Inc.  All rights reserved.
+ *
+ * This software is available to you under a choice of one of two
+ * licenses.  You may choose to be licensed under the terms of the GNU
+ * General Public License (GPL) Version 2, available from the file
+ * COPYING in the main directory of this source tree, or the
+ * OpenIB.org BSD license below:
+ *
+ *     Redistribution and use in source and binary forms, with or
+ *     without modification, are permitted provided that the following

(Continue reading)

Nir Muchtar | 3 Jan 2011 16:33

[PATCH V4 2/6] IB Core: Error Handler

Added missing error handling in ib_core init. (Wasn't intentional right?)

Signed-off-by: Nir Muchtar <nirm@...>
---
 drivers/infiniband/core/device.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index a19effa..6e06e37 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
 <at>  <at>  -719,15 +719,22  <at>  <at>  static int __init ib_core_init(void)
 	int ret;

 	ret = ib_sysfs_setup();
-	if (ret)
+	if (ret) {
 		printk(KERN_WARNING "Couldn't create InfiniBand device class\n");
+		goto err;
+	}

 	ret = ib_cache_setup();
 	if (ret) {
 		printk(KERN_WARNING "Couldn't set up InfiniBand P_Key/GID cache\n");
-		ib_sysfs_cleanup();
+		goto err_sysfs;
 	}

+	return 0;
+

(Continue reading)

Nir Muchtar | 3 Jan 2011 16:33

[PATCH V4 3/6] IB Core: Run Netlink

Include and initialize IB netlink from IB core.

Signed-off-by: Nir Muchtar <nirm@...>
---
 drivers/infiniband/core/Makefile |    2 +-
 drivers/infiniband/core/device.c |   11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/drivers/infiniband/core/Makefile b/drivers/infiniband/core/Makefile
index cb1ab3e..c8bbaef 100644
--- a/drivers/infiniband/core/Makefile
+++ b/drivers/infiniband/core/Makefile
 <at>  <at>  -8,7 +8,7  <at>  <at>  obj-$(CONFIG_INFINIBAND_USER_ACCESS) +=	ib_uverbs.o ib_ucm.o \
 					$(user_access-y)

 ib_core-y :=			packer.o ud_header.o verbs.o sysfs.o \
-				device.o fmr_pool.o cache.o
+				device.o fmr_pool.o cache.o netlink.o
 ib_core-$(CONFIG_INFINIBAND_USER_MEM) += umem.o

 ib_mad-y :=			mad.o smi.o agent.o mad_rmpp.o
diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index 6e06e37..3229102 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
 <at>  <at>  -40,6 +40,8  <at>  <at> 
 #include <linux/mutex.h>
 #include <linux/workqueue.h>

+#include <net/ib_netlink.h>

(Continue reading)

Nir Muchtar | 3 Jan 2011 16:33

[PATCH V4 4/6] RDMA CM: Export State Enum

exported enum cma_state into rdma_cm.h

Signed-off-by: Nir Muchtar <nirm@...>
---
 drivers/infiniband/core/cma.c |  166 +++++++++++++++++++----------------------
 include/rdma/rdma_cm.h        |   14 ++++
 2 files changed, 92 insertions(+), 88 deletions(-)

diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index 6884da2..5821f93 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
 <at>  <at>  -89,20 +89,6  <at>  <at>  struct cma_device {
 	struct list_head	id_list;
 };

-enum cma_state {
-	CMA_IDLE,
-	CMA_ADDR_QUERY,
-	CMA_ADDR_RESOLVED,
-	CMA_ROUTE_QUERY,
-	CMA_ROUTE_RESOLVED,
-	CMA_CONNECT,
-	CMA_DISCONNECT,
-	CMA_ADDR_BOUND,
-	CMA_LISTEN,
-	CMA_DEVICE_REMOVAL,
-	CMA_DESTROYING
-};
-

(Continue reading)

Nir Muchtar | 3 Jan 2011 16:33

[PATCH V4 5/6] RDMA CM: Netlink Client

Add callbacks and data types for statistics export.
One callback is implemented that exports all of the current devices/ids.
Add/remove the callback to IB Netlink on init/cleanup.

Signed-off-by: Nir Muchtar <nirm@...>
---
 drivers/infiniband/core/cma.c |   91 +++++++++++++++++++++++++++++++++++++++++
 include/rdma/ib_netlink.h     |   15 +++++++
 include/rdma/rdma_cm.h        |   11 +++++
 3 files changed, 117 insertions(+), 0 deletions(-)

diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index 5821f93..6436995 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
 <at>  <at>  -51,6 +51,7  <at>  <at> 
 #include <rdma/ib_cm.h>
 #include <rdma/ib_sa.h>
 #include <rdma/iw_cm.h>
+#include <rdma/ib_netlink.h>

 MODULE_AUTHOR("Sean Hefty");
 MODULE_DESCRIPTION("Generic RDMA CM Agent");
 <at>  <at>  -3243,6 +3244,93  <at>  <at>  static void cma_remove_one(struct ib_device *device)
 	kfree(cma_dev);
 }

+static int cma_get_id_stats(struct sk_buff *skb, struct netlink_callback *cb)
+{
+	struct nlmsghdr *nlh;

(Continue reading)

Group

gmane.linux.drivers.rdma.

Project Web Page

mailing list for Linux RDMA and InfiniBand development ()

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 27

Articles in period: 268

January 2011

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

[PATCH infiniband-diags] saquery.c: Dump SwitchInfoRecord based on IsS (25 May 2013)
ibv_reg_mr call failed (24 May 2013)
Patch: Support for Xeon Phi (24 May 2013)
Warning about possible recursive locking detected in IPoIB (23 May 2013)
warning! (23 May 2013)
mlx4/xrc problem (22 May 2013)
[PATCHv3 infiniband-diags] saquery: Add SwitchInfoRecord support (21 May 2013)
better understanding rdma-cm UNREACHABLE/ETIMEDOUT scheme (21 May 2013)
[PATCH 0/2] update to autotools (21 May 2013)
[PATCH] open files with close on exec flag (21 May 2013)
[PATCH 0/2] update to autotools (21 May 2013)
[PATCH 0/3] make read_config() more robust (20 May 2013)
rockets feedbacks? (20 May 2013)
list corruption in IPOIB (20 May 2013)
libibverbs / libmlx4 release (20 May 2013)
warning!! (18 May 2013)
list corruption in IPOIB (17 May 2013)
MLX4 Cq Question (17 May 2013)
BUG: unable to handle kernel paging request at 0000000000070a78 IPoIB (17 May 2013)
[PATCH] IB/qib: fix lockdep splat in qib_alloc_lkey() (17 May 2013)
Extended ibv_send_wr (14 May 2013)

Archives

158	May 2013
325	April 2013
315	March 2013
414	February 2013
153	January 2013
174	December 2012
161	November 2012
222	October 2012
295	September 2012
316	August 2012
392	July 2012
235	June 2012
293	May 2012
303	April 2012
245	March 2012
216	February 2012
295	January 2012
327	December 2011
326	November 2011
317	October 2011
217	September 2011
291	August 2011
445	July 2011
263	June 2011
249	May 2011
276	April 2011
252	March 2011
192	February 2011
268	January 2011
311	December 2010
306	November 2010
416	October 2010
321	September 2010
432	August 2010
404	July 2010
480	June 2010
491	May 2010
434	April 2010
343	March 2010
443	February 2010
361	January 2010
380	December 2009
676	November 2009
596	October 2009
197	September 2009

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template