David Woodhouse | 1 Sep 2008 12:52
Favicon

Re: [PATCH] resend Freescale i.MX2 NAND driver

On Wed, 2008-08-27 at 17:01 +0200, Sascha Hauer wrote:
> I received no reactions on this so far, so I send this one again. I
> would be glad to see this in 2.6.28. Any comments on the patch?

Can I have a version which applies to the current git tree, please?

--

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse <at> intel.com                              Intel Corporation

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Picon
Favicon

Школа секретаря: как стать профессионалом.

Курс для секретарей, помощников руководителей,
офис-менеджеров, сотрудников административных
отделов компании.
***************************************************************
ШКОЛА СЕКРЕТАРЯ: КАК СТАТЬ ПРОФЕССИОНАЛОМ
Пятидневный практический курс

В программе:
Модуль 1: Делопроизводство в работе секретаря.
Нормативно-правовая и методическая база
делопроизводства. Классификация документов и  их
функции. Современные требования к составлению и
оформлению документов. Организация работы с
документами. Номенклатура дел предприятия. 
Модуль 2: Деловая корреспонденция. Деловая
переписка. Характеристика служебной переписки.
Служебные  письма. Коммерческие письма. Внутренняя
переписка. Требования к тексту служебных
документов. 
Модуль 3: Организация работы офиса (офис-менеджмент).
Организация рабочего места. Обеспечение
жизнедеятельности офиса. Организация и
хозяйственное обслуживание представительских
мероприятий. Организационные вопросы
взаимодействия с руководителем. Руководство
административно-хозяйственной службой. 
Модуль 4: Деловой этикет и служебная культура в работе
секретаря. Правила приветствия, представления,
знакомства. Эффективное взаимодействие секретаря
и руководителя. Субординация, взаимоотношения
(Continue reading)

David Woodhouse | 1 Sep 2008 13:01
Favicon

Re: [PATCH] [MTD] mtdchar.c: Fix regression in MEMGETREGIONINFO ioctl()

On Tue, 2008-08-26 at 21:31 -0700, Zev Weiss wrote:
> Well, for what little it's probably worth, I've now tested this patch, with no 
> resulting surprises (seems to work fine for me).  Though I see now that, much to 
> my chagrin, something in my email chain seems to have spacified my code.  If 
> there's any need I can resend appropriately.

Please. With a signed-off-by.

--

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse <at> intel.com                              Intel Corporation

David Woodhouse | 1 Sep 2008 13:26
Favicon

Re: [PATCH resend] MTD: nandsim: allow changing some module parameters

On Mon, 2008-07-28 at 10:06 +0300, Artem Bityutskiy wrote:
> Grant write permissions to some nandsim module parameters
> to make it possible to change them runtime e.g., via sysfs:
> 
> echo 1 > /sys/module/nandsim/parameters/rptwear
> 
> There is no reason to have that file read-only. This patches
> also changes the permissions from octal to S_* format.
> 
> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy <at> nokia.com>

Got a current version of this?

--

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse <at> intel.com                              Intel Corporation

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Artem Bityutskiy | 1 Sep 2008 13:25
Picon

Re: [PATCH resend] MTD: nandsim: allow changing some module parameters

David Woodhouse wrote:
> On Mon, 2008-07-28 at 10:06 +0300, Artem Bityutskiy wrote:
>> Grant write permissions to some nandsim module parameters
>> to make it possible to change them runtime e.g., via sysfs:
>>
>> echo 1 > /sys/module/nandsim/parameters/rptwear
>>
>> There is no reason to have that file read-only. This patches
>> also changes the permissions from octal to S_* format.
>>
>> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy <at> nokia.com>
> 
> Got a current version of this?

Please, do not apply this for now. I'll send a better version
later. This version has a problem - we should make sure
rptwear-related variables are initialized.

Thanks.

--

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Zev Weiss | 1 Sep 2008 14:19
Picon

Re: [PATCH] [MTD] mtdchar.c: Fix regression in MEMGETREGIONINFO ioctl()

From: Zev Weiss <zevweiss <at> gmail.com>
Date: Mon, 1 Sep 2008 05:02:12 -0700
Subject: [PATCH] [MTD] mtdchar.c: Fix regression in MEMGETREGIONINFO ioctl()

The MEMGETREGIONINFO ioctl() in mtdchar.c was clobbering user memory by
overwriting more than intended, due the size of struct mtd_erase_region_info
changing in commit 0ecbc81adfcb9f15f86b05ff576b342ce81bbef8.

Fix avoids this by copying struct members one by one with put_user(), as there
is no longer a convenient struct to use the size of as the length argument to
copy_to_user().

Signed-off-by: Zev Weiss <zevweiss <at> gmail.com>
---
  drivers/mtd/mtdchar.c |   16 ++++++++++------
  1 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
index 13cc67a..424f318 100644
--- a/drivers/mtd/mtdchar.c
+++ b/drivers/mtd/mtdchar.c
 <at>  <at>  -410,16 +410,20  <at>  <at>  static int mtd_ioctl(struct inode *inode, struct file *file,

  	case MEMGETREGIONINFO:
  	{
-		struct region_info_user ur;
+		u32 ur_idx;
+		struct mtd_erase_region_info *kr;
+		struct region_info_user *ur = (struct region_info_user *) argp;

(Continue reading)

Picon
Favicon

Правовое регулирование использования земель различных категорий.

Курс для руководителей, землеустроителей, юристов,
специалистов земельных, имущественных
подразделений органов власти и органов местного
самоуправления.  
*****************************************************************************

ПРАВОВОЕ РЕГУЛИРОВАНИЕ ИСПОЛЬЗОВАНИЯ ЗЕМЕЛЬ
РАЗЛИЧНЫХ КАТЕГОРИЙ. 
Практика операций с земельными участками,
регистрация прав собственности на земельные
участки и объекты недвижимости.

*****************************************************************************
В программе:
 - Порядок предоставления земельных участков
государственной или муниципальной собственности.

 - Прекращение прав на землю.  Основания и порядок прекращения.

 - Целевое назначение земель. Перевод земель и
земельных участков из одной категории в другую.
Изменение вида разрешённого использования
земельного участка. Раздел и объединение земельных
участков (единое землепользование).

 - Контроль за использованием и охраной земель
(государственный, муниципальный, общественный,
производственный). Порядок привлечения к
юридической ответственности за земельные правонарушения.

(Continue reading)

Dmitry Baryshkov | 1 Sep 2008 16:29
Picon
Gravatar

warning during mtd registration in 2.6.27-rc5

Hi,

Since commit abf5439370491dd6fbb4fe1a7939680d2a9bc9d4
I'm seeing this problem:

kobject (c3abad68): tried to init an initialized object, something is seriously wrong.
[<c0027ff0>] (dump_stack+0x0/0x14) from [<c013c484>] (kobject_init+0x40/0x78)
[<c013c444>] (kobject_init+0x0/0x78) from [<c013ca24>] (kobject_init_and_add+0x20/0x44)
 r5:c3abad68 r4:c3ac2520
[<c013ca08>] (kobject_init_and_add+0x4/0x44) from [<c0137c6c>] (blk_register_filter+0x48/0x60)
 r5:c3ab4060 r4:c3aba880
[<c0137c24>] (blk_register_filter+0x0/0x60) from [<c01366c4>] (add_disk+0x60/0xb8)
 r4:c3ac2400
[<c0136664>] (add_disk+0x0/0xb8) from [<c01a6994>] (add_mtd_blktrans_dev+0x210/0x244)
 r5:c3ab4060 r4:00000001
[<c01a6784>] (add_mtd_blktrans_dev+0x0/0x244) from [<c01a6bbc>] (mtdblock_add_mtd+0x58/0x64)
 r8:c03c7910 r7:c3ab6100 r6:c03c6bd4 r5:c03c6c04 r4:c3ab6100
[<c01a6b64>] (mtdblock_add_mtd+0x0/0x64) from [<c01a6144>] (blktrans_notify_add+0x3c/0x68)
 r5:c3ab6100 r4:c03c6c04
[<c01a6108>] (blktrans_notify_add+0x0/0x68) from [<c01a3a20>] (add_mtd_device+0xc0/0x120)
 r6:c03c6b80 r5:c3ab6100 r4:c03c6bc4
[<c01a3960>] (add_mtd_device+0x0/0x120) from [<c01a4e50>] (add_one_partition+0x468/0x500)
 r6:c3ac2000 r5:00700000 r4:c3ab6100
[<c01a49e8>] (add_one_partition+0x0/0x500) from [<c01a4f20>] (add_mtd_partitions+0x38/0x7c)
[<c01a4ee8>] (add_mtd_partitions+0x0/0x7c) from [<c0016a48>] (sharpsl_nand_init+0x1dc/0x238)
....

This happens when adding mtd partitions. I've traced it to the fact that
mtd partition devices share the genhd queue with the whole chip block device.
Thus blk_register_filter receives the same pointer for the chip and for each
(Continue reading)

David Woodhouse | 1 Sep 2008 19:25
Favicon

Re: [PATCH] [MTD] mtdchar.c: Fix regression in MEMGETREGIONINFO ioctl()

On Mon, 2008-09-01 at 05:19 -0700, Zev Weiss wrote:
> From: Zev Weiss <zevweiss <at> gmail.com>
> Date: Mon, 1 Sep 2008 05:02:12 -0700
> Subject: [PATCH] [MTD] mtdchar.c: Fix regression in MEMGETREGIONINFO ioctl()
> 
> The MEMGETREGIONINFO ioctl() in mtdchar.c was clobbering user memory by
> overwriting more than intended, due the size of struct mtd_erase_region_info
> changing in commit 0ecbc81adfcb9f15f86b05ff576b342ce81bbef8.
> 
> Fix avoids this by copying struct members one by one with put_user(), as there
> is no longer a convenient struct to use the size of as the length argument to
> copy_to_user().
> 
> Signed-off-by: Zev Weiss <zevweiss <at> gmail.com>

Thanks. Your patch was whitespace-damaged, but I managed to apply it
anyway. Please check for future patches though -- try sending patches to
yourself and then see if they get mangled. I believe gmail is known to
be broken unless you submit mail with SMTP.

I also try to avoid the pointless types like 'u32' in MTD code -- the C
language has perfectly good explicitly sized types; let's use them.

--

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse <at> intel.com                              Intel Corporation

David Woodhouse | 1 Sep 2008 22:17
Favicon

Re: warning during mtd registration in 2.6.27-rc5

On Mon, 2008-09-01 at 18:29 +0400, Dmitry Baryshkov wrote:
> This happens when adding mtd partitions. I've traced it to the fact that
> mtd partition devices share the genhd queue with the whole chip block device.
> Thus blk_register_filter receives the same pointer for the chip and for each
> registered partition.

Yes, the fix for that is already on its way to Linus.

--

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse <at> intel.com                              Intel Corporation


Gmane