Adrian Bunk | 1 Jan 2008 14:48

[2.6 patch] remove broken MTD drivers

This patch removes two MTD drivers that have been marked as
BROKEN 19 months ago due to requiring nonexisting header files.

Signed-off-by: Adrian Bunk <bunk <at> kernel.org>

---

This patch has been sent on:
- 24 Oct 2007

 drivers/mtd/nand/Kconfig          |   12 
 drivers/mtd/nand/Makefile         |    2 
 drivers/mtd/nand/ppchameleonevb.c |  439 ------------------------------
 drivers/mtd/nand/toto.c           |  208 --------------
 4 files changed, 661 deletions(-)

eb65564be12f427ae8a96a2ffa7e727a814e1129 
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 246d451..fa6b8b5 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
 <at>  <at>  -69,12 +69,6  <at>  <at>  config MTD_NAND_AMS_DELTA
 	help
 	  Support for NAND flash on Amstrad E3 (Delta).

-config MTD_NAND_TOTO
-	tristate "NAND Flash device on TOTO board"
-	depends on ARCH_OMAP && BROKEN
-	help
-	  Support for NAND flash on Texas Instruments Toto platform.
(Continue reading)

David Woodhouse | 1 Jan 2008 17:30
Favicon

Re: [2.6 patch] remove broken MTD drivers

On Tue, 2008-01-01 at 15:48 +0200, Adrian Bunk wrote:
> This patch removes two MTD drivers that have been marked as
> BROKEN 19 months ago due to requiring nonexisting header files.
> 
> Signed-off-by: Adrian Bunk <bunk <at> kernel.org>

Any particular reason you didn't Cc the authors identified in the
drivers you're removing?

--

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Wolfgang Denk | 1 Jan 2008 23:58
Picon
Picon
Favicon

Re: [2.6 patch] remove broken MTD drivers

In message <20080101134839.GN2360 <at> does.not.exist> you wrote:
> This patch removes two MTD drivers that have been marked as
> BROKEN 19 months ago due to requiring nonexisting header files.
...
>  drivers/mtd/nand/Kconfig          |   12 
>  drivers/mtd/nand/Makefile         |    2 
>  drivers/mtd/nand/ppchameleonevb.c |  439 ------------------------------

It would have been nice if you had put the autors of the files on Cc:

Regarding the PPChameleon NAND support: I discussed this issue with
tglx on 23 June 2006. Thomas promised to fix the driver if I send him
the missing file and eventually needed patches.

I did so on Fri, 23 Jun 2006 23:23:42 +0200.

Thomas, can you please have a look at this?

If you don't have time / resources please let me know so we can submit
the stuff here on the list...

Thanks.

Best regards,

Wolfgang Denk

--

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
(Continue reading)

Adrian Bunk | 2 Jan 2008 00:11

Re: [2.6 patch] remove broken MTD drivers

On Tue, Jan 01, 2008 at 04:30:57PM +0000, David Woodhouse wrote:
> On Tue, 2008-01-01 at 15:48 +0200, Adrian Bunk wrote:
> > This patch removes two MTD drivers that have been marked as
> > BROKEN 19 months ago due to requiring nonexisting header files.
> > 
> > Signed-off-by: Adrian Bunk <bunk <at> kernel.org>
> 
> Any particular reason you didn't Cc the authors identified in the
> drivers you're removing?

The header of ppchameleonevb.c claims it comes from info <at> wawnet.biz 
which bounces and the header of toto.c contains as only address Thomas'
address (I took the wrong one from the commit, but bounced the email
to him).

> dwmw2

cu
Adrian

--

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo <at> vger.kernel.org
(Continue reading)

Wolfgang Denk | 2 Jan 2008 01:28
Picon
Picon
Favicon

Re: [2.6 patch] remove broken MTD drivers

In message <20080101231140.GF27566 <at> does.not.exist> you wrote:
>
> The header of ppchameleonevb.c claims it comes from info <at> wawnet.biz 

Argh. That's indeed ancient code.

So what should I do to fix this? Wait for Thomas' response, or port
patches here?

Best regards,

Wolfgang Denk

--

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd <at> denx.de
A Chairman was as necessary to a Board planet  as  the  zero  was  in
mathematics, but being a zero had big disadvantages...
                         - Terry Pratchett, _The Dark Side of the Sun_
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Adrian Bunk | 2 Jan 2008 01:37

Re: [2.6 patch] remove broken MTD drivers

On Wed, Jan 02, 2008 at 01:28:26AM +0100, Wolfgang Denk wrote:
> In message <20080101231140.GF27566 <at> does.not.exist> you wrote:
> >
> > The header of ppchameleonevb.c claims it comes from info <at> wawnet.biz 
> 
> Argh. That's indeed ancient code.
> 
> So what should I do to fix this? Wait for Thomas' response, or port
> patches here?

I'd say post patches, and I'd expect David to actually be the one who
reviews and incorporates them.

> Best regards,
> 
> Wolfgang Denk

cu
Adrian

--

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo <at> vger.kernel.org
(Continue reading)

Nancy | 2 Jan 2008 02:42
Picon

Does UBI support MLC nand flash?

Sir / Madam,

             Does UBI support MLC nand flash?

             According to the MLC nand spec, It is only allowed write
once per erased
block, moreover, it isn't allowed ramdom write during a block, means
the page number must be increase during the write PED operation.

--
Best Regards,
Nancy

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Kyungmin Park | 2 Jan 2008 05:45
Favicon

RE: Does UBI support MLC nand flash?

Hi,

I think it can support MLC NAND in the code.
The big differences between the SLC and MLC are NOP (or subpage) and POR handling.

Generally SLC has NOP 4 (old chips have 8) whereas MLC has NOP 1.
In NAND code, it handles with NAND_NO_SUBPAGE_WRITE and NAND_CI_CELLTYPE_MSK.
Umm, who uses the NAND_NO_SUBPAGE_WRITE in code?
Anyway it maybe checks it with the CELLTYPE from 3rd ID data.

And sequential write is also only permitted at large page SLC NAND. It means it's working well on MLC NAND in
current UBI code. If
not, it also doesn't work at SLC NAND.

Thank you,
Kyungmin Park

-----Original Message-----
From: linux-mtd-bounces <at> lists.infradead.org [mailto:linux-mtd-bounces <at> lists.infradead.org] On
Behalf Of Nancy
Sent: Wednesday, January 02, 2008 10:42 AM
To: linux-mtd <at> lists.infradead.org
Subject: Does UBI support MLC nand flash?

Sir / Madam,

             Does UBI support MLC nand flash?

             According to the MLC nand spec, It is only allowed write
once per erased
(Continue reading)

Nancy | 2 Jan 2008 07:13
Picon

Re: Does UBI support MLC nand flash?

Sir,
     I don't know what is NOP, POP stand for? can you explain that?

     I notice mtd-utils "nandwrite.c" does write each page's oob area
twice, write oob(filesystem area) once, and then call "pwrite" to
write pagedata including oob (ecc part). I don't think that will work
right on MLC nand.

--
Best Regards,
Nancy

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Nancy | 2 Jan 2008 07:19
Picon

Re: Does UBI support MLC nand flash?

oh, forgot to metion UBI.
UBI has two headers for each LED/PED, they are not write at same time.
Is that against MLC nand's no ramdom write and  write only once
permission?

--
Best Regards,
Nancy

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/


Gmane