headers
Joey Ku (辜女育 | 1 Dec 2006 08:29
Picon

[PATCH] [MTD] MAPS: add support for ICH6/7/8 in ichxrom.c

[PATCH] [MTD] MAPS: add support for ICH6/7/8 in ichxrom.c

Add code to support ICH6/7/8
BTW, I don't have ICH7/8 machine for testing.
I guess it should work. :>

Signed-off-by: laface.tw <at> gmail.com

--

--- ichxrom.c.org	2006-11-30 16:56:49.000000000 +0800
+++ ichxrom.c	2006-12-01 15:02:21.086309768 +0800
 <at>  <at>  -26,11 +26,28  <at>  <at> 

 #define ROM_PROBE_STEP_SIZE (64*1024) /* 64KiB */

-#define BIOS_CNTL	0x4e
-#define FWH_DEC_EN1	0xE3
-#define FWH_DEC_EN2	0xF0
-#define FWH_SEL1	0xE8
-#define FWH_SEL2	0xEE
+enum ichxrom_chip_type {
+	ICHXROM_ICH5 = 0,
+	ICHXROM_ICH6,
+};
+
+struct ichxrom_conf_reg_offset {
+	u8 bios_cntl;
+	u8 fwh_dec_en1;
+	u8 fwh_dec_en2;
(Continue reading)

Permalink | Reply | 0 comments |
headers
Artem Bityutskiy | 1 Dec 2006 09:18
Favicon

Re: MTD pointer alignment

On Wed, 2006-11-29 at 13:09 +1300, Gavin Lambert wrote:
> Given that mtdchar assumes that it can mess with the low 2 bits of the
> MTD pointer it keeps around with impunity, add_mtd_device in mtdcore.c
> should probably refuse to add any MTD device pointer that doesn't fall
> on a 4-byte boundary.

Hmm, I personally I do not understand what is this about.

--

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Permalink | Reply | 3 comments |
headers
Artem Bityutskiy | 1 Dec 2006 09:21
Favicon

Re: jffs2_flash_writev(): Non-contiguous write to 00825300 with mtd_dataflash

On Wed, 2006-11-29 at 09:21 -0800, David Brownell wrote:
> > -	device->flags = MTD_CAP_NORFLASH;
> > +	device->flags = MTD_WRITEABLE;
> 
> That "NORFLASH" flag always seemed bogus to me, but it was at the
> time the only way to make the MTD core behave.

I personally not fond of adding capabilities bits to the mtd_info
structure at all...

--

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Permalink | Reply | 0 comments |
headers
Artem Bityutskiy | 1 Dec 2006 09:22
Favicon

Re: Finding flash type...

On Wed, 2006-11-29 at 10:53 -0800, Siddharth Choudhuri wrote:
> Hi,
> 
> Is it possible to know what kind of flash (NOR type or
> NAND type) is installed on a system ? (may be using
> lsmod -or- cat /proc/ksyms | grep ? ) 

It would be ideal if somebody added sysfs support to MTD. Then you could
just look at sysfs and find it out. Now you should use ioctl's.

--

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Permalink | Reply | 5 comments |
headers
Artem Bityutskiy | 1 Dec 2006 09:33
Favicon

RE: NOR read/write beyond end of flash partition

On Thu, 2006-11-30 at 21:23 +0530, Tigadi Kiran-r10350c wrote:
> Please find attached patch for drivers/mtd/mtdchar.c file to fix NOR read beyond flash. Let me know
whether it is valid fix.

Thanks.

--

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Permalink | Reply | 0 comments |
headers
Artem Bityutskiy | 1 Dec 2006 09:44
Favicon

RE: NOR read/write beyond end of flash partition

On Thu, 2006-11-30 at 21:23 +0530, Tigadi Kiran-r10350c wrote:
> Hi Artem,
> 
> Please find attached patch for drivers/mtd/mtdchar.c file to fix NOR read beyond flash. Let me know
whether it is valid fix.

I've looked at the code. Your patch is incorrect as mtd_read() should
return EOF if *ppos == mtd->size, not -ENOSPC.

--

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Permalink | Reply | 3 comments |
headers
Tigadi Kiran-r10350c | 1 Dec 2006 10:48
Favicon

RE: NOR read/write beyond end of flash partition

Hi Artem,

As write routine implementation has -ENOSPC, I created patch with read routine returning same value.

So, please let me know which patch is valid?

Regards,
Kiran

-----Original Message-----
From: Artem Bityutskiy [mailto:dedekind <at> infradead.org] 
Sent: Friday, December 01, 2006 2:14 PM
To: Tigadi Kiran-r10350c
Cc: linux-mtd <at> lists.infradead.org
Subject: RE: NOR read/write beyond end of flash partition

On Thu, 2006-11-30 at 21:23 +0530, Tigadi Kiran-r10350c wrote:
> Hi Artem,
> 
> Please find attached patch for drivers/mtd/mtdchar.c file to fix NOR read beyond flash. Let me know
whether it is valid fix.

I've looked at the code. Your patch is incorrect as mtd_read() should
return EOF if *ppos == mtd->size, not -ENOSPC.

--

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

______________________________________________________
(Continue reading)

Permalink | Reply | 2 comments |
headers
Artem Bityutskiy | 1 Dec 2006 10:59
Favicon

RE: NOR read/write beyond end of flash partition

On Fri, 2006-12-01 at 15:18 +0530, Tigadi Kiran-r10350c wrote:
> Hi Artem,
> 
> As write routine implementation has -ENOSPC, I created patch with read routine returning same value.
> 
> So, please let me know which patch is valid?

Pardon? I think there is no need in a patch and mtd_read() is ok as it
is.

--

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Permalink | Reply | 1 comment |
headers
David Woodhouse | 1 Dec 2006 12:21
Favicon

Re: Upgrading mtd-utils in uClinux.

On Thu, 2006-11-30 at 07:58 -0500, Glen Johnson wrote:
> Ricard Wanderlof wrote:
> > Unless someone here has had this specific problem, some form of output
> > from the compilation indicating what is going wrong would be helpful.
> >
> >   
> Yes, of course.  I have a couple more direct question. First, I found
> the mtd-utils code is not properly using zlib. 
> 
> m68k-elf-gcc -Wl,--fatal-warnings -Wl,-elf2flt -Wl,-move-rodata
> -msep-data -o mkfs.jffs2 crc32.o compr_rtime.o mkfs.jffs2.o compr_zlib.o
> compr.o -L/home/glen/src/c/linux/uClinux-dist-20060803/lib/zlib

No '-lz' on this command line -- you're not actually asking it to link
against zlib. Thus is doesn't find any of zlib's symbols.

> warning: .rodata section contains relocations

I've no idea what this is about. Perhaps the function pointers in the
jffs2_zlib_comp compressor structure?

mkfs.jffs2 builds fine for me for FR-V uClinux, although that's
ELF-FDPIC not flat. Are the relocations in .rodata actually a problem?
Doesn't m68k have ELF-FDPIC yet?

> Secondly, once I get the code to compile it appears I still need to add
> a section to the Makefile to install the files into the romfs image. 
> Can I just pull this out of the old mtd-utils/Makefile or what? 
> Suggestion's/recommendations?
(Continue reading)

Permalink | Reply | 1 comment |
headers
Darshak | 1 Dec 2006 14:04
Favicon

mkfs.jffs


Hi ,
I have compiled kernel [ 2.4.33 ] with jffs support.But I am not able to 
find command mkfs.jffs/2 how could i enable this ?

Thanxs & Rgds
Darshak Modi 

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Permalink | Reply | 3 comments |

Gmane