Pavel Roskin | 6 Mar 16:52 2013

revision 4181 committed

Project     : madwifi
Revision    : 4181
Author      : proski (Pavel Roskin)
Date        : 2013-03-06 16:52:20 +0100 (Wed, 06 Mar 2013)

Log Message :
Remove __devinitdata, it's obsolete now

Affected Files:
* madwifi/trunk/ath/if_ath_pci.c                      updated             

Modified: madwifi/trunk/ath/if_ath_pci.c
===================================================================
--- madwifi/trunk/ath/if_ath_pci.c	2012-05-01 19:55:40 UTC (rev 4180)
+++ madwifi/trunk/ath/if_ath_pci.c	2013-03-06 15:52:20 UTC (rev 4181)
 <at>  <at>  -94,7 +94,7  <at>  <at> 
  * "new way" to do things, we may want to switch back to having
  * the HAL check them by defining a probe method.
  */
-static struct pci_device_id ath_pci_id_table[] __devinitdata = {
+static struct pci_device_id ath_pci_id_table[] = {
 	{ 0x168c, 0x0007, PCI_ANY_ID, PCI_ANY_ID },
 	{ 0x168c, 0x0012, PCI_ANY_ID, PCI_ANY_ID },
 	{ 0x168c, 0x0013, PCI_ANY_ID, PCI_ANY_ID },

------------------------------------------------------------------------------
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
(Continue reading)

Pavel Roskin | 6 Mar 16:53 2013

revision 4182 committed

Project     : madwifi
Revision    : 4182
Author      : proski (Pavel Roskin)
Date        : 2013-03-06 16:53:15 +0100 (Wed, 06 Mar 2013)

Log Message :
Remove __devinitdata, it's obsolete now

Affected Files:
* madwifi/branches/madwifi-0.9.4/ath/if_ath_pci.c     updated             
* madwifi/branches/madwifi-dfs/ath/if_ath_pci.c       updated             

Modified: madwifi/branches/madwifi-0.9.4/ath/if_ath_pci.c
===================================================================
--- madwifi/branches/madwifi-0.9.4/ath/if_ath_pci.c	2013-03-06 15:52:20 UTC (rev 4181)
+++ madwifi/branches/madwifi-0.9.4/ath/if_ath_pci.c	2013-03-06 15:53:15 UTC (rev 4182)
 <at>  <at>  -94,7 +94,7  <at>  <at> 
  * "new way" to do things, we may want to switch back to having
  * the HAL check them by defining a probe method.
  */
-static struct pci_device_id ath_pci_id_table[] __devinitdata = {
+static struct pci_device_id ath_pci_id_table[] = {
 	{ 0x168c, 0x0007, PCI_ANY_ID, PCI_ANY_ID },
 	{ 0x168c, 0x0012, PCI_ANY_ID, PCI_ANY_ID },
 	{ 0x168c, 0x0013, PCI_ANY_ID, PCI_ANY_ID },

Modified: madwifi/branches/madwifi-dfs/ath/if_ath_pci.c
===================================================================
--- madwifi/branches/madwifi-dfs/ath/if_ath_pci.c	2013-03-06 15:52:20 UTC (rev 4181)
+++ madwifi/branches/madwifi-dfs/ath/if_ath_pci.c	2013-03-06 15:53:15 UTC (rev 4182)
(Continue reading)

Pavel Roskin | 1 May 21:55 2012

revision 4180 committed

Project     : madwifi
Revision    : 4180
Author      : proski (Pavel Roskin)
Date        : 2012-05-01 21:55:40 +0200 (Tue, 01 May 2012)

Log Message :
Use "%s" in err() calls to fix a warning on Ubuntu 10.04

err() would be confused if the interface name has formatting characters.

Affected Files:
* madwifi/branches/madwifi-0.9.4/tools/80211stats.c   updated             
* madwifi/branches/madwifi-0.9.4/tools/athstats.c     updated             
* madwifi/branches/madwifi-dfs/tools/80211stats.c     updated             
* madwifi/branches/madwifi-dfs/tools/athstats.c       updated             

Modified: madwifi/branches/madwifi-0.9.4/tools/80211stats.c
===================================================================
--- madwifi/branches/madwifi-0.9.4/tools/80211stats.c	2012-05-01 19:52:26 UTC (rev 4179)
+++ madwifi/branches/madwifi-0.9.4/tools/80211stats.c	2012-05-01 19:55:40 UTC (rev 4180)
 <at>  <at>  -287,7 +287,7  <at>  <at> 
 		/* no args, just show global stats */
 		ifr.ifr_data = (caddr_t) &stats;
 		if (ioctl(s, SIOCG80211STATS, &ifr) < 0)
-			err(1, ifr.ifr_name);
+			err(1, "%s", ifr.ifr_name);
 		printstats(stdout, &stats);
 		return 0;
 	}

(Continue reading)

Pavel Roskin | 1 May 21:52 2012

revision 4179 committed

Project     : madwifi
Revision    : 4179
Author      : proski (Pavel Roskin)
Date        : 2012-05-01 21:52:26 +0200 (Tue, 01 May 2012)

Log Message :
Use "%s" in err() calls to fix a warning on Ubuntu 10.04

err() would be confused if the interface name has formatting characters.

Affected Files:
* madwifi/trunk/tools/80211stats.c                    updated             
* madwifi/trunk/tools/athstats.c                      updated             

Modified: madwifi/trunk/tools/80211stats.c
===================================================================
--- madwifi/trunk/tools/80211stats.c	2012-01-30 19:56:17 UTC (rev 4178)
+++ madwifi/trunk/tools/80211stats.c	2012-05-01 19:52:26 UTC (rev 4179)
 <at>  <at>  -284,7 +284,7  <at>  <at> 
 		/* no args, just show global stats */
 		ifr.ifr_data = (caddr_t) &stats;
 		if (ioctl(s, SIOCG80211STATS, &ifr) < 0)
-			err(1, ifr.ifr_name);
+			err(1, "%s", ifr.ifr_name);
 		printstats(stdout, &stats);
 		return 0;
 	}

Modified: madwifi/trunk/tools/athstats.c
===================================================================
(Continue reading)

Pavel Roskin | 30 Jan 20:56 2012

revision 4178 committed

Project     : madwifi
Revision    : 4178
Author      : proski (Pavel Roskin)
Date        : 2012-01-30 20:56:17 +0100 (Mon, 30 Jan 2012)

Log Message :
Don't reference vlan_group without IEEE80211_VLAN_TAG_USED set

struct vlan_group will be removed in Linux 3.3.

Affected Files:
* madwifi/branches/madwifi-0.9.4/net80211/ieee80211_linux.h  updated             
* madwifi/branches/madwifi-dfs/net80211/ieee80211_linux.h  updated             
* madwifi/branches/madwifi-dfs/net80211/ieee80211_skb.h  updated             

Modified: madwifi/branches/madwifi-0.9.4/net80211/ieee80211_linux.h
===================================================================
--- madwifi/branches/madwifi-0.9.4/net80211/ieee80211_linux.h	2012-01-30 19:55:03 UTC (rev 4177)
+++ madwifi/branches/madwifi-0.9.4/net80211/ieee80211_linux.h	2012-01-30 19:56:17 UTC (rev 4178)
 <at>  <at>  -566,8 +566,10  <at>  <at> 
 	struct net_device *);
 int ieee80211_create_vap(struct ieee80211com *, char *, struct net_device *,
 	int, int);
+#if IEEE80211_VLAN_TAG_USED
 void ieee80211_vlan_register(struct net_device *dev, struct vlan_group *grp);
 void ieee80211_vlan_add_vid(struct net_device *dev, unsigned short vid);
 void ieee80211_vlan_kill_vid(struct net_device *dev, unsigned short vid);
+#endif

 #endif /* _NET80211_IEEE80211_LINUX_H_ */
(Continue reading)

Pavel Roskin | 30 Jan 20:55 2012

revision 4177 committed

Project     : madwifi
Revision    : 4177
Author      : proski (Pavel Roskin)
Date        : 2012-01-30 20:55:03 +0100 (Mon, 30 Jan 2012)

Log Message :
Don't reference vlan_group without IEEE80211_VLAN_TAG_USED set

struct vlan_group will be removed in Linux 3.3.

Affected Files:
* madwifi/trunk/net80211/ieee80211_linux.h            updated             
* madwifi/trunk/net80211/ieee80211_skb.h              updated             

Modified: madwifi/trunk/net80211/ieee80211_linux.h
===================================================================
--- madwifi/trunk/net80211/ieee80211_linux.h	2011-11-22 17:30:17 UTC (rev 4176)
+++ madwifi/trunk/net80211/ieee80211_linux.h	2012-01-30 19:55:03 UTC (rev 4177)
 <at>  <at>  -643,8 +643,11  <at>  <at> 
 	struct net_device *);
 struct ieee80211vap *ieee80211_create_vap(struct ieee80211com *, char *,
 	struct net_device *, int, int);
+
+#if IEEE80211_VLAN_TAG_USED
 void ieee80211_vlan_register(struct net_device *dev, struct vlan_group *grp);
 void ieee80211_vlan_add_vid(struct net_device *dev, unsigned short vid);
 void ieee80211_vlan_kill_vid(struct net_device *dev, unsigned short vid);
+#endif

 #endif /* _NET80211_IEEE80211_LINUX_H_ */
(Continue reading)

Pavel Roskin | 22 Nov 18:30 2011

revision 4176 committed

Project     : madwifi
Revision    : 4176
Author      : proski (Pavel Roskin)
Date        : 2011-11-22 18:30:17 +0100 (Tue, 22 Nov 2011)

Log Message :
Use ndo_set_rx_mode instead of ndo_set_multicast_list on Linux 3.2+

Affected Files:
* madwifi/branches/madwifi-0.9.4/ath/if_ath.c         updated             
* madwifi/branches/madwifi-0.9.4/net80211/ieee80211.c  updated             
* madwifi/branches/madwifi-dfs/ath/if_ath.c           updated             
* madwifi/branches/madwifi-dfs/net80211/ieee80211.c   updated             

Modified: madwifi/branches/madwifi-0.9.4/ath/if_ath.c
===================================================================
--- madwifi/branches/madwifi-0.9.4/ath/if_ath.c	2011-11-22 17:22:34 UTC (rev 4175)
+++ madwifi/branches/madwifi-0.9.4/ath/if_ath.c	2011-11-22 17:30:17 UTC (rev 4176)
 <at>  <at>  -402,7 +402,11  <at>  <at> 
 	.ndo_stop		= ath_stop,
 	.ndo_start_xmit		= ath_hardstart,
 	.ndo_tx_timeout 	= ath_tx_timeout,
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(3,2,0)
+	.ndo_set_rx_mode	= ath_mode_init,
+#else
 	.ndo_set_multicast_list = ath_mode_init,
+#endif
 	.ndo_do_ioctl		= ath_ioctl,
 	.ndo_get_stats		= ath_getstats,
 	.ndo_set_mac_address	= ath_set_mac_address,
(Continue reading)

Pavel Roskin | 22 Nov 18:22 2011

revision 4175 committed

Project     : madwifi
Revision    : 4175
Author      : proski (Pavel Roskin)
Date        : 2011-11-22 18:22:34 +0100 (Tue, 22 Nov 2011)

Log Message :
Use ndo_set_rx_mode instead of ndo_set_multicast_list on Linux 3.2+

Affected Files:
* madwifi/trunk/ath/if_ath.c                          updated             
* madwifi/trunk/net80211/ieee80211.c                  updated             

Modified: madwifi/trunk/ath/if_ath.c
===================================================================
--- madwifi/trunk/ath/if_ath.c	2011-10-25 21:38:00 UTC (rev 4174)
+++ madwifi/trunk/ath/if_ath.c	2011-11-22 17:22:34 UTC (rev 4175)
 <at>  <at>  -511,7 +511,11  <at>  <at> 
 	.ndo_stop		= ath_stop,
 	.ndo_start_xmit		= ath_hardstart,
 	.ndo_tx_timeout 	= ath_tx_timeout,
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(3,2,0)
+	.ndo_set_rx_mode	= ath_mode_init,
+#else
 	.ndo_set_multicast_list = ath_mode_init,
+#endif
 	.ndo_do_ioctl		= ath_ioctl,
 	.ndo_get_stats		= ath_getstats,
 	.ndo_set_mac_address	= ath_set_mac_address,

Modified: madwifi/trunk/net80211/ieee80211.c
(Continue reading)

Pavel Roskin | 25 Oct 23:38 2011

revision 4174 committed

Project     : madwifi
Revision    : 4174
Author      : proski (Pavel Roskin)
Date        : 2011-10-25 23:38:00 +0200 (Tue, 25 Oct 2011)

Log Message :
Merge 4149:4172 from trunk

Affected Files:
* madwifi/branches/madwifi-dfs/Makefile.inc           updated             
* madwifi/branches/madwifi-dfs/ath/if_ath.c           updated             
* madwifi/branches/madwifi-dfs/ath/if_ath_pci.c       updated             
* madwifi/branches/madwifi-dfs/ath/if_ath_radar.c     updated             
* madwifi/branches/madwifi-dfs/ath/if_athvar.h        updated             
* madwifi/branches/madwifi-dfs/ath_hal/ah.c           updated             
* madwifi/branches/madwifi-dfs/ath_hal/ah_os.c        updated             
* madwifi/branches/madwifi-dfs/ath_hal/ah_regdomain.c  updated             
* madwifi/branches/madwifi-dfs/ath_hal/ar5211/ar5211_reset.c  updated             
* madwifi/branches/madwifi-dfs/ath_hal/ar5212/ar2316.c  updated             
* madwifi/branches/madwifi-dfs/ath_hal/ar5212/ar2317.c  updated             
* madwifi/branches/madwifi-dfs/ath_hal/ar5212/ar2413.c  updated             
* madwifi/branches/madwifi-dfs/ath_hal/ar5212/ar2425.c  updated             
* madwifi/branches/madwifi-dfs/ath_hal/ar5212/ar5212_attach.c  updated             
* madwifi/branches/madwifi-dfs/ath_hal/ar5212/ar5212_power.c  updated             
* madwifi/branches/madwifi-dfs/ath_hal/ar5212/ar5212_reset.c  updated             
* madwifi/branches/madwifi-dfs/ath_hal/ar5212/ar5413.c  updated             
* madwifi/branches/madwifi-dfs/ath_hal/ar5416/ar5416_cal.c  updated             
* madwifi/branches/madwifi-dfs/ath_hal/ar5416/ar5416_xmit.c  updated             
* madwifi/branches/madwifi-dfs/ath_hal/ar5416/ar5416reg.h  updated             
* madwifi/branches/madwifi-dfs/ath_rate/amrr/amrr.c   updated             
(Continue reading)

Pavel Roskin | 7 Oct 23:43 2011

revision 4173 committed

Project     : madwifi
Revision    : 4173
Author      : proski (Pavel Roskin)
Date        : 2011-10-07 23:43:03 +0200 (Fri, 07 Oct 2011)

Log Message :
Remove -Werror from WARNINGS

It's impossible to eliminate all warnings with all combinations of
kernels and compilers.  Users are punished for using untested
combinations that should be OK.  Other projects don't use -Werror and
nothing bad happens.

Future compilers would surely introduce new warnings.  MadWifi doesn't
need to break because of that.

There is no way to make -Werror apply to MadWifi code but not to the
kernel headers.  Linux kernel doesn't use -Werror, why should MadWifi?

Using -Werror creates a false sense of security.  It's easy to assume
that the code is warning-free at least on the developers' systems.
However, broken code was committed in the past that would not compile at
all.  Code quality means more that absence of warnings.  It cannot be
ensured by -Werror.

Affected Files:
* madwifi/branches/madwifi-0.9.4/Makefile.inc         updated             

Modified: madwifi/branches/madwifi-0.9.4/Makefile.inc
===================================================================
(Continue reading)

Pavel Roskin | 7 Oct 23:42 2011

revision 4172 committed

Project     : madwifi
Revision    : 4172
Author      : proski (Pavel Roskin)
Date        : 2011-10-07 23:42:25 +0200 (Fri, 07 Oct 2011)

Log Message :
Remove -Werror from WARNINGS

It's impossible to eliminate all warnings with all combinations of
kernels and compilers.  Users are punished for using untested
combinations that should be OK.  Other projects don't use -Werror and
nothing bad happens.

Future compilers would surely introduce new warnings.  MadWifi doesn't
need to break because of that.

There is no way to make -Werror apply to MadWifi code but not to the
kernel headers.  Linux kernel doesn't use -Werror, why should MadWifi?

Using -Werror creates a false sense of security.  It's easy to assume
that the code is warning-free at least on the developers' systems.
However, broken code was committed in the past that would not compile at
all.  Code quality means more that absence of warnings.  It cannot be
ensured by -Werror.

Affected Files:
* madwifi/trunk/Makefile.inc                          updated             

Modified: madwifi/trunk/Makefile.inc
===================================================================
(Continue reading)


Gmane