[patch]: Memory leak when a sqlite3 insert fails

Hi,

The attached file is a very simple patch that frees a buffer when an
insert fails when using SQLite3 in smsd.

Regards,

--

-- 
Pedro Aguilar
http://www.paguilar.org/blog

_______________________________________________
gnokii-users mailing list
gnokii-users <at> nongnu.org
https://lists.nongnu.org/mailman/listinfo/gnokii-users

sms encoding problem on postgresql

Hi all,
We have working (gnokii) smsd service on Debian 64bit, using
Postgresql 9.1 (utf8 db) as storage engine and ZTE MF622 usb modem.
The issue is pg does not support utf16.
1. How does smsd handle conversion from gsm encoding variants to uft8,
and vice versa for sending?

I see in official TODO:
SHORT TERM
 * remove encoding workarounds -- should be purely based on libiconv and
   glib (in progress)

2. Short term is how much exactly (estimation)?
3. Your experience using file system and/or Sqlite and filesystem
considering SMSes with variable encoding (on a tight deadline, so no
time to check out myself)
4. Every now and then (one or two incoming messages per few hundreds
gets duplicated in inbox table). Is this known bug?

Thanks,
Esmin Gracić

_______________________________________________
gnokii-users mailing list
gnokii-users <at> nongnu.org
https://lists.nongnu.org/mailman/listinfo/gnokii-users

Re: [patch]: Memory leak when a sqlite3 insert fails

Hi,

On Fri, Feb 10, 2012 at 10:24, Pedro Aguilar
<pedro.aguilar.iniestra <at> gmail.com> wrote:
> The attached file is a very simple patch that frees a buffer when an
> insert fails when using SQLite3 in smsd.

Thanks, applied.
http://git.savannah.gnu.org/cgit/gnokii.git/commit/?id=ed3253c3ecb76b4a7eea255843495e0005b6274b

take care,
--

-- 
Pawel Kot

Re: sms encoding problem on postgresql

Hi,

On Fri, Feb 10, 2012 at 13:26, Esmin Gracić <esmin.gracic <at> gmail.com> wrote:
> We have working (gnokii) smsd service on Debian 64bit, using

I have no idea why it happens but why is it that hard to imagine that
it is a MUST to provide gnokii version information?

> Postgresql 9.1 (utf8 db) as storage engine and ZTE MF622 usb modem.
> The issue is pg does not support utf16.

But what is the actual problem? This is not the problem description
from gnokii point of view.

> 1. How does smsd handle conversion from gsm encoding variants to uft8,
> and vice versa for sending?

What do you mean by "how"? Usually using iconv library.

> I see in official TODO:
> SHORT TERM
>  * remove encoding workarounds -- should be purely based on libiconv and
>   glib (in progress)

Well, it is mostly done. There are still leftovers with the
workarounds but only as alternative implementations.

> 2. Short term is how much exactly (estimation)?

Given current speed of development I'd say 5 years.

Re: sms encoding problem on postgresql

On Fri, Feb 10, 2012 at 8:25 PM, Pawel Kot <gnokii <at> gmail.com> wrote:
> Hi,
>
> On Fri, Feb 10, 2012 at 13:26, Esmin Gracić <esmin.gracic <at> gmail.com> wrote:
>> We have working (gnokii) smsd service on Debian 64bit, using
>
> I have no idea why it happens but why is it that hard to imagine that
> it is a MUST to provide gnokii version information?
>
not hard, just forgot - 0.6.31. sorry...

>> Postgresql 9.1 (utf8 db) as storage engine and ZTE MF622 usb modem.
>> The issue is pg does not support utf16.
>
> But what is the actual problem? This is not the problem description
> from gnokii point of view.

When there is any of  šđžćčlŠĐŽĆČ (serbian, croatian,
bosnian...)characters in sms (my guess is when sms is using utf16 and
not gsm-7) , I get ? in inbox instead of each of these.
If I send sms with any of this characters, sms receipient gets empty sms.

>
>> 1. How does smsd handle conversion from gsm encoding variants to uft8,
>> and vice versa for sending?
>
> What do you mean by "how"? Usually using iconv library.
>
>> I see in official TODO:
>> SHORT TERM

Re: sms encoding problem on postgresql

Hi,

On Sat, Feb 11, 2012 at 23:19, Esmin Gracić <esmin.gracic <at> gmail.com> wrote:
> On Fri, Feb 10, 2012 at 8:25 PM, Pawel Kot <gnokii <at> gmail.com> wrote:
>>> Postgresql 9.1 (utf8 db) as storage engine and ZTE MF622 usb modem.
>>> The issue is pg does not support utf16.
>>
>> But what is the actual problem? This is not the problem description
>> from gnokii point of view.
>
> When there is any of  šđžćčlŠĐŽĆČ (serbian, croatian,
> bosnian...)characters in sms (my guess is when sms is using utf16 and
> not gsm-7) , I get ? in inbox instead of each of these.
> If I send sms with any of this characters, sms receipient gets empty sms.

It should basically work. Can you try gnokii --getsms/--sendsms? If it
works then the problem lies somewhere between smsd and postgres. If it
does not it lies around libgnokii.

>>
>>> 1. How does smsd handle conversion from gsm encoding variants to uft8,
>>> and vice versa for sending?
>>
>> What do you mean by "how"? Usually using iconv library.
>>
>>> I see in official TODO:
>>> SHORT TERM
>>>  * remove encoding workarounds -- should be purely based on libiconv and
>>>   glib (in progress)
>>

Re: sms encoding problem on postgresql

On Sat, 11 Feb 2012, Esmin Gracić wrote:

> >> Postgresql 9.1 (utf8 db) as storage engine and ZTE MF622 usb modem.
> >> The issue is pg does not support utf16.
> >
> > But what is the actual problem? This is not the problem description
> > from gnokii point of view.
> 
> When there is any of  šđžćčlŠĐŽĆČ (serbian, croatian,
> bosnian...)characters in sms (my guess is when sms is using utf16 and
> not gsm-7) , I get ? in inbox instead of each of these.
> If I send sms with any of this characters, sms receipient gets empty sms.

The smsd - db conversion should work if you have the same client and server
encoding.  If your client has different encoding than db, try to use -e
option for setting client charset (see description of PQsetClientEncoding()
function in posgresql documentation). Postgresql library is then responsible
for correct conversion.
To check if gnokii library works, try with gnokii command line client.

jan

-- 

_______________________________________________
gnokii-users mailing list
gnokii-users <at> nongnu.org
https://lists.nongnu.org/mailman/listinfo/gnokii-users

Once more: Nokia C1-02 and gnokii

Hello,

at the moment i am unable to establish any kind of communication to my 
new Nokia C1-02 via gnokii.
I stumbled across the exchange between Petr Baudis and Pawel Kot, so my 
.gnokiirc looks like that:

[global]
model = series40
port = 1
connection = dku2libusb
[logging]
debug = on

when trying gnokii --identify, i get (after a couple of seconds):

~$ gnokii --identify
GNOKII Version 0.6.31
LOG: debug mask is 0x1
Config read from file /home/netman/.gnokiirc.
phone instance config:
model = series40
port = 1
connection = dku2libusb
initlength = default
serial_baudrate = 19200
serial_write_usleep = -1
handshake = software
require_dcd = 0
smsc_timeout = 10

Invitation to connect on LinkedIn

_______________________________________________
gnokii-users mailing list
gnokii-users <at> nongnu.org
https://lists.nongnu.org/mailman/listinfo/gnokii-users

stupid bug in xgnokii phonebook editor

Hi!

I've got a Nokia C1 phone, which does support multiple phone numbers per name
entry, that is the PM_EXTPBK flag, isn't it? xgnokii phone book editor shows up
correct but editing truncates the list.

Steps to reproduce: launch xgnokii, read phone book. Now create a new phone
book entry and add >1 numbers to it. Click ok, close the two dialogs. Reopen
the entry from the list, open the numbers list: it's truncated to one entry:

xgnokii/xgnokii_contacts.c line 395 in EditPhonebookEntry()

if (phoneMonitor.supported & PM_EXTPBK) {
    number = g_malloc(sizeof(char) * max_number_length);
    gtk_label_get(GTK_LABEL(data->number), number);
    snprintf(current_entry->entry.number, max_number_length, "%s", number[0]);
    snprintf(current_entry->entry.subentries[0].data.number, max_number_length,
"%s", number[0]);
    current_entry->entry.subentries[0].entry_type = GN_PHONEBOOK_ENTRY_Number;
    current_entry->entry.subentries[0].number_type =
GN_PHONEBOOK_NUMBER_General;
    // ??WTF::
    current_entry->entry.subentries_count = 1;
    g_free(number);
} else {
    snprintf(current_entry->entry.number, max_number_length, "%s",
         gtk_entry_get_text(GTK_ENTRY(data->number)));
}

This block doesn't make sense. Delete this block and the phone book works.
current_entry->entry.number is already set.

This is gnokii 0.6.32 from git/master  <at> 
4706c656ec05af5b44dbe98c075616817566329c

greets,

chr[]