headers
Dan Carpenter | 1 Mar 2011 01:03
Picon

Re: [staging-next 1/5] staging/easycap: add first level indentation to easycap_main

On Mon, Feb 28, 2011 at 07:27:06PM +0200, Tomas Winkler wrote:
> Add first level indentation to easayca_main.c
> This created around 300 lines over 80 characters.
> Around 100 of straight forward once were fixed in this patch.
> The another 200 require more code movement and need to be fixed
> later
> 

For this kind of patch it's better to ignore the over 80 char warnings
and send the fixes for that in a separate patch.

I've reviewed all five patches and I didn't see any bugs.  Some of the
JOM() and SAM() messages and normally that kind of thing should be 
mentioned in the changelog, but those were small changes so *shrug*.

regards,
dan carpenter
Permalink | Reply | 0 comments |
headers
Greg KH | 1 Mar 2011 03:22
Gravatar

Re: [PATCH2 17/22] staging: brcm80211: remove usage of struct osl_info for register access

On Sat, Feb 26, 2011 at 04:35:09AM +0300, Dan Carpenter wrote:
> On Fri, Feb 25, 2011 at 04:39:25PM +0100, Arend van Spriel wrote:
> > Register access to the device uses a flag in struct osl_info to determine
> > whether to use memory mapped access or not. This check was not needed as
> > it boils down to memory mapped for brcmsmac driver and not for brcmfmac
> > driver. Only use of struct osl_info is reduced to keeping track of the
> > number of allocated sk_buffs within the driver(s).
> 
> This one doesn't apply on linux-next.

Dan is right, this one doesn't apply.  So I've applied the first 16
patches in this series, but not the rest.  Care to redo them and resend?

thanks,

greg k-h
Permalink | Reply | 0 comments |
headers
Greg KH | 1 Mar 2011 03:32
Gravatar

Re: [PATCH 2/6] Staging: hv: Rename vm_device to hyperv_device

On Fri, Feb 25, 2011 at 06:06:03PM -0800, K. Y. Srinivasan wrote:
> Rename the vm_device abstraction as hyperv_device.

That's a nice name, but it's the first one with a "hyperv_" prefix in
this subsystem.  Ok, second, but hyperv_service_context doesn't really
count as it's not really used.

Everything else is named "hv_" here.  Which is it going to be, "hv_" or
"hyperv_"?

Either is fine, just be aware of the work involved if you pick
"hyperv_"...

You also rename vm_device_info to hyperv_device_info here, doing more
than one thing in a single patch.

Please don't do that, this should be 2 patches.

> 
> Signed-off-by: K. Y. Srinivasan <kys <at> microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz <at> microsoft.com>
> Signed-off-by: Hank Janssen <hjanssen <at> microsoft.com>
> 
> ---
>  drivers/staging/hv/blkvsc.c        |    4 +-
>  drivers/staging/hv/blkvsc_drv.c    |    8 ++--
>  drivers/staging/hv/channel_mgmt.h  |    2 +-
>  drivers/staging/hv/netvsc.c        |   56 +++++++++++++++++++----------------
>  drivers/staging/hv/netvsc.h        |    2 +-
>  drivers/staging/hv/netvsc_api.h    |   12 ++++----
(Continue reading)

Permalink | Reply | 1 comment |
headers
Greg KH | 1 Mar 2011 04:10
Gravatar

Re: [PATCH 1/4] brcm80211: use proper ieee80211 routines

On Sun, Feb 27, 2011 at 11:28:18PM +0300, Stanislav Fomichev wrote:

<snip>

I ended up applying 2 of these patches.  Care to resend the other two?

thanks,

greg k-h
Permalink | Reply | 3 comments |
headers
Greg KH | 1 Mar 2011 04:11
Gravatar

Re: [PATCH 2/2] staging: brcm80211: Remove unused variables and code clean up

On Sun, Feb 27, 2011 at 09:54:15PM +0100, Javier Martinez Canillas wrote:
> tsf_l and tsf_h variables where used in a code segment that is never compiled
> so the variables remains unused. 
> 
> Remove those variables and the code never compiled as well.
> 
> Signed-off-by: Javier Martinez Canillas <martinez.javier <at> gmail.com>
> ---
>  drivers/staging/brcm80211/brcmsmac/wlc_mac80211.c |    9 ---------

This doesn't apply anymore, care to redo it and resend?

thanks,

greg k-h
Permalink | Reply | 0 comments |
headers
Greg KH | 1 Mar 2011 04:07
Gravatar

Re: [PATCH 3/4] staging: brcm80211: remove unused TLV defines

On Sun, Feb 27, 2011 at 11:28:20PM +0300, Stanislav Fomichev wrote:
> 
> Signed-off-by: Stanislav Fomichev <kernel <at> fomichev.me>
> Acked-by: Roland Vossen <rvossen <at> broadcom.com>
> 
> ---
>  drivers/staging/brcm80211/include/proto/802.11.h |    4 ----

This doesn't apply anymore to the tree without a lot of fuzz.

Care to redo it and resend?

thanks,

greg k-h
Permalink | Reply | 0 comments |
headers
Greg KH | 1 Mar 2011 04:08
Gravatar

Re: [PATCH 4/4] brcm80211: replace broadcom specific defines

On Mon, Feb 28, 2011 at 12:51:35PM +0100, Roland Vossen wrote:
> Hi Stani,
> 
> >HT_CAP_MAX_AMSU ->  IEEE80211_HT_CAP_MAX_AMSU
> 
> Small spell mistake: this should be: HT_CAP_MAX_AMSDU ->
> IEEE80211_HT_CAP_MAX_AMSDU. But such a small mistake does not
> justify a new commit. Apart from that, your change looks fine with
> me. Thanks !

I'll edit it.

thanks,

greg k-h
Permalink | Reply | 0 comments |
headers
Dowan Kim | 1 Mar 2011 07:24
Favicon

RE: [PATCH] staging-2.6.git: brcm80211: FIX for bug that prevents system from entering suspend state

Dear Greg KH,

I am so sorry to make another annoyance with this mail but I don't understand why the patch no longer applies
to the staging-next tree. I've downloaded staging-2.6.git several times and checked the tree again and
again, but couldn't find the mistake I made.

Would you please give me a direction what I am supposed to do to make this patch right?

Again, I so sorry to bother you.

Regards,

Dowan Kim

-----Original Message-----
From: Greg KH [mailto:greg <at> kroah.com] 
Sent: Friday, February 18, 2011 1:06 PM
To: Dowan Kim
Cc: Brett Rudley; Henry Ptasinski; Roland Vossen; linux driver project; Venkat Rao
Subject: Re: [PATCH] staging-2.6.git: brcm80211: FIX for bug that prevents system from entering suspend state

On Tue, Feb 15, 2011 at 03:20:04PM -0800, Dowan Kim wrote:
> The attempt to enter to suspend mode can be hindered when the network
> interface is disabled.

Nice description, but this patch no longer applies to the staging-next
tree.  Care to redo it and resend?

thanks,
(Continue reading)

Permalink | Reply | 2 comments |
headers
Greg KH | 1 Mar 2011 07:43
Gravatar

Re: [PATCH] staging-2.6.git: brcm80211: FIX for bug that prevents system from entering suspend state

On Mon, Feb 28, 2011 at 10:24:00PM -0800, Dowan Kim wrote:
> Dear Greg KH,
> 
> I am so sorry to make another annoyance with this mail but I don't
> understand why the patch no longer applies to the staging-next tree.
> I've downloaded staging-2.6.git several times and checked the tree
> again and again, but couldn't find the mistake I made.
> 
> Would you please give me a direction what I am supposed to do to make
> this patch right?

What branch are you making the patch against?

How did you try to apply it?

How did you generate it?

Specifics please.

thanks,

greg k-h
Permalink | Reply | 0 comments |
headers
Dan Carpenter | 1 Mar 2011 07:45
Picon

Re: [PATCH] staging-2.6.git: brcm80211: FIX for bug that prevents system from entering suspend state

On Mon, Feb 28, 2011 at 10:24:00PM -0800, Dowan Kim wrote:
> Dear Greg KH,
> 
> I am so sorry to make another annoyance with this mail but I don't understand why the patch no longer applies
to the staging-next tree. I've downloaded staging-2.6.git several times and checked the tree again and
again, but couldn't find the mistake I made.
> 
> Would you please give me a direction what I am supposed to do to make this patch right?
> 

Your email client isn't configured correctly.  It's swapping tabs for
spaces.  Please read Documentation/email-clients.txt  There is a section
on Thunderbird.

1) Email the patch to yourself.
2) Save the raw email (including headers and everything)
3) cat saved_email.txt | patch -p1
4) When that works resubmit the patch.

regards,
dan carpenter
Permalink | Reply | 0 comments |

Gmane