headers
Thomas Weber | 15 Mar 2010 21:55
Picon

[PATCH 0/4] Some typo fixing

I have fixed some typos.

Thomas Weber (4):
  Fix typo: [Ss]ytem => [Ss]ystem
  Fix typo: udpate => update
  Fix typo: paramters => parameters
  Fix typo: orginal => original

 Documentation/cgroups/cgroups.txt               |    2 +-
 Documentation/kbuild/kconfig.txt                |    2 +-
 Documentation/sysfs-rules.txt                   |    2 +-
 Documentation/trace/events.txt                  |    8 ++++----
 drivers/acpi/osl.c                              |    4 ++--
 drivers/ata/ata_piix.c                          |    2 +-
 drivers/firewire/ohci.c                         |    2 +-
 drivers/gpu/drm/drm_bufs.c                      |    2 +-
 drivers/infiniband/hw/ipath/ipath_iba6110.c     |    2 +-
 drivers/infiniband/hw/ipath/ipath_iba6120.c     |    4 ++--
 drivers/infiniband/hw/ipath/ipath_iba7220.c     |    2 +-
 drivers/isdn/hisax/hfc4s8s_l1.c                 |    2 +-
 drivers/macintosh/windfarm_pm81.c               |    2 +-
 drivers/media/dvb/dvb-usb/friio-fe.c            |    2 +-
 drivers/net/smsc911x.c                          |    4 ++--
 drivers/pci/hotplug/cpqphp_core.c               |    2 +-
 drivers/pci/pci.c                               |    2 +-
 drivers/ps3/ps3-sys-manager.c                   |    2 +-
 drivers/regulator/core.c                        |    2 +-
 drivers/s390/char/sclp_cpi_sys.c                |    2 +-
 drivers/scsi/bfa/include/defs/bfa_defs_cee.h    |    2 +-
 drivers/scsi/bfa/include/defs/bfa_defs_status.h |    4 ++--
(Continue reading)

Permalink | Reply | 0 comments |
headers
Randy Dunlap | 15 Mar 2010 22:09

Re: [PATCH 0/4] Some typo fixing

On 03/15/10 13:55, Thomas Weber wrote:
> I have fixed some typos.

Acked-by: Randy Dunlap <rdunlap <at> xenotime.net>

Jiri, can you merge these, please, unless someone objects (?).

> Thomas Weber (4):
>   Fix typo: [Ss]ytem => [Ss]ystem
>   Fix typo: udpate => update
>   Fix typo: paramters => parameters
>   Fix typo: orginal => original
> 
>  Documentation/cgroups/cgroups.txt               |    2 +-
>  Documentation/kbuild/kconfig.txt                |    2 +-
>  Documentation/sysfs-rules.txt                   |    2 +-
>  Documentation/trace/events.txt                  |    8 ++++----
>  drivers/acpi/osl.c                              |    4 ++--
>  drivers/ata/ata_piix.c                          |    2 +-
>  drivers/firewire/ohci.c                         |    2 +-
>  drivers/gpu/drm/drm_bufs.c                      |    2 +-
>  drivers/infiniband/hw/ipath/ipath_iba6110.c     |    2 +-
>  drivers/infiniband/hw/ipath/ipath_iba6120.c     |    4 ++--
>  drivers/infiniband/hw/ipath/ipath_iba7220.c     |    2 +-
>  drivers/isdn/hisax/hfc4s8s_l1.c                 |    2 +-
>  drivers/macintosh/windfarm_pm81.c               |    2 +-
>  drivers/media/dvb/dvb-usb/friio-fe.c            |    2 +-
>  drivers/net/smsc911x.c                          |    4 ++--
>  drivers/pci/hotplug/cpqphp_core.c               |    2 +-
>  drivers/pci/pci.c                               |    2 +-
(Continue reading)

Permalink | Reply | 0 comments |
headers
Jiri Kosina | 16 Mar 2010 11:32
Picon

Re: [PATCH 0/4] Some typo fixing

On Mon, 15 Mar 2010, Randy Dunlap wrote:

> > I have fixed some typos.
> 
> Acked-by: Randy Dunlap <rdunlap <at> xenotime.net>
> 
> Jiri, can you merge these, please, unless someone objects (?).

Yes, I will take it, thanks. A couple comments though:

- [important!] Thomas, it's not necessary to CC zillions of people on such 
  patches. Just submit them to trivial <at> kernel.org (and eventually CC 
  lkml), and that's it. I believe many people might get annoyed by this.
- I will not be applying the drivers/staging hunks. Staging patches are 
  moving target, the code is changing quickly (including complete 
  drops/rewrites) so we'll likely be getting conflicts there. I will 
  reroute them to Greg.
- I will fold all the patches into one. We don't need one commit per one 
  specific typo.

--

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
Permalink | Reply | 0 comments |
headers
Dominik Brodowski | 1 Mar 2010 17:56

patch Staging-comedi-fix-coding-style-issues.patch

Hey,

On Sat, Feb 27, 2010 at 10:37:33AM +0000, Stewart Robertson wrote:
> From: Stewart Robertson <str at minty7.(none)>

Could you use a proper email-address here, please?

> Date: Sat, 27 Feb 2010 10:03:27 +0000
> Subject: [PATCH] Staging: comedi: fix coding style issues
> This is a patch to the ni_daq_dio24.c file that fixes line
> over 80 characters and KERN_INFO issues found by checkpatch.pl
> Signed-off-by: Stewart Robertson <stewart_r at aliencamel.com>

Please add a few spare blank lines between the Subject and the message, and
between the latter and the SoB-line.

Thanks!

	Dominik
Permalink | Reply | 0 comments |
headers
Ellwyn Cole | 1 Mar 2010 18:43

[PATCH 701/701] Staging: comedi: Fix 80 characters limit and printk issues in skel.c

>From f1ac349f0d531c7ba74abcefc9a1943bfe56536f Mon Sep 17 00:00:00 2001
From: Ellwyn Cole <ellwync <at> googlemail.com>
Date: Mon, 1 Mar 2010 16:44:01 +0000
Subject: [PATCH 701/701] Staging: comedi: Fix 80 characters limit and printk issues in skel.c

This is a patch to the skel.c file that fixes the 80 characters limit and
printk warnings found by the checkpatch.pl tool

Signed-off-by: Ellwyn Cole <ellwync at googlemail.com>
---
 drivers/staging/comedi/drivers/skel.c |   21 ++++++++++++---------
 1 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/comedi/drivers/skel.c b/drivers/staging/comedi/drivers/skel.c
index aba57d9..490753b 100644
--- a/drivers/staging/comedi/drivers/skel.c
+++ b/drivers/staging/comedi/drivers/skel.c
 <at>  <at>  -131,7 +131,8  <at>  <at>  MODULE_DEVICE_TABLE(pci, skel_pci_table);

 /* this structure is for data unique to this hardware driver.  If
    several hardware drivers keep similar information in this structure,
-   feel free to suggest moving the variable to the struct comedi_device struct.  */
+   feel free to suggest moving the variable to the struct comedi_device struct.
+ */
 struct skel_private {

 	int data;
 <at>  <at>  -211,7 +212,7  <at>  <at>  static int skel_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 {
 	struct comedi_subdevice *s;
(Continue reading)

Permalink | Reply | 0 comments |
headers
Chihau Chau | 2 Mar 2010 00:50
Picon
Gravatar

[PATCH] Staging: dream: pmem: fix some code style issues

From: Chihau Chau <chihau <at> gmail.com>

This fixes some code style issues like some braces {} deleted becouse
are not necessary for a single statement blocks and to include KERN_
facility level in the printk() functions.

Signed-off-by: Chihau Chau <chihau at gmail.com>
---
 drivers/staging/dream/pmem.c |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/dream/pmem.c b/drivers/staging/dream/pmem.c
index def6468..d8b5cb0 100644
--- a/drivers/staging/dream/pmem.c
+++ b/drivers/staging/dream/pmem.c
 <at>  <at>  -708,9 +708,8  <at>  <at>  int get_pmem_addr(struct file *file, unsigned long *start,
 	struct pmem_data *data;
 	int id;

-	if (!is_pmem_file(file) || !has_allocation(file)) {
+	if (!is_pmem_file(file) || !has_allocation(file))
 		return -1;
-	}

 	data = (struct pmem_data *)file->private_data;
 	if (data->index == -1) {
 <at>  <at>  -789,9 +788,8  <at>  <at>  void flush_pmem_file(struct file *file, unsigned long offset, unsigned long len)
 	struct list_head *elt;
 	void *flush_start, *flush_end;
(Continue reading)

Permalink | Reply | 1 comment |
headers
Jakob Penzien | 2 Mar 2010 03:16
Picon
Favicon

PATCH: ni_labpc.c


Subject: [PATCH] Staging: comedi: Fixed brace, KERN_, 80 characters issues in ni_labpc.c
 This is a patch to ni_labpc.c file that fixes all the brace
 and 80 character warnings and it also fixes some of the KERN_ facility
 warnings found by the checkpatch.pl tool. The two errors about indent warning
are there because I do not understand what they want and so I left it in the orginal code
and they happened to get pulled in the patch.
 Signed-off-by: Jakob Penzien <supermine290 at gmail.com>

---
 drivers/staging/comedi/drivers/ni_labpc.c |  219 ++++++++++++++++++-----------
 1 files changed, 135 insertions(+), 84 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_labpc.c b/drivers/staging/comedi/drivers/ni_labpc.c
index dc3f398..2140bd8 100644
--- a/drivers/staging/comedi/drivers/ni_labpc.c
+++ b/drivers/staging/comedi/drivers/ni_labpc.c
 <at>  <at>  -1,7 +1,8  <at>  <at> 
 /*
     comedi/drivers/ni_labpc.c
     Driver for National Instruments Lab-PC series boards and compatibles
   Copyright (C) 2001, 2002, 2003 Frank Mori Hess <fmhess at users.sourceforge.net>
+    Copyright (C) 2001, 2002, 2003 Frank Mori Hess
+    <fmhess at users.sourceforge.net>

     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
 <at>  <at>  -101,15 +102,15  <at>  <at>  NI manuals:
 #define   ADC_CHAN_BITS(x)	((x) & 0x7)
 #define   ADC_SCAN_EN_BIT	0x80	/*  enables multi channel scans */
(Continue reading)

Permalink | Reply | 0 comments |
headers
Pavel Machek | 2 Mar 2010 06:24
Picon

[PATCH] Staging: dream: pmem: fix some code style issues (fwd)

----- Forwarded message from Pavel Machek <pavel at ucw.cz> -----

From: Pavel Machek <pavel <at> ucw.cz>
To: Chihau Chau <chihau at gmail.com>
Cc: gregkh at suse.de, devel at driverdev.osuosl.org,
	linux-kernel at vger.kernel.org
Subject: Re: [PATCH] Staging: dream: pmem: fix some code style issues
X-Warning: Reading this can be dangerous to your mental health.

On Mon 2010-03-01 20:50:15, Chihau Chau wrote:
> From: Chihau Chau <chihau at gmail.com>
> 
> This fixes some code style issues like some braces {} deleted becouse
> are not necessary for a single statement blocks and to include KERN_
> facility level in the printk() functions.

Most of patch is good, but...

>  <at>  <at>  -936,8 +934,8  <at>  <at>  int pmem_remap(struct pmem_region *region, struct file *file,
>  	if (unlikely(!PMEM_IS_PAGE_ALIGNED(region->offset) ||
>  		 !PMEM_IS_PAGE_ALIGNED(region->len))) {
>  #if PMEM_DEBUG
> -		printk("pmem: request for unaligned pmem suballocation "
> -		       "%lx %lx\n", region->offset, region->len);
> +		printk(KERN_ERR "pmem: request for unaligned pmem "
> +			"suballocation %lx %lx\n", region->offset, region->len);
>  #endif
>  		return -EINVAL;
>  	}
(Continue reading)

Permalink | Reply | 0 comments |
headers
Barclays Bank Plc | 2 Mar 2010 19:54
Picon

Barclays Bank Plc

Barclays Bank Plc
1 Churchill Place
London, E14 5HP, United Kingdom
http://www.barclays.co.uk

Dear Esteemed Customer,

We at this bank wish to congratulate and inform you that after thorough
review of your Inheritance/Contract funds transfer release documents in
conjunction with the World Bank and the International Monetary Fund
assessment report, your payment file was forwarded to us for immediate
transfer of a part-payment US$5,800,000.00 to your designated bank account
from their offshore account with us.

The audit reports given to us, shows that you have been going through hard
times by paying a lot
of money to see to the release of your funds, which has been delayed by
some dubious officials.
We therefore advice that you stop further communication with any
correspondence outside this office since you do not have to pay any money
or fee to receive your funds as you have met up with the whole funds
transfer requirements.

The only thing required from you is to obtain the Non-Residential
Clearance Form to enable us credit your account directly by telegraphic
transfer or through any of our corresponding banks and send copies of the
funds transfer release documents to you and your bankers for confirmation.
Should you follow our directives, your funds will be credited and reflect
in your bank account within five (5) bank working days from the day you
obtain this Non-Residential Clearance Form.
(Continue reading)

Permalink | Reply | 0 comments |

Gmane