headers
Henrik Kurelid | 5 Dec 2008 10:45
Picon

[patch 0/2]: firedtv cleanup and fixes

Hi,

I have done some work on the firedtv driver to get scrambled channels working in mythtv as well as cleaning up
some FIXMEs. This is the result so far:

0001-firedtv-fix-returned-struct-for-ca_info.patch: Removes a FIXME by correctly setting the
CA_INFO struct.
0002-firedtv-use-length_field-of-PMT-as-length.patch: Enables encrypted channels in mythtv by
interpreting length_field() as the length of CA_PMT
instead of the length field of the ca_msg struct.

The patches are to follow.

Regards,
Henrik
Permalink | Reply | 2 comments |
headers
Henrik Kurelid | 5 Dec 2008 10:47
Picon

[patch 1/2]: firedtv: fix returned struct for ca_info

>From 8aa2c50a84ca7009ea176ddef58dbec3e3a6a2a3 Mon Sep 17 00:00:00 2001
From: Henrik Kurelid <henrik <at> kurelid.se>
Date: Thu, 4 Dec 2008 22:40:52 +0100
Subject: [PATCH] firedtv: fix returned struct for ca_info

The SystemId of the ca_info message was filled with garbage.
It now returns what the card returns.

Signed-off-by: Henrik Kurelid <henrik at kurelid.se>
---
 drivers/media/dvb/firesat/avc_api.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/dvb/firesat/avc_api.c b/drivers/media/dvb/firesat/avc_api.c
index 56911f3..3a4da73 100644
--- a/drivers/media/dvb/firesat/avc_api.c
+++ b/drivers/media/dvb/firesat/avc_api.c
 <at>  <at>  -763,7 +763,7  <at>  <at>  int avc_ca_info(struct firesat *firesat, char *app_info, unsigned int *len)
 {
 	AVCCmdFrm CmdFrm;
 	AVCRspFrm RspFrm;
-	/* int pos;  FIXME: unused */
+	int pos;

 	memset(&CmdFrm, 0, sizeof(AVCCmdFrm));
 	CmdFrm.cts = AVC;
 <at>  <at>  -783,13 +783,13  <at>  <at>  int avc_ca_info(struct firesat *firesat, char *app_info, unsigned int *len)
 	if (avc_write(firesat, &CmdFrm, &RspFrm) < 0)
 		return -EIO;
(Continue reading)

Permalink | Reply | 0 comments |
headers
Henrik Kurelid | 5 Dec 2008 10:48
Picon

[patch 2/2]: firedtv: use length_field() of PMT as length

>From 750daa3bccae26cde9806dad3b4b81eb9baa81c7 Mon Sep 17 00:00:00 2001
From: Henrik Kurelid <henrik <at> kurelid.se>
Date: Fri, 5 Dec 2008 10:00:16 +0100
Subject: [PATCH] firedtv: use length_field() of PMT as length

Parsed and used the length_field() of the PMT mesage instead of using
the length field of the message struct, which does not seem to be
filled correctly by e.g. MythTV.

Signed-off-by: Henrik Kurelid <henrik at kurelid.se>
---
 drivers/media/dvb/firesat/firesat-ci.c |   20 ++++++++++++++------
 1 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/drivers/media/dvb/firesat/firesat-ci.c b/drivers/media/dvb/firesat/firesat-ci.c
index 0deb47e..b4ac414 100644
--- a/drivers/media/dvb/firesat/firesat-ci.c
+++ b/drivers/media/dvb/firesat/firesat-ci.c
 <at>  <at>  -127,14 +127,22  <at>  <at>  static int firesat_ca_pmt(struct firesat *firesat, void *arg)
 {
 	struct ca_msg *msg = arg;
 	int data_pos;
-
-	if (msg->msg[3] & 0x80)
-		data_pos = (msg->msg[4] && 0x7F) + 4;
-	else
-		data_pos = 4;
+	int data_length;
+	int i;
+
(Continue reading)

Permalink | Reply | 1 comment |
headers
Greg KH | 6 Dec 2008 01:10
Gravatar

[patch 0/2]: firedtv cleanup and fixes

On Fri, Dec 05, 2008 at 10:45:04AM +0100, Henrik Kurelid wrote:
> Hi,
> 
> I have done some work on the firedtv driver to get scrambled channels
> working in mythtv as well as cleaning up some FIXMEs. This is the
> result so far:

Looks good, have you pushed these upstream yet?

thanks,

greg k-h
Permalink | Reply | 1 comment |
headers
Stefan Richter | 6 Dec 2008 12:23
Picon

[patch 0/2]: firedtv cleanup and fixes

Greg KH wrote:
> On Fri, Dec 05, 2008 at 10:45:04AM +0100, Henrik Kurelid wrote:
>> Hi,
>>
>> I have done some work on the firedtv driver to get scrambled channels
>> working in mythtv as well as cleaning up some FIXMEs. This is the
>> result so far:
> 
> Looks good, have you pushed these upstream yet?

I took them into linux1394-2.6.git.  Thanks Henrik,
--

-- 
Stefan Richter
-=====-==--- ==-- --==-
http://arcgraph.de/sr/
Permalink | Reply | 0 comments |
headers
Stefan Richter | 6 Dec 2008 12:30
Picon

[patch 2/2]: firedtv: use length_field() of PMT as length

Henrik Kurelid wrote:
> Parsed and used the length_field() of the PMT mesage instead of using
> the length field of the message struct, which does not seem to be
> filled correctly by e.g. MythTV.

I changed braces/ whitespace a little bit:
http://git.kernel.org/?p=linux/kernel/git/ieee1394/linux1394-2.6.git;a=commitdiff_plain;h=cf9b68898263d427e110a5dc8caad14c69605f98
--

-- 
Stefan Richter
-=====-==--- ==-- --==-
http://arcgraph.de/sr/
Permalink | Reply | 0 comments |
headers
Henrik Kurelid | 15 Dec 2008 08:17
Picon

[PATCH] firedtv: adapter number could only be zero

From: Henrik Kurelid <henrik <at> kurelid.se>

There was a bug causing the initialization to fail if adapter number was
greater than zero. The adapter was however registered which caused the driver
to oops the second time initialization was tried.

Signed-off-by: Henrik Kurelid <henrik at kurelid.se>
---
 drivers/media/dvb/firesat/firesat_dvb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/dvb/firesat/firesat_dvb.c b/drivers/media/dvb/firesat/firesat_dvb.c
index cfa3a2e..cb36c03 100644
--- a/drivers/media/dvb/firesat/firesat_dvb.c
+++ b/drivers/media/dvb/firesat/firesat_dvb.c
 <at>  <at>  -206,7 +206,7  <at>  <at>  int firesat_dvbdev_init(struct firesat *firesat, struct device *dev)
 	err = DVB_REGISTER_ADAPTER(&firesat->adapter,
 				   firedtv_model_names[firesat->type],
 				   THIS_MODULE, dev, adapter_nr);
-	if (err)
+	if (err < 0)
 		goto fail_log;

 	/*DMX_TS_FILTERING | DMX_SECTION_FILTERING*/
--

-- 
1.5.4.3
Permalink | Reply | 2 comments |
headers
Stefan Richter | 15 Dec 2008 18:11
Picon

[PATCH] firedtv: adapter number could only be zero

Henrik Kurelid wrote:
> There was a bug causing the initialization to fail if adapter number was
> greater than zero. The adapter was however registered which caused the driver
> to oops the second time initialization was tried.

Committed to linux1394-2.6.git.  Thanks,
--

-- 
Stefan Richter
-=====-==--- ==-- -====
http://arcgraph.de/sr/
Permalink | Reply | 1 comment |
headers
Henrik Kurelid | 15 Dec 2008 21:41
Picon

[PATCH] firedtv: adapter number could only be zero

I have some more cleanups on the way so until you tell me otherwise I will keep posting the patches on the list.

Regards,
Henrik

> Henrik Kurelid wrote:
>> There was a bug causing the initialization to fail if adapter number was
>> greater than zero. The adapter was however registered which caused the driver
>> to oops the second time initialization was tried.
>
> Committed to linux1394-2.6.git.  Thanks,
> --
> Stefan Richter
> -=====-==--- ==-- -====
> http://arcgraph.de/sr/
>
Permalink | Reply | 0 comments |
headers
Greg KH | 16 Dec 2008 21:51
Gravatar

Tranzport and Alphatrack surfaces kernel drivers now in a git tree

On Wed, Apr 16, 2008 at 08:19:16AM +0930, Michael Taht wrote:
> Last year around this time I was working on Linux kernel drivers for the
> Frontier Designs Alphatrack and Tranzport. I got stuck on the API
> issues. See:
> 
> http://www.frontierdesign.com/Products/TranzPort and
> http://www.frontierdesign.com/Products/AlphaTrack
> 
> I have had had since, at best irregular connections to the internet, so
> working with ardour svn has been difficult, and rapidly the rest of the
> surfaces branch of ardour became obsolete, so I just pulled the drivers
> out and put them in a git repository:
> 
> git clone git://teklibre.com/home/d/src/git/frontier.git

This link seems to be dead now.  Do you have a pointer to where it might
have moved to so that we can see about moving this code into the kernel
staging tree?

Sorry for the long delay,

greg k-h
Permalink | Reply | 0 comments |

Gmane