Linux Driver Project development and general discussion ()

Tülin İzer | 22 May 2013 03:20

Picon

[PATCH v2 0/6] fixed checkpatch warnings in tidspbridge.

Changes from v1:
- Subject lines fixed.

This patchset fixes following warnings:

Tülin İzer (6):
  Staging: tidspbridge: _tiomap_pwr.h: fixed indentation warning.
  Staging: tidspbridge: ue_deh.c: fixed space formatting issue.
  Staging: tidspbridge: wdt.c: fixed indentation warning.
  Staging: tidspbridge: tiomap3430_pwr.c: fixed indentation warning.
  Staging: tidspbridge: _tiomap.h: fixed indentation warning.
  Staging: tidspbridge: _tiomap.h: fixed warning 'space prohibited
    before semicolon'.

 drivers/staging/tidspbridge/core/_tiomap.h        |    6 +++---
 drivers/staging/tidspbridge/core/_tiomap_pwr.h    |   10 +++++-----
 drivers/staging/tidspbridge/core/tiomap3430_pwr.c |   10 +++++-----
 drivers/staging/tidspbridge/core/ue_deh.c         |    2 +-
 drivers/staging/tidspbridge/core/wdt.c            |    4 ++--
 5 files changed, 16 insertions(+), 16 deletions(-)

--

-- 
1.7.9.5

_______________________________________________
devel mailing list
devel <at> linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Severin Gsponer | 22 May 2013 02:13

Picon

[PATCH 2/2] Staging: bcm: Change comment style to C89 in vendorspecificextn.c

Changed the comment style to C89 in vendorspecificextn.c. Found with checkpatch.pl

Signed-off-by: Severin Gsponer <svgsponer <at> gmail.com>
---
 drivers/staging/bcm/vendorspecificextn.c |  198 +++++++++++++++---------------
 1 file changed, 97 insertions(+), 101 deletions(-)

diff --git a/drivers/staging/bcm/vendorspecificextn.c b/drivers/staging/bcm/vendorspecificextn.c
index be1f91d..d38a06f 100644
--- a/drivers/staging/bcm/vendorspecificextn.c
+++ b/drivers/staging/bcm/vendorspecificextn.c
 <at>  <at>  -1,70 +1,70  <at>  <at> 
 #include "headers.h"
-//-----------------------------------------------------------------------------
-// Procedure:	vendorextnGetSectionInfo
-//
-// Description: Finds the type of NVM used.
-//
-// Arguments:
-//		Adapter    - ptr to Adapter object instance
-//		pNVMType   - ptr to NVM type.
-// Returns:
-//		STATUS_SUCCESS/STATUS_FAILURE
-//
-//-----------------------------------------------------------------------------
+/*
+ * Procedure:	vendorextnGetSectionInfo
+ *
+ * Description: Finds the type of NVM used.
+ *

(Continue reading)

Severin Gsponer | 22 May 2013 01:46

Picon

[PATCH] Staging: bcm: fix checkpatch errors and warnings in Version.h

This patch change the comment style to C89 and removes a unnecessary line.

Signed-off-by: Severin Gsponer <svgsponer <at> gmail.com>
---
 drivers/staging/bcm/Version.h |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/staging/bcm/Version.h b/drivers/staging/bcm/Version.h
index a07b956..f1cb9de 100644
--- a/drivers/staging/bcm/Version.h
+++ b/drivers/staging/bcm/Version.h
 <at>  <at>  -1,4 +1,3  <at>  <at> 
-
 /*Copyright (c) 2005 Beceem Communications Inc.

 Module Name:
 <at>  <at>  -17,7 +16,6  <at>  <at>  Abstract:
 #define VER_FILETYPE                VFT_DRV
 #define VER_FILESUBTYPE             VFT2_DRV_NETWORK

-
 #define VER_FILEVERSION             5.2.45
 #define VER_FILEVERSION_STR         "5.2.45"

 <at>  <at>  -28,8 +26,4  <at>  <at>  Abstract:
 #define VER_PRODUCTVERSION_STR      VER_FILEVERSION_STR

 
-
-

(Continue reading)

Tomas Hozza | 21 May 2013 15:36

Picon

[PATCH 1/4] tools: hv: Check return value of setsockopt call

Check return value of setsockopt call and if it fails print error
to the system log and exit with non-zero value.

Signed-off-by: Tomas Hozza <thozza <at> redhat.com>
---
 tools/hv/hv_kvp_daemon.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
index 5a1f648..b30f831 100644
--- a/tools/hv/hv_kvp_daemon.c
+++ b/tools/hv/hv_kvp_daemon.c
 <at>  <at>  -1457,7 +1457,13  <at>  <at>  int main(void)
 		exit(EXIT_FAILURE);
 	}
 	nl_group = CN_KVP_IDX;
-	setsockopt(fd, SOL_NETLINK, NETLINK_ADD_MEMBERSHIP, &nl_group, sizeof(nl_group));
+	
+	if (setsockopt(fd, SOL_NETLINK, NETLINK_ADD_MEMBERSHIP, &nl_group, sizeof(nl_group)) < 0) {
+		syslog(LOG_ERR, "setsockopt failed; error: %d %s" errno, strerror(errno));
+		close(fd);
+		exit(EXIT_FAILURE);
+	}
+
 	/*
 	 * Register ourselves with the kernel.
 	 */
--

-- 
1.8.1.4

(Continue reading)

H Hartley Sweeten | 20 May 2013 23:32

[PATCH 14/15] staging: comedi: usbduxsigma: move firmware request/upload into (*auto_attach)

The last step the usb_driver (*probe) does before handing off to the
comedi_driver (*auto_attach) is requesting and uploading the firmware.

Move the request/upload into the (*auto_attach) so we can use the
comedi_load_firmware() helper.

Signed-off-by: H Hartley Sweeten <hsweeten <at> visionengravers.com>
Cc Ian Abbott <abbotti <at> mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>
---
 drivers/staging/comedi/drivers/usbduxsigma.c | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
index 15c5bd1..26357b9 100644
--- a/drivers/staging/comedi/drivers/usbduxsigma.c
+++ b/drivers/staging/comedi/drivers/usbduxsigma.c
 <at>  <at>  -2234,12 +2234,22  <at>  <at>  static int usbduxsigma_auto_attach(struct comedi_device *dev,
 				   unsigned long context_unused)
 {
 	struct usb_interface *uinterf = comedi_to_usb_interface(dev);
+	struct usbduxsub *uds = usb_get_intfdata(uinterf);
+	struct usb_device *usb = uds->usbdev;
+	const struct firmware *fw;
 	int ret;
-	struct usbduxsub *uds;
+
+	ret = request_firmware(&fw, FIRMWARE, &usb->dev);
+	if (ret == 0) {
+		ret = firmwareUpload(uds, fw->data, fw->size);

(Continue reading)

H Hartley Sweeten | 20 May 2013 23:31

[PATCH 13/15] staging: comedi: usbduxsigma: consolidate the firmware upload

Absorb the usbduxsub_stop(), usbduxsub_upload(), and usbduxsub_start()
functions into firmwareUpload().

Each of them just do a usb_control_msg() to the device and output
an error message if it fails. A similar message is also output by
firmware_upload() so the extra messages are redundant.

We can also share the malloc'ed local buffer needed for the
usb_control_msg().

Signed-off-by: H Hartley Sweeten <hsweeten <at> visionengravers.com>
Cc Ian Abbott <abbotti <at> mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>
---
 drivers/staging/comedi/drivers/usbduxsigma.c | 166 ++++++++-------------------
 1 file changed, 47 insertions(+), 119 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
index f8102f5..15c5bd1 100644
--- a/drivers/staging/comedi/drivers/usbduxsigma.c
+++ b/drivers/staging/comedi/drivers/usbduxsigma.c
 <at>  <at>  -667,156 +667,84  <at>  <at>  static void usbduxsub_ao_IsocIrq(struct urb *urb)
 	}
 }

-static int usbduxsub_start(struct usbduxsub *usbduxsub)
-{
-	int errcode = 0;
-	uint8_t *local_transfer_buffer;
-

(Continue reading)

H Hartley Sweeten | 20 May 2013 23:20

[PATCH 01/15] staging: comedi: introduce comedi_to_usb_dev()

Introduce a helper function to get a usb_device pointer from a
comedi_device pointer.

Signed-off-by: H Hartley Sweeten <hsweeten <at> visionengravers.com>
Cc Ian Abbott <abbotti <at> mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>
---
 drivers/staging/comedi/comedi_usb.c | 12 ++++++++++++
 drivers/staging/comedi/comedidev.h  |  1 +
 2 files changed, 13 insertions(+)

diff --git a/drivers/staging/comedi/comedi_usb.c b/drivers/staging/comedi/comedi_usb.c
index b72da79..13f18be 100644
--- a/drivers/staging/comedi/comedi_usb.c
+++ b/drivers/staging/comedi/comedi_usb.c
 <at>  <at>  -31,6 +31,18  <at>  <at>  struct usb_interface *comedi_to_usb_interface(struct comedi_device *dev)
 EXPORT_SYMBOL_GPL(comedi_to_usb_interface);

 /**
+ * comedi_to_usb_dev() - comedi_device pointer to usb_device pointer.
+ *  <at> dev: comedi_device struct
+ */
+struct usb_device *comedi_to_usb_dev(struct comedi_device *dev)
+{
+	struct usb_interface *intf = comedi_to_usb_interface(dev);
+
+	return intf ? interface_to_usbdev(intf) : NULL;
+}
+EXPORT_SYMBOL_GPL(comedi_to_usb_dev);
+

(Continue reading)

H Hartley Sweeten | 20 May 2013 23:30

[PATCH 10/15] staging: comedi: usbdux: move firmware request/upload into (*auto_attach)

The last step the usb_driver (*probe) does before handing off to the
comedi_driver (*auto_attach) is requesting and uploading the firmware.

Move the request/upload into the (*auto_attach) so we can use the
comedi_load_firmware() helper.

Signed-off-by: H Hartley Sweeten <hsweeten <at> visionengravers.com>
Cc Ian Abbott <abbotti <at> mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>
---
 drivers/staging/comedi/drivers/usbdux.c | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
index 405a345..59a2046 100644
--- a/drivers/staging/comedi/drivers/usbdux.c
+++ b/drivers/staging/comedi/drivers/usbdux.c
 <at>  <at>  -2249,13 +2249,22  <at>  <at>  static int usbdux_auto_attach(struct comedi_device *dev,
 			      unsigned long context_unused)
 {
 	struct usb_interface *uinterf = comedi_to_usb_interface(dev);
+	struct usbduxsub *this_usbduxsub = usb_get_intfdata(uinterf);
+	struct usb_device *usb = usbduxsub->usbdev;
+	const struct firmware *fw;
 	int ret;
-	struct usbduxsub *this_usbduxsub;
+
+	ret = request_firmware(&fw, FIRMWARE, &usb->dev);
+	if (ret == 0) {
+		ret = firmware_upload(this_usbduxsub, fw->data, fw->size);

(Continue reading)

H Hartley Sweeten | 20 May 2013 23:29

[PATCH 09/15] staging: comedi: usbdux: consolidate the firmware upload

Absorb the usbdux_stop(), usbdux_upload(), and usbdux_start()
functions into firmware_upload().

Each of them just do a usb_control_msg() to the device and output
an error message if it fails. A similar message is also output by
firmware_upload() so the extra messages are redundant.

We can also share the malloc'ed local buffer needed for the
usb_control_msg().

Signed-off-by: H Hartley Sweeten <hsweeten <at> visionengravers.com>
Cc Ian Abbott <abbotti <at> mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>
---
 drivers/staging/comedi/drivers/usbdux.c | 166 +++++++++-----------------------
 1 file changed, 46 insertions(+), 120 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
index cb63c77..405a345 100644
--- a/drivers/staging/comedi/drivers/usbdux.c
+++ b/drivers/staging/comedi/drivers/usbdux.c
 <at>  <at>  -722,154 +722,80  <at>  <at>  static void usbduxsub_ao_isoc_irq(struct urb *urb)
 	}
 }

-static int usbduxsub_start(struct usbduxsub *usbduxsub)
-{
-	int errcode = 0;
-	uint8_t *local_transfer_buffer;
-

(Continue reading)

H Hartley Sweeten | 20 May 2013 23:32

[PATCH 15/15] staging: comedi: usbduxsigma: use comedi_load_firmware()

Use comedi_load_firmware() instead of duplicating the code in a
private function.

Also, rename firmwareUpload() to have namespace associated with
the driver.

Signed-off-by: H Hartley Sweeten <hsweeten <at> visionengravers.com>
Cc Ian Abbott <abbotti <at> mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>
---
 drivers/staging/comedi/drivers/usbduxsigma.c | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
index 26357b9..5663197 100644
--- a/drivers/staging/comedi/drivers/usbduxsigma.c
+++ b/drivers/staging/comedi/drivers/usbduxsigma.c
 <at>  <at>  -50,7 +50,7  <at>  <at>  Status: testing
 #include <linux/usb.h>
 #include <linux/fcntl.h>
 #include <linux/compiler.h>
-#include <linux/firmware.h>
+
 #include "comedi_fc.h"
 #include "../comedidev.h"

 <at>  <at>  -670,9 +670,11  <at>  <at>  static void usbduxsub_ao_IsocIrq(struct urb *urb)
 /* the FX2LP has twice as much as the standard FX2 */
 #define FIRMWARE_MAX_LEN 0x4000

(Continue reading)

H Hartley Sweeten | 20 May 2013 23:31

[PATCH 12/15] staging: comedi: usbduxsigma: request firmware synchronously

Change the request_firmware_nowait() to a request_firmware() so
that the usb_driver (*probe) can continue with the comedi_driver
(*auto_attach).

Signed-off-by: H Hartley Sweeten <hsweeten <at> visionengravers.com>
Cc Ian Abbott <abbotti <at> mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>
---
 drivers/staging/comedi/drivers/usbduxsigma.c | 48 ++++------------------------
 1 file changed, 7 insertions(+), 41 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
index d34663f..f8102f5 100644
--- a/drivers/staging/comedi/drivers/usbduxsigma.c
+++ b/drivers/staging/comedi/drivers/usbduxsigma.c
 <at>  <at>  -2346,40 +2346,12  <at>  <at>  static struct comedi_driver usbduxsigma_driver = {
 	.detach		= usbduxsigma_detach,
 };

-static void usbdux_firmware_request_complete_handler(const struct firmware *fw,
-						     void *context)
-{
-	struct usbduxsub *usbduxsub_tmp = context;
-	struct usb_interface *uinterf = usbduxsub_tmp->interface;
-	int ret;
-
-	if (fw == NULL) {
-		dev_err(&uinterf->dev,
-			"Firmware complete handler without firmware!\n");
-		return;

(Continue reading)

Group

gmane.linux.drivers.driver-project.devel.

Project Web Page

Linux Driver Project development and general discussion ()

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11

May 2013

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

[PATCH v2 0/6] fixed checkpatch warnings in tidspbridge. (22 May 2013)
[PATCH 2/2] Staging: bcm: Change comment style to C89 in vendorspecifi (22 May 2013)
[PATCH] Staging: bcm: fix checkpatch errors and warnings in Version.h (22 May 2013)
[PATCH 1/4] tools: hv: Check return value of setsockopt call (21 May 2013)
[PATCH 14/15] staging: comedi: usbduxsigma: move firmware request/uplo (20 May 2013)
[PATCH 13/15] staging: comedi: usbduxsigma: consolidate the firmware u (20 May 2013)
[PATCH 01/15] staging: comedi: introduce comedi_to_usb_dev() (20 May 2013)
[PATCH 10/15] staging: comedi: usbdux: move firmware request/upload in (20 May 2013)
[PATCH 09/15] staging: comedi: usbdux: consolidate the firmware upload (20 May 2013)
[PATCH 15/15] staging: comedi: usbduxsigma: use comedi_load_firmware() (20 May 2013)
[PATCH 12/15] staging: comedi: usbduxsigma: request firmware synchrono (20 May 2013)
[PATCH -next] staging: btmtk_usb: remove unused including (21 May 2013)
[PATCH 11/15] staging: comedi: usbdux: use comedi_load_firmware() (20 May 2013)
[PATCH 00/15] staging: comedi: tidy up some usb driver boilerplate (20 May 2013)
[PATCH 0/6] fixed checkpatch warnings in tidspbridge. (21 May 2013)
[PATCH] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to (21 May 2013)
[PATCH 03/15] staging: comedi: vmk80xx: don't pass the private data di (20 May 2013)
[PATCH 04/15] staging: comedi: vmk80xx: use comedi_to_usb_dev() (20 May 2013)
[PATCH 02/15] staging: comedi: usbduxfast: use comedi_to_usb_dev() (20 May 2013)
[PATCH 07/15] staging: comedi: usbduxfast: use comedi_load_firmware() (20 May 2013)
[PATCH 06/15] staging: comedi: dt9812: use comedi_to_usb_dev() (20 May 2013)

Archives

561	May 2013
678	April 2013
875	March 2013
631	February 2013
815	January 2013
399	December 2012
1126	November 2012
879	October 2012
1323	September 2012
608	August 2012
966	July 2012
1010	June 2012
1037	May 2012
582	April 2012
372	March 2012
449	February 2012
431	January 2012
514	December 2011
660	November 2011
640	October 2011
630	September 2011
1147	August 2011
622	July 2011
449	June 2011
828	May 2011
550	April 2011
1663	March 2011
744	February 2011
1080	January 2011
459	December 2010
464	November 2010
571	October 2010
587	September 2010
814	August 2010
314	July 2010
518	June 2010
1161	May 2010
406	April 2010
979	March 2010
301	February 2010
162	January 2010
450	December 2009
188	November 2009
303	October 2009
970	September 2009
203	August 2009
255	July 2009
436	June 2009
21	May 2009
9	April 2009
14	March 2009
4	February 2009
14	January 2009
10	December 2008
13	November 2008
14	October 2008
12	September 2008
41	August 2008
16	July 2008
68	June 2008
28	May 2008
60	April 2008
13	March 2008
15	February 2008
8	January 2008
54	November 2007
239	October 2007
37	September 2007
1	July 2007

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template