Luca Ellero | 19 Sep 13:50 2014

[PATCH v3 0/8] comedi: ni_usb6501: add counter support

This series of patches add counter support for NI USB-6501. I tested it on my
device and it works fine.

Changes for v2:
- rewrite patch 3/9 changelog: replace "fix" with "cleanup"
- avoid sparse warnings
- add SDF_LSAMPL flag to counter subdevice

Changes for v3:
- remove useless checks
- remove empty lines
- ni6501_auto_attach(): replace spaces with tabs for proper alignment
- squash last 5 patches into a single patch (add counter subdevice) to avoid 
  compilation warnings "function defined but not used"
- rename "counter" local vars to "val" to avoid ambiguity with counter number
- let ni6501_cnt_insn_config() return the insn->n value if it succeeds
- let ni6501_cnt_insn_read read insn->n values
- let ni6501_cnt_insn_write be able to handle an array of values

Luca Ellero (8):
  staging: comedi: ni_usb6501: add counter commands
  staging: comedi: ni_usb6501: update comments
  staging: comedi: ni_usb6501: cleanup response_size
  staging: comedi: ni_usb6501: replace spaces with tabs
  staging: comedi: ni_usb6501: remove useless check
  staging: comedi: ni_usb6501: remove empty lines
  staging: comedi: ni_usb6501: rename ni6501_send_command()
  staging: comedi: ni_usb6501: add counter subdevice

 drivers/staging/comedi/drivers/ni_usb6501.c |  260 +++++++++++++++++++++++----
(Continue reading)

Dan Carpenter | 19 Sep 12:43 2014
Picon

[patch 1/2] staging: vt6655: buffer overflow in ioctl

->u.generic_elem.len is a user controlled number between 0-255.  We
should limit it to avoid memory corruption.

Signed-off-by: Dan Carpenter <dan.carpenter <at> oracle.com>

diff --git a/drivers/staging/vt6655/hostap.c b/drivers/staging/vt6655/hostap.c
index 0dd87d4..73429f4 100644
--- a/drivers/staging/vt6655/hostap.c
+++ b/drivers/staging/vt6655/hostap.c
 <at>  <at>  -341,6 +341,9  <at>  <at>  static int hostap_set_generic_element(struct vnt_private *pDevice,
 {
 	PSMgmtObject    pMgmt = pDevice->pMgmt;

+	if (param->u.generic_elem.len > sizeof(pMgmt->abyWPAIE))
+		return -EINVAL;
+
 	memcpy(pMgmt->abyWPAIE,
 	       param->u.generic_elem.data,
 	       param->u.generic_elem.len
Rene Kolarik | 19 Sep 00:57 2014
Picon

[PATCH]imx-drm coding style fixes

Hello,

I've fixed coding style issues in drivers/staging/imx-drm directory. This is a part of Eudyptula Challenge.

Rene Kolarik
Attachment (imx-coding-style.patch): text/x-diff, 3347 bytes
_______________________________________________
devel mailing list
devel <at> linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Rene Kolarik | 18 Sep 23:55 2014
Picon

iMX Coding Style Patch

Hello,

I'm sending this as a part of Eudyptula Challenge.

Rene Kolarik 
Attachment (imx-coding-style.patch): text/x-diff, 3293 bytes
_______________________________________________
devel mailing list
devel <at> linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Julia Lawall | 18 Sep 22:24 2014
Picon

[PATCH] Use kzalloc and rewrite null tests

The following patch removes some kzalloc-related macros and rewrites the
associated null tests to use !x rather than x == NULL.  The complete
semantic patch used for this transformation is as follows:

// <smpl>
 <at> disable unlikely <at> 
expression ptr;
statement S,S1;
 <at>  <at> 

  \(OBD_ALLOC\|OBD_ALLOC_WAIT\|OBD_ALLOC_PTR\|OBD_ALLOC_PTR_WAIT\)(ptr,...);
  if (unlikely(
+     !
      ptr
-      == NULL
     )) S else S1

 <at>  <at> 
expression ptr;
statement S,S1;
 <at>  <at> 

  \(OBD_ALLOC\|OBD_ALLOC_WAIT\|OBD_ALLOC_PTR\|OBD_ALLOC_PTR_WAIT\)(ptr,...);
  if (
+     !
      ptr
-      == NULL
     ) S else S1

 <at> disable unlikely <at> 
(Continue reading)

Abel Moyo | 18 Sep 21:49 2014
Picon

[PATCH v2] Staging: gdm724x: gdm_usb: added error checking in do_tx()

Added error checking for alloc_tx_struct in do_tx()

Signed-off-by: Abel Moyo <abelmoyo.ab <at> gmail.com>
---
Changes in v2:
   - Added spin_unlock
   - Removed print error message

 drivers/staging/gdm724x/gdm_usb.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers/staging/gdm724x/gdm_usb.c
index 483185b..5d44490 100644
--- a/drivers/staging/gdm724x/gdm_usb.c
+++ b/drivers/staging/gdm724x/gdm_usb.c
 <at>  <at>  -682,6 +682,10  <at>  <at>  static void do_tx(struct work_struct *work)
 		}

 		t = alloc_tx_struct(TX_BUF_SIZE);
+		if (t == NULL) {
+			spin_unlock_irqrestore(&tx->lock, flags);
+			return;
+		}
 		t->callback = NULL;
 		t->tx = tx;
 		t->is_sdu = 1;
--

-- 
1.8.5.5
H Hartley Sweeten | 18 Sep 20:46 2014

[PATCH 0/2] staging: comedi: remove cfc_inc_scan_progress()

The inline function cfc_inc_scan_progress() is just a wrapper around
the comedi core function comedi_inc_scan_progress(). Convert all the
drivers to use the core function directly and remove the wrapper.

This series applies after:
 PATCH 00/11] staging: comedi: move comedi_fc functionality into core

H Hartley Sweeten (2):
  staging: comedi: mite: use comedi_inc_scan_progress()
  staging: comedi: comedi_fc.h: remove cfc_inc_scan_progress()

 drivers/staging/comedi/drivers/comedi_fc.h | 6 ------
 drivers/staging/comedi/drivers/mite.c      | 2 +-
 2 files changed, 1 insertion(+), 7 deletions(-)

--

-- 
2.0.3
H Hartley Sweeten | 18 Sep 20:41 2014

[PATCH 0/8] staging: comedi: remove cfc_bytes_per_scan()

The inline function cfc_bytes_per_scan() is just a wrapper around the
comedi core function comedi_bytes_per_scan(). Convert all the drivers
to use the core function directly and remove the wrapper.

This series applies after:
 PATCH 00/11] staging: comedi: move comedi_fc functionality into core

H Hartley Sweeten (8):
  staging: comedi: amplc_pci224: use comedi_bytes_per_scan()
  staging: comedi: amplc_pci230: use comedi_bytes_per_scan()
  staging: comedi: das16: use comedi_bytes_per_scan()
  staging: comedi: mite: use comedi_bytes_per_scan()
  staging: comedi: pcl812: use comedi_bytes_per_scan()
  staging: comedi: pcl816: use comedi_bytes_per_scan()
  staging: comedi: pcl818: use comedi_bytes_per_scan()
  staging: comedi: comedi_fc.h: remove cfc_bytes_per_scan()

 drivers/staging/comedi/drivers/amplc_pci224.c | 2 +-
 drivers/staging/comedi/drivers/amplc_pci230.c | 2 +-
 drivers/staging/comedi/drivers/comedi_fc.h    | 5 -----
 drivers/staging/comedi/drivers/das16.c        | 2 +-
 drivers/staging/comedi/drivers/mite.c         | 2 +-
 drivers/staging/comedi/drivers/pcl812.c       | 6 +++---
 drivers/staging/comedi/drivers/pcl816.c       | 2 +-
 drivers/staging/comedi/drivers/pcl818.c       | 2 +-
 8 files changed, 9 insertions(+), 14 deletions(-)

--

-- 
2.0.3
(Continue reading)

H Hartley Sweeten | 18 Sep 20:35 2014

[PATCH v2 00/25] staging: comedi: tidy up async command termination

The comedi async commands should stop if an error/overflow happens or when
the end-of-acquisition for the command is detected. Some of the drivers
do this correctly but many don't.

The comedi_handle_events() function automatically detects the events that
would terminate a command. If the events are set it calls the subdevice
(*cancel) operation to stop the command.

Convert the drivers to use comedi_handle_events() instead of comedi_event().
This allows removing the unnecessary cancel in the driver, if present, and
ensures that all the drivers terminate the commands if necessary.

The only drivers that still use comedi_event() are the usbdux drivers. These
have a "cancel" in the urb completion routines that does not do what the
(*cancel) does. I'm waiting for a reply from the author to see if this can
be changed.

This series applies after:
 PATCH 00/11] staging: comedi: move comedi_fc functionality into core

v2: use comedi_handle_events() instead of cfc_handle_events()

H Hartley Sweeten (25):
  staging: comedi: hwdrv_apci3200: use comedi_handle_events()
  staging: comedi: addi_apci_1032: use comedi_handle_events()
  staging: comedi: addi_apci_1564: use comedi_handle_events()
  staging: comedi: addi_apci_3xxx: use comedi_handle_events()
  staging: comedi: amplc_pc236_common: use comedi_handle_events()
  staging: comedi: comedi_parport: use comedi_handle_events()
  staging: comedi: dmm32at: use comedi_handle_events()
(Continue reading)

H Hartley Sweeten | 18 Sep 20:11 2014

[PATCH 00/23] staging: comedi: remove cfc_handle_events()

The inline function cfc_handle_events() is just a wrapper around the
comedi core function comedi_handle_events(). Convert all the drivers
to use the core function directly and remove the wrapper.

This series applies after:
 PATCH 00/11] staging: comedi: move comedi_fc functionality into core

H Hartley Sweeten (23):
  staging: comedi: adl_pci9111: use comedi_handle_events()
  staging: comedi: adl_pci9118: use comedi_handle_events()
  staging: comedi: adv_pci1710: use comedi_handle_events()
  staging: comedi: amplc_pci224: use comedi_handle_events()
  staging: comedi: cb_pcidas: use comedi_handle_events()
  staging: comedi: cb_pcidas64: use comedi_handle_events()
  staging: comedi: das16: use comedi_handle_events()
  staging: comedi: das16m1: use comedi_handle_events()
  staging: comedi: das800: use comedi_handle_events()
  staging: comedi: das1800: use comedi_handle_events()
  staging: comedi: dt282x: use comedi_handle_events()
  staging: comedi: dt3000: use comedi_handle_events()
  staging: comedi: gsc_hpdi: use comedi_handle_events()
  staging: comedi: ni_660x: use comedi_handle_events()
  staging: comedi: ni_at_a2150: use comedi_handle_events()
  staging: comedi: ni_labpc_common: use comedi_handle_events()
  staging: comedi: ni_mio_common: use comedi_handle_events()
  staging: comedi: ni_pcidio: use comedi_handle_events()
  staging: comedi: pcl812: use comedi_handle_events()
  staging: comedi: pcl816: use comedi_handle_events()
  staging: comedi: pcl818: use comedi_handle_events()
  staging: comedi: quatech_daqp_cs: use comedi_handle_events()
(Continue reading)

Benedict Boerger | 18 Sep 17:46 2014
Picon

[PATCH v2] staging: rtl8192u: delete unused function CAM_read_entry

Fix the sparse warning: symbol 'CAM_read_entry' was not declared. Should it be static?

The function CAM_read_entry is not used and therefore deleted.

Signed-off-by: Benedict Boerger <benedict.boerger <at> cs.tu-dortmund.de>
---
changes in v2:
add Signed-off-by line

 drivers/staging/rtl8192u/r8192U_core.c | 28 ----------------------------
 1 file changed, 28 deletions(-)

diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index a4e1d6b..3d8ad5f 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
 <at>  <at>  -3190,34 +3190,6  <at>  <at>  RESET_START:
 	}
 }

-void CAM_read_entry(struct net_device *dev, u32 iIndex)
-{
-	u32 target_command = 0;
-	u32 target_content = 0;
-	u8 entry_i = 0;
-	u32 ulStatus;
-	s32 i = 100;
-	for (entry_i = 0; entry_i < CAM_CONTENT_COUNT; entry_i++) {
-		// polling bit, and No Write enable, and address
-		target_command = entry_i+CAM_CONTENT_COUNT*iIndex;
(Continue reading)


Gmane