Lior Pugatch | 4 Aug 21:18 2015
Picon

[PATCH] staging: vt6655: Fixed C99 style comment to C89 style.

Patch created to satisfy checkpatch.pl

Signed-off-by: Lior Pugatch <buzz5800 <at> gmail.com>
---
 drivers/staging/vt6655/rxtx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h
index b9bd163..54694df 100644
--- a/drivers/staging/vt6655/rxtx.h
+++ b/drivers/staging/vt6655/rxtx.h
 <at>  <at>  -197,4 +197,4  <at>  <at>  int vnt_beacon_make(struct vnt_private *, struct ieee80211_vif *);
 int vnt_beacon_enable(struct vnt_private *, struct ieee80211_vif *,
 		      struct ieee80211_bss_conf *);

-#endif // __RXTX_H__
+#endif /* __RXTX_H__ */
--

-- 
1.9.1
Adrian Remonda | 4 Aug 20:44 2015
Picon

[PATCHv5 0/5] Staging: most: several warnings fix reported by sparse

This patch series fix several warnings reported by the Sparse tool

       v2: Fixed patch format and comments as noted by 
		Greg Kroah-Hartman and clear a few more warnings
       v3: Fixed patch format as noted by Greg Kroah-Hartman
       v4: Fixed patch format as noted by Greg Kroah-Hartman
       v5: Because of using a non-updated tree previously two 
       patches did not apply

Adrian Remonda (5):
  Staging: most: mostcore/core.c. Fix "missing static keyword" warnings
  Staging: most: mostcore/core.c. Fix "Using plain integer as NULL
    pointer" warnings
  Staging: most: hdm-usb/hdm_usb.c. Fix "missing static keyword"
    warnings
  Staging: most: hdm-dim2/dim2_hal.c. Fix "Using plain integer as NULL
    pointer" warnings
  Staging: most: aim-cdev/cdev.c. Fix "missing static keyword" warnings

 drivers/staging/most/aim-cdev/cdev.c     | 18 +++++++++---------
 drivers/staging/most/hdm-dim2/dim2_hal.c |  2 +-
 drivers/staging/most/hdm-usb/hdm_usb.c   | 16 ++++++++--------
 drivers/staging/most/mostcore/core.c     | 16 ++++++++--------
 4 files changed, 26 insertions(+), 26 deletions(-)

--

-- 
2.1.4
Salah Triki | 4 Aug 20:19 2015
Picon

[PATCH] zram: Replace pr_* with dev_*

This patch replaces pr_info/pr_warn/pr_err with
dev_info/dev_warn/dev_err.

Signed-off-by: Salah Triki <salah.triki <at> acm.org>
---
 drivers/block/zram/zram_drv.c | 40 +++++++++++++++++++++++-----------------
 1 file changed, 23 insertions(+), 17 deletions(-)

diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index fb655e8..8eecb72 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
 <at>  <at>  -333,7 +333,8  <at>  <at>  static ssize_t max_comp_streams_store(struct device *dev,
 	down_write(&zram->init_lock);
 	if (init_done(zram)) {
 		if (!zcomp_set_max_streams(zram->comp, num)) {
-			pr_info("Cannot change max compression streams\n");
+			dev_warn(dev, "Cannot change max compression streams to %d",
+				num);
 			ret = -EINVAL;
 			goto out;
 		}
 <at>  <at>  -368,7 +369,7  <at>  <at>  static ssize_t comp_algorithm_store(struct device *dev,
 	down_write(&zram->init_lock);
 	if (init_done(zram)) {
 		up_write(&zram->init_lock);
-		pr_info("Can't change algorithm for initialized device\n");
+		dev_warn(dev, "Can't change algorithm for initialized device");
 		return -EBUSY;
 	}
(Continue reading)

H Hartley Sweeten | 4 Aug 19:57 2015

[PATCH 00/46] staging: comedi: me4000: cleanup driver

Here's the big cleanup series for the Comedi me4000 driver.

This fixes all the checkpatch issues and removes a bunch of cruft
from the driver.

H Hartley Sweeten (46):
  staging: comedi: me4000: remove 'dio_nchan' boardinfo
  staging: comedi: me4000: all board types have analog inputs
  staging: comedi: me4000: only set SDF_DIFF when supported
  staging: comedi: me4000: remove 'chan' check in me4000_ai_insn_read()
  staging: comedi: me4000: remove 'board' from me4000_ai_insn_read()
  staging: comedi: me4000: remove 'board' from me4000_ai_check_chanlist()
  staging: comedi: me4000: make boardinfo flags bit-fields
  staging: comedi: me4000: refactor 'ai_diff_nchan' boardinfo
  staging: comedi: me4000: refactor 'ao_nchan' boardinfo
  staging: comedi: me4000: refactor 'ao_fifo' boardinfo
  staging: comedi: me4000: refactor 'ai_sh_nchan' boardinfo
  staging: comedi: me4000: rename local variables used for 'dev->private'
  staging: comedi: me4000: remove unnecessary ME4000_AI_LIST_INPUT_SINGLE_ENDED
  staging: comedi: me4000: simplify analog input range programming
  staging: comedi: me4000: fix ai_write_chanlist()
  staging: comedi: me4000: tidy up ME4000_AI_CHANNEL_LIST_REG bit defines
  staging: comedi: me4000: use comedi_timeout() to wait for ai (*insn_read)
  staging: comedi: me4000: fix me4000_ai_insn_read()
  staging: comedi: me4000: use correct types for extracted chanspec values
  staging: comedi: me4000: use comedi_range_is_bipolar() in ai (*insn_read)
  staging: comedi: me4000: tidy up ME4000_AI_STATUS_REG bit defines
  staging: comedi: me4000: tidy up ME4000_AI_CTRL_REG bit defines
  staging: comedi: me4000: tidy up ME4000_IRQ_STATUS_REG bit defines
  staging: comedi: me4000: tidy up ME4000_AO_STATUS_REG bit defines
(Continue reading)

Shraddha Barke | 4 Aug 19:50 2015
Picon

[PATCH v4 1/3] Staging: lustre: libcfs: Replace comma with a semicolon

Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:

 <at>  <at> 
expression e1,e2;
 <at>  <at> 
e1
- ,
+ ;
e2;

Signed-off-by: Shraddha Barke <shraddha.6596 <at> gmail.com>
---
Changes in v4:
  -Added Signed-off-by line

 drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
index 4dde8e0..efe5e66 100644
--- a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
+++ b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
 <at>  <at>  -400,7 +400,7  <at>  <at>  cfs_expr_list_free(struct cfs_expr_list *expr_list)
 		struct cfs_range_expr *expr;

 		expr = list_entry(expr_list->el_exprs.next,
-				      struct cfs_range_expr, re_link),
+				      struct cfs_range_expr, re_link);
 		list_del(&expr->re_link);
(Continue reading)

Shraddha Barke | 4 Aug 19:32 2015
Picon

[PATCH 1/3] Staging: lustre: libcfs: Drop unnecessary cast on void*

This patch does away with the cast on void * as it is unnecessary.

Semantic patch used is as follows:

 <at> r <at> 
expression x;
void* e;
type T;
identifier f;
 <at>  <at> 
(
  *((T *)e)
|
  ((T *)x)[...]
|
  ((T *)x)->f
|
- (T *)
  e
)

Signed-off-by: Shraddha Barke <shraddha.6596 <at> gmail.com>
---
 drivers/staging/lustre/lustre/libcfs/linux/linux-module.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-module.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-module.c
index e962f89..78acff0 100644
--- a/drivers/staging/lustre/lustre/libcfs/linux/linux-module.c
+++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-module.c
(Continue reading)

Shraddha Barke | 4 Aug 16:16 2015
Picon

[PATCH v3 3/3] Staging: netlogic: Replace comma with a semicolon

Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:

 <at>  <at> 
expression e1,e2;
 <at>  <at> 
e1
- ,
+ ;
e2;
---
Changes in v3:
  -No changes made.

 drivers/staging/netlogic/platform_net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
index 77c3c35..e914147 100644
--- a/drivers/staging/netlogic/platform_net.c
+++ b/drivers/staging/netlogic/platform_net.c
 <at>  <at>  -163,7 +163,7  <at>  <at>  static void xls_gmac_init(void)
 	switch (nlm_prom_info.board_major_version) {
 	case 12:
 		/* first block RGMII or XAUI, use RGMII */
-		ndata0.phy_interface = PHY_INTERFACE_MODE_RGMII,
+		ndata0.phy_interface = PHY_INTERFACE_MODE_RGMII;
 		ndata0.tx_stnid[0] = FMN_STNID_GMAC0_TX0;
 		ndata0.phy_addr[0] = 0;

(Continue reading)

Shraddha Barke | 4 Aug 16:11 2015
Picon

[PATCH v3 1/3] Staging: lustre: libcfs: Replace comma with a semicolon

Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:

 <at>  <at> 
expression e1,e2;
 <at>  <at> 
e1
- ,
+ ;
e2;
---
Changes in v3:
  -Make subject clearer.

 drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
index 4dde8e0..efe5e66 100644
--- a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
+++ b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
 <at>  <at>  -400,7 +400,7  <at>  <at>  cfs_expr_list_free(struct cfs_expr_list *expr_list)
 		struct cfs_range_expr *expr;

 		expr = list_entry(expr_list->el_exprs.next,
-				      struct cfs_range_expr, re_link),
+				      struct cfs_range_expr, re_link);
 		list_del(&expr->re_link);
 		LIBCFS_FREE(expr, sizeof(*expr));
 	}
(Continue reading)

Julia Lawall | 4 Aug 15:45 2015
Picon

Re: [PATCH v2 2/3] Staging: lustre: Replace comma between expression statements by a semicolon.

On Tue, 4 Aug 2015, Shraddha Barke wrote:

> Alright .
> So now I should send a version 3 right ?

Yes.

>  Was there any other issue in the way I sent this version ?

I think it's ok.

julia
_______________________________________________
devel mailing list
devel <at> linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Ted Chen | 4 Aug 15:21 2015
Picon

[PATCH] staging: comedi: fix coding style issue.

fixed coding style issue
  - replaced ENOSYS by ENODEV.

Signed-off-by: Ted Chen <tedc.37zngo <at> gmail.com>
---
 drivers/staging/comedi/comedi_fops.c |    2 +-
 drivers/staging/comedi/drivers.c     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 146ab00..6896a1f 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
 <at>  <at>  -2611,7 +2611,7  <at>  <at>  static int comedi_open(struct inode *inode, struct file *file)
 	}
 	if (dev->attached && dev->use_count == 0) {
 		if (!try_module_get(dev->driver->module)) {
-			rc = -ENOSYS;
+			rc = -ENODEV;
 			goto out;
 		}
 		if (dev->open) {
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index ed0b60c..0b7000a 100644
--- a/drivers/staging/comedi/drivers.c
+++ b/drivers/staging/comedi/drivers.c
 <at>  <at>  -820,7 +820,7  <at>  <at>  int comedi_device_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 			 "driver '%s' does not support attach using comedi_config\n",
 			 driv->driver_name);
 		module_put(driv->module);
(Continue reading)

Shraddha Barke | 4 Aug 15:06 2015
Picon

[PATCH v2 1/3] Staging: lustre: Replace comma with a semicolon

Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:

 <at>  <at> 
expression e1,e2;
 <at>  <at> 
e1
- ,
+ ;
e2;
---
Changes in v2:
  -No changes made.

 drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
index 4dde8e0..efe5e66 100644
--- a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
+++ b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
 <at>  <at>  -400,7 +400,7  <at>  <at>  cfs_expr_list_free(struct cfs_expr_list *expr_list)
 		struct cfs_range_expr *expr;

 		expr = list_entry(expr_list->el_exprs.next,
-				      struct cfs_range_expr, re_link),
+				      struct cfs_range_expr, re_link);
 		list_del(&expr->re_link);
 		LIBCFS_FREE(expr, sizeof(*expr));
 	}
(Continue reading)


Gmane