Julia Lawall | 1 Sep 22:21 2014
Picon

[PATCH 2/2] staging: lustre: ldlm: simplify rc initialization

From: Julia Lawall <Julia.Lawall <at> lip6.fr>

Simplify initialization of rc to take advantage of the fact that it is done
at statement level.

Signed-off-by: Julia Lawall <Julia.Lawall <at> lip6.fr>

---
 drivers/staging/lustre/lustre/ldlm/ldlm_request.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_request.c b/drivers/staging/lustre/lustre/ldlm/ldlm_request.c
index 655a1c7..9ce437b 100644
--- a/drivers/staging/lustre/lustre/ldlm/ldlm_request.c
+++ b/drivers/staging/lustre/lustre/ldlm/ldlm_request.c
 <at>  <at>  -569,7 +569,8  <at>  <at>  int ldlm_cli_enqueue_fini(struct obd_export *exp, struct ptlrpc_request *req,
 		if (lvb_len != 0)
 			rc = ldlm_fill_lvb(lock, &req->rq_pill, RCL_SERVER,
 					   lvb, size);
-		rc = (rc != 0 ? rc : ELDLM_LOCK_ABORTED);
+		if (rc == 0)
+			rc = ELDLM_LOCK_ABORTED;
 		goto cleanup;
 	}
Julia Lawall | 1 Sep 22:21 2014
Picon

[PATCH 1/2] staging: lustre: ldlm: expand the GOTO macro

From: Julia Lawall <Julia.Lawall <at> lip6.fr>

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
 <at>  <at> 
identifier lbl;
identifier rc;
constant c;
 <at>  <at> 

- GOTO(lbl,\(rc\|c\));
+ goto lbl;

 <at>  <at> 
identifier lbl;
expression rc;
 <at>  <at> 

- GOTO(lbl,rc);
+ rc;
+ goto lbl;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall <at> lip6.fr>

---
 drivers/staging/lustre/lustre/ldlm/ldlm_lib.c      |   51 +++++++-----
 drivers/staging/lustre/lustre/ldlm/ldlm_lock.c     |   49 +++++++----
(Continue reading)

Russell King - ARM Linux | 1 Sep 19:07 2014
Picon

[PATCH 0/2] Two imx-drm oops fixes

Greg,

Here's two oops fixes for imx-drm, which I've had queued up for a number
of months now.  Shawn posted different fixes for the same oops recently
as well.

 drivers/staging/imx-drm/imx-ldb.c     | 3 +++
 drivers/staging/imx-drm/ipuv3-plane.c | 3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)

--

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
sunwxg | 1 Sep 17:52 2014
Picon

[PATCH] staging: lustre: lov_pack: fix coding style issue

From: Sun Wang <sun.wxg <at> gmail.com>

Fix the style error checking by checkpatch.pl
ERROR: space required after that ','

Signed-off-by: Sun Wang <sun.wxg <at> gmail.com>

---
 drivers/staging/lustre/lustre/lov/lov_pack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/drivers/staging/lustre/lustre/lov/lov_pack.c
index 20e5870..62ea223 100644
--- a/drivers/staging/lustre/lustre/lov/lov_pack.c
+++ b/drivers/staging/lustre/lustre/lov/lov_pack.c
 <at>  <at>  -95,7 +95,7  <at>  <at>  void lov_dump_lmm_v1(int level, struct lov_mds_md_v1 *lmm)
 void lov_dump_lmm_v3(int level, struct lov_mds_md_v3 *lmm)
 {
 	lov_dump_lmm_common(level, lmm);
-	CDEBUG(level,"pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
+	CDEBUG(level, "pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
 	lov_dump_lmm_objects(level, lmm->lmm_objects,
 			     le16_to_cpu(lmm->lmm_stripe_count));
 }
sunwxg | 1 Sep 17:47 2014
Picon

(unknown)

From: Sun Wang <sun.wxg <at> gmail.com>

Subject: [PATCH] staging: lustre: lov_pack: fix coding style issue

Fix the style error checking by checkpatch.pl
ERROR: space required after that ','

Signed-off-by: Sun Wang <sun.wxg <at> gmail.com>

---
 drivers/staging/lustre/lustre/lov/lov_pack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/drivers/staging/lustre/lustre/lov/lov_pack.c
index 20e5870..62ea223 100644
--- a/drivers/staging/lustre/lustre/lov/lov_pack.c
+++ b/drivers/staging/lustre/lustre/lov/lov_pack.c
 <at>  <at>  -95,7 +95,7  <at>  <at>  void lov_dump_lmm_v1(int level, struct lov_mds_md_v1 *lmm)
 void lov_dump_lmm_v3(int level, struct lov_mds_md_v3 *lmm)
 {
 	lov_dump_lmm_common(level, lmm);
-	CDEBUG(level,"pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
+	CDEBUG(level, "pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
 	lov_dump_lmm_objects(level, lmm->lmm_objects,
 			     le16_to_cpu(lmm->lmm_stripe_count));
 }
navin patidar | 1 Sep 17:43 2014
Picon

[PATCH 1/8] staging: rtl8188eu: Rework function HalPwrSeqCmdParsing()

Rename CamelCase variables and function name.

Signed-off-by: navin patidar <navin.patidar <at> gmail.com>
---
 drivers/staging/rtl8188eu/hal/HalPwrSeqCmd.c     |   64 +++++++++-------------
 drivers/staging/rtl8188eu/hal/usb_halinit.c      |   12 +++-
 drivers/staging/rtl8188eu/include/HalPwrSeqCmd.h |    4 +-
 3 files changed, 38 insertions(+), 42 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/rtl8188eu/hal/HalPwrSeqCmd.c
index caca535..2565d6e 100644
--- a/drivers/staging/rtl8188eu/hal/HalPwrSeqCmd.c
+++ b/drivers/staging/rtl8188eu/hal/HalPwrSeqCmd.c
 <at>  <at>  -15,36 +15,16  <at>  <at> 
  * this program; if not, write to the Free Software Foundation, Inc.,
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
  *
- *
  ******************************************************************************/
-/*++
-Copyright (c) Realtek Semiconductor Corp. All rights reserved.
-
-Module Name:
-	HalPwrSeqCmd.c
-
-Abstract:
-	Implement HW Power sequence configuration CMD handling routine for Realtek devices.
-
-Major Change History:
-	When       Who               What
(Continue reading)

Seunghun Lee | 1 Sep 15:46 2014
Picon

[PATCH] staging: dgnc: split two assignments into the two assignments on two lines.

split two assignments into the two assignments on two lines.

CC: Lidza Louina <lidza.louina <at> gmail.com>
CC: Mark Hounschell <markh <at> compro.net>
Signed-off-by: Seunghun Lee <waydi1 <at> gmail.com>
---
 drivers/staging/dgnc/TODO          |    2 --
 drivers/staging/dgnc/dgnc_cls.c    |   15 ++++++++++-----
 drivers/staging/dgnc/dgnc_driver.c |   10 ++++++----
 drivers/staging/dgnc/dgnc_neo.c    |   16 +++++++++++-----
 drivers/staging/dgnc/dgnc_tty.c    |    9 ++++++---
 5 files changed, 33 insertions(+), 19 deletions(-)

diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO
index d2828c7..22adff1 100644
--- a/drivers/staging/dgnc/TODO
+++ b/drivers/staging/dgnc/TODO
 <at>  <at>  -1,6 +1,4  <at>  <at> 
 * checkpatch fixes
-* split two assignments into the two assignments on two lines;
-  don't use two equals signs
 * remove unecessary comments
 * remove unecessary error messages. Example kzalloc() has its 
   own error message. Adding an extra one is useless.
diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index 84b1377..0393d6d 100644
--- a/drivers/staging/dgnc/dgnc_cls.c
+++ b/drivers/staging/dgnc/dgnc_cls.c
 <at>  <at>  -493,9 +493,12  <at>  <at>  static void cls_param(struct tty_struct *tty)
 	 * If baud rate is zero, flush queues, and set mval to drop DTR.
(Continue reading)

Ian Abbott | 1 Sep 15:13 2014
Picon

[PATCH] staging: comedi: ni_at_a2150: range check board index

The "ni_at_a2150" driver determines the board type by calling
`a2150_probe()`.  This reads a register and converts it to a board index
in the range 0 to 3.  However, the board table array it indexes into
(`a2150_boards[]`) only has 2 entries.  Return an error from the
Comedi driver "attach" handler `a2150_attach()` if the probed board
index is beyond the end of the array.

Signed-off-by: Ian Abbott <abbotti <at> mev.co.uk>
---
 drivers/staging/comedi/drivers/ni_at_a2150.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/ni_at_a2150.c b/drivers/staging/comedi/drivers/ni_at_a2150.c
index de67161..32e7bf2 100644
--- a/drivers/staging/comedi/drivers/ni_at_a2150.c
+++ b/drivers/staging/comedi/drivers/ni_at_a2150.c
 <at>  <at>  -705,7 +705,11  <at>  <at>  static int a2150_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 	if (ret)
 		return ret;

-	dev->board_ptr = a2150_boards + a2150_probe(dev);
+	i = a2150_probe(dev);
+	if (i >= ARRAY_SIZE(a2150_boards))
+		return -ENODEV;
+
+	dev->board_ptr = a2150_boards + i;
 	thisboard = comedi_board(dev);
 	dev->board_name = thisboard->name;

--

-- 
(Continue reading)

Maarten Lankhorst | 1 Sep 14:47 2014

[PATCH] android: fix reference leak in sync_fence_create

According to the documentation sync_fence_create takes ownership of the point,
not a reference on the point.

This fixes a memory leak introduced in 3.17's android fence rework.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst <at> canonical.com>
Cc: Colin Cross <ccross <at> google.com>
Cc: Dan Carpenter <dan.carpenter <at> oracle.com>
---
 drivers/staging/android/sync.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
index e7b2e0234196..69139ce7420d 100644
--- a/drivers/staging/android/sync.c
+++ b/drivers/staging/android/sync.c
 <at>  <at>  -199,7 +199,6  <at>  <at>  struct sync_fence *sync_fence_create(const char *name, struct sync_pt *pt)
 	fence->num_fences = 1;
 	atomic_set(&fence->status, 1);

-	fence_get(&pt->base);
 	fence->cbs[0].sync_pt = &pt->base;
 	fence->cbs[0].fence = fence;
 	if (fence_add_callback(&pt->base, &fence->cbs[0].cb,
--

-- 
2.0.4
Ian Abbott | 1 Sep 13:03 2014
Picon

[PATCH 00/28] staging: comedi: more clean-up and remove legacy attach

Continue to clean up the amplc_pci230 driver code and remove the legacy
attach mechanism, since it isn't very useful for this driver (see PATCH
05/28).

01) staging: comedi: amplc_pci230: update MODULE_DESCRIPTION()
02) staging: comedi: amplc_pci230: don't use multiple blank lines
03) staging: comedi: amplc_pci230: remove some unnecessary parentheses
04) staging: comedi: amplc_pci230: collapse some 'else { if' chains
05) staging: comedi: amplc_pci230: remove "legacy" attach mechanism
06) staging: comedi: amplc_pci230: no need to manipulate PCI ref count
07) staging: comedi: amplc_pci230: set detach handler to
    comedi_pci_detach()
08) staging: comedi: amplc_pci230: absorb pci230_attach_common()
09) staging: comedi: amplc_pci230: no need to comedi_set_hw_dev() here
10) staging: comedi: amplc_pci230: absorb pci230_alloc_private()
11) staging: comedi: amplc_pci230: remove ai_chans member
12) staging: comedi: amplc_pci230: remove ao_chans member
13) staging: comedi: amplc_pci230: shrink struct pci230_board
14) staging: comedi: amplc_pci230: simplify pci230_ao_mangle_datum()
15) staging: comedi: amplc_pci230: simplify pci230_ai_read()
16) staging: comedi: amplc_pci230: remove 'inline'
17) staging: comedi: amplc_pci230: rename pci230_ai_rinsn()
18) staging: comedi: amplc_pci230: add `pci230_` prefix to functions
19) staging: comedi: amplc_pci230: use comedi_range_is_bipolar()
20) staging: comedi: amplc_pci230: make `intr_running` a bitfield
21) staging: comedi: amplc_pci230: replace `state` member with bitfields
22) staging: comedi: amplc_pci230: rewrite shared resource handling
23) staging: comedi: amplc_pci230: reduce indentation in
    pci230_ao_inttrig_scan_begin()
24) staging: comedi: amplc_pci230: reduce indentation in
(Continue reading)

sunwxg | 1 Sep 09:34 2014

(unknown)

From: Sun Wang <xiaoguang_wang5188 <at> qq.com>

Subject: [PATCH] staging: unisys: visorutil: procobjecttree: fix coding style issue 

Coding style issues, the changes include:
-Remove '{}'

Signed-off-by: Sun Wang <xiaoguang_wang5188 <at> qq.com>

---
 drivers/staging/unisys/visorutil/procobjecttree.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/unisys/visorutil/procobjecttree.c b/drivers/staging/unisys/visorutil/procobjecttree.c
index 5c8c95c..c81467e 100644
--- a/drivers/staging/unisys/visorutil/procobjecttree.c
+++ b/drivers/staging/unisys/visorutil/procobjecttree.c
 <at>  <at>  -250,9 +250,9  <at>  <at>  MYPROCOBJECT *visor_proc_CreateObject(MYPROCTYPE *type,
 		}
 		strcpy(obj->name, name);
 		obj->procDir = createProcDir(obj->name, type->procDir);
-		if (obj->procDir == NULL) {
+		if (obj->procDir == NULL)
 			goto Away;
-		}
+
 	}
 	obj->procDirPropertyContexts =
 		kzalloc((type->nProperties + 1) * sizeof(PROCDIRENTRYCONTEXT),
(Continue reading)


Gmane