Tobenna P. Igwe | 18 Nov 02:45 2014
Picon

[PATCH] staging:rtl8723au: Fix sparse warning cast to restricted __le16

This patch fixes the following sparse warning:

drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:343:36: warning:
cast to restricted __le16

by using the le16_to_cpus function.

Signed-off-by: Tobenna P. Igwe <ptigwe <at> gmail.com>
---
 drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
index d80ea4e..78665ee 100644
--- a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
+++ b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
 <at>  <at>  -340,7 +340,7  <at>  <at>  static u8 bthci_GetAssocInfo(struct rtw_adapter *padapter, u8 EntryNum)
 			tempBuf, TotalLen-BaseMemoryShift);

 		pAmpAsoc = (struct amp_assoc_structure *)tempBuf;
-		pAmpAsoc->Length = le16_to_cpu(pAmpAsoc->Length);
+		le16_to_cpus(&pAmpAsoc->Length);
 		BaseMemoryShift += 3 + pAmpAsoc->Length;

 		RTPRINT(FIOCTL, IOCTL_BT_HCICMD, ("TypeID = 0x%x, ", pAmpAsoc->TypeID));
--

-- 
1.7.10.4
ron | 18 Nov 02:25 2014

It Is Our New Alert! Be Ready For A Big Day.

It Should Continue Upward Trend! Huge Update.

Trading Date: Tue, Nov 18, 2014
Latest Pricing: $67.13
Traded as: TG T
Name: Target
Long Term Target Price: 87

Huge New Pick Coming! It is Looking to Burst.
Juston Li | 17 Nov 23:23 2014
Picon

[PATCH] staging: lustre: mdc: use __FMODE_EXEC macro

FMODE_EXEC is type fmode_t but is used in operations
with integers which leads to sparse warnings:
drivers/staging/lustre/lustre/mdc/mdc_lib.c:198:21: warning: restricted fmode_t degrades to integer
drivers/staging/lustre/lustre/mdc/mdc_locks.c:300:49: warning: restricted fmode_t degrades to integer

Fix by using __FMODE_EXEC macro defined in fs.h.

Note the same warnings occurs with other fmode flags
here but they don't have a corresponding int macro.

Signed-off-by: Juston Li <juston.h.li <at> gmail.com>
---
 drivers/staging/lustre/lustre/mdc/mdc_lib.c   | 4 ++--
 drivers/staging/lustre/lustre/mdc/mdc_locks.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/lustre/lustre/mdc/mdc_lib.c b/drivers/staging/lustre/lustre/mdc/mdc_lib.c
index e8732cc..34c9a86 100644
--- a/drivers/staging/lustre/lustre/mdc/mdc_lib.c
+++ b/drivers/staging/lustre/lustre/mdc/mdc_lib.c
 <at>  <at>  -194,8 +194,8  <at>  <at>  static __u64 mds_pack_open_flags(__u64 flags, __u32 mode)
 		cr_flags |= MDS_OPEN_SYNC;
 	if (flags & O_DIRECTORY)
 		cr_flags |= MDS_OPEN_DIRECTORY;
-#ifdef FMODE_EXEC
-	if (flags & FMODE_EXEC)
+#ifdef __FMODE_EXEC
+	if (flags & __FMODE_EXEC)
 		cr_flags |= MDS_FMODE_EXEC;
 #endif
(Continue reading)

Anthony Basim | 17 Nov 21:27 2014

Friend..

Friend,

My name is Anthony Basim; I invite you to partner with me a rewarding business venture, Details on your
indication of interest. My email: abasim777 <at> gmail.com
Regards,
Anthony
Jeffrey Brown | 17 Nov 21:06 2014
Picon

[PATCH 1/1] staging: unisys: parser.c bug

Replaced cleanups: with err_rgn, err_ctx, and out_rgn in the file.
This is to have proper error and success handling.  I also removed
the variable rc because like cleanups, rc is redundant in this file

Signed-off-by: Jeffrey Brown <Jeffrey.Brown <at> unisys.com>
---
 drivers/staging/unisys/visorchipset/parser.c | 62 +++++++++++-----------------
 1 file changed, 25 insertions(+), 37 deletions(-)

diff --git a/drivers/staging/unisys/visorchipset/parser.c b/drivers/staging/unisys/visorchipset/parser.c
index 5f6a7b2..e4e230f 100644
--- a/drivers/staging/unisys/visorchipset/parser.c
+++ b/drivers/staging/unisys/visorchipset/parser.c
 <at>  <at>  -45,7 +45,6  <at>  <at>  parser_init_guts(u64 addr, u32 bytes, BOOL is_local,
 		 BOOL has_standard_payload_header, BOOL *try_again)
 {
 	int allocbytes = sizeof(struct parser_context_tag) + bytes;
-	struct parser_context_tag *rc = NULL;
 	struct parser_context_tag *ctx = NULL;
 	struct memregion *rgn = NULL;
 	struct spar_controlvm_parameters_header *phdr = NULL;
 <at>  <at>  -64,8 +63,7  <at>  <at>  parser_init_guts(u64 addr, u32 bytes, BOOL is_local,
 		       MAX_CONTROLVM_PAYLOAD_BYTES);
 		if (try_again)
 			*try_again = TRUE;
-		rc = NULL;
-		goto cleanups;
+		return NULL;
 	}
 	ctx = kzalloc(allocbytes, GFP_KERNEL|__GFP_NORETRY);
(Continue reading)

Jeffrey Brown | 17 Nov 20:46 2014
Picon

[PATCH 1/1] staging: unisys: parser.c bug

From: Jeff <Jeffrey.Brown <at> unisys.com>

Replaced cleanups: with err_rgn, err_ctx, and out_rgn in the file.
This is to have proper error and success handling.  I also removed
the variable rc because like cleanups, rc is redundant in this file

Signed-off-by: Jeffrey Brown <Jeffrey.Brown <at> unisys.com>
---
 drivers/staging/unisys/visorchipset/parser.c | 62 +++++++++++-----------------
 1 file changed, 25 insertions(+), 37 deletions(-)

diff --git a/drivers/staging/unisys/visorchipset/parser.c b/drivers/staging/unisys/visorchipset/parser.c
index 5f6a7b2..e4e230f 100644
--- a/drivers/staging/unisys/visorchipset/parser.c
+++ b/drivers/staging/unisys/visorchipset/parser.c
 <at>  <at>  -45,7 +45,6  <at>  <at>  parser_init_guts(u64 addr, u32 bytes, BOOL is_local,
 		 BOOL has_standard_payload_header, BOOL *try_again)
 {
 	int allocbytes = sizeof(struct parser_context_tag) + bytes;
-	struct parser_context_tag *rc = NULL;
 	struct parser_context_tag *ctx = NULL;
 	struct memregion *rgn = NULL;
 	struct spar_controlvm_parameters_header *phdr = NULL;
 <at>  <at>  -64,8 +63,7  <at>  <at>  parser_init_guts(u64 addr, u32 bytes, BOOL is_local,
 		       MAX_CONTROLVM_PAYLOAD_BYTES);
 		if (try_again)
 			*try_again = TRUE;
-		rc = NULL;
-		goto cleanups;
+		return NULL;
(Continue reading)

stefan | 17 Nov 16:21 2014

[PATCH 1/2] acquiring and storing all display timing flags from dt

Signed-off-by: stefan <strawberryblack <at> googlemail.com>
---
 drivers/staging/imx-drm/parallel-display.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/staging/imx-drm/parallel-display.c b/drivers/staging/imx-drm/parallel-display.c
index 4ca61af..a67c1ad 100644
--- a/drivers/staging/imx-drm/parallel-display.c
+++ b/drivers/staging/imx-drm/parallel-display.c
 <at>  <at>  -26,6 +26,8  <at>  <at> 
 #include <drm/drm_panel.h>
 #include <linux/videodev2.h>
 #include <video/of_display_timing.h>
+#include <video/videomode.h>
+#include <video/of_videomode.h>

 #include "imx-drm.h"

 <at>  <at>  -80,11 +82,15  <at>  <at>  static int imx_pd_connector_get_modes(struct drm_connector *connector)

 	if (np) {
 		struct drm_display_mode *mode = drm_mode_create(connector->dev);
+		struct videomode vm;
 		if (!mode)
 			return -EINVAL;
 		of_get_drm_display_mode(np, &imxpd->mode, OF_USE_NATIVE_MODE);
 		drm_mode_copy(mode, &imxpd->mode);
 		mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
+		/* imxpd->mode.flags doesn't contain all flags from dt node */
+		of_get_videomode(np, &vm, OF_USE_NATIVE_MODE);
(Continue reading)

Aleh Suprunovich | 17 Nov 11:22 2014

[PATCH] staging: rtl8723au: fix sparse warning

drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:747:1: warning: symbol
'rtl8723a_EfusePgPacketRead' was not declared. Should it be static?

Function 'rtl8723a_EfusePgPacketRead' seems to be unused in current
staging code.

Before, it was available as 'static s32 Hal_EfusePgPacketRead',
but code that was using it removed, in the same commit as rename and
signature change to 'bool rtl8723a_EfusePgPacketRead' has taken place.

Signed-off-by: Aleh Suprunovich <br <at> ahlamon.org>
---
 drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 78 -----------------------
 1 file changed, 78 deletions(-)

diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
index 9a75eb6..3e61a45 100644
--- a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
+++ b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
 <at>  <at>  -743,84 +743,6  <at>  <at>  u16 rtl8723a_EfuseGetCurrentSize_BT(struct rtw_adapter *padapter)
 	return retU2;
 }

-bool
-rtl8723a_EfusePgPacketRead(struct rtw_adapter *padapter, u8 offset, u8 *data)
-{
-	u8 efuse_data, word_cnts = 0;
-	u16 efuse_addr = 0;
-	u8 hoffset = 0, hworden = 0;
-	u8 i;
(Continue reading)

Domagoj Trsan | 17 Nov 09:44 2014
Picon

[PATCH] staging: skein: fix sparse warnings related to shift operator

Fix warnings:
drivers/staging/skein/skein_base.h:89:30: warning: shift too big (50) for type int
...
drivers/staging/skein/skein_base.h:89:30: warning: shift too big (39)for type int
drivers/staging/skein/skein_base.h:89:19: warning: too many warnings

Signed-off-by: Domagoj Trsan <domagoj.trsan <at> gmail.com>
---
 drivers/staging/skein/skein_base.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/skein/skein_base.h b/drivers/staging/skein/skein_base.h
index 993b951..3c7f8ad 100644
--- a/drivers/staging/skein/skein_base.h
+++ b/drivers/staging/skein/skein_base.h
 <at>  <at>  -84,7 +84,7  <at>  <at>  struct skein_1024_ctx { /* 1024-bit Skein hash context structure */
 	u8 b[SKEIN_1024_BLOCK_BYTES];	/* partial block buf (8-byte aligned) */
 };

-static inline int rotl_64(int x, int N)
+static inline u64 rotl_64(u64 x, u8 N)
 {
 	return (x << N) | (x >> (64 - N));
 }
--

-- 
2.1.0
Thomas Wood | 17 Nov 04:21 2014
Picon

[PATCH] drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings Remove an unecessary return statement in a void function. Remove an unecessary space between a function name and the parentheses.


Signed-off-by: Thomas Wood <tommyandrena <at> gmail.com>
---
I hope this hasn't been duplicated...
 drivers/staging/lustre/lnet/lnet/api-ni.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c
index 5e6e4e2..faceb95 100644
--- a/drivers/staging/lustre/lnet/lnet/api-ni.c
+++ b/drivers/staging/lustre/lnet/lnet/api-ni.c
 <at>  <at>  -277,7 +277,7  <at>  <at>  lnet_find_lnd_by_type(int type)
 	struct list_head	 *tmp;

 	/* holding lnd mutex */
-	list_for_each (tmp, &the_lnet.ln_lnds) {
+	list_for_each(tmp, &the_lnet.ln_lnds) {
 		lnd = list_entry(tmp, lnd_t, lnd_list);

 		if ((int)lnd->lnd_type == type)
 <at>  <at>  -1645,7 +1645,6  <at>  <at>  lnet_destroy_ping_info(void)
 		    offsetof(lnet_ping_info_t,
 			     pi_ni[the_lnet.ln_ping_info->pi_nnis]));
 	the_lnet.ln_ping_info = NULL;
-	return;
 }

 int
--

-- 
1.7.10.4
(Continue reading)

Aede Symen Hoekstra | 16 Nov 16:48 2014
Picon

[PATCH] staging: wlan-ng: prism2fw: fixed code style issue

Fixed checkpatch.pl warning message: line over 80 characters

Signed-off-by: Aede Symen Hoekstra <aedesymen <at> gmail.com>
---
 drivers/staging/wlan-ng/prism2fw.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
index e907380..9408644 100644
--- a/drivers/staging/wlan-ng/prism2fw.c
+++ b/drivers/staging/wlan-ng/prism2fw.c
 <at>  <at>  -238,7 +238,8  <at>  <at>  static int prism2_fwtry(struct usb_device *udev, wlandevice_t *wlandev)
 *	0	- success
 *	~0	- failure
 ----------------------------------------------------------------*/
-static int prism2_fwapply(const struct ihex_binrec *rfptr, wlandevice_t *wlandev)
+static int prism2_fwapply(const struct ihex_binrec *rfptr,
+			  wlandevice_t *wlandev)
 {
 	signed int result = 0;
 	struct p80211msg_dot11req_mibget getmsg;
--

-- 
1.7.9.5

Gmane