Benjamin Romer | 25 Jul 19:55 2014
Picon

[PATCH] staging: unisys: fix visorchipset sysfs attribute functions

This patch cleans up the style, error handling, and string handling in the sysfs
functions recently added to visorchipset:

- Use of sscanf() was changed to type-appropriate kstrto*() functions
- error handling was simplified
- the error return value of visorchannel_write() was corrected
- switch use of driver-specific types to kernel types

Signed-off-by: Benjamin Romer <benjamin.romer <at> unisys.com>
---
 .../unisys/visorchipset/visorchipset_main.c        | 123 ++++++++++++---------
 .../staging/unisys/visorutil/memregion_direct.c    |   2 +-
 2 files changed, 69 insertions(+), 56 deletions(-)

diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visorchipset/visorchipset_main.c
index 58a441d..6f87e27 100644
--- a/drivers/staging/unisys/visorchipset/visorchipset_main.c
+++ b/drivers/staging/unisys/visorchipset/visorchipset_main.c
 <at>  <at>  -370,29 +370,31  <at>  <at>  static void controlvm_respond_physdev_changestate(CONTROLVM_MESSAGE_HEADER *
 ssize_t toolaction_show(struct device *dev, struct device_attribute *attr,
 		char *buf)
 {
-	U8 toolAction;
+	u8 toolAction;

 	visorchannel_read(ControlVm_channel,
 		offsetof(ULTRA_CONTROLVM_CHANNEL_PROTOCOL,
-			   ToolAction), &toolAction, sizeof(U8));
+			   ToolAction), &toolAction, sizeof(u8));
 	return scnprintf(buf, PAGE_SIZE, "%u\n", toolAction);
(Continue reading)

Ian Abbott | 25 Jul 19:07 2014
Picon

[PATCH 0/3] staging: comedi: amplc_dio200 detach cleanups

Fix a double free_irq() and do a bit more cleaning up of the "detach"
routines.

1) staging: comedi: amplc_dio200_common: prevent extra free_irq()
2) staging: comedi: amplc_dio200_common: remove some tests from
   amplc_dio200_common_detach()
3) staging: comedi: amplc_dio200_pci: no need to test board pointer in
   dio200_pci_detach()

 drivers/staging/comedi/drivers/amplc_dio200_common.c | 9 +++------
 drivers/staging/comedi/drivers/amplc_dio200_pci.c    | 5 +----
 2 files changed, 4 insertions(+), 10 deletions(-)
Igor Bezukh | 25 Jul 18:53 2014
Picon

[PATCH] Staging: vt6655: removed redundant comments from power.h

Removed redundant comments from power.h header file.

Signed-off-by: Igor Bezukh <igbzkh <at> gmail.com>
---
 drivers/staging/vt6655/power.h |    9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/staging/vt6655/power.h b/drivers/staging/vt6655/power.h
index ce56124..936f171 100644
--- a/drivers/staging/vt6655/power.h
+++ b/drivers/staging/vt6655/power.h
 <at>  <at>  -29,19 +29,10  <at>  <at> 
 #ifndef __POWER_H__
 #define __POWER_H__

-/*---------------------  Export Definitions -------------------------*/
 #define     C_PWBT                   1000      // micro sec. power up before TBTT
 #define     PS_FAST_INTERVAL         1         // Fast power saving listen interval
 #define     PS_MAX_INTERVAL          4         // MAX power saving listen interval

-/*---------------------  Export Classes  ----------------------------*/
-
-/*---------------------  Export Variables  --------------------------*/
-
-/*---------------------  Export Types  ------------------------------*/
-
-/*---------------------  Export Functions  --------------------------*/
-
 bool
 PSbConsiderPowerDown(
(Continue reading)

Igor Bezukh | 25 Jul 18:50 2014
Picon

[PATCH] Staging: vt6655: removed redundant comments from michael.h

Removed redundant comments from michael.h header file.

Signed-off-by: Igor Bezukh <igbzkh <at> gmail.com>
---
 drivers/staging/vt6655/michael.h |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/vt6655/michael.h b/drivers/staging/vt6655/michael.h
index f6c2c15..86cb140 100644
--- a/drivers/staging/vt6655/michael.h
+++ b/drivers/staging/vt6655/michael.h
 <at>  <at>  -33,10 +33,6  <at>  <at> 

 #include <linux/types.h>

-/*---------------------  Export Definitions -------------------------*/
-
-/*---------------------  Export Types  ------------------------------*/
-
 void MIC_vInit(u32 dwK0, u32 dwK1);

 void MIC_vUnInit(void);
 <at>  <at>  -48,8 +44,6  <at>  <at>  void MIC_vAppend(unsigned char *src, unsigned int nBytes);
 /* This also resets the message to empty. */
 void MIC_vGetMIC(u32 *pdwL, u32 *pdwR);

-/*---------------------  Export Macros ------------------------------*/
-
 /* Rotation functions on 32 bit values */
 #define ROL32(A, n)							\
(Continue reading)

Seunghun Lee | 25 Jul 18:49 2014
Picon

[PATCH] staging: dgnc: remove commented code

This patch removes commented code in dgnc driver.

CC: Lidza Louina <lidza.louina <at> gmail.com>
CC: Mark Hounschell <markh <at> compro.net>
Signed-off-by: Seunghun Lee <waydi1 <at> gmail.com>
---
 drivers/staging/dgnc/dgnc_cls.c   |    5 +-
 drivers/staging/dgnc/dgnc_trace.c |  123 -------------------------------------
 drivers/staging/dgnc/dgnc_trace.h |   10 ---
 drivers/staging/dgnc/dgnc_tty.c   |   18 ------
 drivers/staging/dgnc/digi.h       |    1 -
 5 files changed, 1 insertion(+), 156 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index 8e265c2..4b65306 100644
--- a/drivers/staging/dgnc/dgnc_cls.c
+++ b/drivers/staging/dgnc/dgnc_cls.c
 <at>  <at>  -1046,10 +1046,7  <at>  <at>  static void cls_flush_uart_read(struct channel_t *ch)
 	 * I believe this is a BUG in this UART.
 	 * So for now, we will leave the code #ifdef'ed out...
 	 */
-#if 0
-	writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR),
-					 &ch->ch_cls_uart->isr_fcr);
-#endif
+
 	udelay(10);
 }

diff --git a/drivers/staging/dgnc/dgnc_trace.c b/drivers/staging/dgnc/dgnc_trace.c
(Continue reading)

Igor Bezukh | 25 Jul 18:48 2014
Picon

[PATCH] Staging: vt6655: removed redundant comments from mib.h

Removed redundant comments from mib.h header file.

Signed-off-by: Igor Bezukh <igbzkh <at> gmail.com>
---
 drivers/staging/vt6655/mib.h |   45 +++++++++++++++---------------------------
 1 file changed, 16 insertions(+), 29 deletions(-)

diff --git a/drivers/staging/vt6655/mib.h b/drivers/staging/vt6655/mib.h
index c0a5948..732bdda 100644
--- a/drivers/staging/vt6655/mib.h
+++ b/drivers/staging/vt6655/mib.h
 <at>  <at>  -33,13 +33,12  <at>  <at> 
 #include "tether.h"
 #include "desc.h"

-/*---------------------  Export Definitions -------------------------*/
 //
 // 802.11 counter
 //

 typedef struct tagSDot11Counters {
-	unsigned long Length;             // Length of structure
+	unsigned long Length;
 	unsigned long long   TransmittedFragmentCount;
 	unsigned long long   MulticastTransmittedFrameCount;
 	unsigned long long   FailedCount;
 <at>  <at>  -68,8 +67,7  <at>  <at>  typedef struct tagSDot11Counters {
 //
 typedef struct tagSMib2Counter {
 	long    ifIndex;
(Continue reading)

Igor Bezukh | 25 Jul 18:45 2014
Picon

[PATCH] Staging: vt6655: removed redundant comments from mac.h

Removed redundant comments from mac.h header file.

Signed-off-by: Igor Bezukh <igbzkh <at> gmail.com>
---
 drivers/staging/vt6655/mac.h |  388 ++++++++++++++++++++----------------------
 1 file changed, 188 insertions(+), 200 deletions(-)

diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index 7333b8b..e417742 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
 <at>  <at>  -38,7 +38,6  <at>  <at> 
 #include "tmacro.h"
 #include "upc.h"

-/*---------------------  Export Definitions -------------------------*/
 //
 // Registers in the MAC
 //
 <at>  <at>  -72,14 +71,14  <at>  <at> 
 #define MAC_REG_TMCTL1      0x19
 #define MAC_REG_TMDATA0     0x1C
 // MAC Parameter related
-#define MAC_REG_LRT         0x20        //
-#define MAC_REG_SRT         0x21        //
-#define MAC_REG_SIFS        0x22        //
-#define MAC_REG_DIFS        0x23        //
-#define MAC_REG_EIFS        0x24        //
-#define MAC_REG_SLOT        0x25        //
-#define MAC_REG_BI          0x26        //
(Continue reading)

Igor Bezukh | 25 Jul 18:37 2014
Picon

[PATCH] Staging: vt6655: removed redundant comments from key.h

Removed redundant comments from key.h header file.

Signed-off-by: Igor Bezukh <igbzkh <at> gmail.com>
---
 drivers/staging/vt6655/key.h |   26 +++++++-------------------
 1 file changed, 7 insertions(+), 19 deletions(-)

diff --git a/drivers/staging/vt6655/key.h b/drivers/staging/vt6655/key.h
index 4b8b4b6..f0cbd75 100644
--- a/drivers/staging/vt6655/key.h
+++ b/drivers/staging/vt6655/key.h
 <at>  <at>  -34,7 +34,6  <at>  <at> 
 #include "tether.h"
 #include "80211mgr.h"

-/*---------------------  Export Definitions -------------------------*/
 #define MAX_GROUP_KEY       4
 #define MAX_KEY_TABLE       11
 #define MAX_KEY_LEN         32
 <at>  <at>  -65,38 +64,27  <at>  <at>  typedef struct tagSKeyItem
 	unsigned char byReserved0;
 	unsigned long dwKeyIndex;
 	void *pvKeyTable;
-} SKeyItem, *PSKeyItem; //64
+} SKeyItem, *PSKeyItem;

 typedef struct tagSKeyTable
 {
-	unsigned char abyBSSID[ETH_ALEN];  //6
-	unsigned char byReserved0[2];              //8
(Continue reading)

Igor Bezukh | 25 Jul 18:35 2014
Picon

[PATCH] Staging: vt6655: removed redundant comments from iwctl.h

Removed redundant comments from iwctl.h header file.

Signed-off-by: Igor Bezukh <igbzkh <at> gmail.com>
---
 drivers/staging/vt6655/iwctl.h |   12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/staging/vt6655/iwctl.h b/drivers/staging/vt6655/iwctl.h
index 871bd7c..83a5a2d 100644
--- a/drivers/staging/vt6655/iwctl.h
+++ b/drivers/staging/vt6655/iwctl.h
 <at>  <at>  -31,14 +31,6  <at>  <at> 

 #include "device.h"

-/*---------------------  Export Definitions -------------------------*/
-
-/*---------------------  Export Classes  ----------------------------*/
-
-/*---------------------  Export Variables  --------------------------*/
-
-/*---------------------  Export Functions  --------------------------*/
-
 struct iw_statistics *iwctl_get_wireless_stats(struct net_device *dev);

 int iwctl_siwap(struct net_device *dev,
 <at>  <at>  -171,7 +163,6  <at>  <at>  int iwctl_siwscan(struct net_device *dev,
 		  struct iw_param *wrq,
 		  char *extra);

(Continue reading)

Igor Bezukh | 25 Jul 18:33 2014
Picon

[PATCH] Staging: vt6655: removed redundant comments from iowpa.h

Removed redundant comments from iowpa.h header file.

Signed-off-by: Igor Bezukh <igbzkh <at> gmail.com>
---
 drivers/staging/vt6655/iowpa.h |   10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/staging/vt6655/iowpa.h b/drivers/staging/vt6655/iowpa.h
index b7bd190..772bc4c 100644
--- a/drivers/staging/vt6655/iowpa.h
+++ b/drivers/staging/vt6655/iowpa.h
 <at>  <at>  -29,8 +29,6  <at>  <at> 
 #ifndef __IOWPA_H__
 #define __IOWPA_H__

-/*---------------------  Export Definitions -------------------------*/
-
 #define WPA_IE_LEN 64

 //WPA related
 <at>  <at>  -127,14 +125,6  <at>  <at>  struct viawget_scan_result {
 	int maxrate;
 };

-//2006-1116-01,<Add> by NomadZhao
 #pragma pack()
-/*---------------------  Export Classes  ----------------------------*/
-
-/*---------------------  Export Variables  --------------------------*/
-
(Continue reading)

Igor Bezukh | 25 Jul 18:31 2014
Picon

[PATCH] Staging: vt6655: removed redundant comments from ioctl.h

Removed redundant comments from ioctl.h header file.

Signed-off-by: Igor Bezukh <igbzkh <at> gmail.com>
---
 drivers/staging/vt6655/ioctl.h |    8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/staging/vt6655/ioctl.h b/drivers/staging/vt6655/ioctl.h
index 2f0db92..187fc91 100644
--- a/drivers/staging/vt6655/ioctl.h
+++ b/drivers/staging/vt6655/ioctl.h
 <at>  <at>  -31,14 +31,6  <at>  <at> 

 #include "device.h"

-/*---------------------  Export Definitions -------------------------*/
-
-/*---------------------  Export Classes  ----------------------------*/
-
-/*---------------------  Export Variables  --------------------------*/
-
-/*---------------------  Export Functions  --------------------------*/
-
 int private_ioctl(PSDevice pDevice, struct ifreq *rq);

 #endif // __IOCTL_H__
--

-- 
1.7.9.5

Gmane