Felipe Augusto van de Wiel (faw <felipe <at> cathedrallabs.org>
2007-03-01 16:02:21 GMT
On 03/01/2007 10:39 AM, Eder L. Marques wrote:
> Felipe Augusto van de Wiel (faw) escreveu:
>> On 02/28/2007 09:51 PM, Eder L. Marques wrote:
>>> File attached.
>> We probably would need to speed up the review process. Christian,
>> I just finished reviewing the attached PO, if the Eder didn't answer when
>> you got to the package, please consider the attached po.
> Patch apllied and reviewed.
Hmmm... somthing told me that this reviewed could be problematic.
Your new file reintroduces typos that I had fixed on my previous
patch, so, or you didn't applied the patch and hand-fixed it (which is
bad), or you did applied the patch but edited the po.
In either case it is wrong. Usually you discuss the patch before
apply it, and you also provide a new patch so the reviewer can understand
what you change and what you didn't change.
Christian, please, use my previous file. The rest of this message
is about the review procedure and I'm going to carry it in pt_BR, sorry.
Diff entre o meu arquivo e o seu novo arquivo.
--- dbmail_pt_BR.po 2007-03-01 12:51:32.756471151 -0300
+++ rfr2_eder_pt_BR.po 2007-03-01 12:51:20.715718651 -0300
<at> <at> -9,7 +9,7 <at> <at>