Bug#379340: inappropriate dependency on e2fsprogs

I think that initscripts dependency to e2fsprogs and mount should be
removed. They are "Essential: yes" and "Priority: required" packages.
And those dependency version numbers are from many releases ago.

Bug#463504: division by zero when xdm started at 01

Package: sysv-rc
Version: 2.86.ds1-52
Severity: grave

I start xdm first:

lapse:~> ls /etc/rc2.d/S* | head -1
/etc/rc2.d/S01xdm

This causes the num_steps loop on line 257 of /etc/init.d/rc to
break during the first iteration, which in turn causes a division by
zero in the startup_process() function:

  /etc/init.d/rc exited outside the expected control flow
  /etc/init.d/rc: 2: arithmetic expression: division by zero: "1 * 31 / 0 + 61"

I think you may mean s/break/continue in the num_steps loop to not
count those few services, but to continue counting...

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.23-1-686 (SMP w/1 CPU core)
Locale: LANG=en_GB, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

sysv-rc depends on no packages.

Bug#463504: Bug#463504: division by zero when xdm started at 01

[Martin F Krafft]
> I start xdm first:
> 
> lapse:~> ls /etc/rc2.d/S* | head -1
> /etc/rc2.d/S01xdm

First of all, how did xdm end up that early in the boot sequence?  Do
you have usplash or splashy installed and activated?  I know usplash
need to stop before xdm, so it is very surprising to see that xdm is
the first entry in rc2.d/.

> This causes the num_steps loop on line 257 of /etc/init.d/rc to
> break during the first iteration, which in turn causes a division by
> zero in the startup_process() function:
> 
>   /etc/init.d/rc exited outside the expected control flow
>   /etc/init.d/rc: 2: arithmetic expression: division by zero: "1 * 31 / 0 + 61"
> 
> I think you may mean s/break/continue in the num_steps loop to not
> count those few services, but to continue counting...

This is a problem with sysv-rc, all right.  It should not break down
even if there are no progress bar steps to count because xdm (or kdm
and gdm) is the first entry in the runlevel.  Will have a look at the
logic to fix it.

Moving xdm a bit later in the boot sequence is a workaround you can
apply to fix it while a proper fix propagate into testing.

Happy hacking,

Bug#463504: Bug#463504: division by zero when xdm started at 01

[Petter Reinholdtsen]
> This is a problem with sysv-rc, all right.  It should not break down
> even if there are no progress bar steps to count because xdm (or kdm
> and gdm) is the first entry in the runlevel.  Will have a look at
> the logic to fix it.

Can you test this patch?

Index: debian/sysv-rc/etc/init.d/rc
===================================================================
--- debian/sysv-rc/etc/init.d/rc        (revision 1227)
+++ debian/sysv-rc/etc/init.d/rc        (working copy)
 <at>  <at>  -83,6 +83,9  <at>  <at> 
 # Stub to do progress bar ticks (for splash programs) on startup
 #
 startup_progress() {
+    # Avoid divide by zero if anyone moved xdm/kdm/gdm first in a runlevel.
+    if [ 0 = "$num_steps" ] ; then return; fi
+
     step=$(($step + $step_change))
     progress=$(($step * $progress_size / $num_steps + $first_step))
     $debug splash_progress "$progress" || true

Happy hacking,
--

-- 
Petter Reinholdtsen

Processed: Re: Bug#463505: fails to start up most init services, division by zero

Processing commands for control <at> bugs.debian.org:

> severity 463505 grave
Bug#463505: fails to start up most init services, division by zero
Severity set to `grave' from `critical'

> reassign 463505 sysv-rc
Bug#463505: fails to start up most init services, division by zero
Bug reassigned from package `insserv' to `sysv-rc'.

> forcemerge 463504 463505
Bug#463504: division by zero when xdm started at 01
Bug#463505: fails to start up most init services, division by zero
Forcibly Merged 463504 463505.

>
End of message, stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)

Bug#463551: initscripts: error in preinst

Package: initscripts
Version: 2.86.ds1-38.1

While upgrading my machine this morning, I noticed this:

| Preparing to replace initscripts 2.86.ds1-38.1 (using .../initscripts_2.86.ds1-52_i386.deb) ...
| sed: -e expression #1, char 1: unknown command: `"'
| /var/lib/dpkg/tmp.ci/preinst: line 19: s/.*: No such file or directory
| Obsolete conffile /etc/init.d/bootclean has been modified by you.
| Saving as /etc/init.d/bootclean.dpkg-bak ...
| Unpacking replacement initscripts ...
| Setting up initscripts (2.86.ds1-52) ...

Although the upgrade itself seems to be fine, something is probably
broken in the preinst script.

--

-- 
+--------------------------------------------------------------+
| Bas Zoetekouw      | Sweet day, so cool, so calm, so bright, |
|--------------------| The bridall of the earth and skie:      |
| bas <at> zoetekouw.net  | The dew shall weep thy fall tonight;    |
+--------------------|                    For thou must die.   |
                     +-----------------------------------------+

Processing of sysvinit_2.86.ds1-53_i386.changes

sysvinit_2.86.ds1-53_i386.changes uploaded successfully to localhost
along with the files:
  sysvinit_2.86.ds1-53.dsc
  sysvinit_2.86.ds1-53.diff.gz
  sysvinit_2.86.ds1-53_i386.deb
  sysvinit-utils_2.86.ds1-53_i386.deb
  initscripts_2.86.ds1-53_i386.deb
  sysv-rc_2.86.ds1-53_all.deb

Greetings,

	Your Debian queue daemon

sysvinit_2.86.ds1-53_i386.changes ACCEPTED

Accepted:
initscripts_2.86.ds1-53_i386.deb
  to pool/main/s/sysvinit/initscripts_2.86.ds1-53_i386.deb
sysv-rc_2.86.ds1-53_all.deb
  to pool/main/s/sysvinit/sysv-rc_2.86.ds1-53_all.deb
sysvinit-utils_2.86.ds1-53_i386.deb
  to pool/main/s/sysvinit/sysvinit-utils_2.86.ds1-53_i386.deb
sysvinit_2.86.ds1-53.diff.gz
  to pool/main/s/sysvinit/sysvinit_2.86.ds1-53.diff.gz
sysvinit_2.86.ds1-53.dsc
  to pool/main/s/sysvinit/sysvinit_2.86.ds1-53.dsc
sysvinit_2.86.ds1-53_i386.deb
  to pool/main/s/sysvinit/sysvinit_2.86.ds1-53_i386.deb

Override entries for your package:
initscripts_2.86.ds1-53_i386.deb - required admin
sysv-rc_2.86.ds1-53_all.deb - required admin
sysvinit-utils_2.86.ds1-53_i386.deb - required admin
sysvinit_2.86.ds1-53.dsc - source admin
sysvinit_2.86.ds1-53_i386.deb - required admin

Announcing to debian-devel-changes <at> lists.debian.org
Closing bugs: 462354 463504 463551 

Thank you for your contribution to Debian.

Bug#463551: marked as done (initscripts: error in preinst)

Your message dated Fri, 01 Feb 2008 18:47:06 +0000
with message-id <E1JL0uo-0005e1-9c <at> ries.debian.org>
and subject line Bug#463551: fixed in sysvinit 2.86.ds1-53
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

From: Bas Zoetekouw <bas <at> debian.org>
Subject: initscripts: error in preinst
Date: 2008-02-01 11:31:13 GMT

Package: initscripts
Version: 2.86.ds1-38.1

Bug#463504: marked as done (division by zero when xdm started at 01)

Your message dated Fri, 01 Feb 2008 18:47:06 +0000
with message-id <E1JL0uo-0005dz-8r <at> ries.debian.org>
and subject line Bug#463504: fixed in sysvinit 2.86.ds1-53
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

From: martin f krafft <madduck <at> debian.org>
Subject: division by zero when xdm started at 01
Date: 2008-02-01 02:53:49 GMT

Package: sysv-rc
Version: 2.86.ds1-52
Severity: grave