Bug#651964: [Build-common-hackers] Bug#651964: Bug#651964: cdbs: class/langcore.mk doesn't set CPPFLAGS and LDFLAGS from dpkg-buildflags
Jonas Smedegaard <dr <at> jones.dk>
2012-02-01 00:05:39 GMT
On 12-01-31 at 09:48pm, Moritz Muehlenhoff wrote:
> On Wed, Dec 14, 2011 at 01:16:40AM +0700, Jonas Smedegaard wrote:
> > tags 651964 wontfix
> > thanks
> > On 11-12-13 at 05:34pm, Simon Ruderich wrote:
> > > While trying to build poppler with hardening flags I noticed that
> > > CPPFLAGS and LDFLAGS were not set correctly. This is an important
> > > problem as it causes several hardening flags (fortify source,
> > > relro) to not get included in the build.
> > >
> > > Adding the following lines to class/langcore.mk.in in line 57
> > > where CFLAGS and CXXFLAGS are already set fixes the problem:
> > >
> > > CPPFLAGS += $(deb_cppflags)
> > > LDFLAGS += $(deb_ldflags)
> > Thanks for your bugreport.
> > I agree with you that some flags were set properly in the past.
> > Unfortunately some packages depend on the old broken behaviour, so
> > it can not be corrected now.
> Hi Jonas,
> I'm currently working my way through all packages, which have had a
> DSA in the last five years and/or which are of Priority >= important.
> I've nearly finished all packages based on debhelper and I now proceed
> with the packages based on cdbs.