Re: [SCM] advene/master: Use standard dh_python2 instead of pysupport

On 11-05-31 at 09:40pm, oaubert-guest <at> users.alioth.debian.org wrote:
> +DEB_PYTHON_INSTALL_ARGS_ALL = --install-layout=deb

Why do you add --install-layout=deb ?

I suspect because dh_python2 questions the CDBS routines.  But did you 
experience any actual wrong result from the CDBS routines?

 - Jonas

--

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers <at> lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: [SCM] advene/master: Modify include order

On 11-05-31 at 09:40pm, oaubert-guest <at> users.alioth.debian.org wrote:
> The following commit has been merged in the master branch:
> commit 5bb8fc2c567c163876d89e0dbdece76dffd7d864
> Author: Olivier Aubert <olivier.aubert <at> liris.cnrs.fr>
> Date:   Fri May 27 16:00:28 2011 +0200
> 
>     Modify include order
> 
> diff --git a/debian/rules b/debian/rules
> index cecf131..12d8e03 100755
> --- a/debian/rules
> +++ b/debian/rules
>  <at>  <at>  -2,11 +2,11  <at>  <at> 
>  
>  DEB_PYTHON2_MODULE_PACKAGES = advene
>  
> -include /usr/share/cdbs/1/rules/debhelper.mk
>  include /usr/share/cdbs/1/rules/utils.mk
>  include /usr/share/cdbs/1/class/python-distutils.mk
> +include /usr/share/cdbs/1/rules/debhelper.mk
>  
> -DEB_PYTHON_INSTALL_ARGS_ALL = --install-layout=deb
> +DEB_PYTHON_INSTALL_ARGS_ALL = --no-compile --install-layout=deb
>  DEB_INSTALL_CHANGELOGS_ALL := CHANGES.txt
>  DEB_INSTALL_DOCS_ALL := doc/*

Why change include order?  Just cosmetic or what depends on a certain 
order?

Also, why add --no-compile option?

Processing of japa_0.6.0-2_amd64.changes

japa_0.6.0-2_amd64.changes uploaded successfully to localhost
along with the files:
  japa_0.6.0-2.dsc
  japa_0.6.0-2.debian.tar.gz
  japa_0.6.0-2_amd64.deb

Greetings,

	Your Debian queue daemon (running on host franck.debian.org)

japa_0.6.0-2_amd64.changes ACCEPTED into unstable

Accepted:
japa_0.6.0-2.debian.tar.gz
  to main/j/japa/japa_0.6.0-2.debian.tar.gz
japa_0.6.0-2.dsc
  to main/j/japa/japa_0.6.0-2.dsc
japa_0.6.0-2_amd64.deb
  to main/j/japa/japa_0.6.0-2_amd64.deb

Override entries for your package:
japa_0.6.0-2.dsc - source sound
japa_0.6.0-2_amd64.deb - extra sound

Announcing to debian-devel-changes <at> lists.debian.org

Thank you for your contribution to Debian.

Reissue: vo-aacenc_0.1.0~rc1-1_i386.changes ACCEPTED into unstable

Dear ftp-masters and pkg-multimedia team,

to pick up the discussion from 6 weeks ago (see below, sorry for 
top-posting): Are there any news with regard to the acceptance of the 
xvidcore, x264 and mjpegtools packages into Debian?

Our previous discussion at least led to the rejection of the lame 
package for comprehensible reasons which have been forwarded to 
upstream and mostly resolved in the mean time. So, every kind of 
reaction might lead to productivity. ;)

Best regards,
Fabian

Am 19.04.2011 05:25, schrieb Jonas Smedegaard:
>> Private communication with single maintainers may not be considered
>> the most transparent form of communication, especially if there is a
>> whole team of maintainers involved that is waiting for a clear public
>> statement for months.
>
> Indeed.
>
> The queries are referred to was (obviously) the ones public which I
> therefore knew about, not discrete queries.  And with "silence" as the
> response thus far from ftpmasters I did not mean that ftpmasters did not
> discuss with each other or their friends, but that those public queries
> had not received a response from them.
>
> I apologize for my inaccuracy, and really really hope that this is read
> only as clarification: I am happy that we now have a response from

Re: [SCM] advene/master: Use standard dh_python2 instead of pysupport

On Wed, 2011-06-01 at 02:19 +0200, Jonas Smedegaard wrote:
> On 11-05-31 at 09:40pm, oaubert-guest <at> users.alioth.debian.org wrote:
> > +DEB_PYTHON_INSTALL_ARGS_ALL = --install-layout=deb
> Why do you add --install-layout=deb ?
It was indeed a try to remove the dh_python2 warning. It does not change
anything in the produced package, since install dir is overwritten by
CDBS. From my not-so-informed point of view however, since the
--install-layout=deb option was added specifically to help building
debian packages, CDBS should use it when possible, instead of specifying
its own dirs.

> I suspect because dh_python2 questions the CDBS routines.  But did you 
> experience any actual wrong result from the CDBS routines?
The produced package is actually working, even if building it generates
a warning. I do take warnings seriously, since it is a sign of something
not broken but which could have problems. I did not find any definitive
answer about the subject of dist-packages vs site-packages, so I did not
yet, as suggested, file a bug against python/dh_python2. I still do not
know if the warning is superfluous or valid.

Olivier

Re: [SCM] advene/master: Modify include order

This change was to try to solve another issue: the package builds only
for python2.6, while it should build for both 2.6 and 2.7.

I have tracked the issue to the DEB_ARCH_PACKAGES definition, which is
used to filter the cdbs_python_build_versions variable. Modifying the
order seemed to change the initialisation order of these variables (I
may be wrong here, having made too many variations). In the end, it is
still not working, but I chose to commit this include order since it is
the one used in other example packages. Better safe than sorry.

Regards,
Olivier

On Wed, 2011-06-01 at 02:22 +0200, Jonas Smedegaard wrote:
> On 11-05-31 at 09:40pm, oaubert-guest <at> users.alioth.debian.org wrote:
> > The following commit has been merged in the master branch:
> > commit 5bb8fc2c567c163876d89e0dbdece76dffd7d864
> > Author: Olivier Aubert <olivier.aubert <at> liris.cnrs.fr>
> > Date:   Fri May 27 16:00:28 2011 +0200
> > 
> >     Modify include order
> > 
> > diff --git a/debian/rules b/debian/rules
> > index cecf131..12d8e03 100755
> > --- a/debian/rules
> > +++ b/debian/rules
> >  <at>  <at>  -2,11 +2,11  <at>  <at> 
> >  
> >  DEB_PYTHON2_MODULE_PACKAGES = advene
> >  

Re: [SCM] advene/master: Use standard dh_python2 instead of pysupport

On 11-06-01 at 11:18am, Olivier Aubert wrote:
> On Wed, 2011-06-01 at 02:19 +0200, Jonas Smedegaard wrote:
> > On 11-05-31 at 09:40pm, oaubert-guest <at> users.alioth.debian.org wrote:
> > > +DEB_PYTHON_INSTALL_ARGS_ALL = --install-layout=deb
> > Why do you add --install-layout=deb ?
> It was indeed a try to remove the dh_python2 warning. It does not 
> change anything in the produced package, since install dir is 
> overwritten by CDBS. From my not-so-informed point of view however, 
> since the --install-layout=deb option was added specifically to help 
> building debian packages, CDBS should use it when possible, instead of 
> specifying its own dirs.

It was specifically avoided in CDBS to ease backporting.

Using new python install helper cripples backportability as well.

> > I suspect because dh_python2 questions the CDBS routines.  But did 
> > you experience any actual wrong result from the CDBS routines?
> The produced package is actually working, even if building it 
> generates a warning. I do take warnings seriously, since it is a sign 
> of something not broken but which could have problems. I did not find 
> any definitive answer about the subject of dist-packages vs 
> site-packages, so I did not yet, as suggested, file a bug against 
> python/dh_python2. I still do not know if the warning is superfluous 
> or valid.

If you ever find a definitive answer then please let me know.  I believe 
no answer to that is definitive, as it involves multiple opinions.

I do not see it as a warning but a question: Did you forget to include 

Re: [SCM] advene/master: Modify include order

On 11-06-01 at 11:42am, Olivier Aubert wrote:
> This change was to try to solve another issue: the package builds only 
> for python2.6, while it should build for both 2.6 and 2.7.
> 
> I have tracked the issue to the DEB_ARCH_PACKAGES definition, which is 
> used to filter the cdbs_python_build_versions variable. Modifying the 
> order seemed to change the initialisation order of these variables (I 
> may be wrong here, having made too many variations). In the end, it is 
> still not working, but I chose to commit this include order since it 
> is the one used in other example packages. Better safe than sorry.

Order should not matter.

In the few cases that order do matter, CDBS should emit warnings or 
errors about that.

Please file bugreports if you suspect cases of that not to be true.

When you notice a pattern in the order of inclusions from inspecting 
packages I am involved in, most likely it is purely stylistic: I tend to 
include roughly in the order they are used during a normal build.

Please consider mentioning in git commit messages not only what you do 
but also why you do it.

Regards,

 - Jonas

--

-- 

Processing of yoshimi_0.060.10-2_amd64.changes

yoshimi_0.060.10-2_amd64.changes uploaded successfully to localhost
along with the files:
  yoshimi_0.060.10-2.dsc
  yoshimi_0.060.10-2.debian.tar.gz
  yoshimi_0.060.10-2_amd64.deb
  yoshimi-data_0.060.10-2_all.deb
  yoshimi-dbg_0.060.10-2_amd64.deb

Greetings,

	Your Debian queue daemon (running on host franck.debian.org)