Bug#745104: x264 should check the compiler version directly rather than assuming based on architecture.
2014-04-18 00:23:18 GMT
Package: x264 Version: 2:0.142.2389+git956c8d8-4 Tags: patch Version 2:0.142.2389+git956c8d8-2 of the x264 package introduced the use of the compiler flag -fno-aggressive-loop-optimizations to fix/workaround a problem (leading to a segfault) when the code was built with gcc 4.8. However -fno-aggressive-loop-optimizations doesn't exist in 4.6 or 4.7 this lead to build failures on sparc and sh4. It will also lead to build failures for anyone who tries to backport the unstable x264 packages to stable. The sparc build failure was fixed in 2:0.142.2389+git956c8d8-4 by special casing the sparc architecture to not pass the flag but I belive this was a bad soloution for two reasons. 1: it doesn't fix the build failure for sh4, backporters or anyone else who might run into it 2: afaict the issue worked arround by -fno-aggressive-loop-optimizations is not architecture specific, so if/when sparc switches it's default compiler to 4.8 you will want -fno-aggressive-loop-optimizations on sparc. It makes far more sense IMO to just check the compiler version and act accordingly. Patch to do that is attatched.
diff -Nru x264-0.142.2389+git956c8d8/debian/changelog x264-0.142.2389+git956c8d8/debian/changelog --- x264-0.142.2389+git956c8d8/debian/changelog 2014-04-05 21:46:49.000000000 +0000(Continue reading)