[PATCH] First step in converting W83977TF early serial from included to linked
Keith Hui <buurin <at> gmail.com>
2011-03-01 05:20:07 GMT
And here is the patch. abuild-tested. I will boot test it with P2B-LS
and P3B-F tomorrow but I want this patch out there to generate some
discussions and get more boot test coverage.
This I believe falls under "infrastructure projects" [1].
This patch facilitates, for boards using Winbond W83977TF superio,
dropping early_serial.c from #includes of their romstage, instead
linking to them; and converts 12 of 13 mainboards using this superio
to do exactly this. The lone board out, iei/nova4899r, is a
Geode/CS5530 board that has not yet been converted to CAR or tiny
bootblock. The rest are all slot 1/440BX/i82371eb boards that have
been converted. At this stage I should leave converting CS5530 to tiny
bootblock to someone better versed in this platform.
The pnp_... functions defined in romcc_io.h now have a new home in
arch/x86/lib/pnp.c, and is compiled and linked like any other C files
meant for romstage.
This patch puts the W83977TF early serial code in a state where it can
be incorporated both through the old setup (ie. #included in mainboard
romstage), or be compiled separately and linked into romstage. Once
this conversion is done on all superios and all southbridges/boards
have been converted, the few #ifdefs that made this possible can be
cleaned out.
Signed-off-by: Keith Hui <buurin <at> gmail.com>
[1] http://www.coreboot.org/Infrastructure_Projects#Remove_.c_includes
(Continue reading)