1 May 01:06
Re: i440bx RAM initialization code (SPD)
Uwe Hermann <uwe <at> hermann-uwe.de>
2007-04-30 23:06:31 GMT
2007-04-30 23:06:31 GMT
Hi, thanks for your patch. However, please sign-off all patches you submit, otherwise we cannot commit them. http://linuxbios.org/Development_Guidelines#Sign-off_Procedure Please re-send this patch with a sign-off. On Mon, Apr 30, 2007 at 10:47:42AM -0400, Alfred Wanga wrote: > * PMCR - When should it be updated? > Looking at the assembly, it seems as though it's ok to just set the > final value before the RAM refresh code instead of waiting until > afterwards, but I don't know for sure, so I left the original code > alone. Yeah, I'm not sure either. Will look into that later... > * sdram_enable delays > I changed all the RAM timing delays (tRP, tRC, tMRD) to 1usec, since > the timings are on the order of hundreds of nanoseconds (according to > SPD values) and the smallest resolution timer available seems to be > udelay() anyway. It should work for any SDRAM, and shaves a few > milliseconds off previous code. Yep, when everything is working fine (or maybe even before) we'll lower the delays. I set them quite high to make sure that it's definately not a too short delay which is causing problems... If you want you can submit an extra patch with just the delay-fixes. I'll(Continue reading)
RSS Feed