repository service | 9 Oct 04:31 2010

[commit] r5927 - in trunk/src/northbridge/amd/amdmct: mct mct_ddr3

Author: zbao
Date: Sat Oct  9 04:31:10 2010
New Revision: 5927
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5927

Log:
Trivial. Spell checking.

Signed-off-by: Zheng Bao <zheng.bao <at> amd.com>
Acked-by: Zheng Bao <zheng.bao <at> amd.com>

Modified:
   trunk/src/northbridge/amd/amdmct/mct/mct.h
   trunk/src/northbridge/amd/amdmct/mct/mct_d.h
   trunk/src/northbridge/amd/amdmct/mct/mctardk3.c
   trunk/src/northbridge/amd/amdmct/mct/mctardk4.c
   trunk/src/northbridge/amd/amdmct/mct/mctpro_d.c
   trunk/src/northbridge/amd/amdmct/mct_ddr3/mct_d.h

Modified: trunk/src/northbridge/amd/amdmct/mct/mct.h
==============================================================================
--- trunk/src/northbridge/amd/amdmct/mct/mct.h	Fri Oct  8 22:09:21 2010	(r5926)
+++ trunk/src/northbridge/amd/amdmct/mct/mct.h	Sat Oct  9 04:31:10 2010	(r5927)
 <at>  <at>  -110,7 +110,7  <at>  <at> 
 #define Mod64BitMux	4		/* func 2, offset A0h, bit 4 */
 #define DisableJitter	1		/* func 2, offset A0h, bit 1 */
 #define DramEnabled	9		/* func 2, offset A0h, bit 9 */
-#define SyncOnUcEccEn	2		/* fun 3, offset 44h, bit 2 */
+#define SyncOnUcEccEn	2		/* func 3, offset 44h, bit 2 */

(Continue reading)

Bao, Zheng | 9 Oct 04:37 2010
Picon

[patch]: Remove src/northbridge/amd/amdmct/mct/mct.h

Remove src/northbridge/amd/amdmct/mct/mct.h, which is not used any more.

No attached patches to reduce confusing.

Signed-off-by: Zheng Bao <zheng.bao <at> amd.com>

--

-- 
coreboot mailing list: coreboot <at> coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot

Bao, Zheng | 9 Oct 08:29 2010
Picon

Re: [patch]: Remove src/northbridge/amd/amdmct/mct/mct.h

BTW, I tried to use the following way to create patch.
1. svn delete src/northbridge/amd/amdmct/mct/mct.h
2. svn diff > remove.patch
But when I tried to apply the patch, it just makes the mct.h empty
instead of deleting it. 

How to create a patch in this case?

Zheng

> -----Original Message-----
> From: coreboot-bounces+zheng.bao=amd.com <at> coreboot.org
[mailto:coreboot-
> bounces+zheng.bao=amd.com <at> coreboot.org] On Behalf Of Bao, Zheng
> Sent: Saturday, October 09, 2010 10:37 AM
> To: Coreboot
> Subject: [coreboot] [patch]: Remove
src/northbridge/amd/amdmct/mct/mct.h
> 
> Remove src/northbridge/amd/amdmct/mct/mct.h, which is not used any
more.
> 
> No attached patches to reduce confusing.
> 
> Signed-off-by: Zheng Bao <zheng.bao <at> amd.com>
> 
> 
> 
> 
> --
(Continue reading)

repository service | 9 Oct 09:18 2010

[commit] r5928 - in trunk/src/northbridge/amd/amdmct: mct mct_ddr3

Author: zbao
Date: Sat Oct  9 09:18:50 2010
New Revision: 5928
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5928

Log:
Trivial. Spell checking.

Signed-off-by: Zheng Bao <zheng.bao <at> amd.com>
Acked-by: Zheng Bao <zheng.bao <at> amd.com>

Modified:
   trunk/src/northbridge/amd/amdmct/mct/mctecc_d.c
   trunk/src/northbridge/amd/amdmct/mct/mctmtr_d.c
   trunk/src/northbridge/amd/amdmct/mct_ddr3/mctecc_d.c
   trunk/src/northbridge/amd/amdmct/mct_ddr3/mctmtr_d.c
   trunk/src/northbridge/amd/amdmct/mct_ddr3/mhwlc_d.c
   trunk/src/northbridge/amd/amdmct/mct_ddr3/mutilc_d.c
   trunk/src/northbridge/amd/amdmct/mct_ddr3/mwlc_d.h

Modified: trunk/src/northbridge/amd/amdmct/mct/mctecc_d.c
==============================================================================
--- trunk/src/northbridge/amd/amdmct/mct/mctecc_d.c	Sat Oct  9 04:31:10 2010	(r5927)
+++ trunk/src/northbridge/amd/amdmct/mct/mctecc_d.c	Sat Oct  9 09:18:50 2010	(r5928)
 <at>  <at>  -61,7 +61,7  <at>  <at> 
  * guarantee that the NB scrubs the entire dram on its node. Do do this, we
  * simply sample the scrub ADDR once, for an initial value, then we sample and poll until the polled value of
scrub ADDR
  * has wrapped around at least once: Scrub ADDRi+1 < Scrub ADDRi. Since we let all
- * Nodes run in parallel, we need to gaurantee that all nodes have wrapped. To do
(Continue reading)

Warren Turkal | 9 Oct 09:31 2010

Re: [PATCH try 5] Reduce duplicate definition in CAR code.

*ping*

On Thu, Oct 7, 2010 at 11:45 PM, Warren Turkal <wt <at> penguintechs.org> wrote:
> I implemented the consensus method of only replacing the magic numbers
> with constants instead of pulling the lists into assembler macros in
> mtrr.h. How does this one look to everyone?
>
> Comments? Acks?
>
> Thanks,
> wt
> 8<---------------------------------
> Macros for the register addresses for the MTRR MSRs are already defined
> in include/cpu/x86/car.h. This patch uses those macros instead of
> creating a second instance of that same data.
>
> I also added a few macros to the amd mtrr.h to make the MSR naming more
> consistent.
>
> Signed-off-by: Warren Turkal <wt <at> penguintechs.org>
> ---
>  src/cpu/amd/car/cache_as_ram.inc   |   59 +++++++++++++++++++++++++----------
>  src/cpu/intel/car/cache_as_ram.inc |   45 ++++++++++++++++++++-------
>  src/cpu/via/car/cache_as_ram.inc   |   43 +++++++++++++++++++-------
>  src/include/cpu/amd/mtrr.h         |   13 ++++----
>  4 files changed, 114 insertions(+), 46 deletions(-)
>
> diff --git a/src/cpu/amd/car/cache_as_ram.inc b/src/cpu/amd/car/cache_as_ram.inc
> index 5318272..5a19a0c 100644
> --- a/src/cpu/amd/car/cache_as_ram.inc
(Continue reading)

Warren Turkal | 9 Oct 09:32 2010

Re: [PATCH] Build bootblock.S instead of bootblock.c.

*ping*

On Fri, Oct 8, 2010 at 2:06 AM, Warren Turkal <wt <at> penguintechs.org> wrote:
> I did some test builds on a few intel boards using the tiny bootblock. I
> think that this should be pretty low risk.
>
> Looking for an ack,
> wt
> 8<-------------
> The file is actually just including a bunch of assembly. The build rule
> for bootblock.c even states that the file will be "assembler-with-cpp."
>
> Signed-off-by: Warren Turkal <wt <at> penguintechs.org>
> ---
>  src/arch/i386/Makefile.bootblock.inc |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/arch/i386/Makefile.bootblock.inc b/src/arch/i386/Makefile.bootblock.inc
> index face04c..6d975ac 100644
> --- a/src/arch/i386/Makefile.bootblock.inc
> +++ b/src/arch/i386/Makefile.bootblock.inc
>  <at>  <at>  -52,7 +52,7  <at>  <at>  $(obj)/bootblock/ldscript.ld: $$(bootblock_lds) $(obj)/ldoptions
>        mkdir -p $(obj)/bootblock
>        printf '$(foreach ldscript,ldoptions $(bootblock_lds),INCLUDE "$(ldscript)"\n)' > $ <at> 
>
> -$(obj)/bootblock/bootblock.c: $$(bootblock_inc)
> +$(obj)/bootblock/bootblock.S: $$(bootblock_inc)
>         <at> printf "    GEN        $(subst $(obj)/,,$( <at> ))\n"
>        mkdir -p $(obj)/bootblock
>        printf '$(foreach crt0,config.h $(bootblock_inc),#include "$(crt0)"\n)' > $ <at> 
(Continue reading)

Warren Turkal | 9 Oct 09:33 2010

Re: [PATCH] Move d810e2cb to tiny boot block.

I have been told that this might be dangerous or incomplete for moving
to tiny bootloader. Can someone with more experience please comment?

Thanks,
wt

On Fri, Oct 8, 2010 at 2:18 AM, Warren Turkal <wt <at> penguintechs.org> wrote:
> I just tried building the d810e2cb board with a tiny boot block.
>
> It builds! Ship it! :)
>
> Joseph, I see that you did the work on romstage.c on that board. Would
> you be able to test this patch to make sure it works?
>
> If anyone else has this board, I'd appreciate the testing.
>
> Thanks,
> wt
> 8<---------
> Signed-off-by: Warren Turkal <wt <at> penguintechs.org>
> ---
>  src/mainboard/intel/d810e2cb/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/mainboard/intel/d810e2cb/Kconfig b/src/mainboard/intel/d810e2cb/Kconfig
> index 8c6c76b..6d407d2 100644
> --- a/src/mainboard/intel/d810e2cb/Kconfig
> +++ b/src/mainboard/intel/d810e2cb/Kconfig
>  <at>  <at>  -31,6 +31,7  <at>  <at>  config BOARD_SPECIFIC_OPTIONS # dummy
>        select BOARD_ROMSIZE_KB_512
(Continue reading)

Warren Turkal | 9 Oct 09:36 2010

Re: [patch]: Remove src/northbridge/amd/amdmct/mct/mct.h

On Fri, Oct 8, 2010 at 11:29 PM, Bao, Zheng <Zheng.Bao <at> amd.com> wrote:
> BTW, I tried to use the following way to create patch.
> 1. svn delete src/northbridge/amd/amdmct/mct/mct.h
> 2. svn diff > remove.patch
> But when I tried to apply the patch, it just makes the mct.h empty
> instead of deleting it.
>
> How to create a patch in this case?

How did you apply the patch?

See the -E option of patch(1) for more info.

wt

--

-- 
coreboot mailing list: coreboot <at> coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot

Uwe Hermann | 9 Oct 12:04 2010
Picon

Re: [PATCH] Remove various .c #includes from Intel 440BX/82371EB boards

On Fri, Oct 08, 2010 at 02:41:40AM -0400, Corey Osgood wrote:
> I think I've found the problem, include/console/console.h:
> 
> 62 #ifndef __ROMCC__
> 63 void console_init(void);
> 64 void post_code(u8 value);
> 65 void __attribute__ ((noreturn)) die(const char *msg);
> 
> Maybe move that definition a few lines up, and see what happens? Or

So far I couldn't find a combination which works, but it's not needed at
the moment, I can dodge the problem by removing the die() calls
alltogether, that was on my TODO list anyways. Those checks in the code
are not really useful, the PCI device is always there, and we don't do
such checks elsewhere in the code either.

Updated patch attached, now survives abuild.

> else converting the QEMU target to CAR seems like the other option.

That won't work as far as I've heard (QEMU limitations).

Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org
--

-- 
(Continue reading)

Joseph Smith | 9 Oct 15:05 2010

Re: [PATCH] Move d810e2cb to tiny boot block.

On 10/08/2010 05:18 AM, Warren Turkal wrote:
> I just tried building the d810e2cb board with a tiny boot block.
>
> It builds! Ship it! :)
>
> Joseph, I see that you did the work on romstage.c on that board. Would
> you be able to test this patch to make sure it works?
>
> If anyone else has this board, I'd appreciate the testing.
>
> Thanks,
> wt
> 8<---------
> Signed-off-by: Warren Turkal<wt <at> penguintechs.org>
> ---
>   src/mainboard/intel/d810e2cb/Kconfig |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/mainboard/intel/d810e2cb/Kconfig b/src/mainboard/intel/d810e2cb/Kconfig
> index 8c6c76b..6d407d2 100644
> --- a/src/mainboard/intel/d810e2cb/Kconfig
> +++ b/src/mainboard/intel/d810e2cb/Kconfig
>  <at>  <at>  -31,6 +31,7  <at>  <at>  config BOARD_SPECIFIC_OPTIONS # dummy
>   	select BOARD_ROMSIZE_KB_512
>   	select HAVE_MAINBOARD_RESOURCES
>   	select GFXUMA
> +	select TINY_BOOTBLOCK
>
>   config MAINBOARD_DIR
>   	string
(Continue reading)


Gmane