headers
Mathieu Chouquet-Stringer | 14 Feb 2009 23:34
X-Face
Picon
Favicon

[PATH] No Thinkpad Module Autoloading On T30

	Hello,

I'm running 2.6.29-rc5 on my aging T30 laptop (2366-21U) and just
realized thinkpad_acpi wasn't loaded.

Looking at the source, there seems to be a missing * to match my DMI
string.  I mean for newer IBM and Lenovo's laptops you match either one
of the following:
MODULE_ALIAS("dmi:bvnIBM:*:svnIBM:*:pvrThinkPad*:rvnIBM:*");
MODULE_ALIAS("dmi:bvnLENOVO:*:svnLENOVO:*:pvrThinkPad*:rvnLENOVO:*");

While for older Thinkpads, you do this (for instance):
IBM_BIOS_MODULE_ALIAS("1[0,3,6,8,A-G,I,K,M-P,S,T]");

with IBM_BIOS_MODULE_ALIAS being MODULE_ALIAS("dmi:bvnIBM:bvr" __type "ET??WW")

Note there's no * terminating the string.  As result, udev doesn't load
anything because modprobe cannot find anything matching this (my
machine actually):

udevtest: run: '/sbin/modprobe dmi:bvnIBM:bvr1IET71WW(2.10):bd06/16/2006:svnIBM:pn236621U:pvrNotAvailable:rvnIBM:rn236621U:rvrNotAvailable:cvnIBM:ct10:cvrNotAvailable:'

So here's my contribution...

Best,

Signed-off-by: Mathieu Chouquet-Stringer <mchouque <at> free.fr>
---
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index bcbc051..70e702a 100644
(Continue reading)

Permalink | Reply | 4 comments |
headers
Henrique de Moraes Holschuh | 15 Feb 2009 13:59
Picon
Favicon

Re: [PATH] No Thinkpad Module Autoloading On T30

On Sat, 14 Feb 2009, Mathieu Chouquet-Stringer wrote:
> Looking at the source, there seems to be a missing * to match my DMI
> string.  I mean for newer IBM and Lenovo's laptops you match either one
> of the following:
> MODULE_ALIAS("dmi:bvnIBM:*:svnIBM:*:pvrThinkPad*:rvnIBM:*");
> MODULE_ALIAS("dmi:bvnLENOVO:*:svnLENOVO:*:pvrThinkPad*:rvnLENOVO:*");
> 
> While for older Thinkpads, you do this (for instance):
> IBM_BIOS_MODULE_ALIAS("1[0,3,6,8,A-G,I,K,M-P,S,T]");
> 
> with IBM_BIOS_MODULE_ALIAS being MODULE_ALIAS("dmi:bvnIBM:bvr" __type "ET??WW")
> 
> Note there's no * terminating the string.  As result, udev doesn't load
> anything because modprobe cannot find anything matching this (my
> machine actually):
> 
> udevtest: run: '/sbin/modprobe dmi:bvnIBM:bvr1IET71WW(2.10):bd06/16/2006:svnIBM:pn236621U:pvrNotAvailable:rvnIBM:rn236621U:rvrNotAvailable:cvnIBM:ct10:cvrNotAvailable:'
> 
> So here's my contribution...
> 
> Best,
> 
> Signed-off-by: Mathieu Chouquet-Stringer <mchouque <at> free.fr>
Acked-by: Henrique de Moraes Holschuh <hmh <at> hmh.eng.br>

I will:
1. retitle the patch to "thinkpad-acpi: fix module autoloading on older models"
2. add the cc for stable <at> kernel.org
2. queue it to make sure it won't get lost
3. check if Len would take it for 2.6.29 since it is a simple, obvious fix.
(Continue reading)

Permalink | Reply | 2 comments |
headers
Mathieu Chouquet-Stringer | 15 Feb 2009 14:01
X-Face
Picon
Favicon

Re: [PATH] No Thinkpad Module Autoloading On T30

On Sun, Feb 15, 2009 at 09:59:15AM -0300, Henrique de Moraes Holschuh wrote:
> I will:
> 1. retitle the patch to "thinkpad-acpi: fix module autoloading on older models"
> 2. add the cc for stable <at> kernel.org
> 2. queue it to make sure it won't get lost
> 3. check if Len would take it for 2.6.29 since it is a simple, obvious fix.
> If not, it will go in during the 2.6.30 merge window.  After it gets into
> mainline, it will go to the stable trees.
> 
> Thank you.

Works for me!  Thanks much.
--

-- 
Mathieu Chouquet-Stringer                           mchouque <at> free.fr
            The sun itself sees not till heaven clears.
	             -- William Shakespeare --
Permalink | Reply | 0 comments |
headers
Henrique de Moraes Holschuh | 15 Feb 2009 14:25
Picon
Favicon

[PATCH] thinkpad-acpi: fix module autoloading for older models

From: Mathieu Chouquet-Stringer <mchouque <at> free.fr>

Looking at the source, there seems to be a missing * to match my DMI
string.  I mean for newer IBM and Lenovo's laptops you match either one
of the following:
MODULE_ALIAS("dmi:bvnIBM:*:svnIBM:*:pvrThinkPad*:rvnIBM:*");
MODULE_ALIAS("dmi:bvnLENOVO:*:svnLENOVO:*:pvrThinkPad*:rvnLENOVO:*");

While for older Thinkpads, you do this (for instance):
IBM_BIOS_MODULE_ALIAS("1[0,3,6,8,A-G,I,K,M-P,S,T]");

with IBM_BIOS_MODULE_ALIAS being MODULE_ALIAS("dmi:bvnIBM:bvr" __type "ET??WW")

Note there's no * terminating the string.  As result, udev doesn't load
anything because modprobe cannot find anything matching this (my
machine actually):

udevtest: run: '/sbin/modprobe dmi:bvnIBM:bvr1IET71WW(2.10):bd06/16/2006:svnIBM:pn236621U:pvrNotAvailable:rvnIBM:rn236621U:rvrNotAvailable:cvnIBM:ct10:cvrNotAvailable:'

Signed-off-by: Mathieu Chouquet-Stringer <mchouque <at> free.fr>
Acked-by: Henrique de Moraes Holschuh <hmh <at> hmh.eng.br>
Cc: stable <at> kernel.org
---
 drivers/platform/x86/thinkpad_acpi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Len, please consider this for 2.6.29.  It is an obvious one-liner.

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 91ae159..d218ecb 100644
(Continue reading)

Permalink | Reply | 0 comments |
headers
Marc MERLIN | 16 Feb 2009 18:01

Re: cannot resume after hotplugging an ultrabay battery in T61p

Were you able to find any config options that don't look good to you?

Similarly, I have a nagging but annoying problem where my laptop will
occasionally hard deadlock when I plug the power back in while it was
running on batteries.

I've had this problem for quite a while too, across kernel version, and
interestingly enough, restarting acpid from cron may have been a workaround 
in the past, and of course I can't reproduce that one at will either, so
it's hard to get a debugging setup when it happens.
This actually started happening at the same time that for some dumb reason,
acpid stopped logging to /var/log/acpid more than a year ago :(

I just upgraded to 2.6.28.4 so we'll see what happens, but if you have
recommendations on kernel options, debugging, or other ideas, I'm all ears.
(like can I debug on usb serial, or do I need real serial?)

Thanks,
Marc

On Fri, Jan 30, 2009 at 10:58:56AM -0800, Marc MERLIN wrote:
> 
> Hi,
> 
> Thanks for your reply and sorry for the delay, for some reason I never got
> your reply by Cc or the linux-thinkpad list, but found it in the ibm-acpi-devel
> web archive.
> 
> Henrique de Moraes Holschuh wrote wrote:
> > On Wed, 21 Jan 2009, Marc MERLIN wrote:
(Continue reading)

Permalink | Reply | 4 comments |
headers
Henrique de Moraes Holschuh | 21 Feb 2009 03:38
Picon
Favicon

Re: cannot resume after hotplugging an ultrabay battery in T61p

On Mon, 16 Feb 2009, Marc MERLIN wrote:
> Were you able to find any config options that don't look good to you?

Sorry, no :(  But you have some heavy duty debugging stuff that you should
disable if you don't use them, like kprobes.  I'd also disable cgroup and
the group scheduler if you don't use them.

> Similarly, I have a nagging but annoying problem where my laptop will
> occasionally hard deadlock when I plug the power back in while it was
> running on batteries.

If you are using either nVidia or ATI proprietary drivers (sorry, I forgot
the details), they react to power management events like AC
connected/disconnected, and so I suppose a bug there might cause hangs.  If
it is a hard-to-hit race, the hangs would not happen very often.

I don't think the open drivers do this (i.e. they're not advanced enough for
that yet :p), though.  Maybe Intel's do, they're big on the PM stuff.  The
X.org server also wants to listen to acpi events nowadays (and does so,
probably through HAL), so it gets difficult to know for sure what might be
reacting to the AC connected event and causing a hang.

It could also be the BIOS fighting X.org.  Try telling the BIOS to not touch
the screen brightness level when you plug/unplug AC, and see if that stops
the hangs...

> I just upgraded to 2.6.28.4 so we'll see what happens, but if you have
> recommendations on kernel options, debugging, or other ideas, I'm all ears.
> (like can I debug on usb serial, or do I need real serial?)
(Continue reading)

Permalink | Reply | 2 comments |
headers
Marc MERLIN | 23 Feb 2009 00:51

Re: cannot resume after hotplugging an ultrabay battery in Z61p

On Fri, Feb 20, 2009 at 11:38:59PM -0300, Henrique de Moraes Holschuh wrote:
> On Mon, 16 Feb 2009, Marc MERLIN wrote:
> > Were you able to find any config options that don't look good to you?
> 
> Sorry, no :(  But you have some heavy duty debugging stuff that you should
> disable if you don't use them, like kprobes.  I'd also disable cgroup and
> the group scheduler if you don't use them.

I've turned them off and built 2.6.28.7. We'll see...

> > Similarly, I have a nagging but annoying problem where my laptop will
> > occasionally hard deadlock when I plug the power back in while it was
> > running on batteries.
> 
> If you are using either nVidia or ATI proprietary drivers (sorry, I forgot
> the details), they react to power management events like AC
> connected/disconnected, and so I suppose a bug there might cause hangs.  If
> it is a hard-to-hit race, the hangs would not happen very often.

Yes, I know about them. Luckily I'm now able to run standard kernel ATI dri
and Xorg drivers.

> I don't think the open drivers do this (i.e. they're not advanced enough for
> that yet :p), though.  Maybe Intel's do, they're big on the PM stuff.  The

They have no hooks, but the open source drivers seem to take less power than
the ATI ones did, even with the PM clock throttling stuff.

> X.org server also wants to listen to acpi events nowadays (and does so,
> probably through HAL), so it gets difficult to know for sure what might be
(Continue reading)

Permalink | Reply | 0 comments |
headers
Christoph | 23 Feb 2009 23:48
Picon
Favicon

Re: Blueotooth not available anymore

Hi everybody,

Might be a little OT, but maybe someone here has a tip.

My thinkpad X61 had working bluetooth. Then I did something that broke
it. I can't really say what I did, since I don't use bluetooth regularly, but I am still using the same kernel.
There is no /proc/acpi/ibm/bluetooth anymore. I set the bios to factory-defaults,
but that didn't help either.

Loading thinkpad_acpi with  debug=0xffff says this:
> thinkpad_acpi: ibm_init: probing for bluetooth
> thinkpad_acpi: bluetooth_init: initializing bluetooth subdriver
> thinkpad_acpi: drv_acpi_handle_init: trying to locate ACPI handle for hkey
> thinkpad_acpi: drv_acpi_handle_init: Found ACPI handle HKEY for hkey
> thinkpad_acpi: bluetooth_init: bluetooth is supported, status 0x04
> thinkpad_acpi: bluetooth_init: bluetooth hardware not installed

But Bluetooth is built in. I used it before. There is a bluetooth-led !

Has anybody here experienced similar things ?

Regards,
 Christoph

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
(Continue reading)

Permalink | Reply | 4 comments |
headers
Henrique de Moraes Holschuh | 24 Feb 2009 01:41
Picon
Favicon

Re: Blueotooth not available anymore

On Mon, 23 Feb 2009, Christoph wrote:
> Might be a little OT, but maybe someone here has a tip.
> 
> My thinkpad X61 had working bluetooth. Then I did something that broke
> it. I can't really say what I did, since I don't use bluetooth regularly, but I am still using the same kernel.
> There is no /proc/acpi/ibm/bluetooth anymore. I set the bios to factory-defaults,
> but that didn't help either.
>  
> Loading thinkpad_acpi with  debug=0xffff says this:
> > thinkpad_acpi: ibm_init: probing for bluetooth
> > thinkpad_acpi: bluetooth_init: initializing bluetooth subdriver
> > thinkpad_acpi: drv_acpi_handle_init: trying to locate ACPI handle for hkey
> > thinkpad_acpi: drv_acpi_handle_init: Found ACPI handle HKEY for hkey
> > thinkpad_acpi: bluetooth_init: bluetooth is supported, status 0x04
> > thinkpad_acpi: bluetooth_init: bluetooth hardware not installed

Go to the BIOS setup screen, find the "bluetooth" option, or "internal
radios" or whatever it is called nowadays, and enable it :-)  It is probably
set to "hidden".

--

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
(Continue reading)

Permalink | Reply | 3 comments |
headers
christoph | 22 Feb 2009 19:06
Picon
Favicon

Blueotooth not available anymore

Hi everybody,

Might be a little OT, but maybe someone here has a tip.

My thinkpad X61 had working bluetooth. Then I did something that broke
it. I can't really say what I did, since I don't use bluetooth regularly, but I am still using the same kernel.
There is no /proc/acpi/ibm/bluetooth anymore. I set the bios to factory-defaults,
but that didn't help either.

Has anybody here experienced similar things ?

Regards,
 Christoph

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
Permalink | Reply | 5 comments |

Gmane