headers
Len Brown | 7 Dec 2006 07:23
Picon
Favicon
Gravatar

Re: [PATCH 00/21] ACPI: ibm-acpi: cleanups, extended fan/thermal support

On Saturday 25 November 2006 15:41, Henrique de Moraes Holschuh wrote:
> git://repo.or.cz/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git for-upstream/acpi-test

Henrique,
FYI, A pull of this branch will take everything included underneath it.
In this case, it will take all the contents of acpi-test that this branch is built upon.

That is fine for testing, but it isn't a path to upstream b/c
not everything in acpi-test is going to get sent up to Linus at the same time as ibm-acpi.

For this batch, I'll just re-parent the series, or re-commit the e-mail patches.
But in the future, if you base your patches directly against some snapshot of Linus' tree
and don't include anything else besides your changes, then I can pull it directly.

Of course you can do both by checking your changes in on a branch off of Linus'
baseline and then merging onto your mirror of acpi-test.  In that event I'd
pull from your branch based on Linus' mirror.

thanks,
-Len
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Henrique de Moraes Holschuh | 7 Dec 2006 20:35
Picon
Favicon

Re: [PATCH 00/21] ACPI: ibm-acpi: cleanups, extended fan/thermal support

On Thu, 07 Dec 2006, Len Brown wrote:
> Henrique,
> FYI, A pull of this branch will take everything included underneath it.
> In this case, it will take all the contents of acpi-test that this branch is built upon.
> 
> That is fine for testing, but it isn't a path to upstream b/c
> not everything in acpi-test is going to get sent up to Linus at the same time as ibm-acpi.

I was operating under the false idea that the flow should be ibm-acpi-devel
-> acpi-test -> linus.

> For this batch, I'll just re-parent the series, or re-commit the e-mail patches.

Thanks.

> But in the future, if you base your patches directly against some snapshot of Linus' tree
> and don't include anything else besides your changes, then I can pull it directly.
> Of course you can do both by checking your changes in on a branch off of Linus'
> baseline and then merging onto your mirror of acpi-test.  In that event I'd
> pull from your branch based on Linus' mirror.

Will do.

--

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
(Continue reading)

Permalink | Reply | 0 comments |
headers
Theodore Ts'o | 10 Dec 2006 06:13
Picon
Picon
Favicon
Gravatar

[PATCH] Add Ultrabay support for the T60p Thinkpad

Add Ultrabay Support for the T60p Thinkpad

The following patch adds support for obtaining the status and ejecting
Ultrabay devices for the T60p Thinkpad; my guess is that it probably
works on T60 Thinkpads and probably more recent Lenovo latops as well.

With the 2.03 BIOS I have been able to eject a SATA drive in an Ultrabay
carrier by using the command:

  "echo 1 > /sys/class/scsi_device/1:0:0:0/device/delete"

and upon re-inserting the it back into the device and issuing the
command:

 "echo 0 0 0 > /sys/class/scsi_host/host1/scan"

have the device appear again.  (With the 1.02 BIOS the device does not
function when re-inserted, even after a warm boot; a cold reboot is
required to store the Ultrabay device's functionality.)

More complicated Ultrabay eject and insert scripts can be found on the
ThinkWiki, although it's important to comment out the "hdparm -Y" as it
apparently doesn't work or do anything, and causes the eject process to
hang for about a minute.

Signed-off-by: "Theodore Ts'o" <tytso <at> mit.edu>

Index: 2.6.19/drivers/acpi/ibm_acpi.c
===================================================================
--- 2.6.19.orig/drivers/acpi/ibm_acpi.c	2006-12-09 18:35:09.000000000 -0500
(Continue reading)

Permalink | Reply | 6 comments |
headers
Henrique de Moraes Holschuh | 10 Dec 2006 13:49
Picon
Favicon

Re: [PATCH] Add Ultrabay support for the T60p Thinkpad

On Sun, 10 Dec 2006, Theodore Ts'o wrote:
> Add Ultrabay Support for the T60p Thinkpad

Thanks, an equivalent patch is alredy merged in acpi-test, and waiting a
push to linus.

BTW: this is an ACK if you want to merge this patch ahead of the stuff in
acpi-test.

> Ultrabay devices for the T60p Thinkpad; my guess is that it probably
> works on T60 Thinkpads and probably more recent Lenovo latops as well.

It works on all *60 and *61 new ThinkPads, yes.

> have the device appear again.  (With the 1.02 BIOS the device does not
> function when re-inserted, even after a warm boot; a cold reboot is
> required to store the Ultrabay device's functionality.)

Nice to know that, thanks.

Take a look on the experimental ACPI bay and dock support in acpi-test, it
is even better than ibm-acpi's builtin support... and in fact, deprecates
it.

--

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
(Continue reading)

Permalink | Reply | 2 comments |
headers
Theodore Tso | 10 Dec 2006 20:15
Picon
Picon
Favicon
Gravatar

[PATCH] Add Ultrabay support for the T60p Thinkpad

On Sun, Dec 10, 2006 at 10:49:46AM -0200, Henrique de Moraes Holschuh wrote:
> 
> Thanks, an equivalent patch is alredy merged in acpi-test, and waiting a
> push to linus.
> 
> BTW: this is an ACK if you want to merge this patch ahead of the stuff in
> acpi-test.

Great, I don't think I saw any mention of T60 support on the
linux-thinkpad mailing list, so I didn't realize this work had already
been done.  Would have saved me all of 15 minutes or so.  :-)

When is acpi-test scehduled to be merged?  If it's going to be pushed
soon into mainline, then I don't want to make any extra work for
folks.  If it's going to be a while, the patch is pretty simple and
low-risk, so hopefully it can get merged quickly.

> > have the device appear again.  (With the 1.02 BIOS the device does not
> > function when re-inserted, even after a warm boot; a cold reboot is
> > required to store the Ultrabay device's functionality.)
> 
> Nice to know that, thanks.

I wasn't quite exact in describing the problem originally, so for the
record, if you are using a 1.02/1.04 BIOS, if all you do is
disassociate the device using:

  "echo 1 > /sys/class/scsi_device/1:0:0:0/device/delete"

it's fine.  But if you apply this patch and then actually shut the bay using:
(Continue reading)

Permalink | Reply | 0 comments |
headers
John Fettig | 15 Dec 2006 18:53
Picon

Thinkpad X60s brightness button

Hello,

It seems something is wrong with the way ibm_acpi is interpreting the Fn
+Home combo which is supposed to be "brightness up" on this laptop.
When I press it while Xorg is running, it crashes (or at the very least,
blanks).  When I press it while in a VT, it works fine.  If I stop acpi
and then press it, it still works fine.  I'm not sure exactly where the
bug is, and I suspect there are multiple across different packages.  I
created a bug report at 

https://bugs.freedesktop.org/show_bug.cgi?id=9355

Any help?

John

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
Permalink | Reply | 2 comments |
headers
Len Brown | 16 Dec 2006 06:43

Re: [PATCH 00/21] ACPI: ibm-acpi: cleanups, extended fan/thermal support

applied, with this update to play with Linux-2.6.20-rc1

thanks,
-Len

commit 25c68a33b7b74b37793b1250007e5e21d621a7fc
Author: Len Brown <len.brown <at> intel.com>
Date:   Fri Dec 8 04:43:41 2006 -0500

    ACPI: ibm_acpi: respond to workqueue update

    Signed-off-by: Len Brown <len.brown <at> intel.com>

diff --git a/drivers/acpi/ibm_acpi.c b/drivers/acpi/ibm_acpi.c
index 92e7b6e..ab18007 100644
--- a/drivers/acpi/ibm_acpi.c
+++ b/drivers/acpi/ibm_acpi.c
 <at>  <at>  -1825,9 +1825,9  <at>  <at>  static enum fan_control_commands fan_control_commands;
 static int fan_control_status_known;
 static u8 fan_control_initial_status;

-static void fan_watchdog_fire(void *ignored);
+static void fan_watchdog_fire(struct work_struct *ignored);
 static int fan_watchdog_maxinterval;
-static DECLARE_WORK(fan_watchdog_task, fan_watchdog_fire, NULL);
+static DECLARE_DELAYED_WORK(fan_watchdog_task, fan_watchdog_fire);

 static int fan_init(void)
 {
 <at>  <at>  -2284,7 +2284,7  <at>  <at>  static int fan_write(char *buf)
(Continue reading)

Permalink | Reply | 0 comments |
headers
Henrique de Moraes Holschuh | 17 Dec 2006 22:56
Picon
Favicon

Re: Thinkpad X60s brightness button

On Fri, 15 Dec 2006, John Fettig wrote:
> It seems something is wrong with the way ibm_acpi is interpreting the Fn
> +Home combo which is supposed to be "brightness up" on this laptop.
> When I press it while Xorg is running, it crashes (or at the very least,
> blanks).  When I press it while in a VT, it works fine.  If I stop acpi
> and then press it, it still works fine.  I'm not sure exactly where the
> bug is, and I suspect there are multiple across different packages.  I
> created a bug report at 
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=9355
> 
> Any help?

Regression caused by a new BIOS from Lenovo, and I have not had the time to
look into it yet.

--

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
Permalink | Reply | 1 comment |
headers
Henrique de Moraes Holschuh | 18 Dec 2006 18:47
Picon
Favicon

[PATCH 2/2] ACPI: ibm_acpi: allow clean removal

From: Alexey Starikovskiy <alexey_y_starikovskiy@...>

Allow clean removal by setting notify_installed in the right place.

Alexey Starikovskiy <alexey.y.starikovskiy@...>
Signed-off-by: Henrique de Moraes Holschuh <hmh@...>
Signed-off-by: Len Brown <len.brown@...>
---

 drivers/acpi/ibm_acpi.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/ibm_acpi.c b/drivers/acpi/ibm_acpi.c
index 4a9f3bf..025a9f9 100644
--- a/drivers/acpi/ibm_acpi.c
+++ b/drivers/acpi/ibm_acpi.c
 <at>  <at>  -1806,7 +1806,7  <at>  <at>  static int __init setup_notify(struct ibm_struct *ibm)
 		       ibm->name, status);
 		return -ENODEV;
 	}
-
+	ibm->notify_installed = 1;
 	return 0;
 }

 <at>  <at>  -1883,7 +1883,6  <at>  <at>  static int __init ibm_init(struct ibm_struct *ibm)
 		ret = setup_notify(ibm);
 		if (ret < 0)
 			return ret;
-		ibm->notify_installed = 1;
(Continue reading)

Permalink | Reply | 0 comments |
headers
Henrique de Moraes Holschuh | 18 Dec 2006 18:45
Picon
Favicon

[GIT PULL][PATCH 0/2] ibm-acpi: Series short description

Please pull from the ibm-acpi-devel git tree at:
git://repo.or.cz/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git

branch for-upstream/acpi-release, to receve this patch series.

The following series contains two patches that should be merged for 2.6.20,
and also 2.6.19.y (thus stable <at> korg is also cc'ed).

    ACPI: ibm_acpi: allow clean removal
        Without this patch, rmmod'ing ibm-acpi is a Bad Idea.  This patch
        was already in acpi-test, and was dropped for some unknown reason.
	
	I will re-submit it for acpi-test as well.

    ACPI: ibm-acpi: add support for the ultrabay on the T60,X60
        Tested patch that adds support for the T60, X60 and other ThinkPads
        with a SATA Advanced Ultrabay.

	This patch is already in the acpi-test tree.

--

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
(Continue reading)

Permalink | Reply | 1 comment |

Gmane