Zhang Rui | 1 Jul 07:37 2010
Picon

Re: [PATCH 4/4 V2] ACPI: introduce module parameter acpi.aml_debug

On Tue, 2010-06-22 at 11:09 +0800, Len Brown wrote:
> >  
> > +static int param_set_aml_debug(const char *val, struct kernel_param *kp)
> > +{
> > +	if (!strncmp(val, "1\n", 2))
> > +		acpi_gbl_enable_aml_debug_object = 1;
> > +	else if (!strncmp(val, "0\n", 2))
> > +		acpi_gbl_enable_aml_debug_object = 0;
> > +	else
> > +		return -EINVAL;
> > +
> > +	return 0;
> > +}
> > +
> > +static int param_get_aml_debug(char *buffer, struct kernel_param *kp)
> > +{
> > +	if (acpi_gbl_enable_aml_debug_object)
> > +		return sprintf(buffer, "1");
> > +	else
> > +		return sprintf(buffer, "0");
> > +}
> > +
> > +module_param_call(aml_debug, param_set_aml_debug, param_get_aml_debug, NULL, 0644);
> 
> lets do this with a simple module_param instead.
> We can change the type of acpi_gbl_enable_aml_debug_object from u8
> if we need to diverge from acpica.  Maybe we can use a #define
what do you mean by "use a #define"?

> in aclinux.h to change it to a more friendly modparam,
(Continue reading)

Huang Ying | 1 Jul 10:29 2010
Picon

[BUGFIX 0/2] ACPI, APEI, Fix two bugs of APEI implementation

Fix two bugs of APEI implementaiton.

[BUGFIX 1/2] ACPI, APEI, Fix a typo of error path of apei_resources_request
[BUGFIX 2/2] ACPI, APEI, Rename CPER and GHES severity constants
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Huang Ying | 1 Jul 10:29 2010
Picon

[BUGFIX 1/2] ACPI, APEI, Fix a typo of error path of apei_resources_request

Fix a typo of error path of apei_resources_request. release_mem_region
and release_region should be interchange.

Signed-off-by: Huang Ying <ying.huang <at> intel.com>
---
 drivers/acpi/apei/apei-base.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/acpi/apei/apei-base.c
+++ b/drivers/acpi/apei/apei-base.c
 <at>  <at>  -481,14 +481,14  <at>  <at>  err_unmap_ioport:
 	list_for_each_entry(res, &resources->ioport, list) {
 		if (res == res_bak)
 			break;
-		release_mem_region(res->start, res->end - res->start);
+		release_region(res->start, res->end - res->start);
 	}
 	res_bak = NULL;
 err_unmap_iomem:
 	list_for_each_entry(res, &resources->iomem, list) {
 		if (res == res_bak)
 			break;
-		release_region(res->start, res->end - res->start);
+		release_mem_region(res->start, res->end - res->start);
 	}
 	return -EINVAL;
 }
Huang Ying | 1 Jul 10:29 2010
Picon

[BUGFIX 2/2] ACPI, APEI, Rename CPER and GHES severity constants

The abbreviation of severity should be SEV instead of SER, so the CPER
severity constants are renamed accordingly. GHES severity constants
are renamed in the same way too.

Signed-off-by: Huang Ying <ying.huang <at> intel.com>
---
 arch/x86/kernel/cpu/mcheck/mce-apei.c |    4 ++--
 drivers/acpi/apei/ghes.c              |   32 ++++++++++++++++----------------
 include/linux/cper.h                  |    8 ++++----
 3 files changed, 22 insertions(+), 22 deletions(-)

--- a/arch/x86/kernel/cpu/mcheck/mce-apei.c
+++ b/arch/x86/kernel/cpu/mcheck/mce-apei.c
 <at>  <at>  -80,7 +80,7  <at>  <at>  int apei_write_mce(struct mce *m)
 	rcd.hdr.revision = CPER_RECORD_REV;
 	rcd.hdr.signature_end = CPER_SIG_END;
 	rcd.hdr.section_count = 1;
-	rcd.hdr.error_severity = CPER_SER_FATAL;
+	rcd.hdr.error_severity = CPER_SEV_FATAL;
 	/* timestamp, platform_id, partition_id are all invalid */
 	rcd.hdr.validation_bits = 0;
 	rcd.hdr.record_length = sizeof(rcd);
 <at>  <at>  -96,7 +96,7  <at>  <at>  int apei_write_mce(struct mce *m)
 	rcd.sec_hdr.validation_bits = 0;
 	rcd.sec_hdr.flags = CPER_SEC_PRIMARY;
 	rcd.sec_hdr.section_type = CPER_SECTION_TYPE_MCE;
-	rcd.sec_hdr.section_severity = CPER_SER_FATAL;
+	rcd.sec_hdr.section_severity = CPER_SEV_FATAL;

 	memcpy(&rcd.mce, m, sizeof(*m));
(Continue reading)

Lin Ming | 1 Jul 10:45 2010
Picon

Re: Bug 16210 - BUG: scheduling while atomic: swapper/0/0x10000002 when ACPI is initialised

(CC linux-acpi list)

On Thu, 2010-07-01 at 16:44 +0800, Lin Ming wrote:
> Hi,
> 
> Alexy, Fengguang, Xiaotian,
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=16210
> 
> This bug is about the ACPICA preemption point, would you guys please
> have a look at it?
> 
> /* Used within ACPICA to show where it is safe to preempt execution */
> #include <linux/hardirq.h>
> #define ACPI_PREEMPTION_POINT() \
>         do { \
>                 if (!in_atomic_preempt_off() && !irqs_disabled()) \
>                         cond_resched(); \
>         } while (0)
> 
> Thanks,
> Lin Ming

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

David Howells | 1 Jul 11:31 2010
Picon

Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set but not used

Justin P. Mattock <justinmattock <at> gmail.com> wrote:

> +		if (fn) {
> +			dev_warn(&acpi_dev->dev,
> +				"Failed to create firmware_node link to %s %s: %d\n",
> +				dev_driver_string(dev), dev_name(dev), fn);
> +		} else if (pn) {
> +			dev_warn(&acpi_dev->dev,
> +				"Failed to create physical_node link to %s %s: %d\n",
> +				dev_driver_string(dev), dev_name(dev), pn);
> +				return AE_ERROR;
> +		}			

There's one more question to ask yourself: do you really need two dev_warn()
statements?  You could have just one that prints both error values:

		if (fn || pn)
			dev_warn(&acpi_dev->dev,
				 "Failed to create link(s) to %s %s:"
				 " fn=%d pn=%d\n",
				 dev_driver_string(dev), dev_name(dev),
				 fn, pn);

Not sure it's worth going that far.  You could reduce it still further:

		if (fn || pn)
			dev_warn(&acpi_dev->dev,
				 "Failed to create link(s) to %s %s:"
				 " %d\n",
				 dev_driver_string(dev), dev_name(dev),
(Continue reading)

Serg Alexv. | 1 Jul 12:36 2010
Picon

"acpi_apic_instance=2" works better

"acpi_apic_instance=2" works just awesome (-:

Except i still have this:

$ dmesg |grep Error
[    0.206631] ACPI Error (psargs-0359): [CDW1] Namespace lookup
failure, AE_NOT_FOUND
[    0.206796] ACPI Error (psparse-0537): Method parse/execution
failed [\_SB_.PCI0._OSC] (Node f7013270), AE_NOT_FOUND
[    0.214270] ACPI Error (psargs-0359): [CDW1] Namespace lookup
failure, AE_NOT_FOUND
[    0.214434] ACPI Error (psparse-0537): Method parse/execution
failed [\_SB_.PCI0._OSC] (Node f7013270), AE_NOT_FOUND
[    0.300734] ACPI Error (psargs-0359): [CDW1] Namespace lookup
failure, AE_NOT_FOUND
[    0.300896] ACPI Error (psparse-0537): Method parse/execution
failed [\_SB_.PCI0._OSC] (Node f7013270), AE_NOT_FOUND
[    0.301174] ACPI Error (psargs-0359): [CDW1] Namespace lookup
failure, AE_NOT_FOUND
[    0.301339] ACPI Error (psparse-0537): Method parse/execution
failed [\_SB_.PCI0._OSC] (Node f7013270), AE_NOT_FOUND
[    0.301607] ACPI Error (psargs-0359): [CDW1] Namespace lookup
failure, AE_NOT_FOUND
[    0.301770] ACPI Error (psparse-0537): Method parse/execution
failed [\_SB_.PCI0._OSC] (Node f7013270), AE_NOT_FOUND
[    0.302037] ACPI Error (psargs-0359): [CDW1] Namespace lookup
failure, AE_NOT_FOUND
[    0.302200] ACPI Error (psparse-0537): Method parse/execution
failed [\_SB_.PCI0._OSC] (Node f7013270), AE_NOT_FOUND
[    0.302486] ACPI Error (psargs-0359): [CDW1] Namespace lookup
(Continue reading)

Justin P. Mattock | 1 Jul 15:41 2010
Picon

Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set but not used

On 07/01/2010 02:31 AM, David Howells wrote:
> Justin P. Mattock<justinmattock <at> gmail.com>  wrote:
>
>> +		if (fn) {
>> +			dev_warn(&acpi_dev->dev,
>> +				"Failed to create firmware_node link to %s %s: %d\n",
>> +				dev_driver_string(dev), dev_name(dev), fn);
>> +		} else if (pn) {
>> +			dev_warn(&acpi_dev->dev,
>> +				"Failed to create physical_node link to %s %s: %d\n",
>> +				dev_driver_string(dev), dev_name(dev), pn);
>> +				return AE_ERROR;
>> +		}			
>
> There's one more question to ask yourself: do you really need two dev_warn()
> statements?  You could have just one that prints both error values:
>
> 		if (fn || pn)
> 			dev_warn(&acpi_dev->dev,
> 				 "Failed to create link(s) to %s %s:"
> 				 " fn=%d pn=%d\n",
> 				 dev_driver_string(dev), dev_name(dev),
> 				 fn, pn);

ah... I did think about that a few days ago, but had no idea how to 
really follow through with this.. and from looking at what you did, it's 
as simple as  a || b

>
> Not sure it's worth going that far.  You could reduce it still further:
(Continue reading)

Matthew Garrett | 1 Jul 17:01 2010

Re: "acpi_apic_instance=2" works better

On Thu, Jul 01, 2010 at 02:36:00PM +0400, Serg Alexv. wrote:
> "acpi_apic_instance=2" works just awesome (-:

What doesn't work without it?

> [    0.303948] ACPI Error (psparse-0537): Method parse/execution
> failed [\_SB_.PCI0._OSC] (Node f7013270), AE_NOT_FOUND

Could you provide the full dmesg output and the output of the acpidump 
command (found in the pmtools package)?

--

-- 
Matthew Garrett | mjg59 <at> srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thomas Renninger | 1 Jul 17:02 2010
Picon

[PATCH 1/6] ACPI: Provide /sys/devices/system/ec/

This patch provides the same information through sysfs, which previously was
provided through /proc/acpi/embedded_controller/*/info

Signed-off-by: Thomas Renninger <trenn <at> suse.de>

CC: Alexey Starikovskiy <astarikovskiy <at> suse.de>
CC: Len Brown <lenb <at> kernel.org>
CC: linux-kernel <at> vger.kernel.org
CC: linux-acpi <at> vger.kernel.org
CC: Bjorn Helgaas <bjorn.helgaas <at> hp.com>
CC: platform-driver-x86 <at> vger.kernel.org

Index: linux-2.6.34-master/drivers/acpi/Kconfig
===================================================================
---
 drivers/acpi/Kconfig    |   13 +++++++
 drivers/acpi/Makefile   |    1 +
 drivers/acpi/ec.c       |   18 +++-------
 drivers/acpi/ec_sys.c   |   92 +++++++++++++++++++++++++++++++++++++++++++++++
 drivers/acpi/internal.h |   24 ++++++++++++
 5 files changed, 135 insertions(+), 13 deletions(-)
 create mode 100644 drivers/acpi/ec_sys.c

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 7464115..f13708a 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
 <at>  <at>  -104,6 +104,19  <at>  <at>  config ACPI_SYSFS_POWER
 	help
 	  Say N to disable power /sys interface
(Continue reading)


Gmane