headers
Zhang Rui | 1 Jul 2010 07:37
Picon
Favicon

Re: [PATCH 4/4 V2] ACPI: introduce module parameter acpi.aml_debug

On Tue, 2010-06-22 at 11:09 +0800, Len Brown wrote:
> >  
> > +static int param_set_aml_debug(const char *val, struct kernel_param *kp)
> > +{
> > +	if (!strncmp(val, "1\n", 2))
> > +		acpi_gbl_enable_aml_debug_object = 1;
> > +	else if (!strncmp(val, "0\n", 2))
> > +		acpi_gbl_enable_aml_debug_object = 0;
> > +	else
> > +		return -EINVAL;
> > +
> > +	return 0;
> > +}
> > +
> > +static int param_get_aml_debug(char *buffer, struct kernel_param *kp)
> > +{
> > +	if (acpi_gbl_enable_aml_debug_object)
> > +		return sprintf(buffer, "1");
> > +	else
> > +		return sprintf(buffer, "0");
> > +}
> > +
> > +module_param_call(aml_debug, param_set_aml_debug, param_get_aml_debug, NULL, 0644);
> 
> lets do this with a simple module_param instead.
> We can change the type of acpi_gbl_enable_aml_debug_object from u8
> if we need to diverge from acpica.  Maybe we can use a #define
what do you mean by "use a #define"?

> in aclinux.h to change it to a more friendly modparam,
(Continue reading)

Permalink | Reply | 0 comments |
headers
Huang Ying | 1 Jul 2010 10:29
Picon
Favicon

[BUGFIX 0/2] ACPI, APEI, Fix two bugs of APEI implementation

Fix two bugs of APEI implementaiton.

[BUGFIX 1/2] ACPI, APEI, Fix a typo of error path of apei_resources_request
[BUGFIX 2/2] ACPI, APEI, Rename CPER and GHES severity constants
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 2 comments |
headers
Huang Ying | 1 Jul 2010 10:29
Picon
Favicon

[BUGFIX 2/2] ACPI, APEI, Rename CPER and GHES severity constants

The abbreviation of severity should be SEV instead of SER, so the CPER
severity constants are renamed accordingly. GHES severity constants
are renamed in the same way too.

Signed-off-by: Huang Ying <ying.huang <at> intel.com>
---
 arch/x86/kernel/cpu/mcheck/mce-apei.c |    4 ++--
 drivers/acpi/apei/ghes.c              |   32 ++++++++++++++++----------------
 include/linux/cper.h                  |    8 ++++----
 3 files changed, 22 insertions(+), 22 deletions(-)

--- a/arch/x86/kernel/cpu/mcheck/mce-apei.c
+++ b/arch/x86/kernel/cpu/mcheck/mce-apei.c
 <at>  <at>  -80,7 +80,7  <at>  <at>  int apei_write_mce(struct mce *m)
 	rcd.hdr.revision = CPER_RECORD_REV;
 	rcd.hdr.signature_end = CPER_SIG_END;
 	rcd.hdr.section_count = 1;
-	rcd.hdr.error_severity = CPER_SER_FATAL;
+	rcd.hdr.error_severity = CPER_SEV_FATAL;
 	/* timestamp, platform_id, partition_id are all invalid */
 	rcd.hdr.validation_bits = 0;
 	rcd.hdr.record_length = sizeof(rcd);
 <at>  <at>  -96,7 +96,7  <at>  <at>  int apei_write_mce(struct mce *m)
 	rcd.sec_hdr.validation_bits = 0;
 	rcd.sec_hdr.flags = CPER_SEC_PRIMARY;
 	rcd.sec_hdr.section_type = CPER_SECTION_TYPE_MCE;
-	rcd.sec_hdr.section_severity = CPER_SER_FATAL;
+	rcd.sec_hdr.section_severity = CPER_SEV_FATAL;

 	memcpy(&rcd.mce, m, sizeof(*m));
(Continue reading)

Permalink | Reply | 0 comments |
headers
Lin Ming | 1 Jul 2010 10:45
Picon
Favicon

Re: Bug 16210 - BUG: scheduling while atomic: swapper/0/0x10000002 when ACPI is initialised

(CC linux-acpi list)

On Thu, 2010-07-01 at 16:44 +0800, Lin Ming wrote:
> Hi,
> 
> Alexy, Fengguang, Xiaotian,
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=16210
> 
> This bug is about the ACPICA preemption point, would you guys please
> have a look at it?
> 
> /* Used within ACPICA to show where it is safe to preempt execution */
> #include <linux/hardirq.h>
> #define ACPI_PREEMPTION_POINT() \
>         do { \
>                 if (!in_atomic_preempt_off() && !irqs_disabled()) \
>                         cond_resched(); \
>         } while (0)
> 
> Thanks,
> Lin Ming

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
David Howells | 1 Jul 2010 11:31
Picon
Favicon

Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set but not used

Justin P. Mattock <justinmattock <at> gmail.com> wrote:

> +		if (fn) {
> +			dev_warn(&acpi_dev->dev,
> +				"Failed to create firmware_node link to %s %s: %d\n",
> +				dev_driver_string(dev), dev_name(dev), fn);
> +		} else if (pn) {
> +			dev_warn(&acpi_dev->dev,
> +				"Failed to create physical_node link to %s %s: %d\n",
> +				dev_driver_string(dev), dev_name(dev), pn);
> +				return AE_ERROR;
> +		}			

There's one more question to ask yourself: do you really need two dev_warn()
statements?  You could have just one that prints both error values:

		if (fn || pn)
			dev_warn(&acpi_dev->dev,
				 "Failed to create link(s) to %s %s:"
				 " fn=%d pn=%d\n",
				 dev_driver_string(dev), dev_name(dev),
				 fn, pn);

Not sure it's worth going that far.  You could reduce it still further:

		if (fn || pn)
			dev_warn(&acpi_dev->dev,
				 "Failed to create link(s) to %s %s:"
				 " %d\n",
				 dev_driver_string(dev), dev_name(dev),
(Continue reading)

Permalink | Reply | 4 comments |
headers
Serg Alexv. | 1 Jul 2010 12:36
Picon
Gravatar

"acpi_apic_instance=2" works better

"acpi_apic_instance=2" works just awesome (-:

Except i still have this:

$ dmesg |grep Error
[    0.206631] ACPI Error (psargs-0359): [CDW1] Namespace lookup
failure, AE_NOT_FOUND
[    0.206796] ACPI Error (psparse-0537): Method parse/execution
failed [\_SB_.PCI0._OSC] (Node f7013270), AE_NOT_FOUND
[    0.214270] ACPI Error (psargs-0359): [CDW1] Namespace lookup
failure, AE_NOT_FOUND
[    0.214434] ACPI Error (psparse-0537): Method parse/execution
failed [\_SB_.PCI0._OSC] (Node f7013270), AE_NOT_FOUND
[    0.300734] ACPI Error (psargs-0359): [CDW1] Namespace lookup
failure, AE_NOT_FOUND
[    0.300896] ACPI Error (psparse-0537): Method parse/execution
failed [\_SB_.PCI0._OSC] (Node f7013270), AE_NOT_FOUND
[    0.301174] ACPI Error (psargs-0359): [CDW1] Namespace lookup
failure, AE_NOT_FOUND
[    0.301339] ACPI Error (psparse-0537): Method parse/execution
failed [\_SB_.PCI0._OSC] (Node f7013270), AE_NOT_FOUND
[    0.301607] ACPI Error (psargs-0359): [CDW1] Namespace lookup
failure, AE_NOT_FOUND
[    0.301770] ACPI Error (psparse-0537): Method parse/execution
failed [\_SB_.PCI0._OSC] (Node f7013270), AE_NOT_FOUND
[    0.302037] ACPI Error (psargs-0359): [CDW1] Namespace lookup
failure, AE_NOT_FOUND
[    0.302200] ACPI Error (psparse-0537): Method parse/execution
failed [\_SB_.PCI0._OSC] (Node f7013270), AE_NOT_FOUND
[    0.302486] ACPI Error (psargs-0359): [CDW1] Namespace lookup
(Continue reading)

Permalink | Reply | 2 comments |
headers
Matthew Garrett | 1 Jul 2010 17:01
Favicon

Re: "acpi_apic_instance=2" works better

On Thu, Jul 01, 2010 at 02:36:00PM +0400, Serg Alexv. wrote:
> "acpi_apic_instance=2" works just awesome (-:

What doesn't work without it?

> [    0.303948] ACPI Error (psparse-0537): Method parse/execution
> failed [\_SB_.PCI0._OSC] (Node f7013270), AE_NOT_FOUND

Could you provide the full dmesg output and the output of the acpidump 
command (found in the pmtools package)?

--

-- 
Matthew Garrett | mjg59 <at> srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Thomas Renninger | 1 Jul 2010 17:02
Picon

[PATCH 6/6] X86 platform driver: Fix section mismatch in wmi.c

The .add function must not be declared __init.

Signed-off-by: Thomas Renninger <trenn <at> suse.de>

CC: Alexey Starikovskiy <astarikovskiy <at> suse.de>
CC: Len Brown <lenb <at> kernel.org>
CC: linux-kernel <at> vger.kernel.org
CC: linux-acpi <at> vger.kernel.org
CC: platform-driver-x86 <at> vger.kernel.org

Index: linux-2.6.34-master/drivers/platform/x86/wmi.c
===================================================================
---
 drivers/platform/x86/wmi.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index e4eaa14..635ebb4 100644
--- a/drivers/platform/x86/wmi.c
+++ b/drivers/platform/x86/wmi.c
 <at>  <at>  -804,7 +804,7  <at>  <at>  static bool guid_already_parsed(const char *guid_string)
 /*
  * Parse the _WDG method for the GUID data blocks
  */
-static __init acpi_status parse_wdg(acpi_handle handle)
+static acpi_status parse_wdg(acpi_handle handle)
 {
 	struct acpi_buffer out = {ACPI_ALLOCATE_BUFFER, NULL};
 	union acpi_object *obj;
 <at>  <at>  -947,7 +947,7  <at>  <at>  static int acpi_wmi_remove(struct acpi_device *device, int type)
(Continue reading)

Permalink | Reply | 0 comments |
headers
Thomas Renninger | 1 Jul 2010 17:02
Picon

[PATCH 4/6] ACPI: Remove /proc/acpi/embedded_controller/..

Other patches in this series add the same info to /sys/... and
/proc/ioports.

The info removed should never have been used in an application,
eventually someone read it manually.
/proc/acpi is deprecated for more than a year anyway...

Signed-off-by: Thomas Renninger <trenn <at> suse.de>

CC: Alexey Starikovskiy <astarikovskiy <at> suse.de>
CC: Len Brown <lenb <at> kernel.org>
CC: linux-kernel <at> vger.kernel.org
CC: linux-acpi <at> vger.kernel.org
CC: platform-driver-x86 <at> vger.kernel.org

Index: linux-2.6.34-master/drivers/acpi/ec.c
===================================================================
---
 drivers/acpi/ec.c |   81 +----------------------------------------------------
 1 files changed, 1 insertions(+), 80 deletions(-)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index f95fa9f..13d3011 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
 <at>  <at>  -34,8 +34,6  <at>  <at> 
 #include <linux/init.h>
 #include <linux/types.h>
 #include <linux/delay.h>
-#include <linux/proc_fs.h>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Thomas Renninger | 1 Jul 2010 17:02
Picon

[PATCH 2/6] ACPI: Provide /sys/devices/system/ec/*/io for binary access to the EC

Binary sysfs skeleton taken over from drivers/pci/pci-sysfs.c

/sys/devices/system/ec/*/io
A userspace app to easily read/write the EC can be found here:
ftp://ftp.suse.com/pub/people/trenn/sources/ec/ec_access.c

Signed-off-by: Thomas Renninger <trenn <at> suse.de>

Index: linux-2.6.34-master/drivers/acpi/ec_sys.c
===================================================================
---
 Documentation/acpi/ec_sysfs |   33 +++++++++++++++
 drivers/acpi/ec_sys.c       |   95 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 128 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/acpi/ec_sysfs

diff --git a/Documentation/acpi/ec_sysfs b/Documentation/acpi/ec_sysfs
new file mode 100644
index 0000000..479225b
--- /dev/null
+++ b/Documentation/acpi/ec_sysfs
 <at>  <at>  -0,0 +1,33  <at>  <at> 
+		EC Sysfs File Description
+
+This file descibes sysfs files under:
+/sys/devices/system/ec
+
+Currently only one Embedded Controller is supported.
+This could get extended easily if such an ACPI supporting
+system exist, but until know there has no need be seen.
(Continue reading)

Permalink | Reply | 0 comments |

Gmane